OpenBSC

openbsc@lists.osmocom.org

4315 discussions

[PATCH] obscvty: Implement readlines() generator function.
by Alexander Chemeris 30 May '15

30 May '15

The function is useful to process logs generated by OpenBSC/OsmoBTS VTY. -- Regards, Alexander Chemeris. CEO, Fairwaves, Inc. https://fairwaves.co

1 0

[PATCH] gsm_04_08: Use osmo_assert for transt->conn and conn only in case of paging succeeded
by Ivan Kluchnikov 30 May '15

30 May '15

setup_trig_pag_evt function can receive parameter conn = NULL, if T3113 expires. --- openbsc/src/libmsc/gsm_04_08.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/openbsc/src/libmsc/gsm_04_08.c b/openbsc/src/libmsc/gsm_04_08.c index 5609602..d45ae08 100644 --- a/openbsc/src/libmsc/gsm_04_08.c +++ b/openbsc/src/libmsc/gsm_04_08.c @@ -1389,13 +1389,12 @@ static int setup_trig_pag_evt(unsigned int hooknum, unsigned int event, struct gsm_subscriber_connection *conn = _conn; struct gsm_trans *transt = _transt; - OSMO_ASSERT(!transt->conn); - OSMO_ASSERT(conn); - /* check all tranactions (without lchan) for subscriber */ switch (event) { case GSM_PAGING_SUCCEEDED: DEBUGP(DCC, "Paging subscr %s succeeded!\n", transt->subscr->extension); + OSMO_ASSERT(!transt->conn); + OSMO_ASSERT(conn); /* Assign lchan */ transt->conn = conn; /* send SETUP request to called party */ -- 1.7.9.5

3 3

[PATCH] gsm_04_08: Use osmo_assert for transt->conn and conn only in case of paging succeeded
by Ivan Kluchnikov 29 May '15

29 May '15

setup_trig_pag_evt function can receive parameter conn = NULL, if T3113 expires. --- openbsc/src/libmsc/gsm_04_08.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/openbsc/src/libmsc/gsm_04_08.c b/openbsc/src/libmsc/gsm_04_08.c index 5609602..29ab2ba 100644 --- a/openbsc/src/libmsc/gsm_04_08.c +++ b/openbsc/src/libmsc/gsm_04_08.c @@ -1390,12 +1390,12 @@ static int setup_trig_pag_evt(unsigned int hooknum, unsigned int event, struct gsm_trans *transt = _transt; OSMO_ASSERT(!transt->conn); - OSMO_ASSERT(conn); /* check all tranactions (without lchan) for subscriber */ switch (event) { case GSM_PAGING_SUCCEEDED: DEBUGP(DCC, "Paging subscr %s succeeded!\n", transt->subscr->extension); + OSMO_ASSERT(conn); /* Assign lchan */ transt->conn = conn; /* send SETUP request to called party */ -- 1.7.9.5

1 0

Build system patches for libosmo-sccp
by Andreas Rottmann 24 May '15

24 May '15

These are two buildsystem tweaks, in the same vein as the ones I posted recently for libosmocore, plus a gitignore update thrown in for good measure.

1 3

[PATCH] Fix "make distcheck"
by mail＠rotty.xx.vu 19 May '15

19 May '15

From: Andreas Rottmann <a.rottmann(a)gmx.at> Running "make distcheck" failed trying to generate ".version" into the read-only unpacked source directory. Actually shipping ".version" in the tarball fixes that. --- Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile.am b/Makefile.am index 9c82f09..fdcddb9 100644 --- a/Makefile.am +++ b/Makefile.am @@ -6,6 +6,7 @@ SUBDIRS = include src tests pkgconfigdir = $(libdir)/pkgconfig pkgconfig_DATA = libosmoabis.pc libosmotrau.pc +EXTRA_DIST = .version BUILT_SOURCES = $(top_srcdir)/.version $(top_srcdir)/.version: echo $(VERSION) > $@-t && mv $@-t $@ -- 1.9.1

3 6

A build system patch for libosmo-netif
by mail＠rotty.xx.vu 17 May '15

17 May '15

This patch series fixes some build issues in libosmo-abis. The failures occurred on a Debian jessie amd64 system, with libosmo* build dependencies installed into distinct prefixes.

1 2

Some build system patches for libosmocore
by mail＠rotty.xx.vu 17 May '15

17 May '15

The first patch fixes the build-system wrt. out-of-tree builds, while the second future-proofs the build system by enabling the subdir-objects automake option (see commit message for details).

3 5

talloc vs ASAN and other tools (Was: [PATCH] bssgp: Fix call to llist_entry in fc_queue_timer_cfg)
by Mike McTernan (wavemobile) 07 May '15

07 May '15

Hi, On 30.04.2015 20:33, Jacob Erlbeck wrote: > On 30.04.2015 20:01, Holger Freyther wrote: > > Did ASAN help? > No, since the data seems to be taken from then fc struct, so the memory area is > valid. ASAN was enabled and didn't complain. It wouldn't have helped here, but since ASAN is discussed in the context of memory errors, I'd like to check that it's been considered that ASAN's ability to detect and report memory errors may be being impaired by the use of talloc - particularly use after free bugs. I took a very quick look at the talloc code, and it looks like the Valgrind memory poisoning macros are added, but not in a way that I can see as being active (missing #include of the Valgrind API headers + DEVELOPER needs to be defined). The 2.1.2 version of talloc looks to be perhaps more complete in this respect. I'm not sure if ASAN can utilise the Valgrind macros though - perhaps something like Mozilla's approach to cover poisoning is needed: https://dxr.mozilla.org/mozilla-central/source/mfbt/MemoryChecking.h Also I noticed that there is a --disable-talloc option to configure. I hoped this would fall back to libc malloc/free, but it actually disables use of the packaged talloc.c, and links with -ltalloc instead i.e. talloc isn't actually disabled: if ENABLE_TALLOC libosmocore_la_SOURCES += talloc.c else libosmocore_la_LIBADD += -ltalloc endif It may be better named --disable-builtin-talloc. Kind Regards, Mike

3 2

Help - Dual channel on UmTRX‏
by Amber and Sarosh 07 May '15

07 May '15

Hi We have configured OsmoNITB, OsmoBTS and OsmoTRX to run two transceivers using UmTRX. But somehow when the spectrum is monitored, the only frequency that is detected is the one TRX0 is tuned to. ARFCN set for TRX1 is not detected i.e. TRX1 does not seem to be transmitting on the specified frequency. Can anyone please tell what possibly could be the issue? Thanks & Regards, Amber & Sarosh

2 1

[PATCH 1/5] sgsn: Make the free function internal
by Holger Freyther 06 May '15

06 May '15

From: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> All calls should and do go through the sgsn_mm_ctx_cleanup_free function. --- openbsc/include/openbsc/gprs_sgsn.h | 1 - openbsc/src/gprs/gprs_sgsn.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/openbsc/include/openbsc/gprs_sgsn.h b/openbsc/include/openbsc/gprs_sgsn.h index 7a429cd..9e855f8 100644 --- a/openbsc/include/openbsc/gprs_sgsn.h +++ b/openbsc/include/openbsc/gprs_sgsn.h @@ -152,7 +152,6 @@ struct sgsn_mm_ctx *sgsn_mm_ctx_by_imsi(const char *imsi); /* Allocate a new SGSN MM context */ struct sgsn_mm_ctx *sgsn_mm_ctx_alloc(uint32_t tlli, const struct gprs_ra_id *raid); -void sgsn_mm_ctx_free(struct sgsn_mm_ctx *mm); void sgsn_mm_ctx_cleanup_free(struct sgsn_mm_ctx *ctx); struct sgsn_ggsn_ctx *sgsn_mm_ctx_find_ggsn_ctx(struct sgsn_mm_ctx *mmctx, diff --git a/openbsc/src/gprs/gprs_sgsn.c b/openbsc/src/gprs/gprs_sgsn.c index 711540e..2f5d39e 100644 --- a/openbsc/src/gprs/gprs_sgsn.c +++ b/openbsc/src/gprs/gprs_sgsn.c @@ -183,7 +183,7 @@ struct sgsn_mm_ctx *sgsn_mm_ctx_alloc(uint32_t tlli, /* this is a hard _free_ function, it doesn't clean up the PDP contexts * in libgtp! */ -void sgsn_mm_ctx_free(struct sgsn_mm_ctx *mm) +static void sgsn_mm_ctx_free(struct sgsn_mm_ctx *mm) { struct sgsn_pdp_ctx *pdp, *pdp2; -- 2.3.5

1 4

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

OpenBSC