- OpenBSC - lists.osmocom.org

[PATCH 1/8] nat: Add size check for the payload
by Holger Hans Peter Freyther 15 Jun '15

15 Jun '15

From: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> The msgb will always have these bytes but it is better practice to verify that the message really has space for the two bytes. --- openbsc/src/osmo-bsc_nat/bsc_nat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/openbsc/src/osmo-bsc_nat/bsc_nat.c b/openbsc/src/osmo-bsc_nat/bsc_nat.c index 4357485..537001e 100644 --- a/openbsc/src/osmo-bsc_nat/bsc_nat.c +++ b/openbsc/src/osmo-bsc_nat/bsc_nat.c @@ -1185,7 +1185,7 @@ exit: send_reset_ack(bsc); } else if (parsed->ipa_proto == IPAC_PROTO_IPACCESS) { /* do we know who is handling this? */ - if (msg->l2h[0] == IPAC_MSGT_ID_RESP) { + if (msg->l2h[0] == IPAC_MSGT_ID_RESP && msgb_l2len(msg) > 2) { struct tlv_parsed tvp; int ret; ret = ipa_ccm_idtag_parse(&tvp, -- 2.3.5

1 7

measurement report trap/JSON document
by Holger Freyther 11 Jun '15

11 Jun '15

Hi, sorry for the delay from OsmoDevCon to now. Attached is what I proposed in a customer project a long time ago. The idea was to register for traps, version them with vX in the variable name and then send traps as JSON document. holger

1 0

test
by Holger Freyther 10 Jun '15

10 Jun '15

1 0

IPAccess NanoBTS
by Sipos Csaba 08 Jun '15

08 Jun '15

Dear list, I recently integrated nanoBTS under OpenBSC. They work fine, but I encountered the following limitations. 1. Dynamic PDCH/TCH switching is allowed to be configured, but not working. The timeslots are stuck in TCH/F mode and never converted to PDCH. Is there any trick I need to do other than setting the channel type to TCH/F_PDCH? 2. No matter what I do, the BTS only schedules one uplink timeslot. If I understand it correctly, the PCU implementation in this case is inside the NanoBTS. Is there a way to change for example an NVRAM parameter to allow a more balanced UL/DL timeslot ratio? 3. Multi-TRX setup: it is quite a limitation that you cannot use any timeslots as PDCH in a multi-TRX setup on the secondary or third carriers at all. I don't think there is any solution to that, but it worth noting. I hope someone can point me in the right direction with dyn PDCH switching and the single UL TS issue. Thanks! Regards, Csaba

2 1

Why isn't ARFCN 0 supported?
by Mike McTernan (wavemobile) 08 Jun '15

08 Jun '15

Good afternoon! In libbsc/bsc_init.c we have the following case: case GSM_BAND_900: if (bts->c0->arfcn < 1 || (bts->c0->arfcn > 124 && bts->c0->arfcn < 955) || bts->c0->arfcn > 1023) { LOGP(DNM, LOGL_ERROR, "GSM900 channel must be between 1-124, 955-1023.\n"); return -EINVAL; } break; 3GPP 45.005, table 2-2 gives valid channel numbers as: P-GSM900 -> 1-124, E-GSM900 -> 0-124 and 975-1023 R-GSM900 -> 0-124 and 955-1023 ER-GSM900 -> 0-124 and 940-1023 The code looks to bounds check ARFCN closest to R-GSM900, but omits ARFCN 0. Is the check "bts->c0->arfcn < 1" erroneous, or am I missing some history? Also should it really check for the R-GSM 900 range, or should it be E-GSM (more common)? The other band checks look correct. Kind Regards, Mike PS: osmo-arfcn is okay with ARFCN 0: $ ./osmo-arfcn -a 0 ARFCN 0: Uplink 890.0 MHz / Downlink 935.0 MHz

2 1

libosmoabis depends on libosmovty
by Mike McTernan (wavemobile) 02 Jun '15

02 Jun '15

Hi Folks, When I build OpenBsc, I find a number of cases where libosmovty isn't in the link, but is needed by libosmoabis (basically anywhere libosmoabis is linked, but vty isn't) e.g. /bin/ld: warning: libosmovty.so.1, needed by /.build/usr/local/lib/libosmoabis.so, not found (try using -rpath or -rpath-link) /.build/usr/local/lib/libosmoabis.so: undefined reference to `install_node' /.build/usr/local/lib/libosmoabis.so: undefined reference to `install_element_ve' /.build/usr/local/lib/libosmoabis.so: undefined reference to `vty_out_rate_ctr_group' /.build/usr/local/lib/libosmoabis.so: undefined reference to `vty_out' /.build/usr/local/lib/libosmoabis.so: undefined reference to `install_element' /.build/usr/local/lib/libosmoabis.so: undefined reference to `vty_install_default' I'm not sure why/how I'm seeing this and others apparently aren't, but it looks legitimate. I've verified the configure script has [correctly] derived build configfrom the staged pkgconfig: LIBOSMOABIS_CFLAGS='-I/.build/usr/local/include/ ' LIBOSMOABIS_LIBS='-L/.build/usr/local/lib -losmoabis ' So I wonder if libosmoabis.pc.in should be updated to include vty, a bit like libosmogb.pc.in i.e. Signed-off-by: Michael McTernan <Michael.McTernan(a)wavemobile.com> --- libosmoabis.pc.in (revision 19495) +++ libosmoabis.pc.in (working copy) @@ -6,6 +6,6 @@ Name: A-bis Core Library Description: C Utility Library Version: @VERSION@ -Libs: -L${libdir} -losmoabis +Libs: -L${libdir} -losmoabis -losmovty Cflags: -I${includedir}/ Otherwise every user of libosmoabis has to remember to link with -losmovty as well. Kind Regards, Mike PS: I've stripped the very long full build paths from output - I don't really build in /.build!

2 3

[PATCH] Use generic auth API
by Max 01 Jun '15

01 Jun '15

Signed-off-by: Max <max.suraev(a)fairwaves.co> --- openbsc/src/libmsc/auth.c | 69 +++++++++++++++++++---------------------------- 1 file changed, 28 insertions(+), 41 deletions(-) diff --git a/openbsc/src/libmsc/auth.c b/openbsc/src/libmsc/auth.c index 10d8edf..d04b2fc 100644 --- a/openbsc/src/libmsc/auth.c +++ b/openbsc/src/libmsc/auth.c @@ -24,47 +24,11 @@ #include <openbsc/debug.h> #include <openbsc/auth.h> #include <openbsc/gsm_data.h> - -#include <osmocom/gsm/comp128.h> +#include <osmocom/crypt/auth.h> #include <stdlib.h> -static int -_use_xor(struct gsm_auth_info *ainfo, struct gsm_auth_tuple *atuple) -{ - int i, l = ainfo->a3a8_ki_len; - - if ((l > A38_XOR_MAX_KEY_LEN) || (l < A38_XOR_MIN_KEY_LEN)) { - LOGP(DMM, LOGL_ERROR, "Invalid XOR key (len=%d) %s\n", - ainfo->a3a8_ki_len, - osmo_hexdump(ainfo->a3a8_ki, ainfo->a3a8_ki_len)); - return -1; - } - - for (i=0; i<4; i++) - atuple->sres[i] = atuple->rand[i] ^ ainfo->a3a8_ki[i]; - for (i=4; i<12; i++) - atuple->kc[i-4] = atuple->rand[i] ^ ainfo->a3a8_ki[i]; - - return 0; -} - -static int -_use_comp128_v1(struct gsm_auth_info *ainfo, struct gsm_auth_tuple *atuple) -{ - if (ainfo->a3a8_ki_len != A38_COMP128_KEY_LEN) { - LOGP(DMM, LOGL_ERROR, "Invalid COMP128v1 key (len=%d) %s\n", - ainfo->a3a8_ki_len, - osmo_hexdump(ainfo->a3a8_ki, ainfo->a3a8_ki_len)); - return -1; - } - - comp128(ainfo->a3a8_ki, atuple->rand, atuple->sres, atuple->kc); - - return 0; -} - /* Return values * -1 -> Internal error * 0 -> Not available @@ -76,6 +40,11 @@ int auth_get_tuple_for_subscr(struct gsm_auth_tuple *atuple, { struct gsm_auth_info ainfo; int i, rc; + static struct osmo_sub_auth_data auth = { + .type = OSMO_AUTH_TYPE_GSM + }; + struct osmo_auth_vector _vec; + struct osmo_auth_vector *vec = &_vec; /* Get subscriber info (if any) */ rc = db_get_authinfo_for_subscr(&ainfo, subscr); @@ -109,13 +78,23 @@ int auth_get_tuple_for_subscr(struct gsm_auth_tuple *atuple, return 0; case AUTH_ALGO_XOR: - if (_use_xor(&ainfo, atuple)) - return 0; + auth.algo = OSMO_AUTH_ALG_XOR; + if ((ainfo.a3a8_ki_len > A38_XOR_MAX_KEY_LEN) || (ainfo.a3a8_ki_len < A38_XOR_MIN_KEY_LEN)) { + LOGP(DMM, LOGL_ERROR, "Invalid XOR key (len=%d) %s\n", + ainfo.a3a8_ki_len, + osmo_hexdump(ainfo.a3a8_ki, ainfo.a3a8_ki_len)); + return -1; + } break; case AUTH_ALGO_COMP128v1: - if (_use_comp128_v1(&ainfo, atuple)) - return 0; + auth.algo = OSMO_AUTH_ALG_COMP128v1; + if (ainfo.a3a8_ki_len != A38_COMP128_KEY_LEN) { + LOGP(DMM, LOGL_ERROR, "Invalid COMP128v1 key (len=%d) %s\n", + ainfo.a3a8_ki_len, + osmo_hexdump(ainfo.a3a8_ki, ainfo.a3a8_ki_len)); + return -1; + } break; default: @@ -124,6 +103,14 @@ int auth_get_tuple_for_subscr(struct gsm_auth_tuple *atuple, return 0; } + memcpy(auth.u.gsm.ki, ainfo.a3a8_ki, sizeof(auth.u.gsm.ki)); + + if (osmo_auth_gen_vec(vec, &auth, atuple->rand) < 0) + return -1; + + memcpy(atuple->sres, vec->sres, 4); + memcpy(atuple->kc, vec->kc, 8); + db_sync_lastauthtuple_for_subscr(atuple, subscr); DEBUGP(DMM, "Need to do authentication and ciphering\n"); -- 1.9.1

3 3

[PATCH] obscvty: Implement readlines() generator function.
by Alexander Chemeris 30 May '15

30 May '15

The function is useful to process logs generated by OpenBSC/OsmoBTS VTY. -- Regards, Alexander Chemeris. CEO, Fairwaves, Inc. https://fairwaves.co

1 0

[PATCH] gsm_04_08: Use osmo_assert for transt->conn and conn only in case of paging succeeded
by Ivan Kluchnikov 30 May '15

30 May '15

setup_trig_pag_evt function can receive parameter conn = NULL, if T3113 expires. --- openbsc/src/libmsc/gsm_04_08.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/openbsc/src/libmsc/gsm_04_08.c b/openbsc/src/libmsc/gsm_04_08.c index 5609602..d45ae08 100644 --- a/openbsc/src/libmsc/gsm_04_08.c +++ b/openbsc/src/libmsc/gsm_04_08.c @@ -1389,13 +1389,12 @@ static int setup_trig_pag_evt(unsigned int hooknum, unsigned int event, struct gsm_subscriber_connection *conn = _conn; struct gsm_trans *transt = _transt; - OSMO_ASSERT(!transt->conn); - OSMO_ASSERT(conn); - /* check all tranactions (without lchan) for subscriber */ switch (event) { case GSM_PAGING_SUCCEEDED: DEBUGP(DCC, "Paging subscr %s succeeded!\n", transt->subscr->extension); + OSMO_ASSERT(!transt->conn); + OSMO_ASSERT(conn); /* Assign lchan */ transt->conn = conn; /* send SETUP request to called party */ -- 1.7.9.5

3 3

[PATCH] gsm_04_08: Use osmo_assert for transt->conn and conn only in case of paging succeeded
by Ivan Kluchnikov 29 May '15

29 May '15

setup_trig_pag_evt function can receive parameter conn = NULL, if T3113 expires. --- openbsc/src/libmsc/gsm_04_08.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/openbsc/src/libmsc/gsm_04_08.c b/openbsc/src/libmsc/gsm_04_08.c index 5609602..29ab2ba 100644 --- a/openbsc/src/libmsc/gsm_04_08.c +++ b/openbsc/src/libmsc/gsm_04_08.c @@ -1390,12 +1390,12 @@ static int setup_trig_pag_evt(unsigned int hooknum, unsigned int event, struct gsm_trans *transt = _transt; OSMO_ASSERT(!transt->conn); - OSMO_ASSERT(conn); /* check all tranactions (without lchan) for subscriber */ switch (event) { case GSM_PAGING_SUCCEEDED: DEBUGP(DCC, "Paging subscr %s succeeded!\n", transt->subscr->extension); + OSMO_ASSERT(conn); /* Assign lchan */ transt->conn = conn; /* send SETUP request to called party */ -- 1.7.9.5

1 0