August 2012 - OpenBSC - lists.osmocom.org

Re: Any interest for Osmocom meetings in Bavaria ?

by Dieter Spaar

So far three persons have indicated their interest to join a meeting at my place. Considering the time it takes to drive to my place, it probably makes sense to have the meeting at the weekend (either Saturday or Sunday) so that there is more time for the meeting itself. I can suggest one of the following dates for the first meeting, somewhere between 10:00 to 18:00 on each day: 25.8. (Sa) or 26.8. (Su) 1.9. (Sa) or 2.9. (Su) 8.9. (Sa) or 9.9. (Su) So please let me know when you have time and also make suggestions in which Osmocom topic you are interested in so that we can have some sort of agenda for the meeting to make best use of the time. Best regards, Dieter -- Dieter Spaar, Germany spaar(a)mirider.augusta.de

10 years, 11 months

10
40
0 0

SimpleHLR: A web interface for OpenBSC

by Peter Caprioli

Hello everyone, I've just finnished writing together a small web interface for the OpenBSC HLR. It allows you to modify various parameters in the database and also provides a set of functions to modify the HLR or sending SMSes in your own scripts. The project is still very alpha but it seems to work reasonably good. Feel free to give any feedback! Screenshots and source code is available on my website: https://stormhub.org/simplehlr/ -- *Best regards, Peter Caprioli*

10 years, 11 months

3
6
0 0

Several questions

by jason mercury

I have some questions: 1) When I start bsc_hack bsc_init.c first establishes OML link and initializes the bts then it establishes RSL link and bts starts broadcasting. However, it takes so much time to start the bts. Instead of this I want to do the following: it establishes OML link at the beginning and only once, then when i want to start broadcasting it establishes just the RSL link and bts will start faster since i don't have to wait for OML link. What should be done for this? 2) If i send one or two word messages from telnet interface it is okay. But if i send a longer message the phone could't receive the end of the message correctly(last words may be incomplete). Did any one encounter with this problem? What is wrong with me? 3) Could I send SMS in which extension of the sender is text not integer. For example, i want to send an information SMS that this is a test network. For this purpose i want to send an SMS from 'OpenBSC'. I set the extension of the first subscriber in database as text and tried to send the SMS but SMS wasn't delivered. What should i do? 4) Can i add SMS externally to SMS table of database? Thanks. Jason

11 years, 5 months

4
3
0 0

fix of rtp socket binding

by Andreas Eversberg

hi, after having solved an LCR issue, i patched rtp_proxy.c the same way, because it has the same issue. 1. when next_udp_port (in rtp_socket_bind) reaches 0xfffe, the bind process will fail next time. 2. if rtp_sub_socket_bind of rtp socket succeeds and rtp_sub_socket_bind of rtcp socket fails, the rtp socket must be re-created, because it cannot not be bound again to the next higher port. 3. the port range will not wrap arround and start at 0, but at RTP_PORT_BASE. (after reaching RTP_PORT_MAX) andreas

11 years, 8 months

4
3
0 0

Re: Any interest for Osmocom meetings in Bavaria ?

by Dieter Spaar

As already mentioned, the Osmocom Meeting will take place this Saturday, 1.9.2012 at 10:00. Three people have confirmed that they will come, I have send them an email with the location details. Harald is not yet sure if he can attend. A few suggestions for the meeting: - I will run a GSM-1800 network with my test license so you can try out OsmocomBB. If you are interested to do so please bring your Osmocom phone plus Laptop with the already installed OsmocomBB software. - We can do some experiments with SIMtrace if there is any interest. - There should still be enough time for other things, we can decide what to do during the meeting. Best regards, Dieter -- Dieter Spaar, Germany spaar(a)mirider.augusta.de

11 years, 8 months

1
0
0 0

Recurring outbound GPRS Attach Accept messages

by Don A. Bailey

All, Apologies if this is the wrong mailing list for this question. If so, please redirect me to the appropriate Osmocom list. Thanks! I'm having trouble with some older 2G cellular modules. When they initiate GPRS, the GPRS Attach Accept response from the SGSN seems to be dropped on the floor. I thought this was because the inbound TLLI generated by the ME was not included in the subsequent response. However, I verified that the LLC correctly generates the response and attaches the TLLI. I'm not quite sure why these particular 2G modules are not receiving the response as the message seems to be correctly submitted from the SGSN to the BTS. The result is that the GPRS state will get "stuck" on the ME side, which will keep attempting to Attach until it gives up and issues a Detach message (under the same TLLI). Can anyone clue me in on what potential issues may be caused by this ME and how/if I can patch this problem in the SGSN? Thank you, D

11 years, 8 months

2
1
0 0

[PATCH 00/13] libosmo-abis updates (v2)

by pablo＠gnumonks.org

From: Pablo Neira Ayuso <pablo(a)gnumonks.org> Hi, This is the second version of the libosmo-abis patchset. Mostly aiming to improve robustness and fix leaks in error paths. I have tried to address all Holger comments, I leave two things for my TODO list: 1) automate testing via automated testing while compilation 2) check the bfd->fd = -1 to make sure we need it in all cases I have also intensively tested (although it was quite manual) this changes with the IPA BSC/BTS tests, running valgrind to check for leaks. If you find any issue or you think it's OK, please ACK/NACK. Thanks. Pablo Neira Ayuso (13): ipa: fix missing set of write_cb for IPA client connection ipaccess: fix leak of e1inp_line tests: e1inp_ipa_bsc_test: fix crash ipaccess: improve error handling tests: e1inp_ipa_bts_test: fix compilation warnings lapd: use C99 structure initialization for profile templates input: dahdi: use logging facilities instead of fprintf and stderr input: dahdi: replace exit by return input: add generic PCAP interface for LAPD tests: fix CPU suckup e1inp_ipa_bts_test after test finish tests: e1inp_ipa_*_test: add signal handling for process termination tests: e1inp_ipa_*_test: fix leak of msgb in ->sign_link path ipaccess: fix leak of IPA control messages in the BTS side include/Makefile.am | 2 +- include/osmocom/abis/lapd.h | 1 + include/osmocom/abis/lapd_pcap.h | 11 ++ src/Makefile.am | 1 + src/e1_input.c | 1 + src/input/dahdi.c | 54 ++++++---- src/input/hsl.c | 3 - src/input/ipa.c | 3 + src/input/ipaccess.c | 210 ++++++++++++++++++++++++++------------ src/input/lapd.c | 66 +++++++----- src/input/lapd_pcap.c | 159 +++++++++++++++++++++++++++++ tests/e1inp_ipa_bsc_test.c | 26 ++++- tests/e1inp_ipa_bts_test.c | 31 +++++- 13 files changed, 443 insertions(+), 125 deletions(-) create mode 100644 include/osmocom/abis/lapd_pcap.h create mode 100644 src/input/lapd_pcap.c -- 1.7.10.4

11 years, 8 months

3
21
0 0

Uncaught bounce notification

by mailman-bounces＠lists.osmocom.org

The attached message was received as a bounce, but either the bounce format was not recognized, or no member addresses could be extracted from it. This mailing list has been configured to send all unrecognized bounce messages to the list administrator(s). For more information see: https://lists.osmocom.org/mailman/admin/openbsc/bounce

11 years, 8 months

1
0
0 0

[PATCH 00/11] libosmo-abis updates

by pablo＠gnumonks.org

From: Pablo Neira Ayuso <pablo(a)netfilter.org> Hi, The following patchset contain updates for libosmo-abis: * fix for leak of e1inp_line reported by Holger. * more robust handling of error codes in several parts of the ipaccess driver. * minor cleanups for LAPD and dahdi, fix some compilations warnings. * generic LAPD PCAP interface to create PCAP files containing the LAPD frames, so far it was only possible to store the OML/RSL traces, without the LAPD frames. * fix crash of IPA BTS example test If you're OK with those, let me know. I can push them myself if you want or you can manually apply them. Pablo Neira Ayuso (11): ipa: fix missing set of write_cb for IPA client connection ipaccess: fix leak of e1inp_line tests: e1inp_ipa_bsc_test: fix crash ipaccess: more robust error handle in receival path ipaccess: more robust error handling in the accept patch ipaccess: more robust error handling in the send path tests: e1inp_ipa_bts_test: fix compilation warnings lapd: use C99 structure initialization for profile templates input: dahdi: use logging facilities instead of fprintf and stderr input: dahdi: replace exit by return input: add generic PCAP interface for LAPD include/Makefile.am | 2 +- include/osmocom/abis/lapd.h | 1 + include/osmocom/abis/lapd_pcap.h | 11 +++ src/Makefile.am | 1 + src/input/dahdi.c | 54 ++++++++----- src/input/ipa.c | 13 +++- src/input/ipaccess.c | 107 ++++++++++++++++++++----- src/input/lapd.c | 66 +++++++++------- src/input/lapd_pcap.c | 160 ++++++++++++++++++++++++++++++++++++++ tests/e1inp_ipa_bsc_test.c | 8 +- tests/e1inp_ipa_bts_test.c | 7 +- 11 files changed, 353 insertions(+), 77 deletions(-) create mode 100644 include/osmocom/abis/lapd_pcap.h create mode 100644 src/input/lapd_pcap.c -- 1.7.10.4

11 years, 8 months

4
26
0 0

OpenBTS error

by Arturo Rivas

Hi list! When I run ggsn, terminal shows: *fg: 1* *debug: 1* *qos: 0x0b921f* *apn: internet* *net: 192.168.0.0/24* *dynip: 192.168.254.0/24* *pidfile: /var/run/ggsn.pid* *statedir: /var/lib/ggsn/* *timelimit: 0* *gtpclient: Initialising GTP tunnel* *openggsn[7002]: GTP: gtp_newgsn() started* *openggsn[7002]: gtp.c: 719: State information file (/var/lib/ggsn/gsn_restart) not found. Creating new file.* *openggsn[7002]: gtp.c: 740: fopen(path=/var/lib/ggsn/gsn_restart, mode=w) failed: Error = No such file or directory* *openggsn[7002]: gtp.c: 808: bind(fd0=4, addr=bf86f8dc, len=16) failed: Error = Address already in use* *openggsn[7002]: ggsn.c: 498: Failed to create gtp* * * If I run it again addr parameter change but log also indicates that address is already in use. Someone can help me? Thanks! Arturo Rivas.

11 years, 8 months

2
1
0 0

[PATCH] e1: Memory leak/Reference leak on the e1inp_line

by Holger Hans Peter Freyther

Release the e1inp_line when the signalling link is destroyed. The e1inp_line was leaked on every OML/RSL disconnect. The leak occured on the following call path. e1inp_close_socket ipaccess_close e1inp_sign_link_destroy ipaccess_drop_oml ipaccess_drop handle_ts1_read ipaccess_fd_cb --- src/e1_input.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/e1_input.c b/src/e1_input.c index 957b74c..a85dd91 100644 --- a/src/e1_input.c +++ b/src/e1_input.c @@ -486,6 +486,7 @@ void e1inp_sign_link_destroy(struct e1inp_sign_link *link) if (link->ts->line->driver->close) link->ts->line->driver->close(link); + e1inp_line_put(link->ts->line); talloc_free(link); } -- 1.7.10.4

11 years, 8 months

3
3
0 0

Re: Any interest for Osmocom meetings in Bavaria ?

by Dieter Spaar

I have now selected the day for the meeting which should match for all who have send me their preferred days. The first Osmocom meeting in Bavaria near Pfarrkirchen will be held on: Saturday, 1. September, starting at 10:00 If you are going to come, please let me know until next Wednesday (29. August). I will then send you a private email with the details of the location. The agenda is not yet set, but it seems that at least those who send me their areas of interest are mainly targeted towards GMS (OpenBSC/OsmocomBB). We can of course also talk about other stuff, e.g. RTL-SDR, but for this it would be nice if one of the RTL-SDR experts would join us (here you have the chance to receive a nearly clean/empty spectrum without much noise from other sources ;-). Best regards, Dieter -- Dieter Spaar, Germany spaar(a)mirider.augusta.de

11 years, 8 months

1
0
0 0

[PATCH] ipaccess: more robust error handling in the send path

by Pablo Neira Ayuso

In case of problems to transmit message, spot an error and close the socket to force a re-establishment. I have also modified ipa_client_read function. Now it closes the socket if the callback returns an error. I think this is good to force a connection re-establishment and start from scratch. Thanks to Holger Freyther for feedback. --- src/input/ipa.c | 10 ++++-- src/input/ipaccess.c | 82 ++++++++++++++++++++++++++++++++++++++++++-------- 2 files changed, 78 insertions(+), 14 deletions(-) diff --git a/src/input/ipa.c b/src/input/ipa.c index 3c6a507..ceb271f 100644 --- a/src/input/ipa.c +++ b/src/input/ipa.c @@ -131,8 +131,14 @@ static void ipa_client_read(struct ipa_client_conn *link) ipa_client_retry(link); return; } - if (link->read_cb) - link->read_cb(link, msg); + if (link->read_cb) { + ret = link->read_cb(link, msg); + if (ret < 0) { + LOGP(DLINP, LOGL_ERROR, "Connection closed with " + "server.\n"); + ipa_client_retry(link); + } + } } static void ipa_client_write(struct ipa_client_conn *link) diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index ea21de7..079ed61 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -189,26 +189,39 @@ int ipaccess_send_id_req(int fd) /* base handling of the ip.access protocol */ int ipaccess_rcvmsg_base(struct msgb *msg, struct osmo_fd *bfd) { - int ipa_ccm = 0; uint8_t msg_type = *(msg->l2h); - int ret = 0; + int ret; switch (msg_type) { case IPAC_MSGT_PING: - ipa_ccm = 1; ret = ipaccess_send_pong(bfd->fd); + if (ret < 0) { + LOGP(DLINP, LOGL_ERROR, "Cannot send PING " + "message. Reason: %s\n", strerror(errno)); + break; + } + ret = 1; break; case IPAC_MSGT_PONG: DEBUGP(DLMI, "PONG!\n"); - ipa_ccm = 1; + ret = 1; break; case IPAC_MSGT_ID_ACK: DEBUGP(DLMI, "ID_ACK? -> ACK!\n"); - ipa_ccm = 1; ret = ipaccess_send_id_ack(bfd->fd); + if (ret < 0) { + LOGP(DLINP, LOGL_ERROR, "Cannot send ID_ACK " + "message. Reason: %s\n", strerror(errno)); + break; + } + ret = 1; + break; + default: + /* This is not an IPA PING, PONG or ID_ACK message */ + ret = 0; break; } - return ipa_ccm; + return ret; } /* base handling of the ip.access protocol */ @@ -221,6 +234,10 @@ int ipaccess_rcvmsg_bts_base(struct msgb *msg, switch (msg_type) { case IPAC_MSGT_PING: ret = ipaccess_send_pong(bfd->fd); + if (ret < 0) { + LOGP(DLINP, LOGL_ERROR, "Cannot send PONG " + "message. Reason: %s\n", strerror(errno)); + } break; case IPAC_MSGT_PONG: DEBUGP(DLMI, "PONG!\n"); @@ -229,7 +246,7 @@ int ipaccess_rcvmsg_bts_base(struct msgb *msg, DEBUGP(DLMI, "ID_ACK\n"); break; } - return 0; + return ret; } static int ipaccess_drop(struct osmo_fd *bfd) @@ -264,8 +281,23 @@ static int ipaccess_rcvmsg(struct e1inp_line *line, struct msgb *msg, int len, ret; /* Handle IPA PING, PONG and ID_ACK messages. */ - if (ipaccess_rcvmsg_base(msg, bfd)) + ret = ipaccess_rcvmsg_base(msg, bfd); + switch(ret) { + case -1: + /* error in IPA control message handling */ + goto err; + case 1: + /* this is an IPA control message, skip further processing */ return 0; + case 0: + /* this is not an IPA control message, continue */ + break; + default: + LOGP(DLINP, LOGL_ERROR, "Unexpected return from " + "ipaccess_rcvmsg_base " + "(ret=%d)\n", ret); + goto err; + } switch (msg_type) { case IPAC_MSGT_ID_RESP: @@ -512,6 +544,16 @@ static int __handle_ts1_write(struct osmo_fd *bfd, struct e1inp_line *line) DEBUGP(DLMI, "TX %u: %s\n", ts_nr, osmo_hexdump(msg->l2h, msgb_l2len(msg))); ret = send(bfd->fd, msg->data, msg->len, 0); + if (ret != msg->len) { + LOGP(DLINP, LOGL_ERROR, "failed to send A-bis IPA signalling " + "message. Reason: %s\n", strerror(errno)); + if (ipaccess_drop(bfd) >= 0) { + LOGP(DLINP, LOGL_NOTICE, "Sign link problems, " + "closing socket. Reason: %s\n", strerror(errno)); + return ret; + } + } + msgb_free(msg); /* set tx delay timer for next event */ @@ -754,13 +796,16 @@ static int ipaccess_bts_cb(struct ipa_client_conn *link, struct msgb *msg) struct ipaccess_head *hh = (struct ipaccess_head *) msg->data; struct e1inp_ts *e1i_ts = NULL; struct e1inp_sign_link *sign_link; + int ret = 0; /* special handling for IPA CCM. */ if (hh->proto == IPAC_PROTO_IPACCESS) { uint8_t msg_type = *(msg->l2h); /* ping, pong and acknowledgment cases. */ - ipaccess_rcvmsg_bts_base(msg, link->ofd); + ret = ipaccess_rcvmsg_bts_base(msg, link->ofd); + if (ret < 0) + return ret; /* this is a request for identification from the BSC. */ if (msg_type == IPAC_MSGT_ID_GET) { @@ -793,15 +838,28 @@ static int ipaccess_bts_cb(struct ipa_client_conn *link, struct msgb *msg) } rmsg = ipa_bts_id_resp(link->line->ops->cfg.ipa.dev, data + 1, len - 1); - ipaccess_send(link->ofd->fd, rmsg->data, rmsg->len); + ret = ipaccess_send(link->ofd->fd, rmsg->data, + rmsg->len); msgb_free(rmsg); + if (ret != rmsg->len) { + LOGP(DLINP, LOGL_ERROR, "cannot send ID_RESP " + "message. Reason: %s\n", strerror(errno)); + return ret; + } + /* send ID_ACK. */ rmsg = ipa_bts_id_ack(); - ipaccess_send(link->ofd->fd, rmsg->data, rmsg->len); + ret = ipaccess_send(link->ofd->fd, rmsg->data, + rmsg->len); msgb_free(rmsg); + + if (ret != rmsg->len) { + LOGP(DLINP, LOGL_ERROR, "cannot send ID_ACK " + "message. Reason: %s\n", strerror(errno)); + } } - return 0; + return ret; } else if (link->port == IPA_TCP_PORT_OML) e1i_ts = &link->line->ts[0]; else if (link->port == IPA_TCP_PORT_RSL) -- 1.7.10.4 --9jxsPFA5p3P2qPhR--

11 years, 8 months

1
0
0 0

[PATCH 04/13] ipaccess: improve error handling

by Pablo Neira Ayuso

If we hit any error, spot an error message containing the reason and close the links to start over. This patch has been tested by injecting errors in: * ipaccess_send, by randomly returning -1. * returning error from the ->sign_link_up callback, both from the OML and RSL links. * returning error from the ->sign_link callback, both for the OML and RSL links. With this patch, Valgrind shows no "definitely lost" memory blocks anymore (including the error path that has been tested) and the ipaccess driver behaves more robustly in case of errors. --- src/input/ipaccess.c | 199 +++++++++++++++++++++++++++++++++++--------------- 1 file changed, 141 insertions(+), 58 deletions(-) diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index a3c3b70..4ab08db 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -189,26 +189,39 @@ int ipaccess_send_id_req(int fd) /* base handling of the ip.access protocol */ int ipaccess_rcvmsg_base(struct msgb *msg, struct osmo_fd *bfd) { - int ipa_ccm = 0; uint8_t msg_type = *(msg->l2h); - int ret = 0; + int ret; switch (msg_type) { case IPAC_MSGT_PING: - ipa_ccm = 1; ret = ipaccess_send_pong(bfd->fd); + if (ret < 0) { + LOGP(DLINP, LOGL_ERROR, "Cannot send PING " + "message. Reason: %s\n", strerror(errno)); + break; + } + ret = 1; break; case IPAC_MSGT_PONG: DEBUGP(DLMI, "PONG!\n"); - ipa_ccm = 1; + ret = 1; break; case IPAC_MSGT_ID_ACK: DEBUGP(DLMI, "ID_ACK? -> ACK!\n"); - ipa_ccm = 1; ret = ipaccess_send_id_ack(bfd->fd); + if (ret < 0) { + LOGP(DLINP, LOGL_ERROR, "Cannot send ID_ACK " + "message. Reason: %s\n", strerror(errno)); + break; + } + ret = 1; + break; + default: + /* This is not an IPA PING, PONG or ID_ACK message */ + ret = 0; break; } - return ipa_ccm; + return ret; } /* base handling of the ip.access protocol */ @@ -221,6 +234,10 @@ int ipaccess_rcvmsg_bts_base(struct msgb *msg, switch (msg_type) { case IPAC_MSGT_PING: ret = ipaccess_send_pong(bfd->fd); + if (ret < 0) { + LOGP(DLINP, LOGL_ERROR, "Cannot send PONG " + "message. Reason: %s\n", strerror(errno)); + } break; case IPAC_MSGT_PONG: DEBUGP(DLMI, "PONG!\n"); @@ -229,12 +246,12 @@ int ipaccess_rcvmsg_bts_base(struct msgb *msg, DEBUGP(DLMI, "ID_ACK\n"); break; } - return 0; + return ret; } static int ipaccess_drop(struct osmo_fd *bfd) { - int ret = 0; + int ret = 1; struct e1inp_line *line = bfd->data; /* Error case: we did not see any ID_RESP yet for this socket. */ @@ -264,8 +281,23 @@ static int ipaccess_rcvmsg(struct e1inp_line *line, struct msgb *msg, int len, ret; /* Handle IPA PING, PONG and ID_ACK messages. */ - if (ipaccess_rcvmsg_base(msg, bfd)) + ret = ipaccess_rcvmsg_base(msg, bfd); + switch(ret) { + case -1: + /* error in IPA control message handling */ + goto err; + case 1: + /* this is an IPA control message, skip further processing */ return 0; + case 0: + /* this is not an IPA control message, continue */ + break; + default: + LOGP(DLINP, LOGL_ERROR, "Unexpected return from " + "ipaccess_rcvmsg_base " + "(ret=%d)\n", ret); + goto err; + } switch (msg_type) { case IPAC_MSGT_ID_RESP: @@ -379,17 +411,16 @@ static int handle_ts1_read(struct osmo_fd *bfd) struct e1inp_sign_link *link; struct ipaccess_head *hh; struct msgb *msg; - int ret = 0, error; - - error = ipa_msg_recv(bfd->fd, &msg); - if (error < 0) - return error; - else if (error == 0) { - if (ipaccess_drop(bfd) >= 0) { - LOGP(DLINP, LOGL_NOTICE, "Sign link vanished, " - "dead socket\n"); - } - return error; + int ret; + + ret = ipa_msg_recv(bfd->fd, &msg); + if (ret < 0) { + LOGP(DLINP, LOGL_NOTICE, "Sign link problems, " + "closing socket. Reason: %s\n", strerror(errno)); + goto err; + } else if (ret == 0) { + LOGP(DLINP, LOGL_NOTICE, "Sign link vanished, dead socket\n"); + goto err; } DEBUGP(DLMI, "RX %u: %s\n", ts_nr, osmo_hexdump(msgb_l2(msg), msgb_l2len(msg))); @@ -397,7 +428,7 @@ static int handle_ts1_read(struct osmo_fd *bfd) if (hh->proto == IPAC_PROTO_IPACCESS) { ipaccess_rcvmsg(line, msg, bfd); msgb_free(msg); - return ret; + return 0; } /* BIG FAT WARNING: bfd might no longer exist here, since ipaccess_rcvmsg() * might have free'd it !!! */ @@ -406,8 +437,8 @@ static int handle_ts1_read(struct osmo_fd *bfd) if (!link) { LOGP(DLINP, LOGL_ERROR, "no matching signalling link for " "hh->proto=0x%02x\n", hh->proto); - msgb_free(msg); - return -EIO; + ret = -EINVAL; + goto err_msg; } msg->dst = link; @@ -416,20 +447,21 @@ static int handle_ts1_read(struct osmo_fd *bfd) LOGP(DLINP, LOGL_ERROR, "Fix your application, " "no action set for signalling messages.\n"); ret = -EINVAL; - goto err; + goto err_msg; } if (e1i_ts->line->ops->sign_link(msg) < 0) { LOGP(DLINP, LOGL_ERROR, "Bad signalling message," "sign_link returned error: %s\n", osmo_hexdump(msgb_l2(msg), msgb_l2len(msg))); ret = -EINVAL; + goto err; } - return ret; + + return 0; +err_msg: + msgb_free(msg); err: - osmo_fd_unregister(bfd); - close(bfd->fd); - bfd->fd = -1; - e1inp_line_put(line); + ipaccess_drop(bfd); return ret; } @@ -497,9 +529,9 @@ static int __handle_ts1_write(struct osmo_fd *bfd, struct e1inp_line *line) case E1INP_SIGN_RSL: break; default: - msgb_free(msg); bfd->when |= BSC_FD_WRITE; /* come back for more msg */ - return -EINVAL; + ret = -EINVAL; + goto out; } msg->l2h = msg->data; @@ -508,7 +540,11 @@ static int __handle_ts1_write(struct osmo_fd *bfd, struct e1inp_line *line) DEBUGP(DLMI, "TX %u: %s\n", ts_nr, osmo_hexdump(msg->l2h, msgb_l2len(msg))); ret = send(bfd->fd, msg->data, msg->len, 0); - msgb_free(msg); + if (ret != msg->len) { + LOGP(DLINP, LOGL_ERROR, "failed to send A-bis IPA signalling " + "message. Reason: %s\n", strerror(errno)); + goto err; + } /* set tx delay timer for next event */ e1i_ts->sign.tx_timer.cb = timeout_ts1_write; @@ -517,6 +553,12 @@ static int __handle_ts1_write(struct osmo_fd *bfd, struct e1inp_line *line) /* Reducing this might break the nanoBTS 900 init. */ osmo_timer_schedule(&e1i_ts->sign.tx_timer, 0, e1i_ts->sign.delay); +out: + msgb_free(msg); + return ret; +err: + ipaccess_drop(bfd); + msgb_free(msg); return ret; } @@ -571,7 +613,7 @@ static int ipaccess_bsc_oml_cb(struct ipa_server_link *link, int fd) line = e1inp_line_clone(tall_ipa_ctx, link->line); if (line == NULL) { LOGP(DLINP, LOGL_ERROR, "could not clone E1 line\n"); - return -1; + return -ENOMEM; } /* create virrtual E1 timeslots for signalling */ @@ -592,15 +634,25 @@ static int ipaccess_bsc_oml_cb(struct ipa_server_link *link, int fd) ret = osmo_fd_register(bfd); if (ret < 0) { LOGP(DLINP, LOGL_ERROR, "could not register FD\n"); - close(bfd->fd); - e1inp_line_put(line); - return ret; + goto err_line; } /* Request ID. FIXME: request LOCATION, HW/SW VErsion, Unit Name, Serno */ ret = ipaccess_send_id_req(bfd->fd); + if (ret < 0) { + LOGP(DLINP, LOGL_ERROR, "could not send ID REQ. Reason: %s\n", + strerror(errno)); + goto err_socket; + } + return ret; - return ret; +err_socket: + osmo_fd_unregister(bfd); +err_line: + close(bfd->fd); + bfd->fd = -1; + e1inp_line_put(line); + return ret; } static int ipaccess_bsc_rsl_cb(struct ipa_server_link *link, int fd) @@ -615,7 +667,7 @@ static int ipaccess_bsc_rsl_cb(struct ipa_server_link *link, int fd) line = e1inp_line_clone(tall_ipa_ctx, link->line); if (line == NULL) { LOGP(DLINP, LOGL_ERROR, "could not clone E1 line\n"); - return -1; + return -ENOMEM; } /* initialize the fds */ for (i = 0; i < ARRAY_SIZE(line->ts); ++i) @@ -636,14 +688,24 @@ static int ipaccess_bsc_rsl_cb(struct ipa_server_link *link, int fd) ret = osmo_fd_register(bfd); if (ret < 0) { LOGP(DLINP, LOGL_ERROR, "could not register FD\n"); - close(bfd->fd); - e1inp_line_put(line); - return ret; + goto err_line; } /* Request ID. FIXME: request LOCATION, HW/SW VErsion, Unit Name, Serno */ ret = ipaccess_send_id_req(bfd->fd); + if (ret < 0) { + LOGP(DLINP, LOGL_ERROR, "could not send ID REQ. Reason: %s\n", + strerror(errno)); + goto err_socket; + } + return ret; - return 0; +err_socket: + osmo_fd_unregister(bfd); +err_line: + close(bfd->fd); + bfd->fd = -1; + e1inp_line_put(line); + return ret; } static struct msgb * @@ -736,18 +798,21 @@ static int ipaccess_bts_cb(struct ipa_client_conn *link, struct msgb *msg) struct ipaccess_head *hh = (struct ipaccess_head *) msg->data; struct e1inp_ts *e1i_ts = NULL; struct e1inp_sign_link *sign_link; + struct msgb *rmsg; + int ret = 0; /* special handling for IPA CCM. */ if (hh->proto == IPAC_PROTO_IPACCESS) { uint8_t msg_type = *(msg->l2h); /* ping, pong and acknowledgment cases. */ - ipaccess_rcvmsg_bts_base(msg, link->ofd); + ret = ipaccess_rcvmsg_bts_base(msg, link->ofd); + if (ret < 0) + goto err; /* this is a request for identification from the BSC. */ if (msg_type == IPAC_MSGT_ID_GET) { struct e1inp_sign_link *sign_link; - struct msgb *rmsg; uint8_t *data = msgb_l2(msg); int len = msgb_l2len(msg); @@ -756,10 +821,8 @@ static int ipaccess_bts_cb(struct ipa_client_conn *link, struct msgb *msg) LOGP(DLINP, LOGL_ERROR, "Unable to set signal link, " "closing socket.\n"); - osmo_fd_unregister(link->ofd); - close(link->ofd->fd); - link->ofd->fd = -1; - return -EINVAL; + ret = -EINVAL; + goto err; } sign_link = link->line->ops->sign_link_up(msg, link->line, @@ -768,22 +831,32 @@ static int ipaccess_bts_cb(struct ipa_client_conn *link, struct msgb *msg) LOGP(DLINP, LOGL_ERROR, "Unable to set signal link, " "closing socket.\n"); - osmo_fd_unregister(link->ofd); - close(link->ofd->fd); - link->ofd->fd = -1; - return -EINVAL; + ret = -EINVAL; + goto err; } rmsg = ipa_bts_id_resp(link->line->ops->cfg.ipa.dev, data + 1, len - 1); - ipaccess_send(link->ofd->fd, rmsg->data, rmsg->len); + ret = ipaccess_send(link->ofd->fd, rmsg->data, + rmsg->len); + if (ret != rmsg->len) { + LOGP(DLINP, LOGL_ERROR, "cannot send ID_RESP " + "message. Reason: %s\n", strerror(errno)); + goto err_rmsg; + } msgb_free(rmsg); /* send ID_ACK. */ rmsg = ipa_bts_id_ack(); - ipaccess_send(link->ofd->fd, rmsg->data, rmsg->len); + ret = ipaccess_send(link->ofd->fd, rmsg->data, + rmsg->len); + if (ret != rmsg->len) { + LOGP(DLINP, LOGL_ERROR, "cannot send ID_ACK " + "message. Reason: %s\n", strerror(errno)); + goto err_rmsg; + } msgb_free(rmsg); } - return 0; + return ret; } else if (link->port == IPA_TCP_PORT_OML) e1i_ts = &link->line->ts[0]; else if (link->port == IPA_TCP_PORT_RSL) @@ -794,8 +867,8 @@ static int ipaccess_bts_cb(struct ipa_client_conn *link, struct msgb *msg) if (sign_link == NULL) { LOGP(DLINP, LOGL_ERROR, "no matching signalling link for " "hh->proto=0x%02x\n", hh->proto); - msgb_free(msg); - return -EIO; + ret = -EIO; + goto err; } msg->dst = sign_link; @@ -803,10 +876,20 @@ static int ipaccess_bts_cb(struct ipa_client_conn *link, struct msgb *msg) if (!link->line->ops->sign_link) { LOGP(DLINP, LOGL_ERROR, "Fix your application, " "no action set for signalling messages.\n"); - return -ENOENT; + ret = -ENOENT; + goto err; } link->line->ops->sign_link(msg); return 0; + +err_rmsg: + msgb_free(rmsg); +err: + osmo_fd_unregister(link->ofd); + close(link->ofd->fd); + link->ofd->fd = -1; + msgb_free(msg); + return ret; } struct ipaccess_line { -- 1.7.10.4 --J2SCkAp4GZ/dPZZf--

11 years, 8 months

1
0
0 0

[PATCH] ipaccess: fix leak of e1inp_line

by Pablo Neira Ayuso

Holger reported a leak in the ipaccess_drop path and a patch to fix this. This is a new version of the patch posted that also handle the case in which only one of the link (OML / RSL) is established and no ID_RESP was received. Based on patch of Holger Freyther. --- src/e1_input.c | 1 + src/input/hsl.c | 4 +--- src/input/ipaccess.c | 4 +--- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/e1_input.c b/src/e1_input.c index 957b74c..a85dd91 100644 --- a/src/e1_input.c +++ b/src/e1_input.c @@ -486,6 +486,7 @@ void e1inp_sign_link_destroy(struct e1inp_sign_link *link) if (link->ts->line->driver->close) link->ts->line->driver->close(link); + e1inp_line_put(link->ts->line); talloc_free(link); } diff --git a/src/input/hsl.c b/src/input/hsl.c index 3dcba1d..b86d7f6 100644 --- a/src/input/hsl.c +++ b/src/input/hsl.c @@ -82,10 +82,8 @@ static void hsl_drop(struct e1inp_line *line, struct osmo_fd *bfd) osmo_fd_unregister(bfd); close(bfd->fd); bfd->fd = -1; + e1inp_line_put(line); } - /* put the virtual E1 line that we cloned for this socket, if - * it becomes unused, it gets released. */ - e1inp_line_put(line); } static int process_hsl_rsl(struct msgb *msg, struct e1inp_line *line, diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index 76d1994..4c50640 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -248,10 +248,8 @@ static int ipaccess_drop(struct osmo_fd *bfd) close(bfd->fd); bfd->fd = -1; ret = -ENOENT; + e1inp_line_put(line); } - /* put the virtual E1 line that we cloned for this socket, if - * it becomes unused, it gets released. */ - e1inp_line_put(line); return ret; } -- 1.7.10.4 --OgqxwSJOaUobr8KG--

11 years, 8 months

1
0
0 0

OpenGGSN over OpenBSC+LCR+Asterisk

by Arturo Rivas

Hi list! I have a working installation of OpenBSC+LCR+Asterisk in my system and now, I want to install OpenGGSN in addiction. I am trying tutorial of the next link: http://openbsc.osmocom.org/trac/wiki/OpenBSC_GPRS and I don't know if the new compilation of osmo-nitb will crash previous installation. I think that I have to install new programs in the same location where previous are but if I am not sure about because this could crash it. Thank you! Arturo Rivas.

11 years, 8 months

3
2
0 0

Aug 22, 8pm / Osmocom Berlin User Group meeting

by Harald Welte

Hi all! This is the announcement for the next Osmocom Berlin meeting. Aug 22, 8pm @ CCC Berlin, Marienstr. 11, 10113 Berlin There is no formal presentation scheduled for this meeting. However, updates will be provided on various current developments, such as * Progress on the CC32RS512 smart card (osmo-cos) * Possibly: Status of current attempts to get CSD implemented in OpenBSC If you are interested to show up, feel free to do so. There is no registration required. The meeting is free as in "free beer", despite no actual free beer being around. Regards, Harald -- - Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)

11 years, 8 months

1
0
0 0

libosmo-sccp and static archives

by Diego Elio Pettenò

Hello, I was going on with the autotools cleanup (in order of listing in cgit) but I'm a bit surprised about the libosmo-sccp structure, which contrarily to libosmocore, libosmo-abis and libosmo-dsp is not using libtool, but it's actually building three static archives, with one source file each. Now, I don't know if it might be too late to consider changing this but I'm wondering why it has been done this way; when using a shared object it might make sense (although the overhead of using more than one object is probably higher than loading the unused code), but with static archives all the Unix link editors I know only take by default only the objects that are actually needed by what it's being linked; that is using a single libosmo-sccp.a will only bring in the final linking the object files that are actually needed. I also wonder if it wouldn't make more sense to have everything built in the same project/source tree with libosmocore — in general this seems to be small enough, and the time/space spent for these three files is probably well recovered by the extra ./configure run that it has to run. Let me know if I can be of help — I'll still send the autotools cleanup for this project today I think. -- Diego Elio Pettenò — Flameeyes flameeyes(a)flameeyes.eu — http://blog.flameeyes.eu/

11 years, 9 months

3
4
0 0

Re: Any interest for Osmocom meetings in Bavaria ?

by Dieter Spaar

Hello Alexander, On Wed, 8 Aug 2012 20:44:12 +0400, "Alexander Chemeris" <alexander.chemeris(a)gmail.com> wrote: > > I'd love to join, but it strongly depends on the exact dates of the > meeting. I have very tight travel schedule in the next months. Just to avoid any misunderstanding: Those meetings are not supposed to be something similar to the Osmocom Developer Conference earlier this year. The idea is to have a regular or "on demand" oportunity to meet with people for a few hours and demonstrate or talk about the Osmocom projects or share new ideas. Its comparable to the regular Berlin meetings, you can get an idea of what goes on there: http://openbsc.osmocom.org/trac/blog/osmug-20120808 Of course you can attend, if you are close (Munich airport is 120 km away) but I would expect that Berlin is more convenient if you come from really far away and Berlin already has regular meetings. Best regards, Dieter -- Dieter Spaar, Germany spaar(a)mirider.augusta.de

11 years, 9 months

1
0
0 0

Re: Any interest for Osmocom meetings in Bavaria ?

by Dieter Spaar

As a quick follow up: The proposal for the meeting is intended for everyone interested in the various Osmocom projects (e.g. OpenBSC, OsmocomBB, TETRA, SimTrace, OsmoSDR). The meeting is not limited to only those who are actively participating. I will wait until next week to see how many people are interested, so far I am aware of two persons. Best regards, Dieter -- Dieter Spaar, Germany spaar(a)mirider.augusta.de

11 years, 9 months

2
1
0 0

Any interest for Osmocom meetings in Bavaria ?

by Dieter Spaar

I would like to ask if there is interest to have some kind of Osmocom meetings in Bavaria. Suggested location is here at my place in the south-east of Bavaria near Pfarrkirchen. There are no large cities close, but the location is still in reach with a car, some examples (single distance): - from Munich: 130 km - from Passau: 55 km - from Salzburg: 90 km - from Linz: 140 km Why at my place ? There is some GSM/3G/TETRA equipment and RF measurement gear around which could be demonstrated. It is not yet decided when and how (regular or "on demand") this meeting should take place. Before that I want to find out if there is interest at all and how many people are interested. So please write to the list what you think. Best regards, Dieter -- Dieter Spaar, Germany spaar(a)mirider.augusta.de

11 years, 9 months

1
0
0 0

Re: August 8, 8pm / Osmocom meeting in Berlin

by Harald Welte

Hi Matihas, On Mon, Aug 06, 2012 at 11:17:27PM +0200, Mathias K. wrote: > Where is the conference number? ;-). It would be nice to meet this > event virtually for none berlin citizens. Sorry, I don't really like the idea of having an unknown number of people listening in on conversations we have face to face. > Maybe there is some planning, maybe there is no reason/possibility to > do that. But there are some interesting topics that i want to hear, > maybe discuss. I suggest that you post any comments / questions / topics to the respective mailing lists. -- - Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)

11 years, 9 months

1
0
0 0

August 8, 8pm / Osmocom meeting in Berlin

by Harald Welte

Hi all! This is the announcement for the next Osmocom Berlin meeting. Aug 08, 8pm @ CCC Berlin, Marienstr. 11, 10113 Berlin Harald will be giving a short presentation on contemporary smartphone hardware architecture. Furthermore, updates and discussions on various current developments will be exchanged, such as * Demo of OsmoPCU on sysmoBTS * Status of new SMSC * Planning phase of custom calypso board If you are interested to show up, feel free to do so. There is no registration required. The meeting is free as in "free beer", despite no actual free beer being around. Updates and the blog post can be found here: http://openbsc.osmocom.org/trac/blog/osmug-20120808 -- - Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)

11 years, 9 months

1
0
0 0

[PATCH] Add missing includes to timer_test.c and osmo-auc-gen.c

by Chí-Thanh Christopher Nguyễn

This fixes the build with -Werror-implicit-function-declaration. --- tests/timer/timer_test.c | 1 + utils/osmo-auc-gen.c | 1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/tests/timer/timer_test.c b/tests/timer/timer_test.c index 61079bd..ba3127d 100644 --- a/tests/timer/timer_test.c +++ b/tests/timer/timer_test.c @@ -26,6 +26,7 @@ #include <stdlib.h> #include <signal.h> #include <getopt.h> +#include <unistd.h> #include <osmocom/core/talloc.h> #include <osmocom/core/timer.h> diff --git a/utils/osmo-auc-gen.c b/utils/osmo-auc-gen.c index 266d0d6..1a78477 100644 --- a/utils/osmo-auc-gen.c +++ b/utils/osmo-auc-gen.c @@ -26,6 +26,7 @@ #include <errno.h> #include <string.h> #include <getopt.h> +#include <time.h> #include <osmocom/crypt/auth.h> #include <osmocom/core/utils.h> -- 1.7.8.6

11 years, 9 months

3
2
0 0

HLR and EAP-SIM integration

by Thus0 Petrus

Hello everybody, I'm trying to make a testbed for EAP-SIM with freeradius to authenticate on a WLAN network. it works well thanks to the patch provided by seek-for-android : you can see the details here : http://code.google.com/p/seek-for-android/wiki/EapSimAka but you need to store IMSI, RAND, SRES, KC in a flat file as by default, we don't have the Ki of SIM cards and don't have a HLR so we need to precalculate these values. For our testbed, we're using some MagicSIM we've programmed with our own Ki. So I wonder if anybody has already done some integration of freeradius with openbsc HLR to do EAP-SIM ? Or is there a tool to calculate the triplets (RAND, SRES, KC) with input the IMSI (and Ki stored in the database) ? If not, could someone points me where to start to write my own tool ? I don't think pysim can do it... I found an entry about A3/A8 authentication here http://openbsc.osmocom.org/trac/changeset/3606cc576502b95d4973fac2af76d1b9b… int get_authtuple_by_subscr(struct gsm_auth_tuple *atuple, struct gsm_subscriber *subscr) ...but I want to calculate gsm_auth_tuple, not retreive it from the database... Thanks for any information :) -- Thus0

11 years, 9 months

2
1
0 0

EMFCamp - A UK Hackcamp this summer!

by Paul Dart

Hello ! Although not entirely on topic, Harold is happy for me to post to these lists about an event I've been involved in. Electromagnetic Field is a UK hacker/maker camp that is occurring in just under a months time. In case you haven't, here's the gist: Electromagnetic Field is a non-profit three day camping festival for people with an inquisitive mind or an interest in making things: hackers, geeks, scientists, engineers, artists, and craftspeople. It's taking place in Milton Keynes between the 31st August and the 2nd September and is inspired by European camps such as the Chaos Communication Camp and Hacking At Random, which means that we have an absurd internet connection to a field, and power to every tent. There will be talks and workshops on everything from genetic modification to lockpicking, blacksmithing to high-energy physics, reverse engineering to electronic engineering, quadcopters to beer brewing and crocheting to carpentry. If you decide to talk about something, there's space for you to do so, and plenty of people who want to listen. The campsite will be littered with interesting things to play with and explore, from ride-on tanks to giant dinosaurs. And more lasers than you can shake a laser-covered stick at. Attendees are encouraged to form villages and put on activities for other people around the camp, and we're going to have villages covering everything from gaming to 3D printing. If you'd like to form a village, get in touch! https://www.emfcamp.org/tickets Your ticket will give you the following things: * A secure place to camp for three days. * Power to your tent. * Very fast internet access (both wired and wireless). * Access to running water and hot showers. * A whole pile of awesome talks and workshops by amazing people. * A full bar. * One fully programmable camp badge, equipped with wireless communications. * A campsite equipped with weird and wonderful things to play with. * A weekend unlike any other in the UK. If we've still not sold you, maybe you should read our website and blog, which have exhaustive information about the camp: https://www.emfcamp.org http://blog.emfcamp.org If you've got any questions feel free to email me or the team! Paul

11 years, 9 months

1
0
0 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

OpenBSC August 2012