May 2011 - OpenBSC - lists.osmocom.org

by jason mercury

I have some questions: 1) When I start bsc_hack bsc_init.c first establishes OML link and initializes the bts then it establishes RSL link and bts starts broadcasting. However, it takes so much time to start the bts. Instead of this I want to do the following: it establishes OML link at the beginning and only once, then when i want to start broadcasting it establishes just the RSL link and bts will start faster since i don't have to wait for OML link. What should be done for this? 2) If i send one or two word messages from telnet interface it is okay. But if i send a longer message the phone could't receive the end of the message correctly(last words may be incomplete). Did any one encounter with this problem? What is wrong with me? 3) Could I send SMS in which extension of the sender is text not integer. For example, i want to send an information SMS that this is a test network. For this purpose i want to send an SMS from 'OpenBSC'. I set the extension of the first subscriber in database as text and tried to send the SMS but SMS wasn't delivered. What should i do? 4) Can i add SMS externally to SMS table of database? Thanks. Jason

11 years, 4 months

4
3
0 0

sms bugfix

by Dennis Wehrle

Hello Our goal was to send status sms via the vty interface. But all of our sms were cropped. In contrast sms from one MS to another MS are displayed correctly (despite the fact, that the text at the database contains several '@' at the end / the user_data contains several zero-octets). Therefore i have inspect the code and found several bugs. The main problem is that the "user_data_len" is not correctly used. As per GSM 03.40, 9.2.3.16 TP‑User‑Data‑Length (TP‑UDL): "If the TP‑User‑Data is coded using the GSM 7 bit default alphabet, the TP‑User‑Data‑Length field gives an integer representation of the number of septets within the TP‑User‑Data field to follow." Currently the "user_data_len" contains the number of octets (returned from gsm_7bit_encode(...) at gsm_utils.c (libosmocore)). The big problem here is that this information is not unique, e.g.: 1.) 46 non-extension characters + 1 extension character => (46 * 7 bit + (1 * (2 * 7 bit))) / 8 bit = 42 octets 2.) 47 non-extension characters => (47 * 7 bit) / 8 bit = 41,125 = 42 octets 3.) 48 non-extension characters => (48 * 7 bit) / 8 bit = 42 octects But the MS has to know the correct "user_data_len" to decode the correct number of characters. For this reason i updated the gsm_7bit_encode() function to return the correct number of septets. However sometimes it is needed to know the correct number of octets (e.g. at gsm_04_11.c: gsm340_gen_tpdu(...)) => i added a function to gsm_utils.c named: uint8_t get_octet_len(const uint8_t sept_len) I have also fixed the problem, that the sms are wrongly stored / displayed on the database. But the solution on the function *sms_from_result(...) (at db.c) is not really "beautiful". This is because there exists no "user_data_len" field at the database. To store the right value for "user_data_len" (which is further needed) i have to get the length from the "text" field. Unfortunately this is not enough. If the text contains extension characters like {[]} etc. then the "user_data_len" has to be bigger because these characters needs two septets. Therefore i use a switch statement so search for these characters. A better solution for that is to store the right "user_data_len" to the database (on the encoding / decoding procedure). But i don't know if this is a suitable solution for all of you (because you have to change your database structure etc.). Best Regards Dennis Wehrle

12 years, 8 months

6
24
0 0

Licensing of the wiki

by Harald Welte

Hi all, so far we do not have any statement about the licensing of the content on our wiki. This means the default copyright rules apply: All the content is copyrighted, and nobody has any rgiht to reproduce it at all. I would like to propose an official license for the content in the wiki: Create Commons CC-BY-SA. The alternative would be to go for CC-BY-NC-SA, disallowing commercial use of the content. I'm not certain if NC is really what we want. After all, even somebody using OpenBSC in a commercial environment should be able to make copies of the reference documentation we have available - as long as he will releas the result again (which the SA part already covers). If the major contributors to the wiki would agree to a license, I would update the wiki accordingly. Thanks, Harald -- - Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)

12 years, 9 months

3
3
0 0

Re: SGSN Crash

by Holger Hans Peter Freyther

On 05/30/2011 06:27 AM, Seungju Kim wrote: > Hello, I am experiencing some crash with osmo-sgsn. > This is the log : http://pastebin.com/XP8RcaaNI didnt make any modification except removing imsi roaming check. > Every time when a phone tries to connect this happens. What might be wrong? Hi, please make yourself gdb and git and create a patch. The struct msgb has detected a mis-use and forced a crash. What is going wrong is in the log, you will need to identify where this msgb got allocated (or change the panic message to print the name of the msgb) and see why it is using the amount of headroom it wants to use. happy hacking holger

12 years, 10 months

3
6
0 0

[PATCH 00/10] Control interface for OpenBSC

by Daniel Willmann

Hello, this patchset adds an SNMP-like control interface to OpenBSC. Currently you can set and get variables. This interface is enabled in osmo-bsc, osmo-bsc_nat, and in osmo-nitb. It currently supports querying the counters and rate counters, setting and querying the rf_locked status, and geographical location. In osmo-bsc_nat forwarding is implemented to set/query stuff in the actual osmo-bsc. The patches are located in the daniel/controlif branch. Please merge them if you feel they are ready or point me to the problems. Regards Daniel Willmann (10): Add documentation for the control interface protocol Add example to communicate through the control interface Add libctrl, an SNMP-like control interface libctrl: Add macros to help define commands libctrl: Add commands to query counters and rate_cntr bsc_hack: Use libctrl, listen on port 4249 osmo_bsc: Use libctrl, handle ctrl cmds on port 4249 or from the nat osmo_bsc: Add some libctrl commands libctrl: Add ctrl_cmd_cpy() to copy a command nat: Use libctrl and add command forwarding to osmo-bsc openbsc/configure.in | 1 + openbsc/contrib/bsc_control.py | 100 +++++ openbsc/doc/control-interface.txt | 21 + openbsc/include/openbsc/bsc_nat.h | 22 + openbsc/include/openbsc/control_cmd.h | 151 +++++++ openbsc/src/Makefile.am | 2 +- openbsc/src/libctrl/Makefile.am | 7 + openbsc/src/libctrl/control_cmd.c | 479 +++++++++++++++++++++++ openbsc/src/libctrl/control_if.c | 627 ++++++++++++++++++++++++++++++ openbsc/src/osmo-bsc/Makefile.am | 1 + openbsc/src/osmo-bsc/osmo_bsc_main.c | 167 ++++++++ openbsc/src/osmo-bsc/osmo_bsc_msc.c | 34 ++ openbsc/src/osmo-bsc_nat/Makefile.am | 1 + openbsc/src/osmo-bsc_nat/bsc_nat.c | 279 +++++++++++++ openbsc/src/osmo-bsc_nat/bsc_nat_utils.c | 1 + openbsc/src/osmo-nitb/Makefile.am | 3 +- openbsc/src/osmo-nitb/bsc_hack.c | 3 + 17 files changed, 1897 insertions(+), 2 deletions(-) create mode 100755 openbsc/contrib/bsc_control.py create mode 100644 openbsc/doc/control-interface.txt create mode 100644 openbsc/include/openbsc/control_cmd.h create mode 100644 openbsc/src/libctrl/Makefile.am create mode 100644 openbsc/src/libctrl/control_cmd.c create mode 100644 openbsc/src/libctrl/control_if.c -- 1.7.5.rc3

12 years, 10 months

2
11
0 0

Only nanoBTS, or any femtocell?

by Bthomas

Dear OpenBSC lovers and developers! question, I turn towards you again: if the operation OpenBSC nanoBTS and A-bis Over IP basis, you think any of the femtocell (eg Vodafone's preferred cells) are able to operate in the same way? I think that the same standard as well do they work? What is your opinion? For more information: http://wirelessfederation.com/news/74803-vodafone-hungary-launches-3ghsdpa-… Thank You, and have nice day! bthomyka from Hungary

12 years, 10 months

2
1
0 0

Re: SGSN Crash

by Sylvain Munaut

> Hello, I am experiencing some crash with osmo-sgsn. > This is the log : http://pastebin.com/XP8RcaaN > I didnt make any modification except removing imsi roaming check. > Every time when a phone tries to connect this happens. What might be wrong? Build with debug symbols so that the backtrace makes sense ... Cheers, Sylvain

12 years, 10 months

1
0
0 0

GPRS

by Seungju Kim

Hello, I am trying to make a GPRS/EDGE capable network using OpenBSC. These are my config files and results from console http://pastebin.com/rCW6cCeU But I still don't see any data indicator when I connect my iPhone to the network. What do you think is wrong? Sent from my iPhone

12 years, 10 months

1
0
0 0

Roaming

by Seungju Kim

How does the phone know if it is roaming or not? When my phone camps to OpenBTS network it says it is roaming but in OpenBSC it doesn't. I wonder what makes such difference Sent from my iPhone

12 years, 10 months

2
2
0 0

NanoBTS for sale?!

by Luca Bongiorni

Hi guys, someone has a NanoBTS for purchase or could send me in private, some european re-sellers?! Possibly, a version that fully supports A5/1-2 and openGGSN. Thank you for attention Cheers Luca

12 years, 10 months

2
2
0 0

two questions

by Hans Witvliet

Hi all, Got two questions: Firstly, i would like to know if it is possible to have bts and bsc at completely different locations: can the connections be encapsulated in a vpn tunnel (openvpn, ipsec). Or is that connection very sensitive to latency? Secondly, anybody ever looked at the new nanobts/femtobts from "radio access"? Probably they don't manufacture those themselves, but are re-selling it allong with their own bsc/nomc/hlr (clarity) Clarity should be able to handle the new nanobts aswell as the model from ipaccess. >From what i read, it is scalled down model compared to the nano-bts from ipaccess. And scaleddown in two aspects: Limited power: just 200mW and price: around 50 euro. hw

12 years, 10 months

4
3
0 0

OpenBSC operate FemtoCells?

by Bthomas

Dear OpenBSC lovers and developers! My questions is follow: 1. The OpenBSC software operate FemtoCell? (installed OpenBSC generate firmware to FemtoCell devices or operate FemtoCell devices? it is not clear to me) 2. If question nr1 is yes, you do not need any other hardware? (e.g. usrp device or BS11 or anything) 3. If question nr1 and nr2 both yes, then FemtoCell device and OpenBSC the combined use of mini private GSM network? I would like to deal with her hobby, and a better-cheaper-FemtoCell device access, such as a usrp device. Thank you for your answers! bthomyka from Hungary(EU) [ bthomas at mailbox dot hu ]

12 years, 10 months

1
0
0 0

Roaming

by Seungju Kim

How does the phone know if it is roaming or not? When my phone camps to OpenBTS network it says it is roaming but in OpenBSC it doesn't. I wonder what makes such difference Sent from my iPhone

12 years, 10 months

1
0
0 0

Cannot compile OpenBSC

by Steve Mortimer

Hi, I have followed the instructions on building openBSC and have used the git versions of both libosmocore and openbsc. libosmocore builds fine but openbsc gives the following error when running make (after autoreconf -i && ./configure) Making all in libcommon make[3]: Entering directory `/home/user/Desktop/openbsc_git/openbsc/src/libcommon' CC common_vty.o In file included from common_vty.c:27: ../../include/openbsc/gsm_data.h:26: error: nested redefinition of ‘enum gsm_phys_chan_config’ ../../include/openbsc/gsm_data.h:26: error: redeclaration of ‘enum gsm_phys_chan_config’ ../../include/openbsc/gsm_data.h:27: error: redeclaration of enumerator ‘GSM_PCHAN_NONE’ /usr/local/include/osmocom/gsm/gsm_utils.h:119: note: previous definition of ‘GSM_PCHAN_NONE’ was here ../../include/openbsc/gsm_data.h:28: error: redeclaration of enumerator ‘GSM_PCHAN_CCCH’ /usr/local/include/osmocom/gsm/gsm_utils.h:120: note: previous definition of ‘GSM_PCHAN_CCCH’ was here ../../include/openbsc/gsm_data.h:29: error: redeclaration of enumerator ‘GSM_PCHAN_CCCH_SDCCH4’ /usr/local/include/osmocom/gsm/gsm_utils.h:121: note: previous definition of ‘GSM_PCHAN_CCCH_SDCCH4’ was here ../../include/openbsc/gsm_data.h:30: error: redeclaration of enumerator ‘GSM_PCHAN_TCH_F’ /usr/local/include/osmocom/gsm/gsm_utils.h:122: note: previous definition of ‘GSM_PCHAN_TCH_F’ was here ../../include/openbsc/gsm_data.h:31: error: redeclaration of enumerator ‘GSM_PCHAN_TCH_H’ /usr/local/include/osmocom/gsm/gsm_utils.h:123: note: previous definition of ‘GSM_PCHAN_TCH_H’ was here ../../include/openbsc/gsm_data.h:32: error: redeclaration of enumerator ‘GSM_PCHAN_SDCCH8_SACCH8C’ /usr/local/include/osmocom/gsm/gsm_utils.h:124: note: previous definition of ‘GSM_PCHAN_SDCCH8_SACCH8C’ was here ../../include/openbsc/gsm_data.h:33: error: redeclaration of enumerator ‘GSM_PCHAN_PDCH’ /usr/local/include/osmocom/gsm/gsm_utils.h:125: note: previous definition of ‘GSM_PCHAN_PDCH’ was here ../../include/openbsc/gsm_data.h:34: error: redeclaration of enumerator ‘GSM_PCHAN_TCH_F_PDCH’ /usr/local/include/osmocom/gsm/gsm_utils.h:126: note: previous definition of ‘GSM_PCHAN_TCH_F_PDCH’ was here ../../include/openbsc/gsm_data.h:35: error: redeclaration of enumerator ‘GSM_PCHAN_UNKNOWN’ /usr/local/include/osmocom/gsm/gsm_utils.h:127: note: previous definition of ‘GSM_PCHAN_UNKNOWN’ was here ../../include/openbsc/gsm_data.h:37: error: redeclaration of enumerator ‘_GSM_PCHAN_MAX’ /usr/local/include/osmocom/gsm/gsm_utils.h:129: note: previous definition of ‘_GSM_PCHAN_MAX’ was here ../../include/openbsc/gsm_data.h:39: error: nested redefinition of ‘enum gsm_chan_t’ ../../include/openbsc/gsm_data.h:39: error: redeclaration of ‘enum gsm_chan_t’ ../../include/openbsc/gsm_data.h:40: error: redeclaration of enumerator ‘GSM_LCHAN_NONE’ /usr/local/include/osmocom/gsm/gsm_utils.h:133: note: previous definition of ‘GSM_LCHAN_NONE’ was here ../../include/openbsc/gsm_data.h:41: error: redeclaration of enumerator ‘GSM_LCHAN_SDCCH’ /usr/local/include/osmocom/gsm/gsm_utils.h:134: note: previous definition of ‘GSM_LCHAN_SDCCH’ was here ../../include/openbsc/gsm_data.h:42: error: redeclaration of enumerator ‘GSM_LCHAN_TCH_F’ /usr/local/include/osmocom/gsm/gsm_utils.h:135: note: previous definition of ‘GSM_LCHAN_TCH_F’ was here ../../include/openbsc/gsm_data.h:43: error: redeclaration of enumerator ‘GSM_LCHAN_TCH_H’ /usr/local/include/osmocom/gsm/gsm_utils.h:136: note: previous definition of ‘GSM_LCHAN_TCH_H’ was here ../../include/openbsc/gsm_data.h:44: error: redeclaration of enumerator ‘GSM_LCHAN_UNKNOWN’ /usr/local/include/osmocom/gsm/gsm_utils.h:137: note: previous definition of ‘GSM_LCHAN_UNKNOWN’ was here ../../include/openbsc/gsm_data.h:45: error: redeclaration of enumerator ‘GSM_LCHAN_CCCH’ /usr/local/include/osmocom/gsm/gsm_utils.h:138: note: previous definition of ‘GSM_LCHAN_CCCH’ was here ../../include/openbsc/gsm_data.h:47: error: redeclaration of enumerator ‘_GSM_LCHAN_MAX’ /usr/local/include/osmocom/gsm/gsm_utils.h:140: note: previous definition of ‘_GSM_LCHAN_MAX’ was here make[3]: *** [common_vty.o] Error 1 make[3]: Leaving directory `/home/user/openbsc_git/openbsc/src/libcommon' make[2]: *** [all-recursive] Error 1 make[2]: Leaving directory `/home/user/openbsc_git/openbsc/src' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/user/openbsc_git/openbsc' make: *** [all] Error 2 Any ideas? Steve

12 years, 10 months

2
3
0 0

[PATCH 0/2] libosmocore: autoconf improvements

by Alexander Huemer

These are improvements for the autoconf input of libosmocore. Please integrate them, if they seem useful. Alexander Huemer (2): libosmocore: add missing AC_LANG_SOURCE for current autoconf libosmocore: rename configure.in -> configure.ac configure.in => configure.ac | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

12 years, 11 months

2
3
0 0

[PATCH 0/2] libosmo-sccp: various improvements

by Alexander Huemer

These are improvements for the autoconf input of libosmo-sccp, and an update to .gitignore. Please integrate them, if they seem useful. Alexander Huemer (2): libosmo-sccp: add missing AC_LANG_SOURCE for current autoconf libosmo-sccp: update .gitignore .gitignore | 2 ++ configure.ac | 2 +- 2 files changed, 3 insertions(+), 1 deletions(-)

12 years, 11 months

1
2
0 0

[PATCH 0/4] openbsc: various improvements and fixes

by Alexander Huemer

These are improvements for the autoconf input of openbsc, an update to .gitignore, and a fix for a segfault. Please integrate them, if they seem useful. Alexander Huemer (4): openbsc: add missing AC_LANG_SOURCE for current autoconf openbsc: rename configure.in -> configure.ac openbsc: update .gitignore libabis: fix segfault on malformed ipaccess RSL link openbsc/.gitignore | 3 +++ openbsc/{configure.in => configure.ac} | 2 +- openbsc/src/libabis/input/ipaccess.c | 5 ++++- 3 files changed, 8 insertions(+), 2 deletions(-)

12 years, 11 months

1
4
0 0

[PATCH 0/3] new VTY commands to enable IPA proxy

by pablo＠gnumonks.org

From: Pablo Neira Ayuso <pablo(a)gnumonks.org> Hi! This patchset adds new VTY commands that allows to route IPA flows. Patch 3/3 includes one feature that changes the current default behaviour of OpenBSC since you explicity have to make a "ipa setup" to enable OML and RSL links. If you like it, I can make a similar patch for HSL femto, so the only initial open socket is the one at port 4242 for telnet configuration. BTW, the original command syntax was proposed by Harald. Successfully tested bootstrapping the nanoBTS. See the patches for more details. Comments welcome! Pablo Neira Ayuso (3): libcommon: add make_sock_stream_connect() libabis: add VTY commands to route IPA flows libabis: add IPA VTY command to setup ip.access nanoBTS OML and RSL links openbsc/include/openbsc/ipaccess.h | 3 + openbsc/include/openbsc/socket.h | 2 + openbsc/include/openbsc/vty.h | 1 + openbsc/src/ipaccess/Makefile.am | 4 +- openbsc/src/libabis/Makefile.am | 2 +- openbsc/src/libabis/e1_input.c | 2 + openbsc/src/libabis/input/ipaccess.c | 962 +++++++++++++++++++++++++++++- openbsc/src/libbsc/bsc_vty.c | 1 + openbsc/src/libcommon/socket.c | 54 ++ openbsc/src/openbsc.cfg.ipa-proxy | 18 + openbsc/src/openbsc.cfg.nanobts | 3 + openbsc/src/openbsc.cfg.nanobts.multitrx | 3 + openbsc/tests/db/Makefile.am | 5 +- 13 files changed, 1043 insertions(+), 17 deletions(-) create mode 100644 openbsc/src/openbsc.cfg.ipa-proxy -- 1.7.2.3

12 years, 11 months

3
5
0 0

[PATCH 0/4] openBSC: minor fixes and updates

by pablo＠gnumonks.org

From: Pablo Neira Ayuso <pablo(a)gnumonks.org> This patchset contains minor fixes and updates. You can find them in pablo/updates branch. Merge it if you consider that they're OK. Thanks. Pablo Neira Ayuso (4): abis: skip e1_input nesting if empty libbsc: fix bail out in case of problems bootstrapping BTS or E1 input libabis: add init function for emulated ipaccess/HSL emulated E1 input bsc: on-demand setup of nanoBTS and HSL femto sockets openbsc/include/openbsc/Makefile.am | 3 ++- openbsc/include/openbsc/bss.h | 17 +++++++++++++++++ openbsc/include/openbsc/e1_input.h | 1 + openbsc/include/openbsc/gsm_data.h | 3 +++ openbsc/src/libabis/e1_input.c | 4 ++++ openbsc/src/libabis/e1_input_vty.c | 3 +++ openbsc/src/libabis/input/hsl.c | 11 +++++------ openbsc/src/libabis/input/ipaccess.c | 11 +++++------ openbsc/src/libbsc/Makefile.am | 2 +- openbsc/src/libbsc/bsc_init.c | 23 ++++++++++++++--------- openbsc/src/libbsc/bts_ericsson_rbs2000.c | 10 +++++++++- openbsc/src/libbsc/bts_hsl_femtocell.c | 11 ++++++++++- openbsc/src/libbsc/bts_init.c | 29 +++++++++++++++++++++++++++++ openbsc/src/libbsc/bts_ipaccess_nanobts.c | 12 +++++++++++- openbsc/src/libbsc/bts_siemens_bs11.c | 10 +++++++++- openbsc/src/libcommon/gsm_data.c | 8 ++++++++ openbsc/src/osmo-bsc/osmo_bsc_main.c | 11 ++--------- openbsc/src/osmo-nitb/bsc_hack.c | 17 ++--------------- 18 files changed, 135 insertions(+), 51 deletions(-) create mode 100644 openbsc/include/openbsc/bss.h create mode 100644 openbsc/src/libbsc/bts_init.c -- 1.7.2.3

12 years, 11 months

2
5
0 0

fix missing all logging command option

by Pablo Neira Ayuso

Hi Holger, Thanks for fixing this, I missed it: http://cgit.osmocom.org/cgit/libosmocore/commit/?id=952a18ed19f531b82e26108… However, this fix is incomplete: /* This generates the logging command string for VTY. */ const char *log_vty_command_string(const struct log_info *info) { int len = 0, offset = 0, ret, i, rem; int size = strlen("logging level () ()") + 1; ^^ We also have to add `(all|' there.

12 years, 11 months

2
2
0 0

Problems suspected to be related to _output() rework

by Harald Welte

Hi Pablo! I am sometimes getting osmo-nitb segfaults, and sometimes random bytes as output of log messages. I've quickly started it in valgrind, and even during connection of the BTS I get the following issues: <000d> input/ipaccess.c:693 accept()ed new OML link from 192.168.200.117 ==21897== Conditional jump or move depends on uninitialised value(s) ==21897== at 0x60D4BD4: vfprintf (vfprintf.c:1620) ==21897== by 0x60F8F01: vsnprintf (vsnprintf.c:120) ==21897== by 0x4E33670: _output (logging.c:177) ==21897== by 0x4E33878: _logp (logging.c:227) ==21897== by 0x4E33BCB: logp2 (logging.c:246) ==21897== by 0x435E5C: listen_fd_cb (ipaccess.c:692) ==21897== by 0x4E32419: osmo_select_main (select.c:132) ==21897== by 0x40555B: main (bsc_hack.c:306) ==21897== ==21897== Use of uninitialised value of size 8 ==21897== at 0x60D5008: vfprintf (vfprintf.c:1620) ==21897== by 0x60F8F01: vsnprintf (vsnprintf.c:120) ==21897== by 0x4E33670: _output (logging.c:177) ==21897== by 0x4E33878: _logp (logging.c:227) ==21897== by 0x4E33BCB: logp2 (logging.c:246) ==21897== by 0x435E5C: listen_fd_cb (ipaccess.c:692) ==21897== by 0x4E32419: osmo_select_main (select.c:132) ==21897== by 0x40555B: main (bsc_hack.c:306) ==21897== ==21897== Use of uninitialised value of size 8 ==21897== at 0x6101CE0: _IO_default_xsputn (genops.c:480) ==21897== by 0x60D4ED3: vfprintf (vfprintf.c:1620) ==21897== by 0x60F8F01: vsnprintf (vsnprintf.c:120) ==21897== by 0x4E33670: _output (logging.c:177) ==21897== by 0x4E33878: _logp (logging.c:227) ==21897== by 0x4E33BCB: logp2 (logging.c:246) ==21897== by 0x435E5C: listen_fd_cb (ipaccess.c:692) ==21897== by 0x4E32419: osmo_select_main (select.c:132) ==21897== by 0x40555B: main (bsc_hack.c:306) ==21897== ==21897== Conditional jump or move depends on uninitialised value(s) ==21897== at 0x6101CF2: _IO_default_xsputn (genops.c:479) ==21897== by 0x60D4ED3: vfprintf (vfprintf.c:1620) ==21897== by 0x60F8F01: vsnprintf (vsnprintf.c:120) ==21897== by 0x4E33670: _output (logging.c:177) ==21897== by 0x4E33878: _logp (logging.c:227) ==21897== by 0x4E33BCB: logp2 (logging.c:246) ==21897== by 0x435E5C: listen_fd_cb (ipaccess.c:692) ==21897== by 0x4E32419: osmo_select_main (select.c:132) ==21897== by 0x40555B: main (bsc_hack.c:306) ==21897== <000d> input/ipaccess.c:755 accept()ed new RSL link from 192.168.200.117 <0004> bsc_init.c:251 bootstrapping RSL for BTS/TRX (0/0) on ARFCN 871 using MCC=602 MNC=42 LAC=1 CID=0 BSIC=63 TSC=7 ==21897== Use of uninitialised value of size 8 ==21897== at 0x60D2EDB: _itoa_word (_itoa.c:195) ==21897== by 0x60D5386: vfprintf (vfprintf.c:1619) ==21897== by 0x60F8F01: vsnprintf (vsnprintf.c:120) ==21897== by 0x4E33670: _output (logging.c:177) ==21897== by 0x4E33878: _logp (logging.c:227) ==21897== by 0x4E33BCB: logp2 (logging.c:246) ==21897== by 0x410141: inp_sig_cb (bsc_init.c:247) Can you please investigate? I suspect it to be related to your recent _output() related changes in libosmocore. Regards, Harald -- - Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)

12 years, 11 months

4
10
0 0

comment on ipaccess-find: Work without providing an interface name

by Pablo Neira Ayuso

Hi Holger, I think this patch is wrong: http://cgit.osmocom.org/cgit/openbsc/commit/?id=d3080be1317cfa0269b1c12c8f2… ifname should be set if argc == 2, but it seems to be set if argc < 2, in that case argv[1] is always NULL.

12 years, 11 months

2
1
0 0

Re: Reseting Unit-ID on nanoBTS

by Holger Hans Peter Freyther

On 05/15/2011 06:05 PM, henry han wrote: > 你好! Ni Hao! do you think you could try to write in English?

12 years, 11 months

1
0
0 0

Wanted: dpkg/deb/rpm package maintainer

by Harald Welte

Hi all, for quite some time we've been having debian dpkg packaging information as part of our libosmocore, libosmo-sccp, openggsn and openbsc repositories. As the library ABI sis now considered stable, it starts to make sense not only to release source tarballs, but also to offer .deb packages for ubunto and debian, probably both i386 and amd64 and lenny, squeeze and natty as well as ubuntu 10.04. The resulting packages could initially be hosted on an osmoxom.org apt feed that people can wimply put in their sources.list We're looking for somebody with dpkg packaging experience, who would volunteer to take care of building the deb files and maintaining that apt feed. If somebody wants to take care about RPM packaging, that would of course be also welcome. Thanks in advance, Harald -- Sent from a mobile device, excuse my short response

12 years, 11 months

1
0
0 0

Osmocom project vs. sysmocom GmbH

by Harald Welte

Hi all! As some of you already know, Holger and I have recently started a new company called "sysmocom - systems for mobile communications GmbH". The process of establishing the new company has now formally concluded. Before some rumours start to spread, we would like to clarify some points and make sure there is mutual understanding between the Osmocom community and the sysmocom company. sysmocom is intended to provide commercial offerings related to the Osmocom projects. This is not entirely new. Especially on the network side, people like Holger and I have been doing quite a lot of paid development to bring those projects forward. We would not have many of the features we have today, if it wasn't for customers who actually pay us for development of OpenBSC, OsmoBSC, OsmoSGSN and the various side projects more targetted at a real network operator like cellmgr-ng, bsc-nat, gb_proxy - just to name a few. However, this has always only been freelancing development of Software. With sysmocom, we want to go one step further and work on hardware products related to the various Free Software projects. Right now I don't want to talk too much about unfinished products, but we are working towards an inexpensive BTS product, we are funding the prototypes for Osmocom SIMtrace, and we will likely also see stuff like OpenBSC appliances. Given our past involvement and exposure into other projects that share a split Free Software / business set-up, we think we understand very well where potential issues of conflict between the two sides may be. Let me make some more clarification what this is not about: * sysmocom is not about creating proprietary derivates of Osmocom software. We work on Free Software which is publicly available under OSI approved and FSF endorsed licenses. We may offer proprietary hardware and sometimes software - but those are independent projects from existing Osmocom software. * we specifically will not have a public and a non-public version of the same program with differences in features. * sysmocom is not a VC-funded startup. It's a very small company run out of personal funds with no intention to take external funding or grow rapidly. Nobody but Holger and I determine where it goes and what it does. * sysmocom does not hold any copyright on the Free Software projects. The copyrights stay distributed with the major authors such as Holger, Onwaves, Sylvain, Dieter, Andreas and myself. None of the others have any affiliation with sysmocom. I have (personally, unrelated to sysmocom) asked some of the smaller contributors for a copyright transfer to make sure we could do the AGPLv3 transition, or future re-licensing decisions without having to ask dozens and dozens of people. sysmocom does not seek to control the Free Software projects. * we will maintain a strict separation between the community side of things and the business side. Unlike some other popular projects, we will not end up in a situation where the osmocom.org websites will be full of advertisements and hidden links that lure you on the company website. * we will keep a strict separation of naming. Osmocom is for the FOSS projects, sysmocom for the business. The company will use the term "Osmocom" only in descriptive context, not as a product name, brand or for advertisement. If you do have any concerns, please feel free to share them. However, I'd like to avoid cross-posting them throguh different mailing lists. Please follow-up-to openbsc(a)lists.osmocom.org Regards, Harald -- - Harald Welte <hwelte(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Schivelbeiner Str. 5 * 10439 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschaeftsfuehrer / Managing Directors: Holger Freyther, Harald Welte

12 years, 11 months

1
0
0 0

Sim programmer Software for Linux

by Steve Mortimer

Hi, I am after recommendations for software that will allow me to program Super SIM's, etc. I have seen the recent thread on programmer's and understand that a CCID compliant reader is recommended. Many thanks, Steve

12 years, 11 months

2
4
0 0

FrOSCon 2011 - DevRoom anyone?

by Peter Hasse

Hi I'm happy to invite you to the up comming FrOSCon. Like last year we can offer a developer room for the weekend and a official Licences to use one RFCN. We would futher be me more than happy to find some opensource GSM talks in our CFP. The FrOSCon 2011 takes palce in Sank Ausgustin near Bonn in Germany from the 20. to 21. August (one week after the CCC Camp). Below you find the offical CFP invite email. Looking forward to see some of you at FrOSCon 2011 mfg Peter Meanwhile, preparations for the sixth FrOSCon are well underway. This year's FrOSCon takes place on August 20th/21st 2011. We thought you might be interested to hear that the Call for Projects has started. If you as a project want to participate again, please visit https://callforprojects.froscon.org/ and sign up for a room or booth, depending on your needs. Since the demand for developer rooms and booths exceeds the number of rooms and booth we can offer, we need a short summary (1-2 paragraphs) of what you plan to do. On the basis of this text we will choose the projects that appear most promising to us. The deadline for submission of projects is 23rd May 2011. Additionally our Call for Papers has started, so we are looking forward to your submissions of talks. Please visit http://www.froscon.de/en/program/call- for-papers.html for further information. The Call for Papers will end on 23rd May 2011 If you have questions concerning the developer rooms feel free to contact projects(a)froscon.org <https://mng.derpeter.net/horde/imp/message.php?mailbox=FrOSCon.Orga&index=5…>. For questions concerning a booth contact exhibitors(a)froscon.org <https://mng.derpeter.net/horde/imp/message.php?mailbox=FrOSCon.Orga&index=5…> We would love to see all of you again in August. Also, please spread the word and help make this year's FrOSCon's special. Kind regards, Patrick Hallen The FrOSCon Team -- Address: FrOSCon e.V. c/o FH Bonn-Rhein-Sieg Grantham-Allee 20 53757 Sankt Augustin E-Mail: projects(a)froscon.org <https://mng.derpeter.net/horde/imp/message.php?mailbox=FrOSCon.Orga&index=5…> Homepage: http://www.froscon.org

12 years, 11 months

1
0
0 0

Planning for Radio Village at 2011 CCC Camp

by Harald Welte

Hi all! [This message is cross-posted to many lists, please be careful when replying to it! Think twice if your respones really matters to all those projects...] In order to do some better planning for our Camp activities this summer, I would like to request all people who intend to participate in the radio village to add themselves to the wiki: https://events.ccc.de/camp/2011/wiki/index.php/RadioVillage The list of citizens is auto-generated if you use Person template like I have done in my user page at https://events.ccc.de/camp/2011/wiki/index.php/User:LaForge The large main tent is not really intended as a place to sleep, but more like a place where we set up our gear and work on the various projects, similar to what happened at HAR. Thanks in advance! -- - Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)

12 years, 11 months

1
0
0 0

Questions

by Christopher HENARD

Hello everyone, 1) Is it possible to act as a nano BTS and send packets to open BSC ? But how to do that since openBSC uses config files (openbsc.cfg.nanobts, ...) ? 2)I can't get last source code with git, the command always results in a timeout: git clone git://git.osmocom.org/openbsc.git Cloning into openbsc... git.osmocom.org[0: 213.95.46.201]: errno=Connection timed out git.osmocom.org[0: 2001:780:45:f046::201]: errno=Network is unreachable fatal: unable to connect a socket (Network is unreachable) Would that be possible to update the tarballs on the wiki? It seems the current tarball of openBSC (http://openbsc.osmocom.org/trac/wiki) doesn't contains config files in the osmo-nitb directory. There's only source and makefile. The wiki mention 'OpenBSC has a configuration file. The default config file name is *openbsc.cfg* in the current working directory of the osmo-nitb process.' Thank you, Chris

12 years, 11 months

5
18
0 0

[ANN] libosmocore stable API/ABI

by Harald Welte

Hi all! I think now that the namespace issues in libosmocore have been resolved, we seriously have to think of maintaining a stable API and ABI. This allows us to have truly independent library and application releases, and the dynamic linker library versioning support should ensure compatibility. So please think twice about any modifying libosmocore. It is safe to add new functions, but we cannot change the prototypes (number of arguments) for existing functions. As soon as new functions are introduced, we should increment the library interface number. For more information, see http://www.gnu.org/software/libtool/manual/libtool.html#Versioning especially the rules in Chapter 7.3: # If the library source code has changed at all since the last update, then increment revision (‘c:r:a’ becomes ‘c:r+1:a’). # If any interfaces have been added, removed, or changed since the last update, increment current, and set revision to 0. # If any interfaces have been added since the last public release, then increment age. # If any interfaces have been removed or changed since the last public release, then set age to 0. Regards, Harald -- - Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)

12 years, 11 months

2
2
0 0

[ADM] osmocom.org via IPv6

by Harald Welte

Hi all, JFYI: For a couple of days, *.osmocom.org is reachable via IPv6. I've had native IPv6 at my co-located servers for more than 10 years, but somehow never configured it for the virtual machines like *.osmocom.org - this is now fixed. If you encounter any difficulties, please let me know. Regards, Harald -- - Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)

12 years, 11 months

1
0
0 0

[PATCH 0/4] libosmocore: namespace pollution fixes (2/*)

by pablo＠gnumonks.org

From: Pablo Neira Ayuso <pablo(a)gnumonks.org> This patchset fixes the namespace pollution spotted by Harald: * bcd2char, char2bcd -> osmo_bcd2char, osmo_char2bcd * crc16 -> osmo_crc16 * generate_backtrace -> osmo_generate_backtrace * plugin_load_all -> osmo_plugin_load_all * msg_entry_parse -> osmo_config_list This patchset is a follow up, it comes after: [PATCH 0/5] libosmocore: namespace pollution fixes (1/*) 2nd try You can find the whole branch at pablo/namespace. Please, merge it. Thanks! Pablo Neira Ayuso (4): crc: use namespace prefix osmo_* backtrace: use namespace prefix osmo_* plugin: use namespace prefix osmo_* msgfile: use namespace prefix osmo_* and use more descriptive names include/osmocom/core/backtrace.h | 2 +- include/osmocom/core/crc16.h | 8 ++++---- include/osmocom/core/msgfile.h | 8 ++++---- include/osmocom/core/plugin.h | 2 +- src/backtrace.c | 2 +- src/crc16.c | 6 +++--- src/gsm/gprs_cipher_core.c | 2 +- src/msgfile.c | 22 ++++++++++++---------- src/panic.c | 2 +- src/plugin.c | 4 ++-- tests/msgfile/msgfile_test.c | 8 ++++---- 11 files changed, 34 insertions(+), 32 deletions(-) -- 1.7.2.3

12 years, 11 months

3
7
0 0

cellmgr-ng / libosmocore namespace changes

by Harald Welte

Hi Holger, for your convenience I have prepared a branch that makes cellmgr-ng compile against the recent libosmocore namespace changes. You can find it in 'cellmgr-ng.git:laforge/namespace' Regards, Harald -- - Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)

12 years, 11 months

1
0
0 0

[PATCH 0/5] libosmocore: namespace pollution fixes (1/*) 2nd try

by pablo＠gnumonks.org

From: Pablo Neira Ayuso <pablo(a)gnumonks.org> Hi! This is the first patchset that fixes the namespace pollution in libosmocore. You can find in the patch description the sed regular expression to automate the replacement of the function/structure names, e.g: s/struct counter/struct osmo_counter/g s/counter_inc/osmo_counter_inc/g s/counter_get/osmo_counter_get/g s/counter_reset/osmo_counter_reset/g s/counter_alloc/osmo_counter_alloc/g s/counter_free/osmo_counter_free You can use the following script: cat /tmp/replace.txt | while read REPLACE do echo "performing sed \"$REPLACE\"..." find ./ -type f -exec sed -i "$REPLACE" {} \; done The /tmp/replace.txt file have to contain the list of sed regular expressions, one per line. Thus, you can get in sync your branches in a couple of minutes. The entire list of changes in this patchset is the following: s/struct timer_list/struct osmo_timer_list/g s/bsc_add_timer/osmo_timer_add/g s/bsc_schedule_timer/osmo_timer_schedule/g s/bsc_del_timer/osmo_timer_del/g s/bsc_timer_pending/osmo_timer_pending/g s/bsc_nearest_timer/osmo_timers_nearest/g s/bsc_prepare_timers/osmo_timers_prepare/g s/bsc_update_timers/osmo_timers_update/g s/bsc_timer_check/osmo_timers_check/g s/struct bsc_fd/struct osmo_fd/g s/bsc_register_fd/osmo_fd_register/g s/bsc_unregister_fd/osmo_fd_unregister/g s/bsc_select_main/osmo_select_main/g s/signal_cbfn/osmo_signal_cbfn/g s/register_signal_handler/osmo_signal_register_handler/g s/unregister_signal_handler/osmo_signal_unregister_handler/g s/dispatch_signal/osmo_signal_dispatch/g s/struct write_queue/struct osmo_wqueue/g s/write_queue_init/osmo_wqueue_init/g s/write_queue_clear/osmo_wqueue_clear/g s/write_queue_enqueue/osmo_wqueue_enqueue/g s/write_queue_bfd_cb/osmo_wqueue_bfd_cb/g s/struct counter/struct osmo_counter/g s/counter_inc/osmo_counter_inc/g s/counter_get/osmo_counter_get/g s/counter_reset/osmo_counter_reset/g s/counter_alloc/osmo_counter_alloc/g s/counter_free/osmo_counter_free/g You can find it in the pablo/namespace branch. Please, merge it! Pablo Neira Ayuso (5): timer: use namespace prefix osmo_timer* select: use namespace prefix osmo_fd* and osmo_select* signal: use namespace prefix osmo_signal* write-queue: use namespace prefix osmo_wqueue* statistics: use namespace prefix osmo_counter* include/osmocom/core/select.h | 10 +++++----- include/osmocom/core/signal.h | 15 +++++++-------- include/osmocom/core/statistics.h | 16 ++++++++-------- include/osmocom/core/timer.h | 20 ++++++++++---------- include/osmocom/core/write_queue.h | 22 +++++++++++----------- include/osmocom/vty/telnet_interface.h | 2 +- src/gsmtap_util.c | 12 ++++++------ src/rate_ctr.c | 6 +++--- src/select.c | 30 +++++++++++++++--------------- src/signal.c | 11 +++++++---- src/statistics.c | 15 ++++++++------- src/timer.c | 29 +++++++++++++++-------------- src/vty/telnet_interface.c | 18 +++++++++--------- src/write_queue.c | 14 +++++++------- tests/timer/timer_test.c | 18 +++++++++--------- 15 files changed, 121 insertions(+), 117 deletions(-) -- 1.7.2.3

12 years, 11 months

4
8
0 0

[PATCH 1/5] utils: use namespace prefix osmo_*

by pablo＠gnumonks.org

From: Pablo Neira Ayuso <pablo(a)gnumonks.org> Summary of changes: s/bcd2char/osmo_bcd2char/g s/char2bcd/osmo_char2bcd/g s/hexparse/osmo_hexparse/g s/hexdump/osmo_hexdump/g s/hexdump_nospc/osmo_hexdump_nospc/g s/ubit_dump/osmo_ubit_dump/g s/static_assert/osmo_static_assert/g --- include/osmocom/core/msgb.h | 2 +- include/osmocom/core/utils.h | 14 +++++++------- src/gsm/gsm48.c | 12 ++++++------ src/utils.c | 18 +++++++++--------- 4 files changed, 23 insertions(+), 23 deletions(-) diff --git a/include/osmocom/core/msgb.h b/include/osmocom/core/msgb.h index 57b5d7f..8665c2b 100644 --- a/include/osmocom/core/msgb.h +++ b/include/osmocom/core/msgb.h @@ -181,7 +181,7 @@ static inline void msgb_reserve(struct msgb *msg, int len) static inline struct msgb *msgb_alloc_headroom(int size, int headroom, const char *name) { - static_assert(size > headroom, headroom_bigger); + osmo_static_assert(size > headroom, headroom_bigger); struct msgb *msg = msgb_alloc(size, name); if (msg) diff --git a/include/osmocom/core/utils.h b/include/osmocom/core/utils.h index 252228d..0f1ea3b 100644 --- a/include/osmocom/core/utils.h +++ b/include/osmocom/core/utils.h @@ -13,16 +13,16 @@ struct value_string { const char *get_value_string(const struct value_string *vs, uint32_t val); int get_string_value(const struct value_string *vs, const char *str); -char bcd2char(uint8_t bcd); +char osmo_bcd2char(uint8_t bcd); /* only works for numbers in ascci */ -uint8_t char2bcd(char c); +uint8_t osmo_char2bcd(char c); -int hexparse(const char *str, uint8_t *b, int max_len); -char *hexdump(const unsigned char *buf, int len); -char *hexdump_nospc(const unsigned char *buf, int len); -char *ubit_dump(const uint8_t *bits, unsigned int len); +int osmo_hexparse(const char *str, uint8_t *b, int max_len); +char *osmo_hexdump(const unsigned char *buf, int len); +char *osmo_osmo_hexdump_nospc(const unsigned char *buf, int len); +char *osmo_ubit_dump(const uint8_t *bits, unsigned int len); -#define static_assert(exp, name) typedef int dummy##name [(exp) ? 1 : -1]; +#define osmo_static_assert(exp, name) typedef int dummy##name [(exp) ? 1 : -1]; void osmo_str2lower(char *out, const char *in); void osmo_str2upper(char *out, const char *in); diff --git a/src/gsm/gsm48.c b/src/gsm/gsm48.c index 436bf14..d034589 100644 --- a/src/gsm/gsm48.c +++ b/src/gsm/gsm48.c @@ -301,7 +301,7 @@ int gsm48_generate_mid_from_imsi(uint8_t *buf, const char *imsi) uint8_t odd = (length & 0x1) == 1; buf[0] = GSM48_IE_MOBILE_ID; - buf[2] = char2bcd(imsi[0]) << 4 | GSM_MI_TYPE_IMSI | (odd << 3); + buf[2] = osmo_char2bcd(imsi[0]) << 4 | GSM_MI_TYPE_IMSI | (odd << 3); /* if the length is even we will fill half of the last octet */ if (odd) @@ -312,11 +312,11 @@ int gsm48_generate_mid_from_imsi(uint8_t *buf, const char *imsi) for (i = 1; i < buf[1]; ++i) { uint8_t lower, upper; - lower = char2bcd(imsi[++off]); + lower = osmo_char2bcd(imsi[++off]); if (!odd && off + 1 == length) upper = 0x0f; else - upper = char2bcd(imsi[++off]) & 0x0f; + upper = osmo_char2bcd(imsi[++off]) & 0x0f; buf[2 + i] = (upper << 4) | lower; } @@ -349,15 +349,15 @@ int gsm48_mi_to_string(char *string, const int str_len, const uint8_t *mi, case GSM_MI_TYPE_IMSI: case GSM_MI_TYPE_IMEI: case GSM_MI_TYPE_IMEISV: - *str_cur++ = bcd2char(mi[0] >> 4); + *str_cur++ = osmo_bcd2char(mi[0] >> 4); for (i = 1; i < mi_len; i++) { if (str_cur + 2 >= string + str_len) return str_cur - string; - *str_cur++ = bcd2char(mi[i] & 0xf); + *str_cur++ = osmo_bcd2char(mi[i] & 0xf); /* skip last nibble in last input byte when GSM_EVEN */ if( (i != mi_len-1) || (mi[0] & GSM_MI_ODD)) - *str_cur++ = bcd2char(mi[i] >> 4); + *str_cur++ = osmo_bcd2char(mi[i] >> 4); } break; default: diff --git a/src/utils.c b/src/utils.c index af1829c..3ee14ab 100644 --- a/src/utils.c +++ b/src/utils.c @@ -35,7 +35,7 @@ int get_string_value(const struct value_string *vs, const char *str) return -EINVAL; } -char bcd2char(uint8_t bcd) +char osmo_bcd2char(uint8_t bcd) { if (bcd < 0xa) return '0' + bcd; @@ -44,12 +44,12 @@ char bcd2char(uint8_t bcd) } /* only works for numbers in ascii */ -uint8_t char2bcd(char c) +uint8_t osmo_char2bcd(char c) { return c - 0x30; } -int hexparse(const char *str, uint8_t *b, int max_len) +int osmo_hexparse(const char *str, uint8_t *b, int max_len) { int i, l, v; @@ -78,7 +78,7 @@ int hexparse(const char *str, uint8_t *b, int max_len) static char hexd_buff[4096]; -static char *_hexdump(const unsigned char *buf, int len, char *delim) +static char *_osmo_hexdump(const unsigned char *buf, int len, char *delim) { int i; char *cur = hexd_buff; @@ -95,7 +95,7 @@ static char *_hexdump(const unsigned char *buf, int len, char *delim) return hexd_buff; } -char *ubit_dump(const uint8_t *bits, unsigned int len) +char *osmo_ubit_dump(const uint8_t *bits, unsigned int len) { int i; @@ -125,14 +125,14 @@ char *ubit_dump(const uint8_t *bits, unsigned int len) return hexd_buff; } -char *hexdump(const unsigned char *buf, int len) +char *osmo_hexdump(const unsigned char *buf, int len) { - return _hexdump(buf, len, " "); + return _osmo_hexdump(buf, len, " "); } -char *hexdump_nospc(const unsigned char *buf, int len) +char *osmo_osmo_hexdump_nospc(const unsigned char *buf, int len) { - return _hexdump(buf, len, ""); + return _osmo_hexdump(buf, len, ""); } #include "../config.h" -- 1.7.2.3

12 years, 11 months

1
4
0 0

[PATCH] utils: use namespace prefix osmo_*

by Pablo Neira Ayuso

Summary of changes: s/bcd2char/osmo_bcd2char/g s/char2bcd/osmo_char2bcd/g s/hexparse/osmo_hexparse/g s/hexdump/osmo_hexdump/g s/hexdump_nospc/osmo_hexdump_nospc/g s/ubit_dump/osmo_ubit_dump/g s/static_assert/osmo_static_assert/g --- include/osmocom/core/msgb.h | 2 +- include/osmocom/core/utils.h | 14 +++++++------- src/gsm/gsm48.c | 12 ++++++------ src/utils.c | 18 +++++++++--------- 4 files changed, 23 insertions(+), 23 deletions(-) diff --git a/include/osmocom/core/msgb.h b/include/osmocom/core/msgb.h index 57b5d7f..8665c2b 100644 --- a/include/osmocom/core/msgb.h +++ b/include/osmocom/core/msgb.h @@ -181,7 +181,7 @@ static inline void msgb_reserve(struct msgb *msg, int len) static inline struct msgb *msgb_alloc_headroom(int size, int headroom, const char *name) { - static_assert(size > headroom, headroom_bigger); + osmo_static_assert(size > headroom, headroom_bigger); struct msgb *msg = msgb_alloc(size, name); if (msg) diff --git a/include/osmocom/core/utils.h b/include/osmocom/core/utils.h index 252228d..0f1ea3b 100644 --- a/include/osmocom/core/utils.h +++ b/include/osmocom/core/utils.h @@ -13,16 +13,16 @@ struct value_string { const char *get_value_string(const struct value_string *vs, uint32_t val); int get_string_value(const struct value_string *vs, const char *str); -char bcd2char(uint8_t bcd); +char osmo_bcd2char(uint8_t bcd); /* only works for numbers in ascci */ -uint8_t char2bcd(char c); +uint8_t osmo_char2bcd(char c); -int hexparse(const char *str, uint8_t *b, int max_len); -char *hexdump(const unsigned char *buf, int len); -char *hexdump_nospc(const unsigned char *buf, int len); -char *ubit_dump(const uint8_t *bits, unsigned int len); +int osmo_hexparse(const char *str, uint8_t *b, int max_len); +char *osmo_hexdump(const unsigned char *buf, int len); +char *osmo_osmo_hexdump_nospc(const unsigned char *buf, int len); +char *osmo_ubit_dump(const uint8_t *bits, unsigned int len); -#define static_assert(exp, name) typedef int dummy##name [(exp) ? 1 : -1]; +#define osmo_static_assert(exp, name) typedef int dummy##name [(exp) ? 1 : -1]; void osmo_str2lower(char *out, const char *in); void osmo_str2upper(char *out, const char *in); diff --git a/src/gsm/gsm48.c b/src/gsm/gsm48.c index 436bf14..d034589 100644 --- a/src/gsm/gsm48.c +++ b/src/gsm/gsm48.c @@ -301,7 +301,7 @@ int gsm48_generate_mid_from_imsi(uint8_t *buf, const char *imsi) uint8_t odd = (length & 0x1) == 1; buf[0] = GSM48_IE_MOBILE_ID; - buf[2] = char2bcd(imsi[0]) << 4 | GSM_MI_TYPE_IMSI | (odd << 3); + buf[2] = osmo_char2bcd(imsi[0]) << 4 | GSM_MI_TYPE_IMSI | (odd << 3); /* if the length is even we will fill half of the last octet */ if (odd) @@ -312,11 +312,11 @@ int gsm48_generate_mid_from_imsi(uint8_t *buf, const char *imsi) for (i = 1; i < buf[1]; ++i) { uint8_t lower, upper; - lower = char2bcd(imsi[++off]); + lower = osmo_char2bcd(imsi[++off]); if (!odd && off + 1 == length) upper = 0x0f; else - upper = char2bcd(imsi[++off]) & 0x0f; + upper = osmo_char2bcd(imsi[++off]) & 0x0f; buf[2 + i] = (upper << 4) | lower; } @@ -349,15 +349,15 @@ int gsm48_mi_to_string(char *string, const int str_len, const uint8_t *mi, case GSM_MI_TYPE_IMSI: case GSM_MI_TYPE_IMEI: case GSM_MI_TYPE_IMEISV: - *str_cur++ = bcd2char(mi[0] >> 4); + *str_cur++ = osmo_bcd2char(mi[0] >> 4); for (i = 1; i < mi_len; i++) { if (str_cur + 2 >= string + str_len) return str_cur - string; - *str_cur++ = bcd2char(mi[i] & 0xf); + *str_cur++ = osmo_bcd2char(mi[i] & 0xf); /* skip last nibble in last input byte when GSM_EVEN */ if( (i != mi_len-1) || (mi[0] & GSM_MI_ODD)) - *str_cur++ = bcd2char(mi[i] >> 4); + *str_cur++ = osmo_bcd2char(mi[i] >> 4); } break; default: diff --git a/src/utils.c b/src/utils.c index af1829c..3ee14ab 100644 --- a/src/utils.c +++ b/src/utils.c @@ -35,7 +35,7 @@ int get_string_value(const struct value_string *vs, const char *str) return -EINVAL; } -char bcd2char(uint8_t bcd) +char osmo_bcd2char(uint8_t bcd) { if (bcd < 0xa) return '0' + bcd; @@ -44,12 +44,12 @@ char bcd2char(uint8_t bcd) } /* only works for numbers in ascii */ -uint8_t char2bcd(char c) +uint8_t osmo_char2bcd(char c) { return c - 0x30; } -int hexparse(const char *str, uint8_t *b, int max_len) +int osmo_hexparse(const char *str, uint8_t *b, int max_len) { int i, l, v; @@ -78,7 +78,7 @@ int hexparse(const char *str, uint8_t *b, int max_len) static char hexd_buff[4096]; -static char *_hexdump(const unsigned char *buf, int len, char *delim) +static char *_osmo_hexdump(const unsigned char *buf, int len, char *delim) { int i; char *cur = hexd_buff; @@ -95,7 +95,7 @@ static char *_hexdump(const unsigned char *buf, int len, char *delim) return hexd_buff; } -char *ubit_dump(const uint8_t *bits, unsigned int len) +char *osmo_ubit_dump(const uint8_t *bits, unsigned int len) { int i; @@ -125,14 +125,14 @@ char *ubit_dump(const uint8_t *bits, unsigned int len) return hexd_buff; } -char *hexdump(const unsigned char *buf, int len) +char *osmo_hexdump(const unsigned char *buf, int len) { - return _hexdump(buf, len, " "); + return _osmo_hexdump(buf, len, " "); } -char *hexdump_nospc(const unsigned char *buf, int len) +char *osmo_osmo_hexdump_nospc(const unsigned char *buf, int len) { - return _hexdump(buf, len, ""); + return _osmo_hexdump(buf, len, ""); } #include "../config.h" -- 1.7.2.3 --------------080409000203030603090707--

12 years, 11 months

1
0
0 0

talloc linking / include magic

by Harald Welte

Hi Pablo, there is one more thing that would prevent libosmocore from being packaged by distributions right now: We include our own version of talloc. Debian, Fedora and Ubuntu e.g. by now have a shared libtalloc that we should probably use instead of our own copy. So what I'd like to see is: * split talloc.c from libosmocore and make a libosmotalloc instead * some autotools magic in the applications (openbsc, osmoocom-bb, osmo-tetra, etc.) that would try to # detect whether there is a system-wide libtalloc, if yes use it # if no, use libosmotalloc The only big question is how to deal with header files, as we do #include <osmocom/core/talloc.h> and in case of the system-wide libtalloc it should instead be #include <talloc.h> I don't really have a good idea how to handle this. Any ideas? Regards, Harald -- - Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)

12 years, 11 months

3
3
0 0

[PATCH 0/5] openbsc: sync with namespace changes in libosmocore (1/*)

by pablo＠gnumonks.org

From: Pablo Neira Ayuso <pablo(a)gnumonks.org> This patch gets openBSC in sync with the namespace pollution fixes available in the libosmocore pablo/namespace branch. See: [PATCH 0/5] libosmocore: namespace pollution fixes (1/*) 2nd try For further details. You can find this changes in the pablo/namespace branch. Please, merge it! Pablo Neira Ayuso (5): src: use namespace prefix osmo_timer* for timer functions src: use namespace prefix osmo_fd* and osmo_select* src: use namespace prefix osmo_signal* src: use namespace prefix osmo_wqueue* src: use namespace prefix osmo_counter* openbsc/doc/e1-data-model.txt | 2 +- openbsc/include/openbsc/bsc_msc.h | 6 +- openbsc/include/openbsc/bsc_nat.h | 32 ++++++------ openbsc/include/openbsc/db.h | 4 +- openbsc/include/openbsc/e1_input.h | 8 ++-- openbsc/include/openbsc/gprs_llc.h | 4 +- openbsc/include/openbsc/gprs_ns.h | 6 +- openbsc/include/openbsc/gprs_sgsn.h | 4 +- openbsc/include/openbsc/gsm_data.h | 76 ++++++++++++++-------------- openbsc/include/openbsc/ipaccess.h | 4 +- openbsc/include/openbsc/mgcp.h | 2 +- openbsc/include/openbsc/mgcp_internal.h | 4 +- openbsc/include/openbsc/osmo_bsc.h | 4 +- openbsc/include/openbsc/osmo_bsc_rf.h | 10 ++-- openbsc/include/openbsc/osmo_msc_data.h | 6 +- openbsc/include/openbsc/paging.h | 2 +- openbsc/include/openbsc/rtp_proxy.h | 2 +- openbsc/include/openbsc/sgsn.h | 8 ++-- openbsc/include/openbsc/socket.h | 4 +- openbsc/include/openbsc/transaction.h | 4 +- openbsc/src/gprs/gb_proxy_main.c | 6 +- openbsc/src/gprs/gprs_gmm.c | 18 +++--- openbsc/src/gprs/gprs_sndcp.h | 2 +- openbsc/src/gprs/sgsn_libgtp.c | 10 ++-- openbsc/src/gprs/sgsn_main.c | 4 +- openbsc/src/ipaccess/ipaccess-config.c | 6 +- openbsc/src/ipaccess/ipaccess-find.c | 16 +++--- openbsc/src/ipaccess/ipaccess-proxy.c | 72 ++++++++++++++-------------- openbsc/src/ipaccess/network_listen.c | 4 +- openbsc/src/libabis/e1_input.c | 12 ++-- openbsc/src/libabis/input/dahdi.c | 22 ++++---- openbsc/src/libabis/input/hsl.c | 24 +++++----- openbsc/src/libabis/input/ipaccess.c | 58 +++++++++++----------- openbsc/src/libabis/input/lapd.c | 8 ++-- openbsc/src/libabis/input/misdn.c | 18 +++--- openbsc/src/libbsc/abis_nm.c | 20 ++++---- openbsc/src/libbsc/abis_om2000.c | 6 +- openbsc/src/libbsc/abis_rsl.c | 26 +++++----- openbsc/src/libbsc/bsc_api.c | 14 +++--- openbsc/src/libbsc/bsc_init.c | 10 ++-- openbsc/src/libbsc/bsc_msc.c | 36 +++++++------- openbsc/src/libbsc/bsc_rll.c | 10 ++-- openbsc/src/libbsc/bsc_vty.c | 18 +++--- openbsc/src/libbsc/bts_ericsson_rbs2000.c | 6 +- openbsc/src/libbsc/bts_hsl_femtocell.c | 2 +- openbsc/src/libbsc/bts_ipaccess_nanobts.c | 2 +- openbsc/src/libbsc/bts_siemens_bs11.c | 4 +- openbsc/src/libbsc/chan_alloc.c | 14 +++--- openbsc/src/libbsc/gsm_04_08_utils.c | 2 +- openbsc/src/libbsc/handover_decision.c | 2 +- openbsc/src/libbsc/handover_logic.c | 26 +++++----- openbsc/src/libbsc/meas_proc.c | 2 +- openbsc/src/libbsc/paging.c | 20 ++++---- openbsc/src/libcommon/gsm_data.c | 60 +++++++++++----------- openbsc/src/libcommon/socket.c | 6 +- openbsc/src/libgb/gprs_ns.c | 36 +++++++------- openbsc/src/libgb/gprs_ns_frgre.c | 10 ++-- openbsc/src/libmgcp/mgcp_network.c | 24 +++++----- openbsc/src/libmsc/db.c | 2 +- openbsc/src/libmsc/gsm_04_08.c | 48 +++++++++--------- openbsc/src/libmsc/gsm_04_11.c | 22 ++++---- openbsc/src/libmsc/gsm_subscriber.c | 6 +- openbsc/src/libmsc/mncc_sock.c | 28 +++++----- openbsc/src/libmsc/rrlp.c | 4 +- openbsc/src/libmsc/silent_call.c | 4 +- openbsc/src/libmsc/sms_queue.c | 16 +++--- openbsc/src/libmsc/token_auth.c | 4 +- openbsc/src/libmsc/vty_interface_layer3.c | 46 +++++++++--------- openbsc/src/libtrau/rtp_proxy.c | 14 +++--- openbsc/src/osmo-bsc/osmo_bsc_audio.c | 2 +- openbsc/src/osmo-bsc/osmo_bsc_grace.c | 2 +- openbsc/src/osmo-bsc/osmo_bsc_main.c | 4 +- openbsc/src/osmo-bsc/osmo_bsc_msc.c | 30 ++++++------ openbsc/src/osmo-bsc/osmo_bsc_rf.c | 38 +++++++------- openbsc/src/osmo-bsc/osmo_bsc_sccp.c | 14 +++--- openbsc/src/osmo-bsc_mgcp/mgcp_main.c | 6 +- openbsc/src/osmo-bsc_nat/bsc_mgcp_utils.c | 12 ++-- openbsc/src/osmo-bsc_nat/bsc_nat.c | 48 +++++++++--------- openbsc/src/osmo-bsc_nat/bsc_nat_utils.c | 22 ++++---- openbsc/src/osmo-bsc_nat/bsc_nat_vty.c | 10 ++-- openbsc/src/osmo-bsc_nat/bsc_sccp.c | 2 +- openbsc/src/osmo-bsc_nat/bsc_ussd.c | 20 ++++---- openbsc/src/osmo-nitb/bsc_hack.c | 14 +++--- openbsc/src/utils/bs11_config.c | 8 ++-- openbsc/src/utils/rs232.c | 12 ++-- openbsc/tests/channel/channel_test.c | 2 +- 86 files changed, 634 insertions(+), 634 deletions(-) -- 1.7.2.3

12 years, 11 months

1
5
0 0

[PATCH] libosmocore: fix namespace pollution (1/*)

by Pablo Neira Ayuso

This is the first patch in the series, I'll start little by little. This first patch uses the new prefix for timer objects and functions. Please, apply! --- Pablo Neira Ayuso (1): timer: use namespace prefix osmo_timer* include/osmocom/core/timer.h | 20 ++++++++++---------- src/rate_ctr.c | 6 +++--- src/select.c | 8 ++++---- src/timer.c | 29 +++++++++++++++-------------- tests/timer/timer_test.c | 16 ++++++++-------- 5 files changed, 40 insertions(+), 39 deletions(-) -- Signature

12 years, 11 months

3
3
0 0

[PATCH] openBSC: use new osmo_timer* namespace for timers

by Pablo Neira Ayuso

This patch gets openBSC in sync with the changes that I'm proposing for libosmocore. Please, apply! --- Pablo Neira Ayuso (1): src: use new namespace prefix osmo_timer* for timer functions openbsc/include/openbsc/bsc_msc.h | 4 ++-- openbsc/include/openbsc/bsc_nat.h | 8 ++++---- openbsc/include/openbsc/e1_input.h | 2 +- openbsc/include/openbsc/gprs_llc.h | 4 ++-- openbsc/include/openbsc/gprs_ns.h | 2 +- openbsc/include/openbsc/gprs_sgsn.h | 4 ++-- openbsc/include/openbsc/gsm_data.h | 16 ++++++++-------- openbsc/include/openbsc/osmo_bsc.h | 4 ++-- openbsc/include/openbsc/osmo_bsc_rf.h | 6 +++--- openbsc/include/openbsc/osmo_msc_data.h | 4 ++-- openbsc/include/openbsc/paging.h | 2 +- openbsc/include/openbsc/sgsn.h | 2 +- openbsc/include/openbsc/transaction.h | 4 ++-- openbsc/src/gprs/gprs_gmm.c | 18 +++++++++--------- openbsc/src/gprs/gprs_sndcp.h | 2 +- openbsc/src/gprs/sgsn_libgtp.c | 2 +- openbsc/src/ipaccess/ipaccess-find.c | 6 +++--- openbsc/src/ipaccess/ipaccess-proxy.c | 8 ++++---- openbsc/src/libabis/e1_input.c | 6 +++--- openbsc/src/libabis/input/dahdi.c | 2 +- openbsc/src/libabis/input/hsl.c | 2 +- openbsc/src/libabis/input/ipaccess.c | 2 +- openbsc/src/libabis/input/lapd.c | 8 ++++---- openbsc/src/libabis/input/misdn.c | 2 +- openbsc/src/libbsc/abis_rsl.c | 10 +++++----- openbsc/src/libbsc/bsc_api.c | 12 ++++++------ openbsc/src/libbsc/bsc_msc.c | 8 ++++---- openbsc/src/libbsc/bsc_rll.c | 8 ++++---- openbsc/src/libbsc/chan_alloc.c | 8 ++++---- openbsc/src/libbsc/handover_logic.c | 10 +++++----- openbsc/src/libbsc/paging.c | 14 +++++++------- openbsc/src/libgb/gprs_ns.c | 12 ++++++------ openbsc/src/libmsc/gsm_04_08.c | 14 +++++++------- openbsc/src/libmsc/gsm_04_11.c | 10 +++++----- openbsc/src/libmsc/sms_queue.c | 12 ++++++------ openbsc/src/osmo-bsc/osmo_bsc_msc.c | 10 +++++----- openbsc/src/osmo-bsc/osmo_bsc_rf.c | 16 ++++++++-------- openbsc/src/osmo-bsc/osmo_bsc_sccp.c | 12 ++++++------ openbsc/src/osmo-bsc_nat/bsc_nat.c | 22 +++++++++++----------- openbsc/src/osmo-bsc_nat/bsc_ussd.c | 6 +++--- openbsc/src/osmo-nitb/bsc_hack.c | 6 +++--- openbsc/src/utils/bs11_config.c | 4 ++-- 42 files changed, 157 insertions(+), 157 deletions(-) -- Signature

12 years, 11 months

1
0
0 0

[PATCH 0/3] openBSC: several misc updates

by pablo＠gnumonks.org

From: Pablo Neira Ayuso <pablo(a)netfilter.org> Hi! The following patchset contains one fix and two improvements. You can find them in the pablo/updates branch. Please, merge it! Pablo Neira Ayuso (3): msc: bail out if subscriber VTY command fails abis: skip e1_input nesting if empty bsc: on-demand setup of nanoBTS and HSL femto sockets openbsc/src/libabis/e1_input_vty.c | 8 ++++++-- openbsc/src/libbsc/bsc_init.c | 20 +++++++++++++++----- openbsc/src/libmsc/vty_interface_layer3.c | 11 ++++++++++- 3 files changed, 31 insertions(+), 8 deletions(-) -- 1.7.2.3

12 years, 11 months

4
9
0 0

[PATCH 0/5] libosmocore: logging framework updates

by pablo＠gnumonks.org

From: Pablo Neira Ayuso <pablo(a)gnumonks.org> Hi! This patchset updates the logging framework, it contains one fix and several updates/improvements. You can find it in pablo/logging branch. Please, merge it! Pablo Neira Ayuso (5): logging: fix missing description of global loglevel logging: several memory allocation belong to tall_log_ctx context logging: rework _output() function logging: remove workaround now that _output() has been reworked logging: make sure the output is null-terminated src/logging.c | 77 +++++++++++++++++++++++++++++--------------------------- 1 files changed, 40 insertions(+), 37 deletions(-) -- 1.2.3.4

12 years, 11 months

2
6
0 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

OpenBSC May 2011