October 2016 - OpenBSC - lists.osmocom.org

by Max

HI. A little heads up: uhd version in jenkins building osmo-trx should be updated to 3.9.0 - this would allow gerrit #1117 to be properly verified by jenkins. -- Max Suraev <msuraev(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschaeftsfuehrer / Managing Director: Harald Welte

7 years, 2 months

4
5
0 0

Osmo-bts/Osmocom-bb virtual layer 1

by Sebastian Stumpf

Hi, I further implemented the base of the virtual layer with the purpose of replacing the um-air interface with a multicast-socket solution. This has been started by Harald Welte some time ago in the Osmobts - laforge/virt-bts branch. As I was not really confident enough to create an official new branch before someone had a look on what I did, so I developed in copies of the osmocom-bb and osmo-bts projects on my github-page (https://github.com/BastusIII/osmocom-bb-virt/tree/stumpf/virt-um and https://github.com/BastusIII/osmo-bts-virt/tree/stumpf/virt-bts). If someone finds to time to have a look into them (structure, path, implementation) and give me feedback about it, I would be glad :). Please use the following config files that i have tested: - https://github.com/BastusIII/osmocom-config-files/blob/master/openbsc-virtu… - https://github.com/BastusIII/osmocom-config-files/blob/master/osmobts-virtu… - https://github.com/BastusIII/osmocom-config-files/blob/master/osmocom-bb-mo… What works: BTS: - downlink over gsmtap and a multicast socket - OML and RSL on abis properly established and seems to work - virtual-um connection establishment Osmocom-bb: - virtual-um -- l23 app connection establishment (bridging osmocon, no serial link needed) - BCCH downlink handling and forwarding to l23 app - handling of some l1ctl requests from l23 (e.g. power management had to be mocked, so l23 gets a response and is satisfied) What not: BTS: - missing uplink handling Osmocom-bb - missing uplink routines (RACH, TCH, dedicated channels) - handlers for l23 requests only partially implemented (missing TCH, RACH, ... I a currently a bit overwhelmed by the mass of messages exchanged between l23-app (used mobile, btw.) and the virtual-um and hanging because mobile gets a sync timeout. I am looking forward to hear from you :). Sebastian Stumpf

7 years, 4 months

2
2
0 0

MS cannot connect; Location Update Request not received by BTS?

by Bruce Smith

7 years, 5 months

5
7
0 0

osmo-bts-trx channel activation

by Max

Hi. In sysmobts we use ugly hack to auto-activate BCCH/CCCH on TS0 via opstart_compl(). How does channel activation looks like for osmo-bts-trx? On a related note: how do we decide on number of AGCH? In case of sysmobts it's communicated to L1 in agch.u8NbrOfAgch via lch_par. What would be equivalent for osmo-bts-trx? -- Max Suraev <msuraev(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschaeftsfuehrer / Managing Director: Harald Welte

7 years, 5 months

2
2
0 0

Re: Profiling data of decoding EPDAN compressed bitmap

by Holger Freyther

> On 13 Jul 2016, at 12:21, Max <msuraev(a)sysmocom.de> wrote: > Hi all, > After looking at the code, I don't think reusing table implementation > would be easy - the approaches are too different as well as underlying > data structures. okay. then we will need to use the tree based version and from my point of view we should do it the following way: * Remove osmo_t4_decode (and related routines) from libosmocore (last step) * Make the tree based decoder ready in terms of the surrounding style * Adopt/Clone the osmo_t4_decode tests and move them to the PCU (as part of the commit that adds the decoder to the PCU) @Me: After the infrastructure is in the PCU I will remove osmo_t4_decode (and tests) from libosmocore @Radisys: I am afraid the tree based decoding is not ready yet and as it impacts the upcoming encoder (and other RLE code as far as I understand) let me put it here. In osmo-pcu (and all other projects) we use libtalloc for memory allocations. This means the tree should use talloc with proper parent/child allocations. This way the destructor of the decoder will also free all nodes of the tree. There should be no call to malloc/free in the PCU. Please take the tests from libosmocore and make sure they work with the new decoder. Tests are the lifeline and we need more and not less of them. The decoder needs to be robust against invalid input. search_runlen can fail but the caller doesn't check for that. Please test with invalid/truncated or broken inputs to see we don't end in a never terminating while loop. Test using unit tests. Similar the current osmo_t4_decode can return an error that is propagated back to the compressed bitmap decoding and we should have the same. Reduce code duplication. With the decoder the only difference between the if/else is if the data is filled with 0x00 or 0xFF and which table/root to use. Instead of having code clones please parameterize either by having local variables in the beginning or by calling different (inline) functions. kind regards holger

7 years, 5 months

1
1
0 0

open-sip-connector error logs

by Anonim Stefan

Hi, I am using osmo-sip-connector 1.20161024 with osmocom-nitb 0.15.1.20161024 on debian jessie. I keep getting the below error[1] causing my syslog to fill up. Also I can see sometimes the sip connector replies with 0.0.0.0 RTP IP address. Anyone had this issues before ? Any idea what might be causing this? Regards, Stefan [1] Oct 25 11:58:28 openbsc1 osmo-sip-connector[283]: length packettport(0x1064c30): zero length packettport(0x1064c30): zero length packettport(0x1064c30): zero length packettport(0x1064c30): zero length packettport(0x1064c30): zero length packettport(0x1064c30): zero length packettport(0x1064c30): zero length packettport(0x1064c30): zero length packettport(0x1064c30): zero length packettport(0x1064c30): zero length packettport(0x1064c30): zero length packettport(0x1064c30): zero length packettport(0x1064c30): zero length packettport(0x1064c30): zero length packettport(0x1064c30): zero length packettport(0x1064c30): zero length packettport(0x1064c30): zero length packettport(0x1064c30): zero length packettport(0x1064c30): zero length packettport(0x1064c30): zero length packettport(0x1064c30): zero length packettport(0x1064c30): zero length packettport(0x1064c30): zero length packettport(0x1064c30): zero length packettport(0x1064c30): zero length packettport(0x1064c30): zero length packettport(0x1064c30): zero length packettport(0x1064c30): zero length packettport(0x1064c30): zero length packettport(0x1064c30): zero length packettport(0x1064c30): zero length packettport(0x1064c30): zero length packettport(0x1064c30): zero length packettport(0x1064c30): zero length packettport(0x1064c30): zero length packettport(0x1064c30): zero length packettport(0x1064c30): zero length packettport(0x1064c30): zero length packettport(0x1064c30): zero length packettport(0x1064c30): zero length packettpor

7 years, 5 months

2
1
0 0

openbsc - make check error

by Abdulghafar Shabaneh

Hi everyone I was trying Openbsc recently on Ubuntu 16.04.1 and came through these errors in make check command. Are they harmless? since installation and make commands were not having any error. myself@myself34:~/project/openbsc/openbsc$ make check make check-recursive make[1]: Entering directory '/home/myself/project/openbsc/openbsc' Making check in doc make[2]: Entering directory '/home/myself/project/openbsc/openbsc/doc' Making check in examples make[3]: Entering directory '/home/myself/project/openbsc/ openbsc/doc/examples' make[3]: Nothing to be done for 'check'. make[3]: Leaving directory '/home/myself/project/openbsc/ openbsc/doc/examples' make[3]: Entering directory '/home/myself/project/openbsc/openbsc/doc' make[3]: Nothing to be done for 'check-am'. make[3]: Leaving directory '/home/myself/project/openbsc/openbsc/doc' make[2]: Leaving directory '/home/myself/project/openbsc/openbsc/doc' Making check in include make[2]: Entering directory '/home/myself/project/openbsc/openbsc/include' Making check in openbsc make[3]: Entering directory '/home/myself/project/openbsc/ openbsc/include/openbsc' make[3]: Nothing to be done for 'check'. make[3]: Leaving directory '/home/myself/project/openbsc/ openbsc/include/openbsc' make[3]: Entering directory '/home/myself/project/openbsc/openbsc/include' make[3]: Nothing to be done for 'check-am'. make[3]: Leaving directory '/home/myself/project/openbsc/openbsc/include' make[2]: Leaving directory '/home/myself/project/openbsc/openbsc/include' Making check in src make[2]: Entering directory '/home/myself/project/openbsc/openbsc/src' Making check in libcommon make[3]: Entering directory '/home/myself/project/openbsc/ openbsc/src/libcommon' make[3]: Nothing to be done for 'check'. make[3]: Leaving directory '/home/myself/project/openbsc/ openbsc/src/libcommon' Making check in libmgcp make[3]: Entering directory '/home/myself/project/openbsc/ openbsc/src/libmgcp' make[3]: Nothing to be done for 'check'. make[3]: Leaving directory '/home/myself/project/openbsc/ openbsc/src/libmgcp' Making check in libbsc make[3]: Entering directory '/home/myself/project/openbsc/ openbsc/src/libbsc' make[3]: Nothing to be done for 'check'. make[3]: Leaving directory '/home/myself/project/openbsc/openbsc/src/libbsc' Making check in libmsc make[3]: Entering directory '/home/myself/project/openbsc/ openbsc/src/libmsc' make[3]: Nothing to be done for 'check'. make[3]: Leaving directory '/home/myself/project/openbsc/openbsc/src/libmsc' Making check in libtrau make[3]: Entering directory '/home/myself/project/openbsc/ openbsc/src/libtrau' make[3]: Nothing to be done for 'check'. make[3]: Leaving directory '/home/myself/project/openbsc/ openbsc/src/libtrau' Making check in libfilter make[3]: Entering directory '/home/myself/project/openbsc/ openbsc/src/libfilter' make[3]: Nothing to be done for 'check'. make[3]: Leaving directory '/home/myself/project/openbsc/ openbsc/src/libfilter' Making check in osmo-nitb make[3]: Entering directory '/home/myself/project/openbsc/ openbsc/src/osmo-nitb' make[3]: Nothing to be done for 'check'. make[3]: Leaving directory '/home/myself/project/openbsc/ openbsc/src/osmo-nitb' Making check in osmo-bsc_mgcp make[3]: Entering directory '/home/myself/project/openbsc/ openbsc/src/osmo-bsc_mgcp' make[3]: Nothing to be done for 'check'. make[3]: Leaving directory '/home/myself/project/openbsc/ openbsc/src/osmo-bsc_mgcp' Making check in utils make[3]: Entering directory '/home/myself/project/openbsc/openbsc/src/utils' make[3]: Nothing to be done for 'check'. make[3]: Leaving directory '/home/myself/project/openbsc/openbsc/src/utils' Making check in ipaccess make[3]: Entering directory '/home/myself/project/openbsc/ openbsc/src/ipaccess' make[3]: Nothing to be done for 'check'. make[3]: Leaving directory '/home/myself/project/openbsc/ openbsc/src/ipaccess' Making check in gprs make[3]: Entering directory '/home/myself/project/openbsc/openbsc/src/gprs' make[3]: Nothing to be done for 'check'. make[3]: Leaving directory '/home/myself/project/openbsc/openbsc/src/gprs' Making check in osmo-bsc_nat make[3]: Entering directory '/home/myself/project/openbsc/ openbsc/src/osmo-bsc_nat' make[3]: Nothing to be done for 'check'. make[3]: Leaving directory '/home/myself/project/openbsc/ openbsc/src/osmo-bsc_nat' Making check in osmo-bsc make[3]: Entering directory '/home/myself/project/openbsc/ openbsc/src/osmo-bsc' make[3]: Nothing to be done for 'check'. make[3]: Leaving directory '/home/myself/project/openbsc/ openbsc/src/osmo-bsc' make[3]: Entering directory '/home/myself/project/openbsc/openbsc/src' make[3]: Nothing to be done for 'check-am'. make[3]: Leaving directory '/home/myself/project/openbsc/openbsc/src' make[2]: Leaving directory '/home/myself/project/openbsc/openbsc/src' Making check in tests make[2]: Entering directory '/home/myself/project/openbsc/openbsc/tests' Making check in gsm0408 make[3]: Entering directory '/home/myself/project/openbsc/ openbsc/tests/gsm0408' make[3]: Nothing to be done for 'check'. make[3]: Leaving directory '/home/myself/project/openbsc/ openbsc/tests/gsm0408' Making check in db make[3]: Entering directory '/home/myself/project/openbsc/openbsc/tests/db' make[3]: Nothing to be done for 'check'. make[3]: Leaving directory '/home/myself/project/openbsc/openbsc/tests/db' Making check in channel make[3]: Entering directory '/home/myself/project/openbsc/ openbsc/tests/channel' make[3]: Nothing to be done for 'check'. make[3]: Leaving directory '/home/myself/project/openbsc/ openbsc/tests/channel' Making check in mgcp make[3]: Entering directory '/home/myself/project/openbsc/ openbsc/tests/mgcp' make[3]: Nothing to be done for 'check'. make[3]: Leaving directory '/home/myself/project/openbsc/openbsc/tests/mgcp' Making check in gprs make[3]: Entering directory '/home/myself/project/openbsc/ openbsc/tests/gprs' make[3]: Nothing to be done for 'check'. make[3]: Leaving directory '/home/myself/project/openbsc/openbsc/tests/gprs' Making check in abis make[3]: Entering directory '/home/myself/project/openbsc/ openbsc/tests/abis' make[3]: Nothing to be done for 'check'. make[3]: Leaving directory '/home/myself/project/openbsc/openbsc/tests/abis' Making check in gbproxy make[3]: Entering directory '/home/myself/project/openbsc/ openbsc/tests/gbproxy' make[3]: Nothing to be done for 'check'. make[3]: Leaving directory '/home/myself/project/openbsc/ openbsc/tests/gbproxy' Making check in trau make[3]: Entering directory '/home/myself/project/openbsc/ openbsc/tests/trau' make[3]: Nothing to be done for 'check'. make[3]: Leaving directory '/home/myself/project/openbsc/openbsc/tests/trau' Making check in subscr make[3]: Entering directory '/home/myself/project/openbsc/ openbsc/tests/subscr' make[3]: Nothing to be done for 'check'. make[3]: Leaving directory '/home/myself/project/openbsc/ openbsc/tests/subscr' Making check in mm_auth make[3]: Entering directory '/home/myself/project/openbsc/ openbsc/tests/mm_auth' make[3]: Nothing to be done for 'check'. make[3]: Leaving directory '/home/myself/project/openbsc/ openbsc/tests/mm_auth' Making check in bsc-nat make[3]: Entering directory '/home/myself/project/openbsc/ openbsc/tests/bsc-nat' make[3]: Nothing to be done for 'check'. make[3]: Leaving directory '/home/myself/project/openbsc/ openbsc/tests/bsc-nat' Making check in bsc-nat-trie make[3]: Entering directory '/home/myself/project/openbsc/ openbsc/tests/bsc-nat-trie' make[3]: Nothing to be done for 'check'. make[3]: Leaving directory '/home/myself/project/openbsc/ openbsc/tests/bsc-nat-trie' Making check in bsc make[3]: Entering directory '/home/myself/project/openbsc/openbsc/tests/bsc' make[3]: Nothing to be done for 'check'. make[3]: Leaving directory '/home/myself/project/openbsc/openbsc/tests/bsc' Making check in smpp make[3]: Entering directory '/home/myself/project/openbsc/ openbsc/tests/smpp' make[3]: Nothing to be done for 'check'. make[3]: Leaving directory '/home/myself/project/openbsc/openbsc/tests/smpp' Making check in gtphub make[3]: Entering directory '/home/myself/project/openbsc/ openbsc/tests/gtphub' make[3]: Nothing to be done for 'check'. make[3]: Leaving directory '/home/myself/project/openbsc/ openbsc/tests/gtphub' Making check in sgsn make[3]: Entering directory '/home/myself/project/openbsc/ openbsc/tests/sgsn' make[3]: Nothing to be done for 'check'. make[3]: Leaving directory '/home/myself/project/openbsc/openbsc/tests/sgsn' Making check in oap make[3]: Entering directory '/home/myself/project/openbsc/openbsc/tests/oap' make[3]: Nothing to be done for 'check'. make[3]: Leaving directory '/home/myself/project/openbsc/openbsc/tests/oap' Making check in xid make[3]: Entering directory '/home/myself/project/openbsc/openbsc/tests/xid' make[3]: Nothing to be done for 'check'. make[3]: Leaving directory '/home/myself/project/openbsc/openbsc/tests/xid' Making check in sndcp_xid make[3]: Entering directory '/home/myself/project/openbsc/ openbsc/tests/sndcp_xid' make[3]: Nothing to be done for 'check'. make[3]: Leaving directory '/home/myself/project/openbsc/ openbsc/tests/sndcp_xid' Making check in slhc make[3]: Entering directory '/home/myself/project/openbsc/ openbsc/tests/slhc' make[3]: Nothing to be done for 'check'. make[3]: Leaving directory '/home/myself/project/openbsc/openbsc/tests/slhc' Making check in v42bis make[3]: Entering directory '/home/myself/project/openbsc/ openbsc/tests/v42bis' make[3]: Nothing to be done for 'check'. make[3]: Leaving directory '/home/myself/project/openbsc/ openbsc/tests/v42bis' make[3]: Entering directory '/home/myself/project/openbsc/openbsc/tests' make check-local make[4]: Entering directory '/home/myself/project/openbsc/openbsc/tests' :;{ \ echo '# Signature of the current package.' && \ echo 'm4_define([AT_PACKAGE_NAME],' && \ echo ' [openbsc])' && \ echo 'm4_define([AT_PACKAGE_TARNAME],' && \ echo ' [openbsc])' && \ echo 'm4_define([AT_PACKAGE_VERSION],' && \ echo ' [0.15.0.498-582e4])' && \ echo 'm4_define([AT_PACKAGE_STRING],' && \ echo ' [openbsc 0.15.0.498-582e4])' && \ echo 'm4_define([AT_PACKAGE_BUGREPORT],' && \ echo ' [openbsc(a)lists.osmocom.org])'; \ echo 'm4_define([AT_PACKAGE_URL],' && \ echo ' [])'; \ } >'./package.m4' /bin/bash ../missing --run autom4te --language=autotest -I '.' -o testsuite.tmp testsuite.at mv testsuite.tmp testsuite /bin/bash './testsuite' ## ------------------------------------ ## ## openbsc 0.15.0.498-582e4 test suite. ## ## ------------------------------------ ## Regression tests. 1: gsm0408 ok 2: subscr ok 3: db FAILED (testsuite.at:21 ) 4: channel ok 5: mgcp ok 6: mgcp-trans skipped ( testsuite.at:38) 7: gprs ok 8: bsc-nat ok 9: smpp ok 10: bsc-nat-trie ok 11: abis ok 12: bsc ok 13: gbproxy ok 14: trau ok 15: sgsn ok 16: oap ok 17: gtphub ok 18: mm_auth ok 19: xid ok 20: sndcp_xid ok 21: slhc ok 22: v42bis ok ## ------------- ## ## Test results. ## ## ------------- ## ERROR: 21 tests were run, 1 failed unexpectedly. 1 test was skipped. ## -------------------------- ## ## testsuite.log was created. ## ## -------------------------- ## Please send `tests/testsuite.log' and all information you think might help: To: <openbsc(a)lists.osmocom.org> Subject: [openbsc 0.15.0.498-582e4] testsuite: 3 failed You may investigate any problem if you feel able to do so, in which case the test suite provides a good starting point. Its output may be found below `tests/testsuite.dir'. Makefile:717: recipe for target 'check-local' failed make[4]: *** [check-local] Error 1 make[4]: Leaving directory '/home/myself/project/openbsc/openbsc/tests' Makefile:568: recipe for target 'check-am' failed make[3]: *** [check-am] Error 2 make[3]: Leaving directory '/home/myself/project/openbsc/openbsc/tests' Makefile:420: recipe for target 'check-recursive' failed make[2]: *** [check-recursive] Error 1 make[2]: Leaving directory '/home/myself/project/openbsc/openbsc/tests' Makefile:484: recipe for target 'check-recursive' failed make[1]: *** [check-recursive] Error 1 make[1]: Leaving directory '/home/myself/project/openbsc/openbsc' Makefile:775: recipe for target 'check' failed make: *** [check] Error 2 myself@myself34:~/project/openbsc/openbsc$ Thanks Abdulghafar

7 years, 5 months

2
1
0 0

asan for libosmo*

by Max

Hi. Address Sanitizer is currently enabled for libosmocore jenkins build (which is really great, thanks al being involved!) but not for other libraries. According to recent checks in http://jenkins.osmocom.org/jenkins/job/Osmocom_Sanitizer/ asan only fails for OpenBSC so it seems like it can be enabled for other libosmo* libraries as well. What do you think? -- Max Suraev <msuraev(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschaeftsfuehrer / Managing Director: Harald Welte

7 years, 5 months

2
2
0 0

plz fix osmo-gsm-manuals/OpenBTS Makefile

by Neels Hofmeyr

Hi, the below commit drops the osmo-bts-abis.pdf from the Makefile! Currently the Abis manual is thus missing completely. Please fix... thx! ~Neels commit 05f5adbe837f2cbfb9301cdb8c9b454ca0bfc825 Author: Alexander Couzens <lynxis(a)fe80.eu> Date: Fri Oct 14 16:56:42 2016 +0200 OsmoBTS: add vty reference documentation Including the required changes of the Makefile which is now simliar as the other projects Makefile's. Based on: OsmoBTS 0.3.0.283-f869 Change-Id: Id7362ce1c584b1926330b93770d68453e091c71c -- - Neels Hofmeyr <nhofmeyr(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Harald Welte

7 years, 5 months

1
2
0 0

[scan-admin@coverity.com: New Defects reported by Coverity Scan for Osmocom]

by Neels Hofmeyr

Hi, Please find the latest report on new defect(s) introduced to Osmocom found with Coverity Scan. 2 new defect(s) introduced to Osmocom found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 150437: Insecure data handling (TAINTED_SCALAR) /source-Osmocom/libosmo-abis/src/input/misdn.c: 462 in handle_ts_raw_read() ________________________________________________________________________________________________________ *** CID 150437: Insecure data handling (TAINTED_SCALAR) /source-Osmocom/libosmo-abis/src/input/misdn.c: 462 in handle_ts_raw_read() 456 DEBUGP(DLMIB, "<= RAW CHAN len = %d, prim(0x%x) id(0x%x): %s\n", 457 ret, hh->prim, hh->id, 458 get_value_string(prim_names, hh->prim)); 459 460 switch (hh->prim) { 461 case PH_DATA_IND: >>> CID 150437: Insecure data handling (TAINTED_SCALAR) >>> Assigning: "msg->l2h" = "msg->data + 8UL". Both are now tainted. 462 msg->l2h = msg->data + MISDN_HEADER_LEN; 463 DEBUGP(DLMIB, "RAW CHAN RX: %s\n", 464 osmo_hexdump(msgb_l2(msg), ret - MISDN_HEADER_LEN)); 465 /* the number of bytes received indicates that data to send */ 466 handle_ts_raw_write(bfd, msgb_l2len(msg)); 467 return e1inp_rx_ts(e1i_ts, msg, 0, 0); ** CID 150436: API usage errors (PW.PRINTF_ARG_MISMATCH) /source-Osmocom/osmo-pcu/src/tbf_dl.cpp: 310 in () ________________________________________________________________________________________________________ *** CID 150436: API usage errors (PW.PRINTF_ARG_MISMATCH) /source-Osmocom/osmo-pcu/src/tbf_dl.cpp: 310 in () 304 msgb_free(msg); 305 bts->llc_dropped_frame(); 306 continue; 307 } 308 309 if (frames) { >>> CID 150436: API usage errors (PW.PRINTF_ARG_MISMATCH) >>> argument is incompatible with corresponding format string conversion 310 LOGP(DRLCMACDL, LOGL_NOTICE, "%s Discarding LLC PDU " 311 "because lifetime limit reached, " 312 "count=%u new_queue_size=%zu\n", 313 tbf_name(this), frames, llc_queue_size()); 314 if (frames > 0xff) 315 frames = 0xff;

7 years, 5 months

3
4
0 0

Review of conv_gen changes

by Harald Welte

Hi Sylvian, I was hoping that you could review the conv_gen.py and related changes that Vadim has been working on. I don't feel familiar enough with the code (and not morally authorized to merge such significant canges) to your code. The code is at https://gerrit.osmocom.org/#/c/828/5 as well as related changes like https://gerrit.osmocom.org/#/c/829/4 Thanks! -- - Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)

7 years, 5 months

2
1
0 0

new warnings because of ctrl constify

by Neels Hofmeyr

Presumably after this libosmocore commit, I get scores of new warnings (see below) when compiling openbsc: commit ed9d6da5df98538adc70aa03cb569eb9505d04b6 Author: Max <msuraev(a)sysmocom.de> AuthorDate: Tue Oct 11 15:20:28 2016 +0200 Constify ctrl_cmd struct fields where appropriate Some of these can be fixed by constifying the functions as well, but talloc_free() of a const char * looks really wrong? Please follow up on this or revert the commit... constifying is good, but having twice the amount of warnings means twice the reading effort during development cycles. I would most prefer a revert now and come back as soon as no new warnings are introduced; ymmv... In file included from /usr/local/include/osmocom/core/talloc.h:4:0, from ../../../src/osmo-bsc_nat/bsc_nat_ctrl.c:22: ../../../src/osmo-bsc_nat/bsc_nat_ctrl.c: In function ‘bsc_nat_handle_ctrlif_msg’: ../../../src/osmo-bsc_nat/bsc_nat_ctrl.c:131:16: warning: passing argument 1 of ‘_talloc_free’ discards ‘const’ qualifier from pointer target type talloc_free(cmd->variable); ^ /usr/include/talloc.h:227:5: note: expected ‘void *’ but argument is of type ‘const char *’ int _talloc_free(void *ptr, const char *location); ^ ../../../src/osmo-bsc_nat/bsc_nat_ctrl.c:143:34: warning: passing argument 2 of ‘bsc_get_pending’ discards ‘const’ qualifier from pointer target type pending = bsc_get_pending(bsc, cmd->id); ^ ../../../src/osmo-bsc_nat/bsc_nat_ctrl.c:86:29: note: expected ‘char *’ but argument is of type ‘const char *’ static struct bsc_cmd_list *bsc_get_pending(struct bsc_connection *bsc, char *id_str) ^ ../../../src/osmo-bsc_nat/bsc_ussd.c: In function ‘bsc_ussd_check’: ../../../src/osmo-bsc_nat/bsc_nat_ctrl.c: In function ‘forward_to_bsc’: ../../../src/osmo-bsc_nat/bsc_nat_ctrl.c:228:31: warning: passing argument 1 of ‘extract_bsc_nr_variable’ discards ‘const’ qualifier from pointer target type if (!extract_bsc_nr_variable(cmd->variable, &nr, &bsc_variable)) { ^ ../../../src/osmo-bsc_nat/bsc_nat_ctrl.c:198:12: note: expected ‘char *’ but argument is of type ‘const char *’ static int extract_bsc_nr_variable(char *variable, unsigned int *nr, char **bsc_variable) ^ In file included from /usr/local/include/osmocom/core/talloc.h:4:0, from ../../../src/osmo-bsc_nat/bsc_nat_ctrl.c:22: ../../../src/osmo-bsc_nat/bsc_nat_ctrl.c:259:16: warning: passing argument 1 of ‘_talloc_free’ discards ‘const’ qualifier from pointer target type talloc_free(bsc_cmd->id); ^ /usr/include/talloc.h:227:5: note: expected ‘void *’ but argument is of type ‘const char *’ int _talloc_free(void *ptr, const char *location); ^ ../../../src/osmo-bsc_nat/bsc_nat_ctrl.c:266:16: warning: passing argument 1 of ‘_talloc_free’ discards ‘const’ qualifier from pointer target type talloc_free(bsc_cmd->variable); ^ /usr/include/talloc.h:227:5: note: expected ‘void *’ but argument is of type ‘const char *’ int _talloc_free(void *ptr, const char *location); ^ ../../../src/osmo-bsc_nat/bsc_nat_ctrl.c: In function ‘extract_bsc_cfg_variable’: ../../../src/osmo-bsc_nat/bsc_nat_ctrl.c:323:31: warning: passing argument 1 of ‘extract_bsc_nr_variable’ discards ‘const’ qualifier from pointer target type if (!extract_bsc_nr_variable(cmd->variable, &nr, bsc_variable)) { ^ ../../../src/osmo-bsc_nat/bsc_nat_ctrl.c:198:12: note: expected ‘char *’ but argument is of type ‘const char *’ static int extract_bsc_nr_variable(char *variable, unsigned int *nr, char **bsc_variable) ^ -- - Neels Hofmeyr <nhofmeyr(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Harald Welte

7 years, 5 months

2
5
0 0

Probleme mit pySim

by Ivaylo Kostov

Hallo zusammen, wegen meines Versuch die pySim zu verwenden habe ich folgendes bekommen: > ./pySim-read.py -p 0 > Reading ... > Traceback (most recent call last): > File "./pySim-read.py", line 90, in <module> > (res, sw) = scc.read_binary(['3f00', '2fe2']) > File "/home/wirelesss/net/pysim/pySim/commands.py", line 51, in > read_binary > r = self.select_file(ef) > File "/home/wirelesss/net/pysim/pySim/commands.py", line 44, in > select_file > data, sw = self._tp.send_apdu_checksw(self.cla_byte + "a4000C02" + i) > File "/home/wirelesss/net/pysim/pySim/transport/__init__.py", line > 87, in send_apdu_checksw > raise RuntimeError("SW match failed ! Expected %s and got %s." % > (sw.lower(), rv[1])) > RuntimeError: SW match failed ! Expected 9000 and got 6b00. > $ ./pySim-read.py -p 1 > Traceback (most recent call last): > File "./pySim-read.py", line 78, in <module> > sl = PcscSimLink(opts.pcsc_dev) > File "/home/wirelesss/net/pysim/pySim/transport/pcsc.py", line 38, > in __init__ > self._reader = r[reader_number] > IndexError: list index out of range > Exception AttributeError: "'PcscSimLink' object has no attribute > '_con'" in <bound method PcscSimLink.__del__ of > <pySim.transport.pcsc.PcscSimLink object at 0x7f3dca255750>> ignored wenn man ./pySim-prog.py gebe, dann das Ergebnis auch nicht so richtig ist. > ./pySim-prog.py -p 0 -t sysmosim-gr1 -i 001640000000072 -c 001 -x 001 > -y 64 -s 1791198229180000071 > Insert card now (or CTRL-C to cancel) > Generated card parameters : > > Name : Magic > > SMSP : e1ffffffffffffffffffffffff0581005155f5ffffffffffff000000 > > ICCID : 1791198229180000071 > > MCC/MNC : 1/64 > > IMSI : 001640000000072 > > Ki : 895c5a0e9e5f635111d6c366ae8c957f > > OPC : a230dcc3c71c17019189a8be734f9c74 > > ACC : None > > Programming ... > Traceback (most recent call last): > File "./pySim-prog.py", line 626, in <module> > card.program(cp) > File "/home/wirelesss/net/pysim/pySim/cards.py", line 274, in program > r = self._scc.select_file(['3f00', '2fe2']) > File "/home/wirelesss/net/pysim/pySim/commands.py", line 44, in > select_file > data, sw = self._tp.send_apdu_checksw(self.cla_byte + "a4000C02" + i) > File "/home/wirelesss/net/pysim/pySim/transport/__init__.py", line > 87, in send_apdu_checksw > raise RuntimeError("SW match failed ! Expected %s and got %s." % > (sw.lower(), rv[1])) > RuntimeError: SW match failed ! Expected 9000 and got 6b00. Kommando: pcsc_scan funktioniert reibungslos. Grüße, Ivaylo -- - Ivaylo Kostov <ikostov(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Harald Welte

7 years, 6 months

3
5
0 0

pysim Fakemagicsim problem + workaround Fwd: SIM Card Reader Problem!!

by Martin Dudok van Heel

Second try. (I already sent this mail yesterday, but it did not appear in the mailinglist. I do not know why. Maybe because I attached a file (a patch)) Hi all, This is my first post to the OpenBSC mailinglist. I had a problem with the latest pysim version giving errors while trying to program 2G (Fake)MagicSIM cards. This had worked fine in the past with an older release from 2011. I tried al lot of versions in between. I was finally able to narrow it down to the commit that broke compatibility with (fake)magicsim: http://cgit.osmocom.org/pysim/commit/pySim/commands.py?id=8c1b33c439fef423c… The comment with this comit is: "Do not return the FCI information while selecting a file The sysmoUSIM-SJS1 card does not support returning the FCI information. Plus, the FCI information are not used anyway." If I revert the change with attached patch, it works again. But it may break sysmoUSIM-SJS1 compatibility. I am not sure on how to test whether the programming of sysmoUSIM-SJS1 still works fine and if the SIMS themselves then will still work as expected with OpenBSC or OpenBTS or OpenAirinterface. If the code needs to stay in for sysmoUSIM-SJS1 then we probably need somehing like the pseudocode below: if carttype is fakemagicsim: "a4000002" elif cardtype is sysmoUSIM-SJS1: "a4000C02" else: #What should be the default for the other cards? Or is there another solution? With best regards, Martin Dudok van Heel This is the patch inline (attaching it as a file, blocked my email from going through) mdvh_pysim_make_fakesim_work_again_patch_2016081201.diff diff --git a/pySim/commands.py b/pySim/commands.py index 721b3d4..b7fb77f 100644 --- a/pySim/commands.py +++ b/pySim/commands.py @@ -41,7 +41,7 @@ class SimCardCommands(object): def select_file(self, dir_list): rv = [] for i in dir_list: - data, sw = self._tp.send_apdu_checksw(self.cla_byte + "a4000C02" + i) + data, sw = self._tp.send_apdu_checksw(self.cla_byte + "a4000002" + i) rv.append(data) return rv On 12-08-16 09:50, Holger Freyther wrote: >> On 12 Aug 2016, at 09:18, Rene Groothuis wrote: >> >> Hello, > Hi! > > >> I’m still having problems, sorry to report this. Below the log file >> of different combinations: >> > >> I’ve used different (same model) SIM cards. I’ve reinstated the USB >> reader. Tried in different USB ports. No Luck. >> >> What am I doing wrong, can you please help? >> >> > Sysmocom sold the last 16in1 magicsim in 2012? Did you buy these cards > from us? Maybe this specific one is just broken? Maybe try an older > version of pySIM? E.g. maybe some of the patches required for the > sysmoUSIM-SJS1 broke magicsim support? > > In the future you could consider getting the sysmoUSIM-SJS1 from us, > they are of way higher quality than the Chinese (GRcard, magicsim, > etc.) ones. For emergencies like these it might make sense for you to > get a support contract from sysmocom as well. > > good luck > > holger > >

7 years, 6 months

2
1
0 0

osmo-trx and gpsdo

by Max

Hi. While trying to make osmo-trx work in multichannel configuration I've found following: - running "./Transceiver52M/osmo-trx -m -c 2 -l INFO" works but - running "./Transceiver52M/osmo-trx -m -c 2 -l INFO -g" gives following: linux; GNU C++ version 4.8.4; Boost_105400; UHD_003.010.000.000-release opening configuration table from path :memory: Config Settings Log Level............... INFO Device args............. TRX Base Port........... 5700 TRX Address............. 127.0.0.1 Channels................ 2 Tx Samples-per-Symbol... 4 Rx Samples-per-Symbol... 4 EDGE support............ Disabled Reference............... GPS C0 Filler Table......... Disabled Multi-Carrier........... Enabled Diversity............... Disabled Tuning offset........... 0 RSSI to dBm offset...... 0 Swap channels........... 0 INFO 3032180480 13:36:38.4 UHDDevice.cpp:786:open: Using discovered UHD device type=b200,name=MyB210,serial=30AC26A,product=B210 -- Detected Device: B210 -- Operating over USB 2. -- Initialize CODEC control... -- Initialize Radio control... -- Performing register loopback test... pass -- Performing register loopback test... pass -- Performing CODEC loopback test... pass -- Performing CODEC loopback test... pass -- Setting master clock rate selection to 'automatic'. -- Asking for clock rate 16.000000 MHz... -- Actually got clock rate 16.000000 MHz. -- Performing timer loopback test... pass -- Performing timer loopback test... pass INFO 3032180480 13:36:41.6 UHDDevice.cpp:743:parse_dev_type: Using USRP1 type transmit window for B-Series Device B210 terminate called after throwing an instance of 'uhd::key_error' what(): LookupError: KeyError: update_clock_source: unknown source: gpsdo Aborted (core dumped) The tests were performed with usrp B210 and rather recent uhd (see above). Is this some know error/hw incompatibility? -- Max Suraev <msuraev(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschaeftsfuehrer / Managing Director: Harald Welte

7 years, 6 months

2
5
0 0

osmo-trx gerrit

by Neels Hofmeyr

<bump> https://gerrit.osmocom.org/1067 Would be nice to have the build script in master, and at the same time verify that you have +2 voting powers on osmo-trx -- you're currently the only one there. Feel free to appoint other reviewers at your discretion (tell me). Thanks! ~Neels -- - Neels Hofmeyr <nhofmeyr(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Harald Welte

7 years, 6 months

2
2
0 0

creepy dirs in osmo-bts/tests

by Max

Hi. I've ran "make check" in osmo-bts recently ang got weird dir names in tests/*/ like '$srcdir' - it seems like those should be evaluated variable but it's written literally to FS. Do you guys see it as well or it's some glitch local to my shell? -- Max Suraev <msuraev(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschaeftsfuehrer / Managing Director: Harald Welte

7 years, 6 months

2
1
0 0

bind & connect

by Neels Hofmeyr

Hi osmo_sock experts, I'm currently looking at making the osmo-hnbgw interface addresses configurable, an I came across a detail. This is not really pressing, but while I'm at it I might as well cover all of the addresses. So far I see in osmo-iuh's hnbgw.c the local address osmo-hnbgw uses to accept Iuh connections from a 3G cell, and the remote addresses of IuCS and IuPS, each passed to osmo_sock_init(): 3G cell -------> 1.2.3.4 OSMO-HNBGW IuPS-local? -------> 10.9.8.7 OSMO-SGSN So we tell one socket to listen on local 1.2.3.4 for Iuh. We tell another to send IuPS to 10.9.8.7. But how would I tell the IuPS to use a given local interface 1.2.3.5 to contact the SGSN's address? Would I bind() to a given local IP address and connect() to the remote one? I must admit that the details are not 100% clear to me. AFAIK it can be important to set a local IP address and port to send from. So if there's something I don't understand yet I would appreciate a hint. Anyway, in osmo_sock_init, I see: if ((flags & (OSMO_SOCK_F_BIND | OSMO_SOCK_F_CONNECT)) == (OSMO_SOCK_F_BIND | OSMO_SOCK_F_CONNECT)) { fprintf(stderr, "invalid: both bind and connect flags set:" " %s:%u\n", host, port); return -EINVAL; } Should we have another osmo_sock_init that can set up a socket like this code I found somewhere at sysmocom to define both ends of a connection? fd = socket(AF_INET, SOCK_DGRAM, 0); if (fd < 0) { printf("socket() failed: %s\n", strerror(errno)); return -1; } memset(&bindaddr, 0, sizeof(bindaddr)); bindaddr.sin_family = AF_INET; bindaddr.sin_port = htons(lport); rc = inet_pton(AF_INET, baddr, &(bindaddr.sin_addr)); if (rc != 1) { printf("inet_pton() failed with %i: %s\n", rc, strerror(errno)); return -1; } rc = bind(fd, (struct sockaddr *)&bindaddr, sizeof(bindaddr)); if (rc < 0) { printf("bind() failed: %s\n", strerror(errno)); return -1; } memset(&destaddr, 0, sizeof(destaddr)); destaddr.sin_family = AF_INET; destaddr.sin_port = htons(dport); rc = inet_pton(AF_INET, dest, &(destaddr.sin_addr)); if (rc != 1) { printf("inet_pton() failed with %i: %s\n", rc, strerror(errno)); return -1; } rc = connect(fd, (const struct sockaddr *)&destaddr, sizeof(destaddr)); if (rc < 0) { printf("connect() failed: %s\n", strerror(errno)); return -1; } rc = send(fd, buf, len, 0); if (rc != len) { printf("send() failed\n"); return -1; } Thanks, ~Neels -- - Neels Hofmeyr <nhofmeyr(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Harald Welte

7 years, 6 months

2
4
0 0

moved to gerrit patch submission

by Neels Hofmeyr

The following git repositories have now moved to gerrit, please submit future patches for these at gerrit.osmocom.org, no longer via mailing lists: osmo-gsm-manuals asn1c libasn1c osmo-trx openpcd osmo-sim-auth libtelnet mncc-python osmocom-lcs Thanks, ~Neels -- - Neels Hofmeyr <nhofmeyr(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Harald Welte

7 years, 6 months

1
0
0 0

Re: OsmoBTS -> libosmogsm code migration

by Vadim Yanitskiy

Hi Max, > Unfortunately I could not find any tests for the code in > question so the only way to test it is by: I uploaded tests recently. You can find them here: https://gerrit.osmocom.org/#/c/933/4/tests/coding/coding_test.c > I think the puncturing code should be part of the library (otherwise > every user will have to reimplement the same thing again and again). I am agree with you. We recently discussed this question with Tom Tsou. He said, that there was some performance related reasons to perform puncturing inside both gsm0503_pdtch_encode() / gsm0503_pdtch_decode(). With best regards, Vadim Yanitskiy.

7 years, 6 months

3
6
0 0

move to gerrit

by Neels Hofmeyr

Hi all, opinions please: I would move patch submission for the following osmocom repositories to gerrit: osmo-gsm-manuals asn1c libasn1c osmo-python-tests osmo-trx (TT already agreed) Let me know if any other come to mind. Possibly *all* projects seen at git.osmocom.org? Thanks, ~Neels -- - Neels Hofmeyr <nhofmeyr(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Harald Welte

7 years, 6 months

5
6
0 0

Re: New Defects reported by Coverity Scan for Osmocom

by Neels Hofmeyr

On Thu, Oct 13, 2016 at 09:32:21AM -0700, scan-admin(a)coverity.com wrote: > > Hi, > > Please find the latest report on new defect(s) introduced to Osmocom found with Coverity Scan. > > 4 new defect(s) introduced to Osmocom found with Coverity Scan. > 2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. > > New defect(s) Reported-by: Coverity Scan > Showing 4 of 4 defect(s) > > > ** CID 150135: Null pointer dereferences (REVERSE_INULL) > /source-Osmocom/openggsn/ggsn/ggsn.c: 142 in delete_context() > > > ________________________________________________________________________________________________________ > *** CID 150135: Null pointer dereferences (REVERSE_INULL) > /source-Osmocom/openggsn/ggsn/ggsn.c: 142 in delete_context() > 136 int delete_context(struct pdp_t *pdp) > 137 { > 138 DEBUGP(DGGSN, "Deleting PDP context\n"); > 139 struct ippoolm_t *member = pdp->peer; > 140 char v[NAMESIZE]; > 141 snprintf(v, sizeof(v), "%" PRIu64 ",%s", pdp->imsi, inet_ntoa(member->addr)); > >>> CID 150135: Null pointer dereferences (REVERSE_INULL) > >>> Null-checking "pdp->peer" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. > 142 if (pdp->peer) > 143 ippool_freeip(ippool, (struct ippoolm_t *)pdp->peer); > 144 else > 145 SYS_ERR(DGGSN, LOGL_ERROR, 0, "Peer not defined!"); > 146 > 147 if (gtp_kernel_tunnel_del(pdp)) { This one's for you, Max. (openggsn commit 727417dd28813c697b4820aef9f54f249e30c4b8) > ** CID 150134: Null pointer dereferences (REVERSE_INULL) > /source-Osmocom/openbsc/openbsc/src/gprs/gprs_sgsn.c: 257 in sgsn_mm_ctx_alloc_iu() > > > ________________________________________________________________________________________________________ > *** CID 150134: Null pointer dereferences (REVERSE_INULL) > /source-Osmocom/openbsc/openbsc/src/gprs/gprs_sgsn.c: 257 in sgsn_mm_ctx_alloc_iu() > 251 ctx->auth_triplet.key_seq = GSM_KEY_SEQ_INVAL; > 252 ctx->ctrg = rate_ctr_group_alloc(ctx, &mmctx_ctrg_desc, 0); > 253 > 254 /* Need to get RAID from IU conn */ > 255 ctx->ra = ctx->iu.ue_ctx->ra_id; > 256 fixed (sysmocom/iu branch). > >>> CID 150134: Null pointer dereferences (REVERSE_INULL) > >>> Null-checking "ctx->iu.ue_ctx" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. > 257 if (ctx->iu.ue_ctx) > 258 ctx->iu.ue_ctx->rab_assign_addr_enc = > 259 sgsn->cfg.iu.rab_assign_addr_enc; > 260 > 261 INIT_LLIST_HEAD(&ctx->pdp_list); > 262 > > ** CID 150133: Memory - corruptions (OVERRUN) > /source-Osmocom/osmo-bts/src/common/msg_utils.c: 121 in dtx_cache_payload() > > > ________________________________________________________________________________________________________ > *** CID 150133: Memory - corruptions (OVERRUN) > /source-Osmocom/osmo-bts/src/common/msg_utils.c: 121 in dtx_cache_payload() > 115 copy_len = OSMO_MIN(length + 1, ARRAY_SIZE(lchan->tch.dtx.cache)); > 116 > 117 lchan->tch.dtx.len = copy_len + amr; > 118 lchan->tch.dtx.fn = fn; > 119 lchan->tch.dtx.is_update = update; > 120 > >>> CID 150133: Memory - corruptions (OVERRUN) > >>> Overrunning buffer pointed to by "&lchan->tch.dtx.cache[amr]" of 20 bytes by passing it to a function which accesses it at byte offset 21 using argument "copy_len" (which evaluates to 20). > 121 memcpy(lchan->tch.dtx.cache + amr, l1_payload, copy_len); @Max, maybe 'copy_len - amr'? In any case there's potentially 'amr' too many bytes. > 122 } > 123 > 124 /*! \brief Check current state of DTX DL AMR FSM and dispatch necessary events > 125 * \param[in] lchan Logical channel on which we check scheduling > 126 * \param[in] rtp_pl buffer with RTP data > > ** CID 150132: Incorrect expression (BAD_SIZEOF) > /source-Osmocom/osmo-bts/src/common/msg_utils.c: 262 in dtx_sched_optional() > > > ________________________________________________________________________________________________________ > *** CID 150132: Incorrect expression (BAD_SIZEOF) > /source-Osmocom/osmo-bts/src/common/msg_utils.c: 262 in dtx_sched_optional() > 256 h1[] = { 14, 16, 18, 20, 66, 68, 70, 72 }; > 257 if (lchan->tch_mode == GSM48_CMODE_SPEECH_V1) { > 258 if (lchan->type == GSM_LCHAN_TCH_F) > 259 return fn_chk(f, fn, ARRAY_SIZE(f)); > 260 else > 261 return fn_chk(lchan->nr ? h1 : h0, fn, > >>> CID 150132: Incorrect expression (BAD_SIZEOF) > >>> The expression "sizeof (lchan->nr ? h1 : h0) / sizeof (lchan->nr ? h1 : h0[0])" is suspicious. Note that "lchan->nr ? h1 : h0" is a pointer and therefore the division will not return the number of array elements which may have been the intent. > 262 ARRAY_SIZE(lchan->nr ? h1 : h0)); @Max, has to be lchan-nr? ARRAY_SIZE(h1) : ARRAY_SIZE(h0) so ARRAY_SIZE can be resolved at compile time. > 263 } > 264 return false; > 265 } > 266 > 267 /* repeat last SID if possible, returns SID length + 1 or 0 */ > > > ________________________________________________________________________________________________________ > -- - Neels Hofmeyr <nhofmeyr(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Harald Welte

7 years, 6 months

1
0
0 0

multiple phy with osmo-trx

by Max

Hi! I've asked about it before but this seems to have been lost in communication. The question is basically how to enable multi-TRX support for osmo-bts-trx using phy/instance infrastructure similar to other bts? What I've tried so far is documented in http://projects.osmocom.org/issues/1648 but it did not result in working setup yet. In short, I'd like to configure OpenBSC with 1 BTS with 2 TRX, each with its own arfcn and set of channels. I'm running "osmo-bts-trx -t 2" and correspondingly "osmo-trx -c 2" on usrp b210. Any ideas on what's missing to make this actually work are greatly appreciated. -- Max Suraev <msuraev(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschaeftsfuehrer / Managing Director: Harald Welte

7 years, 6 months

4
15
0 0

[PATCH] mobile/vty_interface.c: Fix typo

by Martin Hauke

--- src/host/layer23/src/mobile/vty_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/host/layer23/src/mobile/vty_interface.c b/src/host/layer23/src/mobile/vty_interface.c index 9a86880..f4d7df1 100644 --- a/src/host/layer23/src/mobile/vty_interface.c +++ b/src/host/layer23/src/mobile/vty_interface.c @@ -528,7 +528,7 @@ static int _sim_test_cmd(struct vty *vty, int argc, const char *argv[], DEFUN(sim_test, sim_test_cmd, "sim testcard MS_NAME [MCC] [MNC] [LAC] [TMSI]", - "SIM actions\nAttach bulit in test SIM\nName of MS (see \"show ms\")\n" + "SIM actions\nAttach built-in test SIM\nName of MS (see \"show ms\")\n" "Optionally set mobile Country Code of RPLMN\n" "Optionally set mobile Network Code of RPLMN\n" "Optionally set location area code of RPLMN\n" @@ -539,7 +539,7 @@ DEFUN(sim_test, sim_test_cmd, DEFUN(sim_test_att, sim_test_att_cmd, "sim testcard MS_NAME MCC MNC LAC TMSI attached", - "SIM actions\nAttach bulit in test SIM\nName of MS (see \"show ms\")\n" + "SIM actions\nAttach built-in test SIM\nName of MS (see \"show ms\")\n" "Set mobile Country Code of RPLMN\nSet mobile Network Code of RPLMN\n" "Set location area code\nSet current assigned TMSI\n" "Indicate to MM that card is already attached") @@ -1758,7 +1758,7 @@ DEFUN(cfg_ms_sap, cfg_ms_sap_cmd, "sap-socket PATH", DEFUN(cfg_ms_sim, cfg_ms_sim_cmd, "sim (none|reader|test|sap)", "Set SIM card to attach when powering on\nAttach no SIM\n" - "Attach SIM from reader\nAttach bulit in test SIM\n" + "Attach SIM from reader\nAttach built-in test SIM\n" "Attach SIM over SAP interface") { struct osmocom_ms *ms = vty->index; -- 2.6.6

7 years, 6 months

1
0
0 0

[PATCH] Typo in Chapter 14.2

by Ivaylo Kostov

--- OsmoNITB/chapters/smpp.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/OsmoNITB/chapters/smpp.adoc b/OsmoNITB/chapters/smpp.adoc index 2557580..91f8c07 100644 --- a/OsmoNITB/chapters/smpp.adoc +++ b/OsmoNITB/chapters/smpp.adoc @@ -44,7 +44,7 @@ SMPP (`no smpp-first`). === ESME configuration -nder the `smpp` vty node, you can add any number of `esme` nodes, one +Under the `smpp` vty node, you can add any number of `esme` nodes, one for each ESME that you wish to configure. Use the `esme NAME` command (where NAME corresponds to the system-id of -- 2.7.4

7 years, 6 months

2
1
0 0

Re: [MERGED] libosmo-abis[master]: Resync RTP session in case of timestamp jump

by Neels Hofmeyr

In below patch (already merged) there's apparently only a LOGP tweak. Looks like something is missing there and Harald didn't spot it? It can't possibly fix OS#1803, can it? ~Neels On Wed, Oct 12, 2016 at 09:26:01AM +0000, Harald Welte wrote: > Harald Welte has submitted this change and it was merged. > > Change subject: Resync RTP session in case of timestamp jump > ...................................................................... > > > Resync RTP session in case of timestamp jump > > This will prevent the timestamp jump to occur between each call for DTX > if something goes wrong. It's handy as oRTP does not manage well > timestamp jump if it is not resynced. > > Fixes: OS#1803 > Change-Id: Iae5da832218dbd1ede7a9451102074f2a5eb66df > --- > M src/trau/osmo_ortp.c > 1 file changed, 2 insertions(+), 1 deletion(-) > > Approvals: > Harald Welte: Looks good to me, approved > Jenkins Builder: Verified > > > > diff --git a/src/trau/osmo_ortp.c b/src/trau/osmo_ortp.c > index 6ce70d2..e3c6234 100644 > --- a/src/trau/osmo_ortp.c > +++ b/src/trau/osmo_ortp.c > @@ -139,7 +139,8 @@ > uint32_t ts = rtp_session_get_current_recv_ts(rs); > > LOGP(DLMIB, LOGL_NOTICE, > - "osmo-ortp(%d): timestamp_jump, new TS %d\n", port, ts); > + "osmo-ortp(%d): timestamp_jump, new TS %d, resyncing\n", port, ts); > + rtp_session_resync(rs); > } > > > > -- > To view, visit https://gerrit.osmocom.org/1028 > To unsubscribe, visit https://gerrit.osmocom.org/settings > > Gerrit-MessageType: merged > Gerrit-Change-Id: Iae5da832218dbd1ede7a9451102074f2a5eb66df > Gerrit-PatchSet: 4 > Gerrit-Project: libosmo-abis > Gerrit-Branch: master > Gerrit-Owner: Max <msuraev(a)sysmocom.de> > Gerrit-Reviewer: Harald Welte <laforge(a)gnumonks.org> > Gerrit-Reviewer: Jenkins Builder -- - Neels Hofmeyr <nhofmeyr(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Harald Welte

7 years, 6 months

2
2
0 0

Re: OsmoBTS -> libosmogsm code migration

by Vadim Yanitskiy

Hi Max, Thanks for your reply! > I think extending utils/conv_gen.py is the way to go because it will > allow us to have concise description of the convolutional codes in one > place and as close to the description in standards as possible. Ok, I will keep your opinion in my mind. > Could you specify which files exactly are you referring to? Also you can > use 'git blame' to clarify authorship. No problem, they are: - gsm0503_conv.c - gsm0503_interleaving.c - gsm0503_mapping.c - gsm0503_parity.c - gsm0503_tables.c Almost all the gsm0503_*, excluding the 'gsm0503_coding.*'. Thank you for this hint, this command is very usable! :) > I don't think library functions should do any sort of logging by itself > (unless it's a logging functions of course :) > Instead they should return clearly distinguishable values and let caller > do the logging as they see fit. I am agree with you. It's time to use return codes. Have a nice day! With best regards, Vadim Yanitskiy.

7 years, 6 months

6
17
0 0

openbsc: rate ctr segfault in master

by Neels Hofmeyr

Hi lynxis, I have reverted your recent commit 38e9ea3 (see below): it introduces a reproducable segfault in openbsc, because msg->trx is not actually set/used in the openbsc code paths (it seems only osmo-bts uses msg->trx). FYI, struct msgb is used very generically in osmocom, and it's dangerous to assume that any of its members are valid or consistent with other callers, without fully understanding and testing the surrounding code paths. commit 38e9ea3f7f385c6660c5958970af5c71adc1682b Author: Alexander Couzens <lynxis(a)fe80.eu> Date: Tue Aug 23 06:27:19 2016 +0200 bsc: count the usage of codec by setting the lchan active we count the codec when the channel was successful setted up Change-Id: Ifc8a406a11dce16b9e7f3310841e470545550a2c Backtrace: 20161010011516712 DCC <0001> ../../../src/libmsc/transaction.c:71 subscr=0x813b20, net=0x7e0150 20161010011516712 DPAG <0007> ../../../src/libbsc/paging.c:291 Start paging of subscriber 49 on bts 0. 20161010011517034 DRLL <0000> ../../../src/libbsc/abis_rsl.c:1959 (bts=0,trx=0,ts=2,ss=0) SAPI=0 DATA INDICATION 20161010011517034 DRSL <0004> ../../../src/libbsc/abis_rsl.c:2176 (bts=0,trx=0,ts=2,ss=0) IPAC_BIND speech_mode=0x10 RTP_PAYLOAD=3 Program received signal SIGSEGV, Segmentation fault. count_codecs (lchan=0x1, bts=<optimized out>) at ../../../src/libbsc/abis_rsl.c:104 104 rate_ctr_inc(&bts->network->bsc_ctrs->ctr[BSC_CTR_CODEC_V1_FR]); (gdb) bt #0 count_codecs (lchan=0x1, bts=<optimized out>) at ../../../src/libbsc/abis_rsl.c:104 #1 0x0000000000425661 in abis_rsl_rx_dchan (msg=<optimized out>) at ../../../src/libbsc/abis_rsl.c:1516 #2 abis_rsl_rcvmsg (msg=0x8143f0) at ../../../src/libbsc/abis_rsl.c:2611 #3 0x00007ffff71420d0 in handle_ts1_read (bfd=<optimized out>) at ../../src/input/ipaccess.c:271 #4 ipaccess_fd_cb (bfd=0x815af8, what=1) at ../../src/input/ipaccess.c:386 #5 0x00007ffff7779b62 in osmo_fd_disp_fds (_eset=0x7fffffffe590, _wset=0x7fffffffe510, _rset=0x7fffffffe490) at ../../src/select.c:149 #6 osmo_select_main (polling=polling@entry=0) at ../../src/select.c:189 #7 0x0000000000406fac in main (argc=<optimized out>, argv=0x7fffffffe738) at ../../../src/osmo-nitb/bsc_hack.c:385 (gdb) Hope you can find a different way to count codec uses :) ~Neels -- - Neels Hofmeyr <nhofmeyr(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Harald Welte

7 years, 6 months

2
1
0 0

problems compiling for sysmobts

by Neels Hofmeyr

Hi all, I'd like to share my odd? interesting? unnerving? experience today. All I wanted to do is quickly check something (gerrit #713) on sysmobts, but I faced a series of problems. First some sysmobts related problems, later two problems entirely unrelated to osmocom... (*) My sysmobts SDK no longer works: libosmo-abis now requires libortp >= 0.22.0, but the SDK I have used so far doesn't have that: poky-eglibc-i686-meta-toolchain-osmo-armv5te-toolchain-osmo-1.5.3-20160323112523.sh (I didn't go through it in this sequence, but tried these things:) a) tried to build a more recent libortp into the installed SDK. It goes fine up to a point. It takes a bit of work to find and fetch all the repositories that are required: git://git.linphone.org/bcunit.git git://git.linphone.org/bctoolbox.git git://git.linphone.org/ortp.git but sadly, bctoolbox wants libpolarssl aka mbedtls git@github.com:ARMmbed/mbedtls.git -- which has no automake/autoconf, only a plain Makefile! It also has cmake and others, but so far I only know how to tell the ./configure script to cross-compile and install into the SDK, so I kind of gave up on figuring out cmake for that, for now. b) just reverted the libortp version bumping commit in libosmo-abis (15d9b7929d449e4138bcb003c614035bceadc3d1) Everything compiles and works out, but alas, I get constant very weird distortion/blip-tones/hickups on the voice channels, a bit of voice still audible but definitely some bad codec problem. A regression? Is it related to libortp? This happens both for a TS config of TCH/H and TCH/F. c) tried fetching a new SDK from 201310-testing/sdk: poky-eglibc-i686-meta-toolchain-osmo-armv5te-toolchain-osmo-1.5.3-20160910200558.sh This has the same problem with too old libortp. Again I revert the libortp version bump from libosmo-abis. Same results as above: badly broken voice. d) tried a new 1.5.4 SDK from 201310-nightly/sdk: poky-eglibc-i686-meta-toolchain-osmo-armv5te-toolchain-osmo-1.5.4-20161004010024.sh Here libosmo-abis is fine with the libortp it finds, so far so good. Sadly, this doesn't even do hickuped voice, only low noise on both ends. So I decided to go back to the SDK that worked for me last time to bisect. I will post another mail in case I found a regression. (*) For half a minute there I wondered why GPRS wasn't working until I remembered our two-phase-access aka WAIT_ASSIGN problem in osmo-pcu and reverted f1a7b8fc. With that, GPRS works fine with all of the above. phew ;) (*) Entirely unrelated to osmocom: I launch my CN programs from a script that launches multiple terminals. I happen to use rxvt-unicode for that and always have for a year. Turns out this time urxvt strips the LD_LIBRARY_PATH when it is invoked. I still don't know how this changed, but when I drop the suid that I find for unknown reasons sitting on the urxvt binary's group ('chmod g-s /usr/bin/urxvt'), it lets the LD_LIBRARY_PATH be, and the binaries run. How did this change from the last time I ran my CN scripts?? No idea. (*) Same with sudo: LD_LIBRARY_PATH now all of a sudden gets stripped during my sudo ggsn -f -c ggsn.conf invocation. I use sudo for ggsn to allow establishing tunnels. Again I didn't change anything about my scripts, just today it doesn't find the libraries in /usr/local/lib anymore. I have to manually add it like sudo LD_LIBRARY_PATH=/usr/local/lib ggsn ... but then sudo tells me I'm not allowed to set the env. After searching around, I add 'SETENV:' to my sudoers file: neels ALL= NOPASSWD:SETENV: /usr/local/bin/ggsn * This time ggsn starts again like it always used to. How did this change from last time I ran ggsn this way?? No idea at all. So my quick test took a bit longer than expected (hasn't started), and the night has progressed at an alarming rate... I'll write again when I found anything on the broken voice. ~Neels -- - Neels Hofmeyr <nhofmeyr(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Harald Welte

7 years, 6 months

3
7
0 0

coverity for osmocom projects

by Neels Hofmeyr

Today, I've taken a quick look at the coverity stuff, because so far I've only seen coverity reports on the Iu code. I see now that actually all of the other osmocom components are also tested by coverity. So far I'm only seeing the "Osmocom" coverity project, which contains only the iu build. In fact that's a bit of a misnomer -- I assumed that "Osmocom" would contain all of the osmos, it should be more like 'Osmocom-3G' or 'Osmocom-Iu'. The other osmos are in coverity projects named "libosmocore", "osmo-bts", etc: https://scan.coverity.com/projects?utf8=%E2%9C%93&search=osmo I see there are "add me to project" buttons e.g. here https://scan.coverity.com/projects/libosmocore so I'm trying that now. Wouldn't it make sense to redirect all the coverity reports to a mailing list? Probably best would be a new mailing list, to avoid noise on openbsc@, like the gerrit-log@ list. Are these coverity reports a matter of secrecy, to avoid publishing security holes before we fixed them, in which case the coverity mailing list should be invite-only? ~Neels

7 years, 6 months

3
6
0 0

Query on run time control of network with VTY

by Dhananjay kumar

Hi, While ruining osmo-bts and osmo-trx via VTY we tried to change parameter like Band ,ARFCN MS max power. We observed that once ARFCN is changed on VTY TRX does not switch to new ARFCN. Same behavior has been observed with Band and MS-Max-Power and RF-Locked 0/1 parameter. Request someone who is running osmo-stack has controlled network ,please reply or any document/pointer is appreciated. BR Dhananjay

7 years, 6 months

4
6
0 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

OpenBSC October 2016