OpenBSC October 2016

openbsc@lists.osmocom.org

15 participants
36 discussions

osmo-trx gerrit
by Neels Hofmeyr 18 Oct '16

18 Oct '16

<bump> https://gerrit.osmocom.org/1067 Would be nice to have the build script in master, and at the same time verify that you have +2 voting powers on osmo-trx -- you're currently the only one there. Feel free to appoint other reviewers at your discretion (tell me). Thanks! ~Neels -- - Neels Hofmeyr <nhofmeyr(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Harald Welte

2 2

creepy dirs in osmo-bts/tests
by Max 17 Oct '16

17 Oct '16

Hi. I've ran "make check" in osmo-bts recently ang got weird dir names in tests/*/ like '$srcdir' - it seems like those should be evaluated variable but it's written literally to FS. Do you guys see it as well or it's some glitch local to my shell? -- Max Suraev <msuraev(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschaeftsfuehrer / Managing Director: Harald Welte

2 1

bind & connect
by Neels Hofmeyr 17 Oct '16

17 Oct '16

Hi osmo_sock experts, I'm currently looking at making the osmo-hnbgw interface addresses configurable, an I came across a detail. This is not really pressing, but while I'm at it I might as well cover all of the addresses. So far I see in osmo-iuh's hnbgw.c the local address osmo-hnbgw uses to accept Iuh connections from a 3G cell, and the remote addresses of IuCS and IuPS, each passed to osmo_sock_init(): 3G cell -------> 1.2.3.4 OSMO-HNBGW IuPS-local? -------> 10.9.8.7 OSMO-SGSN So we tell one socket to listen on local 1.2.3.4 for Iuh. We tell another to send IuPS to 10.9.8.7. But how would I tell the IuPS to use a given local interface 1.2.3.5 to contact the SGSN's address? Would I bind() to a given local IP address and connect() to the remote one? I must admit that the details are not 100% clear to me. AFAIK it can be important to set a local IP address and port to send from. So if there's something I don't understand yet I would appreciate a hint. Anyway, in osmo_sock_init, I see: if ((flags & (OSMO_SOCK_F_BIND | OSMO_SOCK_F_CONNECT)) == (OSMO_SOCK_F_BIND | OSMO_SOCK_F_CONNECT)) { fprintf(stderr, "invalid: both bind and connect flags set:" " %s:%u\n", host, port); return -EINVAL; } Should we have another osmo_sock_init that can set up a socket like this code I found somewhere at sysmocom to define both ends of a connection? fd = socket(AF_INET, SOCK_DGRAM, 0); if (fd < 0) { printf("socket() failed: %s\n", strerror(errno)); return -1; } memset(&bindaddr, 0, sizeof(bindaddr)); bindaddr.sin_family = AF_INET; bindaddr.sin_port = htons(lport); rc = inet_pton(AF_INET, baddr, &(bindaddr.sin_addr)); if (rc != 1) { printf("inet_pton() failed with %i: %s\n", rc, strerror(errno)); return -1; } rc = bind(fd, (struct sockaddr *)&bindaddr, sizeof(bindaddr)); if (rc < 0) { printf("bind() failed: %s\n", strerror(errno)); return -1; } memset(&destaddr, 0, sizeof(destaddr)); destaddr.sin_family = AF_INET; destaddr.sin_port = htons(dport); rc = inet_pton(AF_INET, dest, &(destaddr.sin_addr)); if (rc != 1) { printf("inet_pton() failed with %i: %s\n", rc, strerror(errno)); return -1; } rc = connect(fd, (const struct sockaddr *)&destaddr, sizeof(destaddr)); if (rc < 0) { printf("connect() failed: %s\n", strerror(errno)); return -1; } rc = send(fd, buf, len, 0); if (rc != len) { printf("send() failed\n"); return -1; } Thanks, ~Neels -- - Neels Hofmeyr <nhofmeyr(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Harald Welte

2 4

moved to gerrit patch submission
by Neels Hofmeyr 14 Oct '16

14 Oct '16

The following git repositories have now moved to gerrit, please submit future patches for these at gerrit.osmocom.org, no longer via mailing lists: osmo-gsm-manuals asn1c libasn1c osmo-trx openpcd osmo-sim-auth libtelnet mncc-python osmocom-lcs Thanks, ~Neels -- - Neels Hofmeyr <nhofmeyr(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Harald Welte

1 0

Re: OsmoBTS -> libosmogsm code migration
by Vadim Yanitskiy 14 Oct '16

14 Oct '16

Hi Max, > Unfortunately I could not find any tests for the code in > question so the only way to test it is by: I uploaded tests recently. You can find them here: https://gerrit.osmocom.org/#/c/933/4/tests/coding/coding_test.c > I think the puncturing code should be part of the library (otherwise > every user will have to reimplement the same thing again and again). I am agree with you. We recently discussed this question with Tom Tsou. He said, that there was some performance related reasons to perform puncturing inside both gsm0503_pdtch_encode() / gsm0503_pdtch_decode(). With best regards, Vadim Yanitskiy.

3 6

move to gerrit
by Neels Hofmeyr 14 Oct '16

14 Oct '16

Hi all, opinions please: I would move patch submission for the following osmocom repositories to gerrit: osmo-gsm-manuals asn1c libasn1c osmo-python-tests osmo-trx (TT already agreed) Let me know if any other come to mind. Possibly *all* projects seen at git.osmocom.org? Thanks, ~Neels -- - Neels Hofmeyr <nhofmeyr(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Harald Welte

5 6

Re: New Defects reported by Coverity Scan for Osmocom
by Neels Hofmeyr 14 Oct '16

14 Oct '16

On Thu, Oct 13, 2016 at 09:32:21AM -0700, scan-admin(a)coverity.com wrote: > > Hi, > > Please find the latest report on new defect(s) introduced to Osmocom found with Coverity Scan. > > 4 new defect(s) introduced to Osmocom found with Coverity Scan. > 2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. > > New defect(s) Reported-by: Coverity Scan > Showing 4 of 4 defect(s) > > > ** CID 150135: Null pointer dereferences (REVERSE_INULL) > /source-Osmocom/openggsn/ggsn/ggsn.c: 142 in delete_context() > > > ________________________________________________________________________________________________________ > *** CID 150135: Null pointer dereferences (REVERSE_INULL) > /source-Osmocom/openggsn/ggsn/ggsn.c: 142 in delete_context() > 136 int delete_context(struct pdp_t *pdp) > 137 { > 138 DEBUGP(DGGSN, "Deleting PDP context\n"); > 139 struct ippoolm_t *member = pdp->peer; > 140 char v[NAMESIZE]; > 141 snprintf(v, sizeof(v), "%" PRIu64 ",%s", pdp->imsi, inet_ntoa(member->addr)); > >>> CID 150135: Null pointer dereferences (REVERSE_INULL) > >>> Null-checking "pdp->peer" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. > 142 if (pdp->peer) > 143 ippool_freeip(ippool, (struct ippoolm_t *)pdp->peer); > 144 else > 145 SYS_ERR(DGGSN, LOGL_ERROR, 0, "Peer not defined!"); > 146 > 147 if (gtp_kernel_tunnel_del(pdp)) { This one's for you, Max. (openggsn commit 727417dd28813c697b4820aef9f54f249e30c4b8) > ** CID 150134: Null pointer dereferences (REVERSE_INULL) > /source-Osmocom/openbsc/openbsc/src/gprs/gprs_sgsn.c: 257 in sgsn_mm_ctx_alloc_iu() > > > ________________________________________________________________________________________________________ > *** CID 150134: Null pointer dereferences (REVERSE_INULL) > /source-Osmocom/openbsc/openbsc/src/gprs/gprs_sgsn.c: 257 in sgsn_mm_ctx_alloc_iu() > 251 ctx->auth_triplet.key_seq = GSM_KEY_SEQ_INVAL; > 252 ctx->ctrg = rate_ctr_group_alloc(ctx, &mmctx_ctrg_desc, 0); > 253 > 254 /* Need to get RAID from IU conn */ > 255 ctx->ra = ctx->iu.ue_ctx->ra_id; > 256 fixed (sysmocom/iu branch). > >>> CID 150134: Null pointer dereferences (REVERSE_INULL) > >>> Null-checking "ctx->iu.ue_ctx" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. > 257 if (ctx->iu.ue_ctx) > 258 ctx->iu.ue_ctx->rab_assign_addr_enc = > 259 sgsn->cfg.iu.rab_assign_addr_enc; > 260 > 261 INIT_LLIST_HEAD(&ctx->pdp_list); > 262 > > ** CID 150133: Memory - corruptions (OVERRUN) > /source-Osmocom/osmo-bts/src/common/msg_utils.c: 121 in dtx_cache_payload() > > > ________________________________________________________________________________________________________ > *** CID 150133: Memory - corruptions (OVERRUN) > /source-Osmocom/osmo-bts/src/common/msg_utils.c: 121 in dtx_cache_payload() > 115 copy_len = OSMO_MIN(length + 1, ARRAY_SIZE(lchan->tch.dtx.cache)); > 116 > 117 lchan->tch.dtx.len = copy_len + amr; > 118 lchan->tch.dtx.fn = fn; > 119 lchan->tch.dtx.is_update = update; > 120 > >>> CID 150133: Memory - corruptions (OVERRUN) > >>> Overrunning buffer pointed to by "&lchan->tch.dtx.cache[amr]" of 20 bytes by passing it to a function which accesses it at byte offset 21 using argument "copy_len" (which evaluates to 20). > 121 memcpy(lchan->tch.dtx.cache + amr, l1_payload, copy_len); @Max, maybe 'copy_len - amr'? In any case there's potentially 'amr' too many bytes. > 122 } > 123 > 124 /*! \brief Check current state of DTX DL AMR FSM and dispatch necessary events > 125 * \param[in] lchan Logical channel on which we check scheduling > 126 * \param[in] rtp_pl buffer with RTP data > > ** CID 150132: Incorrect expression (BAD_SIZEOF) > /source-Osmocom/osmo-bts/src/common/msg_utils.c: 262 in dtx_sched_optional() > > > ________________________________________________________________________________________________________ > *** CID 150132: Incorrect expression (BAD_SIZEOF) > /source-Osmocom/osmo-bts/src/common/msg_utils.c: 262 in dtx_sched_optional() > 256 h1[] = { 14, 16, 18, 20, 66, 68, 70, 72 }; > 257 if (lchan->tch_mode == GSM48_CMODE_SPEECH_V1) { > 258 if (lchan->type == GSM_LCHAN_TCH_F) > 259 return fn_chk(f, fn, ARRAY_SIZE(f)); > 260 else > 261 return fn_chk(lchan->nr ? h1 : h0, fn, > >>> CID 150132: Incorrect expression (BAD_SIZEOF) > >>> The expression "sizeof (lchan->nr ? h1 : h0) / sizeof (lchan->nr ? h1 : h0[0])" is suspicious. Note that "lchan->nr ? h1 : h0" is a pointer and therefore the division will not return the number of array elements which may have been the intent. > 262 ARRAY_SIZE(lchan->nr ? h1 : h0)); @Max, has to be lchan-nr? ARRAY_SIZE(h1) : ARRAY_SIZE(h0) so ARRAY_SIZE can be resolved at compile time. > 263 } > 264 return false; > 265 } > 266 > 267 /* repeat last SID if possible, returns SID length + 1 or 0 */ > > > ________________________________________________________________________________________________________ > -- - Neels Hofmeyr <nhofmeyr(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Harald Welte

1 0

multiple phy with osmo-trx
by Max 13 Oct '16

13 Oct '16

Hi! I've asked about it before but this seems to have been lost in communication. The question is basically how to enable multi-TRX support for osmo-bts-trx using phy/instance infrastructure similar to other bts? What I've tried so far is documented in http://projects.osmocom.org/issues/1648 but it did not result in working setup yet. In short, I'd like to configure OpenBSC with 1 BTS with 2 TRX, each with its own arfcn and set of channels. I'm running "osmo-bts-trx -t 2" and correspondingly "osmo-trx -c 2" on usrp b210. Any ideas on what's missing to make this actually work are greatly appreciated. -- Max Suraev <msuraev(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschaeftsfuehrer / Managing Director: Harald Welte

4 15

[PATCH] mobile/vty_interface.c: Fix typo
by Martin Hauke 13 Oct '16

13 Oct '16

--- src/host/layer23/src/mobile/vty_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/host/layer23/src/mobile/vty_interface.c b/src/host/layer23/src/mobile/vty_interface.c index 9a86880..f4d7df1 100644 --- a/src/host/layer23/src/mobile/vty_interface.c +++ b/src/host/layer23/src/mobile/vty_interface.c @@ -528,7 +528,7 @@ static int _sim_test_cmd(struct vty *vty, int argc, const char *argv[], DEFUN(sim_test, sim_test_cmd, "sim testcard MS_NAME [MCC] [MNC] [LAC] [TMSI]", - "SIM actions\nAttach bulit in test SIM\nName of MS (see \"show ms\")\n" + "SIM actions\nAttach built-in test SIM\nName of MS (see \"show ms\")\n" "Optionally set mobile Country Code of RPLMN\n" "Optionally set mobile Network Code of RPLMN\n" "Optionally set location area code of RPLMN\n" @@ -539,7 +539,7 @@ DEFUN(sim_test, sim_test_cmd, DEFUN(sim_test_att, sim_test_att_cmd, "sim testcard MS_NAME MCC MNC LAC TMSI attached", - "SIM actions\nAttach bulit in test SIM\nName of MS (see \"show ms\")\n" + "SIM actions\nAttach built-in test SIM\nName of MS (see \"show ms\")\n" "Set mobile Country Code of RPLMN\nSet mobile Network Code of RPLMN\n" "Set location area code\nSet current assigned TMSI\n" "Indicate to MM that card is already attached") @@ -1758,7 +1758,7 @@ DEFUN(cfg_ms_sap, cfg_ms_sap_cmd, "sap-socket PATH", DEFUN(cfg_ms_sim, cfg_ms_sim_cmd, "sim (none|reader|test|sap)", "Set SIM card to attach when powering on\nAttach no SIM\n" - "Attach SIM from reader\nAttach bulit in test SIM\n" + "Attach SIM from reader\nAttach built-in test SIM\n" "Attach SIM over SAP interface") { struct osmocom_ms *ms = vty->index; -- 2.6.6

1 0

[PATCH] Typo in Chapter 14.2
by Ivaylo Kostov 13 Oct '16

13 Oct '16

--- OsmoNITB/chapters/smpp.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/OsmoNITB/chapters/smpp.adoc b/OsmoNITB/chapters/smpp.adoc index 2557580..91f8c07 100644 --- a/OsmoNITB/chapters/smpp.adoc +++ b/OsmoNITB/chapters/smpp.adoc @@ -44,7 +44,7 @@ SMPP (`no smpp-first`). === ESME configuration -nder the `smpp` vty node, you can add any number of `esme` nodes, one +Under the `smpp` vty node, you can add any number of `esme` nodes, one for each ESME that you wish to configure. Use the `esme NAME` command (where NAME corresponds to the system-id of -- 2.7.4

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

OpenBSC October 2016