June 2015 - OpenBSC - lists.osmocom.org

[PATCH 0/4] core/conv: Fast Viterbi decoding

by Thomas Tsou

Hi all, This patch set adds to libosmocore an optimized Viterbi decodeer for architecture specific (Intel SSE) and non-specific cases. The implementation covers codes with constraint lengths of K=5 and K=7 and rates 1/4 to 3/4, which make up the majority of GSM use cases. Speedup from the current implementation is in the range of 5 to 20 depending on the processor and code type. API is unchanged. Tested on Haswell (i7-4770K) and Atom (D2550). Additional test codes from osmo-bts are included. Further tests for AWGN bit-error-rate and benchmarks can be found in the following repository. https://github.com/ttsou/osmo-conv-test Here are some examples. Bit error test for GPRS CS2 with SNR of 5 dB and 100000 bursts. $ ./conv_test -c 2 -e -r 5 -i 100000 ================================================= [+] Testing: GPRS CS2 [.] Specs: (N=2, K=5, non-recursive, flushed, not punctured) [.] Input length : ret = 290 exp = 290 -> OK [.] Output length : ret = 588 exp = 588 -> OK [.] BER tests: [..] Testing base: [..] Input BER.......................... 0.042443 [..] Output BER......................... 0.000006 [..] Output FER......................... 0.001350 (135) [..] Testing SIMD: [..] Input BER.......................... 0.042460 [..] Output BER......................... 0.000005 [..] Output FER......................... 0.001240 (124) Timed AFS benchmark with 8 threads and 100000 bursts per thread. $ ./conv_test -b -c 10 -j 8 -i 100000 ================================================= [+] Testing: GSM TCH/AFS 6.7 [.] Specs: (N=4, K=5, recursive, flushed, punctured) [.] Input length : ret = 140 exp = 140 -> OK [.] Output length : ret = 448 exp = 448 -> OK [.] Performance benchmark: [..] Encoding / Decoding 800000 bursts on 8 thread(s): [..] Testing base: [..] Elapsed time....................... 4.320001 secs [..] Rate............................... 25.925920 Mbps [..] Testing SIMD: [..] Elapsed time....................... 0.458272 secs [..] Rate............................... 244.396341 Mbps [..] Speedup............................ 9.426718 -TT

8 years

5
13
0 0

OpenBSC + Huawei BTS 3900B

by Роман Жогов

Hi all. I'm working on probation on mobile operator as a student. Currently, I'm trying to create site for testing, using Huawei BTS 3900B and OpenBSC software. But I can't set up it. I have a several questions: 1) Huawei BTS uses Abis over IP, how can I connect this BTS to OpenBSC. 2) Are there any examples of configuration in this case? Thanks.

8 years, 8 months

2
1
0 0

osmo-nitb hangs with large hlr.sqlite3 file

by F Abdu

Dear Experts, Hello, I am running a gsm system with followings: OpenBSC version: 0.13.0.319-30e0e LCR version 1.14 astersik version 1.8.10.1 The system is sited is a busy area. The system works fine for few days but hangs once the hlr.sqlite3 file size reaches near 12 MB and that causes the osmo-nitb to take 99% of the cpu usage. I used "./osmo-nitb -m -P -C" to run the system. The hlr.sqlite3 file increases @2MB/Day. The 'Subscriber' table of the hlr.sqlite3 file adds a large number of IMSI with authorized=0. Tables like Counters, Eqipment and EquipmentWatch are filling up with lots of data. Now the only solution to this problem is to manually delete the data from the tables. May I get some light to solve the issue form the experts like you all? With regards. [ Content from the openbsc.cfg file is as following: ! ! OpenBSC configuration saved from vty ! ! password foo ! line vty no login ! e1_input e1_line 0 driver ipa network network country code XXX mobile network code XX short name Test long name Test auth policy closed location updating reject cause 13 encryption a5 0 neci 1 rrlp mode none mm info 0 handover 0 handover window rxlev averaging 10 handover window rxqual averaging 1 handover window rxlev neighbor averaging 10 handover power budget interval 6 handover power budget hysteresis 3 handover maximum distance 9999 timer t3101 10 timer t3103 0 timer t3105 0 timer t3107 0 timer t3109 4 timer t3111 1 timer t3113 60 timer t3115 0 timer t3117 0 timer t3119 0 timer t3141 0 bts 0 type sysmobts band GSMXXX cell_identity X location_area_code X training_sequence_code 7 base_station_id_code 63 ms max power 30 cell reselection hysteresis 4 rxlev access min 0 periodic location update 100 channel allocator ascending rach tx integer 9 rach max transmission 7 ip.access unit_id XXXX 0 oml ip.access stream_id 255 line 0 gprs mode none trx 0 rf_locked 0 arfcn XXX nominal power 23 max_power_red XX rsl e1 tei 0 timeslot 0 phys_chan_config CCCH+SDCCH4 timeslot 1 phys_chan_config SDCCH8 timeslot 2 phys_chan_config TCH/F timeslot 3 phys_chan_config TCH/F timeslot 4 phys_chan_config TCH/F timeslot 5 phys_chan_config TCH/F timeslot 6 phys_chan_config TCH/F timeslot 7 phys_chan_config TCH/F

8 years, 8 months

2
1
0 0

[PATCH 1/1] openbsc: Rename core_ncc to core_mnc

by Mike McTernan (wavemobile)

Hi Folks, Struct osmo_msc_data contains int core_ncc, which is actually the MNC part of the PLMN, not to be confused with the Network Colour Code. The following patch renames this field for clarity and consistency with the standards. Please consider it for inclusion. Signed-off-by: Michael McTernan <Michael.McTernan(a)wavemobile.com> diff -Nrup openbsc.orig/openbsc/include/openbsc/osmo_msc_data.h openbsc/openbsc/include/openbsc/osmo_msc_data.h --- openbsc.orig/openbsc/include/openbsc/osmo_msc_data.h 2015-06-02 12:45:13.682136307 +0100 +++ openbsc/openbsc/include/openbsc/osmo_msc_data.h 2015-06-02 12:45:28.661356866 +0100 @@ -65,7 +65,7 @@ struct osmo_msc_data { struct osmo_timer_list pong_timer; int advanced_ping; struct bsc_msc_connection *msc_con; - int core_ncc; + int core_mnc; int core_mcc; int core_lac; int core_ci; diff -Nrup openbsc.orig/openbsc/src/osmo-bsc/osmo_bsc_api.c openbsc/openbsc/src/osmo-bsc/osmo_bsc_api.c --- openbsc.orig/openbsc/src/osmo-bsc/osmo_bsc_api.c 2015-06-02 12:45:13.679136263 +0100 +++ openbsc/openbsc/src/osmo-bsc/osmo_bsc_api.c 2015-06-02 12:45:28.664356910 +0100 @@ -53,8 +53,8 @@ static int complete_layer3(struct gsm_su static uint16_t get_network_code_for_msc(struct osmo_msc_data *msc) { - if (msc->core_ncc != -1) - return msc->core_ncc; + if (msc->core_mnc != -1) + return msc->core_mnc; return msc->network->network_code; } diff -Nrup openbsc.orig/openbsc/src/osmo-bsc/osmo_bsc_filter.c openbsc/openbsc/src/osmo-bsc/osmo_bsc_filter.c --- openbsc.orig/openbsc/src/osmo-bsc/osmo_bsc_filter.c 2015-06-02 12:45:13.679136263 +0100 +++ openbsc/openbsc/src/osmo-bsc/osmo_bsc_filter.c 2015-06-02 12:46:00.653828021 +0100 @@ -313,7 +313,7 @@ static int bsc_patch_mm_info(struct gsm_ static int has_core_identity(struct osmo_msc_data *msc) { - if (msc->core_ncc != -1) + if (msc->core_mnc != -1) return 1; if (msc->core_mcc != -1) return 1; diff -Nrup openbsc.orig/openbsc/src/osmo-bsc/osmo_bsc_msc.c openbsc/openbsc/src/osmo-bsc/osmo_bsc_msc.c --- openbsc.orig/openbsc/src/osmo-bsc/osmo_bsc_msc.c 2015-06-02 12:45:13.679136263 +0100 +++ openbsc/openbsc/src/osmo-bsc/osmo_bsc_msc.c 2015-06-02 12:45:28.664356910 +0100 @@ -522,7 +522,7 @@ struct osmo_msc_data *osmo_msc_data_allo INIT_LLIST_HEAD(&msc_data->dests); msc_data->ping_timeout = 20; msc_data->pong_timeout = 5; - msc_data->core_ncc = -1; + msc_data->core_mnc = -1; msc_data->core_mcc = -1; msc_data->core_ci = -1; msc_data->core_lac = -1; diff -Nrup openbsc.orig/openbsc/src/osmo-bsc/osmo_bsc_vty.c openbsc/openbsc/src/osmo-bsc/osmo_bsc_vty.c --- openbsc.orig/openbsc/src/osmo-bsc/osmo_bsc_vty.c 2015-06-02 12:45:13.679136263 +0100 +++ openbsc/openbsc/src/osmo-bsc/osmo_bsc_vty.c 2015-06-02 12:45:28.664356910 +0100 @@ -107,9 +107,9 @@ static void write_msc(struct vty *vty, s vty_out(vty, "msc %d%s", msc->nr, VTY_NEWLINE); if (msc->bsc_token) vty_out(vty, " token %s%s", msc->bsc_token, VTY_NEWLINE); - if (msc->core_ncc != -1) + if (msc->core_mnc != -1) vty_out(vty, " core-mobile-network-code %d%s", - msc->core_ncc, VTY_NEWLINE); + msc->core_mnc, VTY_NEWLINE); if (msc->core_mcc != -1) vty_out(vty, " core-mobile-country-code %d%s", msc->core_mcc, VTY_NEWLINE); @@ -234,10 +234,10 @@ DEFUN(cfg_net_bsc_token, DEFUN(cfg_net_bsc_ncc, cfg_net_bsc_ncc_cmd, "core-mobile-network-code <1-999>", - "Use this network code for the core network\n" "NCC value\n") + "Use this network code for the core network\n" "MNC value\n") { struct osmo_msc_data *data = osmo_msc_data(vty); - data->core_ncc = atoi(argv[0]); + data->core_mnc = atoi(argv[0]); return CMD_SUCCESS; } The same patch is attached, md5sum 2082d6b4b174236fcf3b84e548dcf2ad (in case it gets mangled by the mailer). Kind Regards, Mike

8 years, 9 months

2
1
0 0

Re: bssgp test

by Jacob Erlbeck

Hi On 05.06.2015 15:15, ☎ wrote: > Could you perhaps summarize what's happening around tests/gb/gprs_bssgp_test.c:229? The line before the failing test is rc = bssgp_tx_fc_bvc(&bctx, tag, bmax, rate, bmax_ms, rate_ms, NULL, NULL); The bssgp_tx_fc_bvc function will in general call gprs_ns_sendmsg -> gprs_ns_tx -> nsip_sendmsg -> sendto. The sendto function had been "replaced" by redefining it locally which worked at least with the default ld up to ubuntu 14.04. (see Holger's replies). The system's sendto will fail in the test, since the UDP socket has not been configured. The local replacement (see gprs_bbsgp_test.c:37) will call fprintf(stderr, "MESSAGE to 0x%08x, msg length %d\n%s\n", dest_host, len, osmo_hexdump(buf, len)); so you just need to look into the stderr output to see, whether this is a linker issue. If yes, the issue will appear in more test programs, since that pattern has been used many times. If there is no way to trick the linker to use the "old" behaviour, those test programs will have to be changed to use another mocking mechanism, e.g. by using the --wrap feature (if it is supported by the linker), see openbsc:openbsc/tests/sgsn/sgsn_test.c. HTH Jacob > > The test fails for me (and another person with ubuntu 15.04 x86_64) on OSMO_ASSERT(rc >> = 0); > > This is 100% reproducible but I don't know much about Gb part so I'm not sure how to > track this down properly. Any ideas/advices? > -- - Jacob Erlbeck <jerlbeck(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschaeftsfuehrer / Managing Directors: Holger Freyther, Harald Welte

8 years, 9 months

3
4
0 0

Re: segfault on bssgp test

by ☎

Pardon for multiple copies, but this is really curious: gbprocy test also fails for me during OpenBSC build at gbproxy_test.c:1922 which also contains following misterious comment: /* TODO: The following breaks with the current libosmocore, enable it * again (and remove the plain expect_msg), when the msgb_bssgph patch * is integrated */ What is the status of this "msgb_bssgph patch" patch? Is there patchwork link available? I suspect it's still unmerged because swapping the lines as instructed in comment still results in crash with the latest libosmocore from git. Commenting out both lines produce sane-looking output but the test expectedly fails due to mismatch with expected output. I wonder if should comment out the 2nd line until the libosmocore patch is merged or perhaps consider merging the necessary patch? 22.05.2015 15:38, ☎ пишет: > Hi. > > Anyone else experienced this with latest libosmocore from git? > > ./testsuite.at:124: $abs_top_builddir/tests/gb/gprs_bssgp_test > stderr: > MESSAGE to 0x7f0000ff, msg length 12 > 02 00 81 01 01 82 0b 56 04 82 0b 55 > All NS-VCs for NSEI 2901 are either dead or blocked! > All NS-VCs for NSEI 2901 are either dead or blocked! > BSSGP BVCI=0 Rx BVC STATUS, cause=Protocol error - unspecified > BSSGP BVCI=1234 Rx BVC STATUS, cause=Unknown BVCI > NSEI=2901/BVCI=2989 Cannot handle PDU type 34 for unknown BVCI, NS BVCI 2989 > Unable to resolve NSEI 4660 to NS-VC! > Assert failed rc >= 0 gb/gprs_bssgp_test.c:229 > /home/user/source/libosmocore/tests/testsuite.dir/at-groups/19/test-source: line 25: > 8497 Aborted (core dumped) $abs_top_builddir/tests/gb/gprs_ > bssgp_test > -- best regards, Max, http://fairwaves.co

8 years, 9 months

2
6
0 0

Random nanoBTS reboot

by Pierre Kim

Hello, I've been experiencing this bug ever since I started experimenting with OpenBSC. At first I thought it as a problem with unstable connection, but it continued to happen even after I connected to the nanoBTS directly through a switch. I used Wireshark to track down the cause and discovered that OpenBSC was responding too late to PING message from the nanoBTS. I am attaching the pcap file of the moment. This happens as soon as 1 hour from the first connection, sometimes it runs okay for 18 hours but I've never seen my nanoBTS running straight for more than 24hrs Please take a look into the log. Any help will be greatly appreciated. Tell me in case if you need more information Regards, Pierre Following is the log from openbsc console. Sat Jun 27 03:24:43 2015 <0004> bsc_init.c:286 bootstrapping RSL for BTS/TRX (0/0) on ARFCN 520 using MCC=450 MNC=9 LAC=1 CID=0 BSIC=63 TSC=7 Sat Jun 27 08:17:39 2015 <001a> ipa.c:246 Cannot send PING message. Reason: Broken pipe Sat Jun 27 08:17:39 2015 <001a> input/ipaccess.c:110 Unexpected return from ipa_ccm_rcvmsg_base (ret=-32) Sat Jun 27 08:17:39 2015 <001a> input/ipaccess.c:236 Sign link vanished, dead socket Sat Jun 27 08:17:39 2015 <001a> input/ipaccess.c:69 Forcing socket shutdown with no signal link set Sat Jun 27 08:20:51 2015 <001a> input/ipa.c:265 accept()ed new link from 192.168.28.31 to port 3002 Sat Jun 27 08:21:08 2015 <001a> input/ipa.c:265 accept()ed new link from 192.168.28.31 to port 3003 Sat Jun 27 08:21:11 2015 <0004> bsc_init.c:286 bootstrapping RSL for BTS/TRX (0/0) on ARFCN 520 using MCC=450 MNC=9 LAC=1 CID=0 BSIC=63 TSC=7 and sometimes without the error from ipa_ccm_rcvmsg_base Sun Jun 28 09:17:40 2015 <001a> input/ipaccess.c:236 Sign link vanished, dead socket Sun Jun 28 09:17:40 2015 <001a> input/ipaccess.c:69 Forcing socket shutdown with no signal link set Sun Jun 28 09:20:39 2015 <001a> input/ipa.c:265 accept()ed new link from 192.168.28.31 to port 3002 Sun Jun 28 09:20:56 2015 <001a> input/ipa.c:265 accept()ed new link from 192.168.28.31 to port 3003 Sun Jun 28 09:20:59 2015 <0004> bsc_init.c:286 bootstrapping RSL for BTS/TRX (0/0) on ARFCN 520 using MCC=450 MNC=9 LAC=1 CID=0 BSIC=63 TSC=7

8 years, 10 months

1
0
0 0

NanoBTS for sale?

by brogan.tom.iii＠gmail.com

I would like to know if anyone has a Nanobts for sale hopefully under 500$. I'm looking for the 900MHz or 1800MHz ones, preferably the ones with SMA antenna connectors (the white square ones) without internal antennas. Doesn't matter if they are used/old/new, just something that works without issues :)

8 years, 10 months

1
0
0 0

[PATCH 2/2] libbsc: Update a BTS's SIs when ms_max_power is changed from VTY.

by Alexander Chemeris

Otherwise you have to restart BTS or at least break the RSL connection to apply the change. -- Regards, Alexander Chemeris. CEO, Fairwaves, Inc. https://fairwaves.co

8 years, 10 months

3
7
0 0

[PATCH] bssgp: Fix IMSI buffer size (Coverity)

by Jacob Erlbeck

Currently the size of the IMSI pointer is used instead of the size of the talloc'ed buffer. This commit changes the call to gsm48_mi_to_string to use the same value that has been used with talloc_zero_size(). The length is changed to 17 since that value is used for GSM_IMSI_LENGTH in openbsc. Fixes: Coverity CID 1040663 Sponsored-by: On-Waves ehf --- src/gb/gprs_bssgp_bss.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gb/gprs_bssgp_bss.c b/src/gb/gprs_bssgp_bss.c index 962bf2e..3a9012e 100644 --- a/src/gb/gprs_bssgp_bss.c +++ b/src/gb/gprs_bssgp_bss.c @@ -34,6 +34,8 @@ #include "common_vty.h" +#define GSM_IMSI_LENGTH 17 + uint8_t *bssgp_msgb_tlli_put(struct msgb *msg, uint32_t tlli) { uint32_t _tlli = htonl(tlli); @@ -498,8 +500,8 @@ int bssgp_rx_paging(struct bssgp_paging_info *pinfo, if (!TLVP_PRESENT(&tp, BSSGP_IE_IMSI)) goto err_mand_ie; if (!pinfo->imsi) - pinfo->imsi = talloc_zero_size(pinfo, 16); - gsm48_mi_to_string(pinfo->imsi, sizeof(pinfo->imsi), + pinfo->imsi = talloc_zero_size(pinfo, GSM_IMSI_LENGTH); + gsm48_mi_to_string(pinfo->imsi, GSM_IMSI_LENGTH, TLVP_VAL(&tp, BSSGP_IE_IMSI), TLVP_LEN(&tp, BSSGP_IE_IMSI)); -- 1.9.1

8 years, 10 months

2
1
0 0

[PATCH] bssgp/test: Add missing START/END printfs

by Jacob Erlbeck

Sponsored-by: On-Waves ehf --- tests/gb/gprs_bssgp_test.c | 7 ++++++- tests/gb/gprs_bssgp_test.ok | 2 ++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/tests/gb/gprs_bssgp_test.c b/tests/gb/gprs_bssgp_test.c index 63abf8b..14ba4d1 100644 --- a/tests/gb/gprs_bssgp_test.c +++ b/tests/gb/gprs_bssgp_test.c @@ -173,10 +173,13 @@ static void test_bssgp_status(void) static void test_bssgp_bad_reset() { - struct msgb *msg = bssgp_msgb_alloc(); + struct msgb *msg; uint16_t bvci_be = htons(2); uint8_t cause = BSSGP_CAUSE_OML_INTERV; + printf("----- %s START\n", __func__); + msg = bssgp_msgb_alloc(); + msgb_v_put(msg, BSSGP_PDUT_BVC_RESET); msgb_tvlv_put(msg, BSSGP_IE_BVCI, sizeof(bvci_be), (uint8_t *)&bvci_be); msgb_tvlv_put(msg, BSSGP_IE_CAUSE, sizeof(cause), &cause); @@ -184,6 +187,8 @@ static void test_bssgp_bad_reset() msgb_bvci(msg) = 0xbad; msgb_bssgp_send_and_free(msg); + + printf("----- %s END\n", __func__); } static void test_bssgp_flow_control_bvc(void) diff --git a/tests/gb/gprs_bssgp_test.ok b/tests/gb/gprs_bssgp_test.ok index a011bee..83d633b 100644 --- a/tests/gb/gprs_bssgp_test.ok +++ b/tests/gb/gprs_bssgp_test.ok @@ -7,6 +7,8 @@ BSSGP primitive, SAP 16777219, prim = 4, op = 0, msg = 0e 1f 84 f0 12 34 56 1b 8 BSSGP primitive, SAP 16777221, prim = 11, op = 2, msg = 41 07 81 27 BSSGP primitive, SAP 16777221, prim = 11, op = 2, msg = 41 07 81 05 04 82 04 d2 ----- test_bssgp_status END +----- test_bssgp_bad_reset START +----- test_bssgp_bad_reset END ----- test_bssgp_flow_control_bvc START Got message: 26 1e 81 2a 05 82 10 22 03 82 c0 40 01 82 08 11 1c 82 60 20 Got message: 26 1e 81 2a 05 82 10 22 03 82 c0 40 01 82 08 11 1c 82 60 20 3c 81 78 06 82 11 44 -- 1.9.1

8 years, 10 months

1
0
0 0

[PATCH] Fix GSM900 ARFCN range check

by Mike McTernan (wavemobile)

Allow ARFCN 0 to be used in GSM900 band. Signed-off-by: Michael McTernan <mike.mcternan(a)wavemobile.com> Index: osmobss/openbsc/openbsc/src/libbsc/bsc_init.c =================================================================== --- osmobss.orig/openbsc/openbsc/src/libbsc/bsc_init.c 2015-06-03 11:36:16.114471430 +0100 +++ osmobss/openbsc/openbsc/src/libbsc/bsc_init.c 2015-06-18 08:53:14.116369178 +0100 @@ -379,10 +379,10 @@ static int bootstrap_bts(struct gsm_bts } break; case GSM_BAND_900: - if (bts->c0->arfcn < 1 || + if (bts->c0->arfcn < 0 || (bts->c0->arfcn > 124 && bts->c0->arfcn < 955) || bts->c0->arfcn > 1023) { - LOGP(DNM, LOGL_ERROR, "GSM900 channel must be between 1-124, 955-1023.\n"); + LOGP(DNM, LOGL_ERROR, "GSM900 channel must be between 0-124, 955-1023.\n"); return -EINVAL; } break;

8 years, 10 months

1
0
0 0

openbsc: build system tweaks

by Andreas Rottmann

Here are a bunch of buildsystem tweaks for openbsc. I'm not sure whether it is warranted to group them as a patch series, as they are (should be) independent of each other.

8 years, 10 months

3
9
0 0

[PATCH 1/2] libbsc: Abstract out SIs update/generation for a BTS into a separate function.

by Alexander Chemeris

The code to do that doesn't belong to the control interface, so abstract it out to a separate function gsm_bts_set_system_infos(). -- Regards, Alexander Chemeris. CEO, Fairwaves, Inc. https://fairwaves.co

8 years, 10 months

2
2
0 0

[PATCH] libmsc: Improve 'max_power_red' VTY command.

by Alexander Chemeris

Changes: * Apply change even if the supplied value is odd, just warn that it is rounded. Previously the value was not set at all, which may have lead to a situation when a user thinks the BTS operating at low power, while it is running full power. * Apply change even if the supplied value is higher than the 24dB maximum suggested by the standard, just warn about this. UmSITE and probably other SDR based BTS support much wider power regulation range. * Apply change to the BTS over OML immediately. -- Regards, Alexander Chemeris. CEO, Fairwaves, Inc. https://fairwaves.co

8 years, 10 months

2
2
0 0

[PATCH 1/8] nat: Add size check for the payload

by Holger Hans Peter Freyther

From: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> The msgb will always have these bytes but it is better practice to verify that the message really has space for the two bytes. --- openbsc/src/osmo-bsc_nat/bsc_nat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/openbsc/src/osmo-bsc_nat/bsc_nat.c b/openbsc/src/osmo-bsc_nat/bsc_nat.c index 4357485..537001e 100644 --- a/openbsc/src/osmo-bsc_nat/bsc_nat.c +++ b/openbsc/src/osmo-bsc_nat/bsc_nat.c @@ -1185,7 +1185,7 @@ exit: send_reset_ack(bsc); } else if (parsed->ipa_proto == IPAC_PROTO_IPACCESS) { /* do we know who is handling this? */ - if (msg->l2h[0] == IPAC_MSGT_ID_RESP) { + if (msg->l2h[0] == IPAC_MSGT_ID_RESP && msgb_l2len(msg) > 2) { struct tlv_parsed tvp; int ret; ret = ipa_ccm_idtag_parse(&tvp, -- 2.3.5

8 years, 10 months

1
7
0 0

measurement report trap/JSON document

by Holger Freyther

Hi, sorry for the delay from OsmoDevCon to now. Attached is what I proposed in a customer project a long time ago. The idea was to register for traps, version them with vX in the variable name and then send traps as JSON document. holger

8 years, 10 months

1
0
0 0

test

by Holger Freyther

8 years, 10 months

1
0
0 0

IPAccess NanoBTS

by Sipos Csaba

Dear list, I recently integrated nanoBTS under OpenBSC. They work fine, but I encountered the following limitations. 1. Dynamic PDCH/TCH switching is allowed to be configured, but not working. The timeslots are stuck in TCH/F mode and never converted to PDCH. Is there any trick I need to do other than setting the channel type to TCH/F_PDCH? 2. No matter what I do, the BTS only schedules one uplink timeslot. If I understand it correctly, the PCU implementation in this case is inside the NanoBTS. Is there a way to change for example an NVRAM parameter to allow a more balanced UL/DL timeslot ratio? 3. Multi-TRX setup: it is quite a limitation that you cannot use any timeslots as PDCH in a multi-TRX setup on the secondary or third carriers at all. I don't think there is any solution to that, but it worth noting. I hope someone can point me in the right direction with dyn PDCH switching and the single UL TS issue. Thanks! Regards, Csaba

8 years, 10 months

2
1
0 0

Why isn't ARFCN 0 supported?

by Mike McTernan (wavemobile)

Good afternoon! In libbsc/bsc_init.c we have the following case: case GSM_BAND_900: if (bts->c0->arfcn < 1 || (bts->c0->arfcn > 124 && bts->c0->arfcn < 955) || bts->c0->arfcn > 1023) { LOGP(DNM, LOGL_ERROR, "GSM900 channel must be between 1-124, 955-1023.\n"); return -EINVAL; } break; 3GPP 45.005, table 2-2 gives valid channel numbers as: P-GSM900 -> 1-124, E-GSM900 -> 0-124 and 975-1023 R-GSM900 -> 0-124 and 955-1023 ER-GSM900 -> 0-124 and 940-1023 The code looks to bounds check ARFCN closest to R-GSM900, but omits ARFCN 0. Is the check "bts->c0->arfcn < 1" erroneous, or am I missing some history? Also should it really check for the R-GSM 900 range, or should it be E-GSM (more common)? The other band checks look correct. Kind Regards, Mike PS: osmo-arfcn is okay with ARFCN 0: $ ./osmo-arfcn -a 0 ARFCN 0: Uplink 890.0 MHz / Downlink 935.0 MHz

8 years, 10 months

2
1
0 0

libosmoabis depends on libosmovty

by Mike McTernan (wavemobile)

Hi Folks, When I build OpenBsc, I find a number of cases where libosmovty isn't in the link, but is needed by libosmoabis (basically anywhere libosmoabis is linked, but vty isn't) e.g. /bin/ld: warning: libosmovty.so.1, needed by /.build/usr/local/lib/libosmoabis.so, not found (try using -rpath or -rpath-link) /.build/usr/local/lib/libosmoabis.so: undefined reference to `install_node' /.build/usr/local/lib/libosmoabis.so: undefined reference to `install_element_ve' /.build/usr/local/lib/libosmoabis.so: undefined reference to `vty_out_rate_ctr_group' /.build/usr/local/lib/libosmoabis.so: undefined reference to `vty_out' /.build/usr/local/lib/libosmoabis.so: undefined reference to `install_element' /.build/usr/local/lib/libosmoabis.so: undefined reference to `vty_install_default' I'm not sure why/how I'm seeing this and others apparently aren't, but it looks legitimate. I've verified the configure script has [correctly] derived build configfrom the staged pkgconfig: LIBOSMOABIS_CFLAGS='-I/.build/usr/local/include/ ' LIBOSMOABIS_LIBS='-L/.build/usr/local/lib -losmoabis ' So I wonder if libosmoabis.pc.in should be updated to include vty, a bit like libosmogb.pc.in i.e. Signed-off-by: Michael McTernan <Michael.McTernan(a)wavemobile.com> --- libosmoabis.pc.in (revision 19495) +++ libosmoabis.pc.in (working copy) @@ -6,6 +6,6 @@ Name: A-bis Core Library Description: C Utility Library Version: @VERSION@ -Libs: -L${libdir} -losmoabis +Libs: -L${libdir} -losmoabis -losmovty Cflags: -I${includedir}/ Otherwise every user of libosmoabis has to remember to link with -losmovty as well. Kind Regards, Mike PS: I've stripped the very long full build paths from output - I don't really build in /.build!

8 years, 10 months

2
3
0 0

[PATCH] Use generic auth API

by Max

Signed-off-by: Max <max.suraev(a)fairwaves.co> --- openbsc/src/libmsc/auth.c | 69 +++++++++++++++++++---------------------------- 1 file changed, 28 insertions(+), 41 deletions(-) diff --git a/openbsc/src/libmsc/auth.c b/openbsc/src/libmsc/auth.c index 10d8edf..d04b2fc 100644 --- a/openbsc/src/libmsc/auth.c +++ b/openbsc/src/libmsc/auth.c @@ -24,47 +24,11 @@ #include <openbsc/debug.h> #include <openbsc/auth.h> #include <openbsc/gsm_data.h> - -#include <osmocom/gsm/comp128.h> +#include <osmocom/crypt/auth.h> #include <stdlib.h> -static int -_use_xor(struct gsm_auth_info *ainfo, struct gsm_auth_tuple *atuple) -{ - int i, l = ainfo->a3a8_ki_len; - - if ((l > A38_XOR_MAX_KEY_LEN) || (l < A38_XOR_MIN_KEY_LEN)) { - LOGP(DMM, LOGL_ERROR, "Invalid XOR key (len=%d) %s\n", - ainfo->a3a8_ki_len, - osmo_hexdump(ainfo->a3a8_ki, ainfo->a3a8_ki_len)); - return -1; - } - - for (i=0; i<4; i++) - atuple->sres[i] = atuple->rand[i] ^ ainfo->a3a8_ki[i]; - for (i=4; i<12; i++) - atuple->kc[i-4] = atuple->rand[i] ^ ainfo->a3a8_ki[i]; - - return 0; -} - -static int -_use_comp128_v1(struct gsm_auth_info *ainfo, struct gsm_auth_tuple *atuple) -{ - if (ainfo->a3a8_ki_len != A38_COMP128_KEY_LEN) { - LOGP(DMM, LOGL_ERROR, "Invalid COMP128v1 key (len=%d) %s\n", - ainfo->a3a8_ki_len, - osmo_hexdump(ainfo->a3a8_ki, ainfo->a3a8_ki_len)); - return -1; - } - - comp128(ainfo->a3a8_ki, atuple->rand, atuple->sres, atuple->kc); - - return 0; -} - /* Return values * -1 -> Internal error * 0 -> Not available @@ -76,6 +40,11 @@ int auth_get_tuple_for_subscr(struct gsm_auth_tuple *atuple, { struct gsm_auth_info ainfo; int i, rc; + static struct osmo_sub_auth_data auth = { + .type = OSMO_AUTH_TYPE_GSM + }; + struct osmo_auth_vector _vec; + struct osmo_auth_vector *vec = &_vec; /* Get subscriber info (if any) */ rc = db_get_authinfo_for_subscr(&ainfo, subscr); @@ -109,13 +78,23 @@ int auth_get_tuple_for_subscr(struct gsm_auth_tuple *atuple, return 0; case AUTH_ALGO_XOR: - if (_use_xor(&ainfo, atuple)) - return 0; + auth.algo = OSMO_AUTH_ALG_XOR; + if ((ainfo.a3a8_ki_len > A38_XOR_MAX_KEY_LEN) || (ainfo.a3a8_ki_len < A38_XOR_MIN_KEY_LEN)) { + LOGP(DMM, LOGL_ERROR, "Invalid XOR key (len=%d) %s\n", + ainfo.a3a8_ki_len, + osmo_hexdump(ainfo.a3a8_ki, ainfo.a3a8_ki_len)); + return -1; + } break; case AUTH_ALGO_COMP128v1: - if (_use_comp128_v1(&ainfo, atuple)) - return 0; + auth.algo = OSMO_AUTH_ALG_COMP128v1; + if (ainfo.a3a8_ki_len != A38_COMP128_KEY_LEN) { + LOGP(DMM, LOGL_ERROR, "Invalid COMP128v1 key (len=%d) %s\n", + ainfo.a3a8_ki_len, + osmo_hexdump(ainfo.a3a8_ki, ainfo.a3a8_ki_len)); + return -1; + } break; default: @@ -124,6 +103,14 @@ int auth_get_tuple_for_subscr(struct gsm_auth_tuple *atuple, return 0; } + memcpy(auth.u.gsm.ki, ainfo.a3a8_ki, sizeof(auth.u.gsm.ki)); + + if (osmo_auth_gen_vec(vec, &auth, atuple->rand) < 0) + return -1; + + memcpy(atuple->sres, vec->sres, 4); + memcpy(atuple->kc, vec->kc, 8); + db_sync_lastauthtuple_for_subscr(atuple, subscr); DEBUGP(DMM, "Need to do authentication and ciphering\n"); -- 1.9.1

8 years, 10 months

3
3
0 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

OpenBSC June 2015