October 2015 - OpenBSC - lists.osmocom.org

by Sipos Csaba

Dear List, I am in the process of creating the Wiki page for Ettus B200/B210 with OpenBSC, GPRS and Asterisk. I am quite close, both data and calls are working, but the voice calls are half sided. The downlink direction works, but the uplink does not. I tried without Asterisk and LCR (between two phones) and still the calls are half sided. In the mean time I got these messages in the Osmo-BTS log: <0006> scheduler.c:276 PH-DATA.req: chan_nr=0x0a link_id=0x00 fn=1284768 ts=2 tr x=0 <0006> scheduler.c:1036 TCH/F has not been served !! No prim for trx=0 ts=1 at f n=1284764 to transmit. <0006> scheduler.c:1036 TCH/F has not been served !! No prim for trx=0 ts=2 at f n=1284764 to transmit. <0006> scheduler.c:379 TCH RTS.ind: chan=TCH/F chan_nr=0x09 fn=1284772 ts=1 trx= 0 <0006> scheduler.c:276 PH-DATA.req: chan_nr=0x09 link_id=0x00 fn=1284772 ts=1 tr x=0 <0006> scheduler.c:379 TCH RTS.ind: chan=TCH/F chan_nr=0x0a fn=1284772 ts=2 trx= 0 <0006> scheduler.c:276 PH-DATA.req: chan_nr=0x0a link_id=0x00 fn=1284772 ts=2 tr x=0 <0006> scheduler.c:1036 TCH/F has not been served !! No prim for trx=0 ts=1 at f n=1284768 to transmit. <0006> scheduler.c:1036 TCH/F has not been served !! No prim for trx=0 ts=2 at f n=1284768 to transmit. SMS and GPRS seems to be fine. If someone have any idea, I would love to hear it. :-) Thanks! Csaba

7 years, 12 months

5
10
0 0

[PATCH 0/4] core/conv: Fast Viterbi decoding

by Thomas Tsou

Hi all, This patch set adds to libosmocore an optimized Viterbi decodeer for architecture specific (Intel SSE) and non-specific cases. The implementation covers codes with constraint lengths of K=5 and K=7 and rates 1/4 to 3/4, which make up the majority of GSM use cases. Speedup from the current implementation is in the range of 5 to 20 depending on the processor and code type. API is unchanged. Tested on Haswell (i7-4770K) and Atom (D2550). Additional test codes from osmo-bts are included. Further tests for AWGN bit-error-rate and benchmarks can be found in the following repository. https://github.com/ttsou/osmo-conv-test Here are some examples. Bit error test for GPRS CS2 with SNR of 5 dB and 100000 bursts. $ ./conv_test -c 2 -e -r 5 -i 100000 ================================================= [+] Testing: GPRS CS2 [.] Specs: (N=2, K=5, non-recursive, flushed, not punctured) [.] Input length : ret = 290 exp = 290 -> OK [.] Output length : ret = 588 exp = 588 -> OK [.] BER tests: [..] Testing base: [..] Input BER.......................... 0.042443 [..] Output BER......................... 0.000006 [..] Output FER......................... 0.001350 (135) [..] Testing SIMD: [..] Input BER.......................... 0.042460 [..] Output BER......................... 0.000005 [..] Output FER......................... 0.001240 (124) Timed AFS benchmark with 8 threads and 100000 bursts per thread. $ ./conv_test -b -c 10 -j 8 -i 100000 ================================================= [+] Testing: GSM TCH/AFS 6.7 [.] Specs: (N=4, K=5, recursive, flushed, punctured) [.] Input length : ret = 140 exp = 140 -> OK [.] Output length : ret = 448 exp = 448 -> OK [.] Performance benchmark: [..] Encoding / Decoding 800000 bursts on 8 thread(s): [..] Testing base: [..] Elapsed time....................... 4.320001 secs [..] Rate............................... 25.925920 Mbps [..] Testing SIMD: [..] Elapsed time....................... 0.458272 secs [..] Rate............................... 244.396341 Mbps [..] Speedup............................ 9.426718 -TT

7 years, 12 months

5
13
0 0

Meas_web and meas_json

by Sipos Csaba

Hi Alexander, Just wanted to thank you for the web version of meas_vis utility, and wanted to confirm that it works very well with Nokia Site family (E1 based) and the USRP B200 too :-) If someone missed it, the web version can be found here: https://github.com/fairwaves/meas_web It would make life easier if the meas_json utility would make it to the master branch: http://cgit.osmocom.org/openbsc/log/?h=achemeris/meas_json Is there a reason it is not being merged? Regards, Csaba

8 years, 4 months

3
8
0 0

[PATCH 1/3] mncc: Implement helper functions to convert MNCC cause to a string.

by Alexander Chemeris

This is the first patch of the series. The first two patches are improvements of the log output and are independent of the 3rd patch in terms of code - proposed logging improvements just make it easier to debug issues with MNCC cause codes. The code is also a part of the achemeris/mncc_cause_fixes_master branch. -- Regards, Alexander Chemeris. CEO, Fairwaves, Inc. https://fairwaves.co

8 years, 4 months

2
3
0 0

[PATCH 3/3] mncc: Send "Dest OOO" cause in case of a link radio failure.

by Alexander Chemeris

Previously we were sending a generic "Resource unavailable" cause code making it impossible to distinguish real error cases from a regular radio link failure. This was the reason for many "unknown" call errors we've seen at Rhizomatica installations. Now they are properly classified as non-erroneous call failures. The code is also a part of the achemeris/mncc_cause_fixes_master branch. -- Regards, Alexander Chemeris. CEO, Fairwaves, Inc. https://fairwaves.co

8 years, 5 months

1
2
0 0

[PATCH 2/3] mncc: Log CC cause when sending a primitive to MNCC.

by Alexander Chemeris

The code is also a part of the achemeris/mncc_cause_fixes_master branch. -- Regards, Alexander Chemeris. CEO, Fairwaves, Inc. https://fairwaves.co

8 years, 5 months

1
1
0 0

EGPRS(EDGE) data rate is not stable?

by wangpalm

With phone attached to my configured EGPRS, sometimes it has a data rate around 200kbps (which is near optimal), while frequently it has a intolerablly slow data rate. Is it a common problem, or it's due to incorrect configrations or hardware problems? I run a gsm test system with nanobts, and the libosmocore, openbsc, openggsn codes are based on the version around end of April 2015. The configuration is made accorrding to the instruction from openbsc web. The correction in fc_queue_timer_cfg has also been made according to Jacob Erlbeck.

8 years, 5 months

3
3
0 0

[PATCH 0/6] gtp: compat and build updates

by Andreas Schultz

Hi, This is the first series of my gtp kernel updates. It contains mostly the removal of Linux version ifdefs. After this the module builds only on 4.3+. The goal here is the preparation for main line inclusion. The other small change is a update to the Makefile for simpler out-of-tree build Andreas -- Andreas Schultz (6): build: update Makefile for simpler out of tree builds gtp: remove genl_ops compat ifdef for Linux < 3.13 gtp: remove per cpu stats compat ifdef for Linux < 3.13 gtp: update for Linux > 4.1+, __ip_select_ident arguments have changed gtp: update for Linux > 4.1+, genlmsg_end return should be ignored gtp: update for Linux > 4.2+, set NO_QUEUE flag on gtp device Makefile | 17 ++++++++++++----- gtp.c | 11 +++++------ gtp.h | 4 ---- 3 files changed, 17 insertions(+), 15 deletions(-) -- 2.5.0

8 years, 5 months

2
7
0 0

OAP patch set fixes

by Neels Hofmeyr

Here is the fixed OAP patch set of those changes not merged yet. For decode_big_endian(), see the new API comment and my mail from thursday night/friday morning. Thanks for the review! ~Neels

8 years, 5 months

2
11
0 0

Improved patches: openggsn cosmetics

by Neels Hofmeyr

Here is another set of cosmetic improvements for openggsn (branch: neels/refactor). This prints the host address in human readable form and covers two more similar occurences. A new error log fix has been added (see 4/4). A nonstandard curly brace change from the previous patch has been dropped, and replaced by a blank line to increase readability. ~Neels

8 years, 5 months

2
5
0 0

[RFC] GTP-U v0/v1 kernel module

by Andreas Schultz

Hi, Some time ago, Pablo Neira Ayuso wrote a GTP-U kernel module and OpenGGSN support for it. The OpenGGSN side is easily available in the osmocom git [1]. The kernel part is somewhat harder to find, but it's at [2]. It seems that both sides are at 70% completion and only somewhat working. I have played with the kernel module, changed a couple things and would like to get some feedback on my changes. It can be found at: https://github.com/RoadRunnr/osmo-ggsn Things I've changed: * requires kernel from net-next (or 4.3) * convert to use the existing kernel iptunnel infrastructure * fix GTP-u v1 TEI usage (we need one TEI for RX and another one for TX) * use UDP sockets passed from userland for sending (instead of direct push to network interface) * fix resource release on GTP-U socket shutdown * release all resource on module removal The module currently works with a proof-of-concept GGSN/PGW implemented in Erlang (will post once the licensing is sorted). OpenGGSN will need some small changes (will post soon). Andreas [1]: http://git.osmocom.org/openggsn/ [2]: http://git.sysmocom.de/osmo-ggsn

8 years, 5 months

4
5
0 0

GTP ports and IP addresses

by Neels Hofmeyr

Hi all, a remark / question about GTP, in the context of writing code for gtphub... So far I've tried to keep the GTP IP addresses and ports config general -- you never know what weird things one might want to do some day (different IP addresses for User and Control? Nonstandard port numbers?). But now I'm at the point where I've got a Control plane message from a "control peer", and need to figure out the matching peer on the User plane. How do I do that? By IP address, of course. Thus it struck me that GTP *depends* on a setup where the User IP address is identical to the IP of the sender of the Ctrl plane packet. (view with a monospaced font) SGSN GGSN (or gtphub) 1.2.3.4 5.6.7.8 Ctrl: 2123 <-------> 2123 User: 2152 <-------> 2152 So trying to stay general with IP addresses is an exercise in futility, because it plainly doesn't work for GTP: I can't match up a peer's two message planes unless the above standard is given. Thinking of a nonstandard situation: GGSN (or gtphub) SGSN 5.6.7.8 Ctrl: 1.2.3.4:111 <-------> 2123 User: 4.3.2.1:222 X-------> 2152 The GGSN can record that there's a Ctrl peer at 1.2.3.4:111, from the incoming GTP packet's sender address. Say it receives a Create PDP Context Request, in which the nonstandard SGSN sends two TEIs it wants to use, on the Ctrl *and* User plane. Now, the GGSN cannot possibly know that 4.3.2.1 is the User plane peer for which the TEI from the Create PDP Ctx Req should be valid. One may think that the SGSN can just contact the GGSN from 4.3.2.1:222 and send the TEI from the Create PDP, so the GGSN could know that it's the same peer. But in fact a TEI is scoped *within* a comm plane with a peer, meaning that any other peer could choose the exact same TEI at any point, and the means to disambiguate is the peer's IP address. So my wishful thinking to stay general there is thwarted by design. The Ctrl and User IP addresses must be identical. Still, the SGSN's port numbers could theoretically be chosen freely. The GGSN knows the sender of the Ctrl packet(s), and as soon as a User packet comes in from the same IP address, it also knows the User plane port. As long as the IP address is the same and there are no other SGSNs using different ports on the same IP address, the GGSN could figure out both nonstandard Ctrl and User ports like this. BTW, we've also thought about securing the GTP wire towards gtphub with some kind of authentication (future). With identification sent on both planes, the limitations discussed here would be void... So I'll actually keep gtphub's config as general as it is, but will not invest time, neither in implications of choosing nonstandard setups, nor in prohibiting them (yet). The nonstandard ports config capability actually comes in handy for unit testing, where I can place some netcats and a gtphub on arbitrary port numbers on the same IP address. (Since implicit creation of 127.0.0.N interfaces is linux specific, using several local addresses without root privilege is not portable). If you spot any thinkos there, please let me know :) ~Neels

8 years, 5 months

3
3
0 0

openggsn: gtpie.h

by Neels Hofmeyr

Hi all, though promising GTP implementations are emerging from the shadows, current GTP Hub development is still using OpenGGSN's kludgy GTP API. I'd love to switch, but it's not the time for that yet. To be able to query and manipulate IEs in the OpenGGSN way, I've taken the liberty to commit below patch on openggsn.git/master, which publishes gtpie.h. ~Neels commit 6c06d25667f7c46e179bfd1121c512234c98649f Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Oct 27 14:57:18 2015 +0100 make install: also install gtpie.h diff --git a/gtp/Makefile.am b/gtp/Makefile.am index 4ad9f65..9586dfe 100644 --- a/gtp/Makefile.am +++ b/gtp/Makefile.am @@ -1,6 +1,6 @@ lib_LTLIBRARIES = libgtp.la -include_HEADERS = gtp.h pdp.h +include_HEADERS = gtp.h pdp.h gtpie.h AM_CFLAGS = -O2 -fno-builtin -Wall -DSBINDIR='"$(sbindir)"' -ggdb $(LIBOSMOCORE_CFLAGS)

8 years, 5 months

1
0
0 0

osmo-nitb initialzing_error

by Rehab Khan

Hey all, I am having some trouble in initializing osmo-nitb. When i run osmo-nitb -c /etc/osmocom.openbsc.cfg -l /etc/osmocom.openbsc.cfg P -C --debug=DRLL:DCC:DMM:DRR:DRSL:DNMi am receiving an error DB: Failed to create connection. DB: Failed to init database. Please check the option settings. Can anyone please guide me how to proceed?? I have checked all the drivers required initialze database as per suggested in http://openbsc.osmocom.org/trac/wiki/osmo-nitb Still the issue is consistent.

8 years, 6 months

1
0
0 0

[PATCH] initial commit for libosmo-gtp

by pablo＠gnumonks.org

From: Pablo Neira Ayuso <pablo(a)gnumonks.org> I started this libosmo-gtp library after spending quite some time trying to clean up libgtp and add IPv6 support to it in some clean way. The result was this library that I started from scratch in my spare time. The basic idea behind this is to avoid mixing the carrier (socket) code with the message building and parsing, and avoid overly the complicated callback scheme of libgtp. This implements minimal support for GTPv0, it also includes automated tests by generating GTPv0 messages then hand it over to gtp0_recv() which generates the reply. I remember that I also validated this code by sending GTPv0 messages over UDP to inspect them through wireshark, and they were OK. It's fairly incomplete. The only client I have for this library is an initial (fairly incomplete) osmo-gtp daemon using this library to replace opengtp. BTW, there's a src/libosmocore.c file that contains helper functions to provide a more consistent way to work with different TLV types. Probably it can be uploaded to the osmocom repository even if incomplete? Well, just wanted to get this code out there, it got stuck here and I didn't find so far more time to make more progress on it, but we'll try to update it when traveling or something. .gitignore | 43 +++ Makefile.am | 13 + configure.ac | 42 +++ git-version-gen | 151 +++++++++++ include/Makefile.am | 3 + include/gtp.h | 102 +++++++ include/libosmocore.h | 20 ++ include/osmocom/gtp/gtp.h | 49 ++++ libosmogtp.pc.in | 11 + src/Makefile.am | 15 ++ src/gtp.c | 669 ++++++++++++++++++++++++++++++++++++++++++++++ src/libosmocore.c | 70 +++++ tests/Makefile.am | 52 ++++ tests/gtp/gtp_test.ok | 0 tests/gtp_test.c | 121 +++++++++ tests/gtp_test.ok | 4 + tests/testsuite.at | 18 ++ 17 files changed, 1383 insertions(+) create mode 100644 .gitignore create mode 100644 Makefile.am create mode 100644 configure.ac create mode 100755 git-version-gen create mode 100644 include/Makefile.am create mode 100644 include/gtp.h create mode 100644 include/libosmocore.h create mode 100644 include/osmocom/gtp/gtp.h create mode 100644 libosmogtp.pc.in create mode 100644 src/Makefile.am create mode 100644 src/gtp.c create mode 100644 src/libosmocore.c create mode 100644 tests/Makefile.am create mode 100644 tests/gtp/gtp_test.ok create mode 100644 tests/gtp_test.c create mode 100644 tests/gtp_test.ok create mode 100644 tests/testsuite.at diff --git a/.gitignore b/.gitignore new file mode 100644 index 0000000..ee984ce --- /dev/null +++ b/.gitignore @@ -0,0 +1,43 @@ +Makefile +Makefile.in +.deps +.libs +*.o +*.lo +*.la +*.pc +aclocal.m4 +m4/*.m4 +autom4te.cache +config.h* +config.sub +config.log +config.status +config.guess +configure +compile +depcomp +missing +ltmain.sh +install-sh +stamp-h1 +libtool +#libosmo-abis-* +tests/*_test + +.tarball-version +.version +.dirstamp + +# tests +tests/atconfig +tests/package.m4 +tests/testsuite +tests/testsuite.log +tests/testsuite.dir/ +tests/gtp_test + + + +# vi/vim files +*.sw? diff --git a/Makefile.am b/Makefile.am new file mode 100644 index 0000000..5ab1484 --- /dev/null +++ b/Makefile.am @@ -0,0 +1,13 @@ +ACLOCAL_AMFLAGS = -I m4 + +AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include +SUBDIRS = include src tests + +pkgconfigdir = $(libdir)/pkgconfig +pkgconfig_DATA = libosmogtp.pc + +BUILT_SOURCES = $(top_srcdir)/.version +$(top_srcdir)/.version: + echo $(VERSION) > $@-t && mv $@-t $@ +dist-hook: + echo $(VERSION) > $(distdir)/.tarball-version diff --git a/configure.ac b/configure.ac new file mode 100644 index 0000000..c22fab4 --- /dev/null +++ b/configure.ac @@ -0,0 +1,42 @@ +AC_INIT([libosmogtp], + m4_esyscmd([./git-version-gen .tarball-version]), + [gprs(a)lists.osmocom.org]) + +AM_INIT_AUTOMAKE([foreign dist-bzip2 no-dist-gzip 1.6]) +AC_CONFIG_TESTDIR(tests) + +dnl kernel style compile messages +m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])]) + +dnl checks for programs +AC_PROG_MAKE_SET +AC_PROG_CC +AC_PROG_INSTALL +LT_INIT([pic-only]) + +AC_CONFIG_MACRO_DIR([m4]) + +# The following test is taken from WebKit's webkit.m4 +saved_CFLAGS="$CFLAGS" +CFLAGS="$CFLAGS -fvisibility=hidden " +AC_MSG_CHECKING([if ${CC} supports -fvisibility=hidden]) +AC_COMPILE_IFELSE([AC_LANG_SOURCE([char foo;])], + [ AC_MSG_RESULT([yes]) + SYMBOL_VISIBILITY="-fvisibility=hidden"], + AC_MSG_RESULT([no])) +CFLAGS="$saved_CFLAGS" +AC_SUBST(SYMBOL_VISIBILITY) + +dnl Generate the output +AM_CONFIG_HEADER(config.h) + +PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 0.3.0) +PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 0.3.0) +PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 0.3.10) + +AC_OUTPUT( + libosmogtp.pc + include/Makefile + src/Makefile + tests/Makefile + Makefile) diff --git a/git-version-gen b/git-version-gen new file mode 100755 index 0000000..42cf3d2 --- /dev/null +++ b/git-version-gen @@ -0,0 +1,151 @@ +#!/bin/sh +# Print a version string. +scriptversion=2010-01-28.01 + +# Copyright (C) 2007-2010 Free Software Foundation, Inc. +# +# This program is free software: you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + +# This script is derived from GIT-VERSION-GEN from GIT: http://git.or.cz/. +# It may be run two ways: +# - from a git repository in which the "git describe" command below +# produces useful output (thus requiring at least one signed tag) +# - from a non-git-repo directory containing a .tarball-version file, which +# presumes this script is invoked like "./git-version-gen .tarball-version". + +# In order to use intra-version strings in your project, you will need two +# separate generated version string files: +# +# .tarball-version - present only in a distribution tarball, and not in +# a checked-out repository. Created with contents that were learned at +# the last time autoconf was run, and used by git-version-gen. Must not +# be present in either $(srcdir) or $(builddir) for git-version-gen to +# give accurate answers during normal development with a checked out tree, +# but must be present in a tarball when there is no version control system. +# Therefore, it cannot be used in any dependencies. GNUmakefile has +# hooks to force a reconfigure at distribution time to get the value +# correct, without penalizing normal development with extra reconfigures. +# +# .version - present in a checked-out repository and in a distribution +# tarball. Usable in dependencies, particularly for files that don't +# want to depend on config.h but do want to track version changes. +# Delete this file prior to any autoconf run where you want to rebuild +# files to pick up a version string change; and leave it stale to +# minimize rebuild time after unrelated changes to configure sources. +# +# It is probably wise to add these two files to .gitignore, so that you +# don't accidentally commit either generated file. +# +# Use the following line in your configure.ac, so that $(VERSION) will +# automatically be up-to-date each time configure is run (and note that +# since configure.ac no longer includes a version string, Makefile rules +# should not depend on configure.ac for version updates). +# +# AC_INIT([GNU project], +# m4_esyscmd([build-aux/git-version-gen .tarball-version]), +# [bug-project@example]) +# +# Then use the following lines in your Makefile.am, so that .version +# will be present for dependencies, and so that .tarball-version will +# exist in distribution tarballs. +# +# BUILT_SOURCES = $(top_srcdir)/.version +# $(top_srcdir)/.version: +# echo $(VERSION) > $@-t && mv $@-t $@ +# dist-hook: +# echo $(VERSION) > $(distdir)/.tarball-version + +case $# in + 1) ;; + *) echo 1>&2 "Usage: $0 \$srcdir/.tarball-version"; exit 1;; +esac + +tarball_version_file=$1 +nl=' +' + +# First see if there is a tarball-only version file. +# then try "git describe", then default. +if test -f $tarball_version_file +then + v=`cat $tarball_version_file` || exit 1 + case $v in + *$nl*) v= ;; # reject multi-line output + [0-9]*) ;; + *) v= ;; + esac + test -z "$v" \ + && echo "$0: WARNING: $tarball_version_file seems to be damaged" 1>&2 +fi + +if test -n "$v" +then + : # use $v +elif + v=`git describe --abbrev=4 --match='v*' HEAD 2>/dev/null \ + || git describe --abbrev=4 HEAD 2>/dev/null` \ + && case $v in + [0-9]*) ;; + v[0-9]*) ;; + *) (exit 1) ;; + esac +then + # Is this a new git that lists number of commits since the last + # tag or the previous older version that did not? + # Newer: v6.10-77-g0f8faeb + # Older: v6.10-g0f8faeb + case $v in + *-*-*) : git describe is okay three part flavor ;; + *-*) + : git describe is older two part flavor + # Recreate the number of commits and rewrite such that the + # result is the same as if we were using the newer version + # of git describe. + vtag=`echo "$v" | sed 's/-.*//'` + numcommits=`git rev-list "$vtag"..HEAD | wc -l` + v=`echo "$v" | sed "s/$.*$-$.*$/\1-$numcommits-\2/"`; + ;; + esac + + # Change the first '-' to a '.', so version-comparing tools work properly. + # Remove the "g" in git describe's output string, to save a byte. + v=`echo "$v" | sed 's/-/./;s/$.*$-g/\1-/'`; +else + v=UNKNOWN +fi + +v=`echo "$v" |sed 's/^v//'` + +# Don't declare a version "dirty" merely because a time stamp has changed. +git status > /dev/null 2>&1 + +dirty=`sh -c 'git diff-index --name-only HEAD' 2>/dev/null` || dirty= +case "$dirty" in + '') ;; + *) # Append the suffix only if there isn't one already. + case $v in + *-dirty) ;; + *) v="$v-dirty" ;; + esac ;; +esac + +# Omit the trailing newline, so that m4_esyscmd can use the result directly. +echo "$v" | tr -d '\012' + +# Local variables: +# eval: (add-hook 'write-file-hooks 'time-stamp) +# time-stamp-start: "scriptversion=" +# time-stamp-format: "%:y-%02m-%02d.%02H" +# time-stamp-end: "$" +# End: diff --git a/include/Makefile.am b/include/Makefile.am new file mode 100644 index 0000000..d04cac0 --- /dev/null +++ b/include/Makefile.am @@ -0,0 +1,3 @@ +noinst_HEADERS = gtp.h libosmocore.h + +nobase_include_HEADERS = osmocom/gtp/gtp.h diff --git a/include/gtp.h b/include/gtp.h new file mode 100644 index 0000000..3a47de6 --- /dev/null +++ b/include/gtp.h @@ -0,0 +1,102 @@ +#ifndef _GTP_PROTOCOL_H_ +#define _GTP_PROTOCOL_H_ + +enum gtp_type { + GTP_UNUSED = 0, /* GSM 09.60 says for future use */ + GTP_ECHO_REQ = 1, /* 7.4.1 GSM 09.60 */ + GTP_ECHO_RESP = 2, /* 7.4.2 GSM 09.60 */ + GTP_VERSION_NOTSUPP = 3, /* 7.4.3 GSM 09.60 */ + GTP_PDP_CREATE_REQ = 16, /* 7.5.1 GSM 09.60 */ + GTP_PDP_CREATE_RESP = 17, /* 7.5.2 GSM 09.60 */ + GTP_PDP_UPDATE_REQ = 18, /* 7.5.3 GSM 09.60 */ + GTP_PDP_UPDATE_RESP = 19, /* 7.5.4 GSM 09.60 */ + GTP_PDP_DELETE_REQ = 20, /* 7.5.5 GSM 09.60 */ + GTP_PDP_DELETE_RESP = 21, /* 7.5.6 GSM 09.60 */ + GTP_TYPE_MAX, +}; + +struct gtp0_header { +#if BYTE_ORDER == BIG_ENDIAN + uint8_t version:3, + pt:1, + spare:3, + snn:1; +#elif BYTE_ORDER == LITTLE_ENDIAN + uint8_t snn:1, + spare:3, + pt:1, + version:3; +#else +#warn "BYTE_ORDER is not defined, please fix your headers" +#endif + uint8_t type; + uint16_t length; + uint16_t seq; + uint16_t flow; + uint8_t number; + uint8_t spare1; + uint8_t spare2; + uint8_t spare3; + uint64_t tid; +} __attribute__((packed)); + +/* + * Information elements + */ +/* TV */ +#define GTPV0_IE_CAUSE 1 /* 8 bits */ +#define GTPV0_IE_QOS_PROFILE 6 /* 24 bits */ +#define GTPV0_IE_REORDERING_REQ 8 /* 1 bit */ +#define GTPV0_IE_RECOVERY 14 /* 8 bit */ +#define GTPV0_IE_SELECT_MODE 15 /* 16 bits */ +#define GTPV0_IE_FLOW_LABEL_DATA 16 /* 16 bits */ +#define GTPV0_IE_FLOW_LABEL_SIGNAL 17 /* 16 bits */ +#define GTPV0_IE_CHARGING_ID 127 /* 32 bits */ +/* TLV >= 128 */ +#define GTPV0_IE_ENDUSER_ADDR 128 +#define GTPV0_IE_AP_NAME 131 +#define GTPV0_IE_PROTO_CONF_OPTS 132 +#define GTPV0_IE_GSN_ADDR 133 +#define GTPV0_IE_MSISDN 134 +#define GTPV0_IE_CHARGING_GW_ADDR 251 + +/* + * Other + */ +#define GTPV0_CAUSE_REQ_ACCEPTED 128 /* GSM 09.60 7.9.1 */ + +#include <netinet/in.h> + +struct enduser_addr_ie_payload_ipv4 { +#if BYTE_ORDER == BIG_ENDIAN + uint8_t spare:4, + pdp_org_type:4; +#elif BYTE_ORDER == LITTLE_ENDIAN + uint8_t pdp_org_type:4, + spare:4; +#else +#warn "BYTE_ORDER is not defined, please fix your headers" +#endif + uint8_t pdp_type_number; + struct in_addr addr; +} __attribute__((packed)); + +struct enduser_addr_ie_payload_ipv6 { +#if BYTE_ORDER == BIG_ENDIAN + uint8_t spare:4, + pdp_org_type:4; +#elif BYTE_ORDER == LITTLE_ENDIAN + uint8_t pdp_org_type:4, + spare:4; +#else +#warn "BYTE_ORDER is not defined, please fix your headers" +#endif + uint8_t pdp_type_number; + struct in6_addr addr; +} __attribute__((packed)); + +#define PDP_ORG_IETF 1 +#define PDP_TYPE_IPV4 0x21 +#define PDP_TYPE_IPV6 0x57 + +#endif diff --git a/include/libosmocore.h b/include/libosmocore.h new file mode 100644 index 0000000..dab9265 --- /dev/null +++ b/include/libosmocore.h @@ -0,0 +1,20 @@ +#ifndef _GTP_LIBOSMOCORE_H_ +#define _GTP_LIBOSMOCORE_H_ + +#include <osmocom/gsm/tlv.h> + +void *msgb_tv_put_be8(struct msgb *msg, int type, uint8_t value); +void *msgb_tv_put_be16(struct msgb *msg, int type, uint16_t value); +void *msgb_tv_put_be24(struct msgb *msg, int type, uint32_t value); +void *msgb_tv_put_be32(struct msgb *msg, int type, uint32_t value); +void *msgb_tlv_put_be32(struct msgb *msg, int type, uint32_t data); +void *msgb_tlv_put_data(struct msgb *msg, int type, int len, void *data); + +uint8_t tv_get_be8(struct tlv_parsed *tp, int type); +uint16_t tv_get_be16(struct tlv_parsed *tp, int type); +uint32_t tv_get_be24(struct tlv_parsed *tp, int type); +uint32_t tv_get_be32(struct tlv_parsed *tp, int type); +const char *tv_get_strdup(struct tlv_parsed *tp, int type); +const char *tlv_get_strdup(struct tlv_parsed *tp, int type); + +#endif diff --git a/include/osmocom/gtp/gtp.h b/include/osmocom/gtp/gtp.h new file mode 100644 index 0000000..cb1b362 --- /dev/null +++ b/include/osmocom/gtp/gtp.h @@ -0,0 +1,49 @@ +#ifndef _OSMO_GTP_H_ +#define _OSMO_GTP_H_ + +enum osmo_gtp_event { + OSMO_GTP_PDP_NEW, + OSMO_GTP_PDP_UPD, + OSMO_GTP_PDP_DEL, + /* XXX add more events here */ + OSMO_GTP_EVENT_MAX, +}; + +enum gtp_err_type { + GTP_ENOSUPP = 0, + GTP_ETOOSHORT, + GTP_ETRUNCATED, + GTP_EMALFORMED, + GTP_EMAX +}; + +struct osmo_gtp_err { + const char *file; + int line; + enum gtp_err_type type; +}; + +struct osmo_gsn; + +struct osmo_gsn *osmo_gsn_alloc(void); + +struct msgb *gtp0_recv(struct osmo_gsn *gsn, struct msgb *msg, + struct osmo_gtp_err *err); + +enum { + OSMO_GTP_DEFAULT = 0, + OSMO_GTP_HEX, +}; + +void osmo_gtp0_fprintf(FILE *fd, struct msgb *msg, uint32_t type); + +struct gtp0_header *gtp0_header_put(struct msgb *msg, uint32_t type, + uint16_t seq, uint16_t flow, uint64_t tid); +void gtp0_header_end(struct gtp0_header *gtp0h, struct msgb *msg); + +enum osmo_gsn_proto { + OSMO_GSN_IPV4 = 0, + OSMO_GSN_IPV6, +}; + +#endif diff --git a/libosmogtp.pc.in b/libosmogtp.pc.in new file mode 100644 index 0000000..f8998ea --- /dev/null +++ b/libosmogtp.pc.in @@ -0,0 +1,11 @@ +prefix=@prefix@ +exec_prefix=@exec_prefix@ +libdir=@libdir@ +includedir=@includedir@ + +Name: GTP Core Library +Description: C Utility Library +Version: @VERSION@ +Libs: -L${libdir} -losmogtp +Cflags: -I${includedir}/ + diff --git a/src/Makefile.am b/src/Makefile.am new file mode 100644 index 0000000..cad0c75 --- /dev/null +++ b/src/Makefile.am @@ -0,0 +1,15 @@ +# This is _NOT_ the library release version, it's an API version. +# Please read Chapter 6 "Library interface versions" of the libtool documentation before making any modification +LIBVERSION=0:0:0 + +AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -I$(top_builddir) +AM_CFLAGS= -Wall $(LIBOSMOCORE_CFLAGS) $(LIBOSMOGSM_CFLAGS) $(LIBOSMOVTY_CFLAGS) $(COVERAGE_CFLAGS) +AM_LDFLAGS = $(COVERAGE_LDFLAGS) +COMMONLIBS = $(LIBOSMOCORE_LIBS) $(LIBOSMOGSM_LIBS) $(LIBOSMOVTY_LIBS) + +lib_LTLIBRARIES = libosmogtp.la + +libosmogtp_la_LDFLAGS = $(AM_LDFLAGS) -version-info $(LIBVERSION) +libosmogtp_la_LIBADD = $(COMMONLIBS) +libosmogtp_la_SOURCES = gtp.c \ + libosmocore.c diff --git a/src/gtp.c b/src/gtp.c new file mode 100644 index 0000000..672af5a --- /dev/null +++ b/src/gtp.c @@ -0,0 +1,669 @@ +#include <stdio.h> +#include <stdlib.h> +#include <stdint.h> +#include <stdbool.h> +#include <arpa/inet.h> + +#include <gtp.h> +#include <osmocom/core/logging.h> +#include <osmocom/core/msgb.h> +#include <osmocom/core/write_queue.h> +#include <osmocom/gtp/gtp.h> +#include <osmocom/gsm/tlv.h> + +#include "libosmocore.h" + +/* Generic context pointer to data in the event context */ +struct osmo_gtp_ctx { + struct osmo_gtp_pdp *pdp; + /* XXX Add more event context here */ +}; + +/* Events are called from the GTP stack to notify upper layer application */ +struct gtp_event_cb { + int (*cb)(enum osmo_gtp_event event, struct osmo_gtp_ctx *ctx); +}; + +struct osmo_gsn { + struct { + enum osmo_gsn_proto proto; + bool reordering_required; + union { + struct in_addr ip_addr; + struct in6_addr ip6_addr; + } ggsn; + } cfg; + + struct gtp_event_cb event[OSMO_GTP_EVENT_MAX]; + + uint8_t restart_counter; +}; + +struct osmo_gtp_pdp { + uint32_t qos_profile:24; + uint16_t flow_label_data; + uint16_t flow_label_signal; + uint8_t sel_mode; + const char *ap_name; + union { + struct in_addr ip_addr; + struct in6_addr ip6_addr; + } enduser; + union { + struct in_addr ip_addr; + struct in6_addr ip6_addr; + } sgsn; + const char *msisdn; +}; + +#define OSMO_GTP_MTU 1500 + +#define GTPV0 0 /* GSM 09.60 */ +#define GTP_PRIME 0 /* GSM 09.60 */ +#define GTP_NON_PRIME 1 /* GSM 12.15 */ +#define GTP_SNDCP_NPDU_UNSET 0 + +struct gtp0_header *gtp0_header_put(struct msgb *msg, uint32_t type, + uint16_t seq, uint16_t flow, uint64_t tid) +{ + struct gtp0_header *gtp0h = (struct gtp0_header *)msg->data; + + gtp0h->version = GTPV0; + gtp0h->pt = GTP_NON_PRIME; + gtp0h->spare = 0x7; + gtp0h->snn = GTP_SNDCP_NPDU_UNSET; + gtp0h->type = type; + gtp0h->seq = htons(seq); + gtp0h->tid = htobe64(tid); + gtp0h->spare1 = 0xff; + gtp0h->spare2 = 0xff; + gtp0h->spare3 = 0xff; + gtp0h->number = 0xff; + gtp0h->flow = flow; + msgb_put(msg, sizeof(*gtp0h)); + + return gtp0h; +} + +void gtp0_header_end(struct gtp0_header *gtp0h, struct msgb *msg) +{ + gtp0h->length = htons(msg->len - sizeof(*gtp0h)); +} + +uint64_t gtp0h_tid(const struct msgb *msg) +{ + const struct gtp0_header *gtp0h = + (const struct gtp0_header *)msg->data; + + return be64toh(gtp0h->tid); +} + +uint16_t gtp0h_seq(const struct msgb *msg) +{ + const struct gtp0_header *gtp0h = + (const struct gtp0_header *)msg->data; + + return ntohs(gtp0h->seq); +} + +struct osmo_gsn *osmo_gsn_alloc(void) +{ + return calloc(1, sizeof(struct osmo_gsn)); +} + +static struct msgb *gtp_unsupp(struct msgb *msg) +{ + struct msgb *reply; + struct gtp0_header *gtp0h; + + reply = msgb_alloc(OSMO_GTP_MTU, "gtp"); + if (reply == NULL) + return NULL; + + gtp0h = gtp0_header_put(reply, GTP_VERSION_NOTSUPP, gtp0h_seq(msg), 0, + gtp0h_tid(msg)); + gtp0_header_end(gtp0h, reply); + + return reply; +} + +struct osmo_gtp_handler { + bool request; + struct msgb *(*handler)(struct osmo_gsn *gsn, struct msgb *msg, + struct osmo_gtp_err *err); +}; + +static struct msgb *gtp_echo_req_handler(struct osmo_gsn *gsn, + struct msgb *msg, + struct osmo_gtp_err *err) +{ + struct msgb *reply; + struct gtp0_header *gtp0h; + + reply = msgb_alloc(OSMO_GTP_MTU, "gtp"); + if (reply == NULL) + return NULL; + + gtp0h = gtp0_header_put(reply, GTP_ECHO_RESP, gtp0h_seq(msg), 0, + gtp0h_tid(msg)); + msgb_tv_put(reply, GTPV0_IE_RECOVERY, gsn->restart_counter); + + /* TODO: Private extension. 7.9.26 (Optional) */ + /* TODO: IE T=255 Length ExtensionID=(8 bits) ExtValue=(variable) */ + + gtp0_header_end(gtp0h, reply); + + return reply; +} + +static int ip_alloc(struct osmo_gtp_pdp *pdp) +{ + pdp->enduser.ip_addr.s_addr= 0x01020304; + return 0; +} + +static int ip6_alloc(struct osmo_gtp_pdp *pdp) +{ + return 0; +} + +static void build_enduser_addr(struct msgb *reply, struct osmo_gsn *gsn, + struct osmo_gtp_pdp *pdp) +{ + switch (gsn->cfg.proto) { + case OSMO_GSN_IPV4: { + struct enduser_addr_ie_payload_ipv4 ie_ipv4; + + ip_alloc(pdp); + + ie_ipv4.spare = 0xf; + ie_ipv4.pdp_org_type = PDP_ORG_IETF; + ie_ipv4.pdp_type_number = PDP_TYPE_IPV4; + ie_ipv4.addr = pdp->enduser.ip_addr; + + msgb_tlv_put_data(reply, GTPV0_IE_ENDUSER_ADDR, + sizeof(ie_ipv4), &ie_ipv4); + break; + } + case OSMO_GSN_IPV6: { + struct enduser_addr_ie_payload_ipv6 ie_ipv6; + + ip6_alloc(pdp); + + ie_ipv6.spare = 0xf; + ie_ipv6.pdp_org_type = PDP_ORG_IETF; + ie_ipv6.pdp_type_number = PDP_TYPE_IPV6; + ie_ipv6.addr = pdp->enduser.ip6_addr; + + msgb_tlv_put_data(reply, GTPV0_IE_ENDUSER_ADDR, + sizeof(ie_ipv6), &ie_ipv6); + } + break; + } +} + +static void build_gsn_addr(struct msgb *reply, struct osmo_gsn *gsn, + struct osmo_gtp_pdp *pdp) +{ + switch (gsn->cfg.proto) { + case OSMO_GSN_IPV4: + msgb_tlv_put_data(reply, GTPV0_IE_GSN_ADDR, + sizeof(struct in_addr), + &gsn->cfg.ggsn.ip_addr); + break; + case OSMO_GSN_IPV6: + msgb_tlv_put_data(reply, GTPV0_IE_GSN_ADDR, + sizeof(struct in6_addr), + &gsn->cfg.ggsn.ip6_addr); + break; + } +} + +static struct msgb *gtp_pdp_ctx_create_resp(struct osmo_gsn *gsn, + const struct msgb *msg, + struct osmo_gtp_pdp *pdp) +{ + struct msgb *reply; + struct gtp0_header *gtp0h; + + reply = msgb_alloc(OSMO_GTP_MTU, "gtp"); + if (reply == NULL) + return NULL; + + gtp0h = gtp0_header_put(reply, GTP_PDP_CREATE_RESP, gtp0h_seq(msg), 0, + gtp0h_tid(msg)); + + /* TODO: implement reject PDP request + reason */ + msgb_tv_put_be8(reply, GTPV0_IE_CAUSE, GTPV0_CAUSE_REQ_ACCEPTED); + + if (GTPV0_CAUSE_REQ_ACCEPTED == GTPV0_CAUSE_REQ_ACCEPTED) { + /* Quality of service profile. 7.9.6 (Conditional) */ + + /* broken u24 */ + msgb_tv_put_be24(reply, GTPV0_IE_QOS_PROFILE, pdp->qos_profile); + + /* Reordering required. 7.9.7 (Conditional) */ + msgb_tv_put_be8(reply, GTPV0_IE_REORDERING_REQ, + gsn->cfg.reordering_required | 0xfe); + + /* Recovery. 7.9.12 (Optional) */ + msgb_tv_put_be8(reply, GTPV0_IE_RECOVERY, gsn->restart_counter); + + int val = 0xa; + + /* Flow label signalling. 7.9.15 (Conditional) */ + msgb_tv_put_be16(reply, GTPV0_IE_FLOW_LABEL_DATA, val); + /* Flow label data I. 7.9.14 (Conditional) */ + msgb_tv_put_be16(reply, GTPV0_IE_FLOW_LABEL_SIGNAL, val); + + /* Charging ID. 7.9.17 (Conditional) */ + msgb_tv_put_be32(reply, GTPV0_IE_CHARGING_ID, val); + + /* End user address. 7.9.18 (Conditional) */ + build_enduser_addr(reply, gsn, pdp); + + /* TODO: Protocol configuration options. 7.9.22 (Optional) */ + + /* TODO: GGSN Address for signalling. 7.9.23 (Conditional) */ + /* TODO: GGSN Address for user traffic. 7.9.23 (Conditional) */ + build_gsn_addr(reply, gsn, pdp); + + /* TODO: Charging Gateway Address. 7.9.25 (Optional) */ + msgb_tlv_put_data(reply, GTPV0_IE_CHARGING_GW_ADDR, sizeof(val), &val); + + /* TODO: Private extension. 7.9.26 (Optional) */ + } + + gtp0_header_end(gtp0h, reply); + + return reply; +} + +static const struct tlv_definition gtp_pdp_create_req_attr_tlvdef = { + .def = { + [GTPV0_IE_QOS_PROFILE] = { TLV_TYPE_FIXED, 3 }, + [GTPV0_IE_RECOVERY] = { TLV_TYPE_FIXED, 1 }, + [GTPV0_IE_SELECT_MODE] = { TLV_TYPE_FIXED, 1 }, + [GTPV0_IE_FLOW_LABEL_DATA] = { TLV_TYPE_FIXED, 2 }, + [GTPV0_IE_FLOW_LABEL_SIGNAL] = { TLV_TYPE_FIXED, 2 }, + [GTPV0_IE_ENDUSER_ADDR] = { TLV_TYPE_TL16V }, + [GTPV0_IE_AP_NAME] = { TLV_TYPE_TL16V }, + [GTPV0_IE_PROTO_CONF_OPTS] = { TLV_TYPE_TL16V }, + [GTPV0_IE_GSN_ADDR] = { TLV_TYPE_TL16V }, + [GTPV0_IE_MSISDN] = { TLV_TYPE_TL16V }, + }, +}; + +struct enduser_addr_ie_payload { +#if BYTE_ORDER == BIG_ENDIAN + uint8_t spare:4, + pdp_org_type:4; +#elif BYTE_ORDER == LITTLE_ENDIAN + uint8_t pdp_org_type:4, + spare:4; +#else +#warn "BYTE_ORDER is not defined, please fix your headers" +#endif + uint8_t pdp_type_number; + char addr[0]; +} __attribute__((packed)); + +static int gtp0_parse_enduser_addr(struct tlv_parsed *tp, + struct osmo_gtp_pdp *pdp) +{ + struct enduser_addr_ie_payload *ie = + (struct enduser_addr_ie_payload *) + TLVP_VAL(tp, GTPV0_IE_ENDUSER_ADDR); + int attrlen = TLVP_LEN(tp, GTPV0_IE_ENDUSER_ADDR); + int hdrlen = sizeof(struct enduser_addr_ie_payload); + + if (ie->pdp_org_type != PDP_ORG_IETF) { + LOGP(DLINP, LOGL_ERROR, "Unsupported PDP org type %d", + ie->pdp_org_type); + return -1; + } + + switch (ie->pdp_type_number) { + case PDP_TYPE_IPV4: + if (attrlen != hdrlen + sizeof(struct in_addr)) { + LOGP(DLINP, LOGL_ERROR, + "bad enduser address length %d for IPv4", + attrlen); + return -1; + } + memcpy(&pdp->enduser.ip_addr, ie->addr, sizeof(struct in_addr)); + break; + case PDP_TYPE_IPV6: + if (attrlen != hdrlen + sizeof(struct in6_addr)) { + LOGP(DLINP, LOGL_ERROR, + "bad enduser address length %d for IPv6", + attrlen); + return -1; + } + memcpy(&pdp->enduser.ip6_addr, ie->addr, sizeof(struct in6_addr)); + break; + default: + LOGP(DLINP, LOGL_ERROR, "Unsupported PDP type number %d\n", + ie->pdp_type_number); + break; + } + + return 0; +} + +static int gtp0_parse_gsn_addr(struct tlv_parsed *tp, + struct osmo_gtp_pdp *pdp) +{ + switch (TLVP_LEN(tp, GTPV0_IE_GSN_ADDR)) { + case sizeof(struct in_addr): + memcpy(&pdp->sgsn, TLVP_VAL(tp, GTPV0_IE_GSN_ADDR), + sizeof(struct in_addr)); + break; + case sizeof(struct in6_addr): + memcpy(&pdp->sgsn, TLVP_VAL(tp, GTPV0_IE_GSN_ADDR), + sizeof(struct in6_addr)); + break; + default: + return -1; + } + return 0; +} + +static struct msgb *gtp_pdp_create_req_handler(struct osmo_gsn *gsn, + struct msgb *msg, + struct osmo_gtp_err *err) +{ + struct msgb *reply; + struct tlv_parsed tp; + struct osmo_gtp_pdp _pdp, *pdp = &_pdp; + int ret; + + memset(pdp, 0, sizeof(_pdp)); + + ret = tlv_parse(&tp, &gtp_pdp_create_req_attr_tlvdef, + msg->data + sizeof(struct gtp0_header), + msg->len - sizeof(struct gtp0_header), 0, 0); + if (ret < 0) { + LOGP(DLINP, LOGL_ERROR, "cannot parse TLVs: %u\n", ret); + return NULL; + } + + /* Mandatory attributes: + * + * 1) 7.9.6. QoS profile. 32 bits. GSM 04.08 + * 2) 7.9.13. Selection mode. 8 bits & 0x3. + * 3) 7.9.14. Flow label data. 16 bits + * 4) 7.9.15. Flow label signalling. 16 bits + * 5) 7.9.18. End User Address (see struct enduser_addr_ie_payload). + * 6) 7.9.21. Access Point (AP) Name (variable length) + * 7) 7.9.23. GSN address (variable length) + * 8) 7.9.24. MSISDN (variable length) + */ + if (!TLVP_PRESENT(&tp, GTPV0_IE_QOS_PROFILE) || + !TLVP_PRESENT(&tp, GTPV0_IE_SELECT_MODE) || + !TLVP_PRESENT(&tp, GTPV0_IE_FLOW_LABEL_DATA) || + !TLVP_PRESENT(&tp, GTPV0_IE_FLOW_LABEL_SIGNAL) || + !TLVP_PRESENT(&tp, GTPV0_IE_ENDUSER_ADDR) || + !TLVP_PRESENT(&tp, GTPV0_IE_AP_NAME) || + !TLVP_PRESENT(&tp, GTPV0_IE_GSN_ADDR) || + !TLVP_PRESENT(&tp, GTPV0_IE_MSISDN)) { + LOGP(DLINP, LOGL_ERROR, "missing mandatory TLV\n"); + return NULL; + } + + pdp->qos_profile = tv_get_be24(&tp, GTPV0_IE_QOS_PROFILE); + + /* Validate spare 6 bits to one (7.9.13)? */ + pdp->sel_mode = tv_get_be8(&tp, GTPV0_IE_SELECT_MODE) & 0x03; + pdp->flow_label_data = tv_get_be16(&tp, GTPV0_IE_FLOW_LABEL_DATA); + pdp->flow_label_signal = tv_get_be16(&tp, GTPV0_IE_FLOW_LABEL_SIGNAL); + pdp->ap_name = tv_get_strdup(&tp, GTPV0_IE_AP_NAME); + + if (gtp0_parse_enduser_addr(&tp, pdp) < 0 || + gtp0_parse_gsn_addr(&tp, pdp) < 0) + return NULL; + + pdp->msisdn = tlv_get_strdup(&tp, GTPV0_IE_MSISDN); + + /* TODO: Optional attributes: + * 1) 7.9.21. Protocol configuration options. GSM 04.08. + */ + if (TLVP_PRESENT(&tp, GTPV0_IE_PROTO_CONF_OPTS)) { + } + + reply = gtp_pdp_ctx_create_resp(gsn, msg, pdp); + if (reply == NULL) + return NULL; + + return reply; +} + +static const struct tlv_definition gtp_pdp_update_req_attr_tlvdef = { + .def = { + [GTPV0_IE_QOS_PROFILE] = { TLV_TYPE_FIXED, 3 }, + [GTPV0_IE_RECOVERY] = { TLV_TYPE_FIXED, 1 }, + [GTPV0_IE_FLOW_LABEL_DATA] = { TLV_TYPE_FIXED, 2 }, + [GTPV0_IE_FLOW_LABEL_SIGNAL] = { TLV_TYPE_FIXED, 2 }, + [GTPV0_IE_GSN_ADDR] = { TLV_TYPE_TL16V }, + }, +}; + +static struct msgb *gtp_pdp_ctx_update_resp(struct osmo_gsn *gsn, + const struct msgb *msg, + struct osmo_gtp_pdp *pdp) +{ + struct msgb *reply; + struct gtp0_header *gtp0h; + + reply = msgb_alloc(OSMO_GTP_MTU, "gtp"); + if (reply == NULL) + return NULL; + + gtp0h = gtp0_header_put(reply, GTP_PDP_UPDATE_RESP, gtp0h_seq(msg), 0, + gtp0h_tid(msg)); + + /* TODO: implement reject PDP request + reason */ + msgb_tv_put_be8(reply, GTPV0_IE_CAUSE, GTPV0_CAUSE_REQ_ACCEPTED); + + if (GTPV0_CAUSE_REQ_ACCEPTED == GTPV0_CAUSE_REQ_ACCEPTED) { + /* Quality of service profile. 7.9.6 (Conditional) */ + + /* broken u24 */ + msgb_tv_put_be24(reply, GTPV0_IE_QOS_PROFILE, pdp->qos_profile); + + /* Recovery. 7.9.12 (Optional) */ + msgb_tv_put_be8(reply, GTPV0_IE_RECOVERY, gsn->restart_counter); + + int val = 0xa; + + /* Flow label signalling. 7.9.15 (Conditional) */ + msgb_tv_put_be16(reply, GTPV0_IE_FLOW_LABEL_DATA, val); + /* Flow label data I. 7.9.14 (Conditional) */ + msgb_tv_put_be16(reply, GTPV0_IE_FLOW_LABEL_SIGNAL, val); + + /* Charging ID. 7.9.17 (Conditional) */ + msgb_tv_put_be32(reply, GTPV0_IE_CHARGING_ID, val); + + /* TODO: Protocol configuration options. 7.9.22 (Optional) */ + /* TODO: GGSN Address for signalling. 7.9.23 (Conditional) */ + /* TODO: GGSN Address for user traffic. 7.9.23 (Conditional) */ + build_gsn_addr(reply, gsn, pdp); + + /* TODO: Charging Gateway Address. 7.9.25 (Optional) */ + msgb_tlv_put_data(reply, GTPV0_IE_CHARGING_GW_ADDR, sizeof(val), &val); + + /* TODO: Private extension. 7.9.26 (Optional) */ + } + + gtp0_header_end(gtp0h, reply); + + return reply; +} + +static struct msgb *gtp_pdp_update_req_handler(struct osmo_gsn *gsn, + struct msgb *msg, + struct osmo_gtp_err *err) +{ + struct msgb *reply; + struct tlv_parsed tp; + struct osmo_gtp_pdp _pdp, *pdp = &_pdp; + int ret; + + memset(pdp, 0, sizeof(_pdp)); + + ret = tlv_parse(&tp, &gtp_pdp_update_req_attr_tlvdef, + msg->data + sizeof(struct gtp0_header), + msg->len - sizeof(struct gtp0_header), 0, 0); + if (ret < 0) { + LOGP(DLINP, LOGL_ERROR, "cannot parse TLVs: %u\n", ret); + return NULL; + } + + /* Mandatory attributes: + * + * 1) 7.9.6. QoS profile. 32 bits. GSM 04.08 + * 2) 7.9.14. Flow label data. 16 bits + * 3) 7.9.15. Flow label signalling. 16 bits + * 4) 7.9.23. GSN address (variable length) + * 5) 7.9.24. MSISDN (variable length) + */ + if (!TLVP_PRESENT(&tp, GTPV0_IE_QOS_PROFILE) || + !TLVP_PRESENT(&tp, GTPV0_IE_FLOW_LABEL_DATA) || + !TLVP_PRESENT(&tp, GTPV0_IE_FLOW_LABEL_SIGNAL) || + !TLVP_PRESENT(&tp, GTPV0_IE_GSN_ADDR)) { + LOGP(DLINP, LOGL_ERROR, "missing mandatory TLV\n"); + return NULL; + } + + pdp->qos_profile = tv_get_be24(&tp, GTPV0_IE_QOS_PROFILE); + + pdp->flow_label_data = tv_get_be16(&tp, GTPV0_IE_FLOW_LABEL_DATA); + pdp->flow_label_signal = tv_get_be16(&tp, GTPV0_IE_FLOW_LABEL_SIGNAL); + if (gtp0_parse_gsn_addr(&tp, pdp) < 0) + return NULL; + + reply = gtp_pdp_ctx_update_resp(gsn, msg, pdp); + if (reply == NULL) + return NULL; + + return reply; +} + +static struct msgb *gtp_pdp_ctx_delete_resp(struct osmo_gsn *gsn, + const struct msgb *msg, + struct osmo_gtp_pdp *pdp) +{ + struct msgb *reply; + struct gtp0_header *gtp0h; + + reply = msgb_alloc(OSMO_GTP_MTU, "gtp"); + if (reply == NULL) + return NULL; + + gtp0h = gtp0_header_put(reply, GTP_PDP_DELETE_RESP, gtp0h_seq(msg), 0, + gtp0h_tid(msg)); + + /* TODO: implement reject PDP request + reason */ + msgb_tv_put_be8(reply, GTPV0_IE_CAUSE, GTPV0_CAUSE_REQ_ACCEPTED); + + gtp0_header_end(gtp0h, reply); + + return reply; +} + +static struct msgb *gtp_pdp_delete_req_handler(struct osmo_gsn *gsn, + struct msgb *msg, + struct osmo_gtp_err *err) +{ + struct msgb *reply; + struct osmo_gtp_pdp _pdp, *pdp = &_pdp; + + reply = gtp_pdp_ctx_delete_resp(gsn, msg, pdp); + if (reply == NULL) + return NULL; + + return reply; +} + +static struct osmo_gtp_handler gtp0_handler[GTP_TYPE_MAX] = { + [GTP_ECHO_REQ] = { + .request = true, + .handler = gtp_echo_req_handler, + }, + [GTP_PDP_CREATE_REQ] = { + .request = true, + .handler = gtp_pdp_create_req_handler, + }, + [GTP_PDP_UPDATE_REQ] = { + .request = true, + .handler = gtp_pdp_update_req_handler, + }, + [GTP_PDP_DELETE_REQ] = { + .request = true, + .handler = gtp_pdp_delete_req_handler, + }, +}; + +struct msgb *gtp0_recv(struct osmo_gsn *gsn, struct msgb *msg, + struct osmo_gtp_err *err) +{ + struct gtp0_header *gtp0h = (struct gtp0_header *)msg->data; + struct msgb *reply = NULL; + + if (gtp0h->version != 0) { + LOGP(DLINP, LOGL_ERROR, "wrong GTP packet version %u\n", + gtp0h->version); + return gtp_unsupp(msg); + } + if (msg->len < sizeof(*gtp0h)) { + LOGP(DLINP, LOGL_ERROR, "GTPv0 packet too short msg->len %u\n", + msg->len); + return NULL; + } + if (msg->len != ntohs(gtp0h->length) + sizeof(*gtp0h)) { + LOGP(DLINP, LOGL_ERROR, + "truncated GTPv0 header msg->len %u != %u\n", + msg->len, ntohs(gtp0h->length) + (int)sizeof(*gtp0h)); + return NULL; + } + + if ((gtp0h->type < GTP_TYPE_MAX) && gtp0_handler[gtp0h->type].handler) + reply = gtp0_handler[gtp0h->type].handler(gsn, msg, err); + + return reply; +} + +struct osmo_gtp_pdp *osmo_gtp_get_pdp(struct osmo_gtp_ctx *ctx) +{ + return ctx->pdp; +} + +void osmo_gtp0_fprintf(FILE *fd, struct msgb *msg, uint32_t type) +{ + struct gtp0_header *gtp0h = (struct gtp0_header *)msg->data; + int i; + + if (msg->len < sizeof(*gtp0h)) + return; + + switch (type) { + case OSMO_GTP_DEFAULT: + printf("version pt spare snn\n%x %x %x %x\n", + gtp0h->version, gtp0h->pt, gtp0h->spare, gtp0h->snn); + printf("type seq tid flow\n%u %x %llx %x\n", + gtp0h->type, ntohs(gtp0h->seq), + (unsigned long long)be64toh(gtp0h->tid), gtp0h->flow); + + for (i = sizeof(*gtp0h); i < msg->len; i++) { + printf("(%d) %.2x ", i, msg->data[i] & 0xff); + } + printf("\n"); + break; + case OSMO_GTP_HEX: + for (i = 0; i < msg->len; i++) + printf("\\x%.2x", msg->data[i] & 0xff); + + printf("\n"); + break; + } +} diff --git a/src/libosmocore.c b/src/libosmocore.c new file mode 100644 index 0000000..28b60d0 --- /dev/null +++ b/src/libosmocore.c @@ -0,0 +1,70 @@ +#include <osmocom/gsm/tlv.h> +#include "libosmocore.h" +#include <arpa/inet.h> + +void *msgb_tv_put_be8(struct msgb *msg, int type, uint8_t value) +{ + return msgb_tv_fixed_put(msg, type, 1, (uint8_t *)&value); +} + +void *msgb_tv_put_be16(struct msgb *msg, int type, uint16_t value) +{ + value = htons(value); + return msgb_tv_fixed_put(msg, type, 2, (uint8_t *)&value); +} + +void *msgb_tv_put_be24(struct msgb *msg, int type, uint32_t value) +{ + value = htonl(value & 0x00ffffff) >> 8; + return msgb_tv_fixed_put(msg, type, 3, (uint8_t *)&value); +} + +void *msgb_tv_put_be32(struct msgb *msg, int type, uint32_t value) +{ + value = htonl(value); + return msgb_tv_fixed_put(msg, type, 4, (uint8_t *)&value); +} + +void *msgb_tlv_put_be32(struct msgb *msg, int type, uint32_t value) +{ + value = htonl(value); + return msgb_tlv_put(msg, type, sizeof(uint32_t), (uint8_t *)&value); +} + +void *msgb_tlv_put_data(struct msgb *msg, int type, int len, void *data) +{ + return msgb_tl16v_put(msg, type, len, data); +} + +uint8_t tv_get_be8(struct tlv_parsed *tp, int type) +{ + return *((uint8_t *)TLVP_VAL(tp, type)); +} + +uint16_t tv_get_be16(struct tlv_parsed *tp, int type) +{ + return ntohs(*((uint16_t *)TLVP_VAL(tp, type))); +} + +uint32_t tv_get_be24(struct tlv_parsed *tp, int type) +{ + uint32_t tmp = *((uint32_t *)TLVP_VAL(tp, type)); + + return ntohl(tmp) >> 8; +} + +uint32_t tv_get_be32(struct tlv_parsed *tp, int type) +{ + return ntohl(*((uint32_t *)TLVP_VAL(tp, type))); +} + +const char *tv_get_strdup(struct tlv_parsed *tp, int type) +{ + return strndup((const char *)TLVP_VAL(tp, type), TLVP_LEN(tp, type)); +} + +const char *tlv_get_strdup(struct tlv_parsed *tp, int type) +{ + /* XXX validate length */ + return strndup((const char *)TLVP_VAL(tp, type), TLVP_LEN(tp, type)); +} diff --git a/tests/Makefile.am b/tests/Makefile.am new file mode 100644 index 0000000..9dfe830 --- /dev/null +++ b/tests/Makefile.am @@ -0,0 +1,52 @@ +AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include +AM_CFLAGS=-Wall -g $(LIBOSMOCORE_CFLAGS) $(LIBOSMOGSM_CFLAGS) $(COVERAGE_CFLAGS) +AM_LDFLAGS = $(COVERAGE_LDFLAGS) + +check_PROGRAMS = gtp_test + +gtp_test_SOURCES = gtp_test.c +gtp_test_LDADD = $(top_builddir)/src/libosmogtp.la \ + $(LIBOSMOCORE_LIBS) $(LIBOSMOGSM_LIBS) + +# boilerplate for the tests +# The `:;' works around a Bash 3.2 bug when the output is not writeable. +$(srcdir)/package.m4: $(top_srcdir)/configure.ac + :;{ \ + echo '# Signature of the current package.' && \ + echo 'm4_define([AT_PACKAGE_NAME],' && \ + echo ' [$(PACKAGE_NAME)])' && \ + echo 'm4_define([AT_PACKAGE_TARNAME],' && \ + echo ' [$(PACKAGE_TARNAME)])' && \ + echo 'm4_define([AT_PACKAGE_VERSION],' && \ + echo ' [$(PACKAGE_VERSION)])' && \ + echo 'm4_define([AT_PACKAGE_STRING],' && \ + echo ' [$(PACKAGE_STRING)])' && \ + echo 'm4_define([AT_PACKAGE_BUGREPORT],' && \ + echo ' [$(PACKAGE_BUGREPORT)])'; \ + echo 'm4_define([AT_PACKAGE_URL],' && \ + echo ' [$(PACKAGE_URL)])'; \ + } >'$(srcdir)/package.m4' + +EXTRA_DIST = testsuite.at $(srcdir)/package.m4 $(TESTSUITE) \ + gtp/gtp_test.ok + +TESTSUITE = $(srcdir)/testsuite + +DISTCLEANFILES = atconfig + +check-local: atconfig $(TESTSUITE) + $(SHELL) '$(TESTSUITE)' $(TESTSUITEFLAGS) + +installcheck-local: atconfig $(TESTSUITE) + $(SHELL) '$(TESTSUITE)' AUTOTEST_PATH='$(bindir)' \ + $(TESTSUITEFLAGS) + +clean-local: + test ! -f '$(TESTSUITE)' || \ + $(SHELL) '$(TESTSUITE)' --clean + +AUTOM4TE = $(SHELL) $(top_srcdir)/missing --run autom4te +AUTOTEST = $(AUTOM4TE) --language=autotest +$(TESTSUITE): $(srcdir)/testsuite.at $(srcdir)/package.m4 + $(AUTOTEST) -I '$(srcdir)' -o $@.tmp $@.at + mv $@.tmp $@ diff --git a/tests/gtp/gtp_test.ok b/tests/gtp/gtp_test.ok new file mode 100644 index 0000000..e69de29 diff --git a/tests/gtp_test.c b/tests/gtp_test.c new file mode 100644 index 0000000..53be1da --- /dev/null +++ b/tests/gtp_test.c @@ -0,0 +1,121 @@ +#include <stdio.h> +#include <stdlib.h> +#include <stdint.h> +#include <gtp.h> +#include <osmocom/core/msgb.h> +#include <osmocom/gtp/gtp.h> +#include <osmocom/gsm/tlv.h> + +#include "libosmocore.h" + +int main(void) +{ + struct osmo_gsn *gsn; + struct msgb *msg, *reply; + struct osmo_gtp_err err; + struct gtp0_header *gtp0h; + + gsn = osmo_gsn_alloc(); + + msg = msgb_alloc(1500, "gtp-test"); + + /* + * GTP echo request + */ + gtp0h = gtp0_header_put(msg, GTP_ECHO_REQ, 0x1234, 0, 0); + gtp0_header_end(gtp0h, msg); + + reply = gtp0_recv(gsn, msg, &err); + if (reply) + osmo_gtp0_fprintf(stdout, reply, OSMO_GTP_HEX); + else + printf("failure\n"); + + msgb_free(reply); + msgb_reset(msg); + + /* + * GTP PDP context create request + */ + int val = 0x654321; + + gtp0h = gtp0_header_put(msg, GTP_PDP_CREATE_REQ, 0x1234, 0, 10); + msgb_tv_put_be24(msg, GTPV0_IE_QOS_PROFILE, val); + msgb_tv_put_be8(msg, GTPV0_IE_SELECT_MODE, 0); + msgb_tv_put_be16(msg, GTPV0_IE_FLOW_LABEL_DATA, 1); + msgb_tv_put_be16(msg, GTPV0_IE_FLOW_LABEL_SIGNAL, 2); + + const char *test = "test"; + + struct enduser_addr_ie_payload_ipv4 ie_ipv4 = { + .spare = 0xf, + .pdp_org_type = PDP_ORG_IETF, + .pdp_type_number = PDP_TYPE_IPV4, + .addr = { + .s_addr = 0x04030201, + }, + }; + msgb_tlv_put_data(msg, GTPV0_IE_ENDUSER_ADDR, sizeof(ie_ipv4), + &ie_ipv4); + msgb_tlv_put_data(msg, GTPV0_IE_AP_NAME, strlen(test), (uint8_t *)test); + val = 0x01020304; + msgb_tlv_put_data(msg, GTPV0_IE_GSN_ADDR, sizeof(val), (uint8_t *)&val); + val = 0x0a0b0c0d; + + const char *msisdn = "650102030"; + msgb_tlv_put_data(msg, GTPV0_IE_MSISDN, strlen(msisdn), (uint8_t *)msisdn); + + gtp0_header_end(gtp0h, msg); + + reply = gtp0_recv(gsn, msg, &err); + if (reply) + osmo_gtp0_fprintf(stdout, reply, OSMO_GTP_HEX); + else + printf("failure\n"); + + msgb_free(reply); + msgb_reset(msg); + + /* + * GTP Update PDP context request + */ + val = 0x654321; + + gtp0h = gtp0_header_put(msg, GTP_PDP_UPDATE_REQ, 0x1234, 0, 10); + msgb_tv_put_be24(msg, GTPV0_IE_QOS_PROFILE, val); + /* Recovery 7.9.12 optional */ + msgb_tv_put_be16(msg, GTPV0_IE_FLOW_LABEL_DATA, 1); + msgb_tv_put_be16(msg, GTPV0_IE_FLOW_LABEL_SIGNAL, 2); + val = 0x01020304; + msgb_tlv_put_data(msg, GTPV0_IE_GSN_ADDR, sizeof(val), (uint8_t *)&val); + + gtp0_header_end(gtp0h, msg); + + reply = gtp0_recv(gsn, msg, &err); + if (reply) + osmo_gtp0_fprintf(stdout, reply, OSMO_GTP_HEX); + else + printf("failure\n"); + + msgb_free(reply); + msgb_reset(msg); + + /* + * GTP delete PDP context request + */ + val = 0x654321; + + gtp0h = gtp0_header_put(msg, GTP_PDP_DELETE_REQ, 0x1234, 0, 10); + gtp0_header_end(gtp0h, msg); + + reply = gtp0_recv(gsn, msg, &err); + if (reply) + osmo_gtp0_fprintf(stdout, reply, OSMO_GTP_HEX); + else + printf("failure\n"); + + msgb_free(reply); + msgb_reset(msg); + + return EXIT_SUCCESS; +} diff --git a/tests/gtp_test.ok b/tests/gtp_test.ok new file mode 100644 index 0000000..6860a40 --- /dev/null +++ b/tests/gtp_test.ok @@ -0,0 +1,4 @@ +version pt spare snn +0 1 7 0 +ntype seq tid flow +2 3412 0 0(20) e (21) 0 diff --git a/tests/testsuite.at b/tests/testsuite.at new file mode 100644 index 0000000..fb55669 --- /dev/null +++ b/tests/testsuite.at @@ -0,0 +1,18 @@ +AT_INIT +AT_BANNER([Regression tests.]) + +# Example for tests.. copy and uncomment. This creates a new category +# and test. It will copy the expected output to expout and then run +# the given test. The stdout will be compared with the expout to determine +# if the test was successfull. +# AT_SETUP([NAME]) +# AT_KEYWORDS([NAME]) +# cat $abs_srcdir/NAME/NAME_test.ok > expout +# AT_CHECK([$abs_top_builddir/tests/NAME/NAME_test], [], [expout]) +# AT_CLEANUP + +AT_SETUP([gtp_test]) +AT_KEYWORDS([gtp_test]) +cat $abs_srcdir/gtp_test.ok > expout +AT_CHECK([$abs_top_builddir/tests/gtp_test], [], [expout], [ignore]) +AT_CLEANUP -- 2.1.4

8 years, 6 months

4
5
0 0

Oct 21, 8pm / Osmocom Berlin Meeting

by Harald Welte

Hi all! This is the announcement for the re-incarnation of our bi-weekly Osmocom Berlin Meeting. Oct 21, 8pm @ CCC Berlin, Marienstr. 11, 10117 Berlin There is no formal presentation this time, but * there will be SDR equipment in case more people are interested to have a look at MPT1327 and/or Tetrapol signals that can be received in Berlin * Harald would like to discuss OpenBSC website / documentation improvements The meeting is open to anyone interested in mobile communications. You do not have to be involved with the Osmocom projects in order to attend. Anyone interested in mobile communications protocols is welcome. If you are interested to show up, feel free to do so. The meeting is "free as in free beer", despite no actual free beer being around ;) More information can be found at http://openbsc.osmocom.org/trac/wiki/OsmocomMeeting/Berlin Regards, Harald -- - Harald Welte <laforge(a)gnumonks.org> ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)

8 years, 6 months

1
0
0 0

osmo_loadXXbe_ext -- was: [PATCH 1/8] libcommon: soak up three static functions.

by Neels Hofmeyr

> > +uint64_t decode_big_endian(const uint8_t *data, size_t data_len) > > +uint8_t *encode_big_endian(uint64_t value, size_t data_len) > have you looked at osmo_load64le_ext of libosmocore? I think you don't need > these routines. and it applies to GSUP too. Ah, nice. Hadn't seen those yet. Oh well, I notice that the decode_big_endian() is more elegant to use than osmo_load64be_ext(), since passing a length of less than 8 bytes to decode_big_endian() writes the N least significant bytes, and allows this: uint16_t val; val = decode_big_endian(buf, sizeof(val)); It has the desired result. However this: uint16_t val; val = osmo_load64be_ext(buf, sizeof(val)); will write the bytes bound to the "wrong", most significant end of the uint64_t, and only zero is written to val. So I would need to explicitly use osmo_load16be(). Which is less elegant, isn't it? Is it about performance? Would changing that behavior break anything besides bitrev_test.c? (It checks for exactly this ordering) I'd like to change only the osmo_loadXXbe_ext() function, so that it writes the least significant bytes, like decode_big_endian() does. But first, does it write the most significant end for a reason? If it doesn't, we don't actually need to generate functions for each integer size. Instead we can glorify the decode_big_endian() and encode_big_endian(), made threadsafe, to become osmo_load/store*(). Right?? Except for bitrev_test.c, all callers I found (in my currently cloned few source trees) use only the non-"_ext" functions, and would not be affected by the change at all. ~Neels P.S.: Holger, after I said to you that osmo_loadXXbe_ext is not less elegant after all, I re-re-realized that it is indeed still less elegant...

8 years, 6 months

1
1
0 0

libosmocore and osmo-trx uploaded to Debian

by Ruben Undheim

Hi everyone, I just want to announce that packages of libosmocore and osmo-trx have been uploaded to Debian. They are waiting in the NEW queue to be accepted by the FTP masters: - https://ftp-master.debian.org/new/libosmocore_0.8.3-1.html - https://ftp-master.debian.org/new/osmo-trx_0~20150325gitf147b17+dfsg-1.html Best regards, Ruben

8 years, 6 months

1
1
0 0

Femto - IuH

by Sipos Csaba

Dear Harald, Now that the implementation of the IuH interface is on its way, can you please recommend any femtos which you think can probably be used with this implementation? I think in a previous conversation in this subject someone mentioned that probably Alcatel based units has the highest chance because of certain configuration and/or implementation options. Anyway, if you can shed some light on this subject, that would be awsome. Thanks! Csaba

8 years, 6 months

2
4
0 0

Re: osmo-nitb (HLR/sqlite part) - segmentation fault

by Holger Freyther

> On 18 Oct 2015, at 05:26, Marcin Starzyk <marcin.starzyk(a)gmail.com> wrote: > Hi! > Is it acceptable for you?- if so - how should I start? (I've read section for developers on openbsc wiki but still things are not clear to me as to how to start) 0.) The first libdbi corruption has been fixed by a patch[1]. You might just suffer from this one. 1.) In OpenBSC and when linking against libdbi 0.9 we get crashes on i386. I have a first analysis here[2] you could see which part fails. E.g. you could start compiling libdbi/libdi-drivers on your system with the address sanitizer (ASAN) and see if crashes are already triggered by the builtin testsuite, if not move on to OpenBSC 2.) Start looking into replacing libdbi calls with direct sqlite3 calls. To store "BLOB" libdi was wrapping it and we either copy that code or we migrate the data. E.g. have a look at how we migrate SMS on a schema change. 1st and 2nd are two alternatives, both of them have ups and downs and are acceptable ways to move forward. holger [1] https://github.com/sysmocom/meta-telephony/blob/master/recipes-misc/libdbi/… [2] http://sourceforge.net/p/libdbi/mailman/message/32607036/

8 years, 6 months

1
0
0 0

osmo-nitb (HLR/sqlite part) - segmentation fault

by Marcin Starzyk

Hi All, I’m facing an issue with osmo-nitb (HLR/sqlite part) - segmentation fault. All works ok for the first usage od DB (e.g. Location Updating Request) – but there is segmentation fault on second Location Updating request or any other attempt to execute any command using VTY for HLR. Syslog____________________________________________________________________________ Oct 12 20:32:29 debian kernel: [ 2397.242984] osmo-nitb[985]: segfault at 64692e74 ip b77c15c9 sp bf8688b0 error 4 in libdbdsqlite3.so[b77be000+8000] Part of bt__________________________________________________________________________ #0 0xb77c15c9 in ?? () from /usr/lib/i386-linux-gnu/dbd/libdbdsqlite3.so #1 0xb77c17e4 in ?? () from /usr/lib/i386-linux-gnu/dbd/libdbdsqlite3.so #2 0xb77c26f7 in dbd_query () from /usr/lib/i386-linux-gnu/dbd/libdbdsqlite3.so No symbol table info available. Can anybody please advise? Thank you, Regards, Marcin Attached files -Tcpump (between nanoBTS(.34) and BSC (.20)) -Debug output, backtrace, syslog below Debug-output 1/2________________________________________________________________________ <0004> abis_rsl.c:1465 (bts=0,trx=0,ts=0,ss=0) Activating ARFCN(514) SS(0) lctype SDCCH r=LOCATION_UPDATE ra=0x01 ta=0 <0004> abis_rsl.c:1199 (bts=0,trx=0,ts=0,ss=0) CHANNEL ACTIVATE ACK <0000> abis_rsl.c:1653 (bts=0,trx=0,ts=0,ss=0) SAPI=0 ESTABLISH INDICATION <0000> gsm_04_08.c:3584 Dispatching 04.08 message, pdisc=5 <0002> gsm_04_08.c:1136 LOCATION UPDATING REQUEST: MI(IMSI)=260060059332155 type=NORMAL <0001> gsm_04_08.c:145 (bts 0 trx 0 ts 0 pd 05) Sending 0x18 to MS. <0000> abis_rsl.c:1653 (bts=0,trx=0,ts=0,ss=0) SAPI=0 DATA INDICATION <0003> bsc_api.c:500 CLASSMARK CHANGE CM2(len=3) CM3(len=7) <0000> abis_rsl.c:1653 (bts=0,trx=0,ts=0,ss=0) SAPI=0 DATA INDICATION <0000> gsm_04_08.c:3584 Dispatching 04.08 message, pdisc=5 <0002> gsm_04_08.c:523 IDENTITY RESPONSE: MI(IMEI)=359809011036930 <0002> gsm_04_08.c:568 Location Updating Request procedure timedout. <0002> gsm_04_08.c:452 Subscriber 260060059332155: LOCATION UPDATING REJECT LAC=1 BTS=0 <0001> gsm_04_08.c:145 (bts 0 trx 0 ts 0 pd 05) Sending 0x04 to MS. <0000> chan_alloc.c:324 (bts=0,trx=0,ts=0,ss=0) starting release sequence <0003> gsm_04_08_utils.c:239 Sending Channel Release: Chan: Number: 0 Type: 1 <0004> abis_rsl.c:616 (bts=0,trx=0,ts=0,ss=0) DEACTivate SACCH CMD DB-ouput___________________________________________________________________________ sqlite> select * from subscriber ; 1|2015-10-12 18:31:38|2015-10-12 18:31:39|260060059332155||22685|0||0| Debug-output 2/2_____________________________________________________________________ <0004> abis_rsl.c:1465 (bts=0,trx=0,ts=0,ss=0) Activating ARFCN(514) SS(0) lctype SDCCH r=LOCATION_UPDATE ra=0x07 ta=0 <0004> abis_rsl.c:1199 (bts=0,trx=0,ts=0,ss=0) CHANNEL ACTIVATE ACK 0000> abis_rsl.c:1653 (bts=0,trx=0,ts=0,ss=0) SAPI=0 ESTABLISH INDICATION <0000> gsm_04_08.c:3584 Dispatching 04.08 message, pdisc=5 <0002> gsm_04_08.c:1136 LOCATION UPDATING REQUEST: MI(IMSI)=260060059332155 type=NORMAL <0001> gsm_04_08.c:145 (bts 0 trx 0 ts 0 pd 05) Sending 0x18 to MS. Segmentation fault (core dumped) Syslog____________________________________________________________________________ Oct 12 20:32:29 debian kernel: [ 2397.242984] osmo-nitb[985]: segfault at 64692e74 ip b77c15c9 sp bf8688b0 error 4 in libdbdsqlite3.so[b77be000+8000] Backtrace__________________________________________________________________________ root@debian:~/openbsc/openbsc/src/osmo-nitb# gdb osmo-nitb core GNU gdb (Debian 7.7.1+dfsg-5) 7.7.1 Copyright (C) 2014 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html > This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. This GDB was configured as "i586-linux-gnu". Type "show configuration" for configuration details. For bug reporting instructions, please see: <http://www.gnu.org/software/gdb/bugs/>. Find the GDB manual and other documentation resources online at: <http://www.gnu.org/software/gdb/documentation/>. For help, type "help". Type "apropos word" to search for commands related to "word"... Reading symbols from osmo-nitb...done. [New LWP 985] [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib/i386-linux-gnu/i686/cmov/libthread_db.so.1". Core was generated by `./osmo-nitb --debug=DRLL:DCC:DMM:DRR:DRSL:DNM'. Program terminated with signal SIGSEGV, Segmentation fault. #0 0xb77c15c9 in ?? () from /usr/lib/i386-linux-gnu/dbd/libdbdsqlite3.so (gdb) bt full #0 0xb77c15c9 in ?? () from /usr/lib/i386-linux-gnu/dbd/libdbdsqlite3.so No symbol table info available. #1 0xb77c17e4 in ?? () from /usr/lib/i386-linux-gnu/dbd/libdbdsqlite3.so No symbol table info available. #2 0xb77c26f7 in dbd_query () from /usr/lib/i386-linux-gnu/dbd/libdbdsqlite3.so No symbol table info available. #3 0xb77a7122 in dbi_conn_queryf () from /usr/lib/i386-linux-gnu/libdbi.so.1 No symbol table info available. #4 0x0806f99f in get_equipment_by_subscr (subscr=0x9055b60) at db.c:550 result = 0x9053520 cm2 = 0xbf8688e4 "" cm3 = 0xbf8688e4 "" #5 0x08070523 in db_get_subscriber (field=151346016, id=0xbf868e00 "260060059332155") at db.c:897 result = 0x9053520 quoted = 0x904fa58 "x4q\267x5\005\t2015-10-12 18:31:39" subscr = 0x9055b60 #6 0x0807423a in get_subscriber (ident=0xbf868e00 "260060059332155", type=0, sgrp=0x9010840) at gsm_subscriber.c:67 subscr = <optimized out> #7 subscr_get_by_imsi (sgrp=0x9010840, imsi=0xbf868e00 "260060059332155") at gsm_subscriber.c:240 subscr = 0x80c20e0 <subscriber_create_cmd+32> #8 0x0807f8a5 in mm_rx_loc_upd_req (msg=<optimized out>, conn=0x9063740) at gsm_04_08.c:643 subscr = 0x0 bts = 0xb7737b01 <osmo_timer_schedule+81> ---Type <return> to continue, or q <return> to quit--- mi_type = <optimized out> gh = 0x9063793 mi_string = "260060059332155\000\267zs\267\230+\005\t@7 \006\t\206\353\a\b" #9 gsm0408_rcv_mm (msg=0x8085488, conn=0x9063740) at gsm_04_08.c:1137 gh = <optimized out> rc = 0 #10 gsm0408_dispatch (conn=0x9052b98, msg=0x9063740) at gsm_04_08.c:3594 gh = <optimized out> pdisc = <optimized out> rc = 0 #11 0x0807895a in msc_compl_l3 (conn=0x9052b98, msg=0x9063740, chosen_channel=0) at osmo_msc.c:49 No locals. #12 0x0804e468 in gsm0408_rcvmsg (msg=0x9063740, link_id=0 '\000') at bsc_api.c:684 rc = -1081702172 #13 0x0806619b in abis_rsl_rx_rll (msg=<optimized out>) at abis_rsl.c:1674 ts_name = 0xbf8688e4 "" sapi = 0 '\000' #14 abis_rsl_rcvmsg (msg=0x9063740) at abis_rsl.c:2085 rc = 151402378 #15 0xb771f107 in handle_ts1_read (bfd=<optimized out>) at input/ipaccess.c:271 link = 0xbf8688e4 hh = 0x5 msg = 0x9063740 ---Type <return> to continue, or q <return> to quit--- ts_nr = 3077720460 #16 ipaccess_fd_cb (bfd=0x9056b30, what=1) at input/ipaccess.c:386 rc = 151348668 #17 0xb77380d8 in osmo_select_main (polling=0) at select.c:160 flags = 1 ufd = 0x9056b30 tmp = 0xb7754524 <osmo_fds> readset = {__fds_bits = {0 <repeats 32 times>}} writeset = {__fds_bits = {0 <repeats 32 times>}} exceptset = {__fds_bits = {0 <repeats 32 times>}} work = 1 rc = <optimized out> no_time = {tv_sec = 0, tv_usec = 0} #18 0x0804c8bf in main (argc=2, argv=0xbf869214) at bsc_hack.c:356 rc = <optimized out>

8 years, 6 months

3
5
0 0

[PATCH 00/15] Add GTP hub, in early alpha stage

by Neels Hofmeyr

Here is the part of the branch openbsc:neels/gtphub that I believe may be merged to master at this point. (Holger: please go ahead with the merge, or tell me to do so...) The remaining bit is mostly a unit test netcat'ing to a gtphub instance. To do that properly, gtphub must be configurable. Hence I'm starting to add VTY config, which is not complete yet. Hence that part is still omitted here. Neels Hofmeyr (15): Add GTP hub stub, as simplistic UDP forwarder. gtphub: add to build gtphub: add skeletal gtphub.[hc] gtphub: populate API impl from test prog gtphub: add a todo comment gtphub: add TEI map API. gtphub: add gtphub_test.c (empty) gtphub: add TEI map test gtphub: add GTP header validation gtphub: undup code: memset on a struct. gtphub: tweak logging gtphub: index IEs, decode and log a few. gtphub: split gtp_relay() in r/w funcs gtphub: map sequence numbers SGSNs<->GGSNs gtphub: add signal handler to gtphub_main openbsc/.gitignore | 2 + openbsc/configure.ac | 1 + openbsc/include/openbsc/Makefile.am | 3 +- openbsc/include/openbsc/debug.h | 1 + openbsc/include/openbsc/gtphub.h | 151 ++++++++ openbsc/src/gprs/Makefile.am | 4 + openbsc/src/gprs/gtphub.c | 714 ++++++++++++++++++++++++++++++++++++ openbsc/src/gprs/gtphub_main.c | 256 +++++++++++++ openbsc/tests/Makefile.am | 2 +- openbsc/tests/gtphub/Makefile.am | 15 + openbsc/tests/gtphub/gtphub_test.c | 117 ++++++ openbsc/tests/gtphub/gtphub_test.ok | 1 + openbsc/tests/testsuite.at | 7 + 13 files changed, 1272 insertions(+), 2 deletions(-) create mode 100644 openbsc/include/openbsc/gtphub.h create mode 100644 openbsc/src/gprs/gtphub.c create mode 100644 openbsc/src/gprs/gtphub_main.c create mode 100644 openbsc/tests/gtphub/Makefile.am create mode 100644 openbsc/tests/gtphub/gtphub_test.c create mode 100644 openbsc/tests/gtphub/gtphub_test.ok -- 2.1.4

8 years, 6 months

1
15
0 0

Authorization using IMEI

by Ravi Shankar

Dear Sir It's mentioned on the site that the non-secure authorization is feasible with IMEI/IMSI. How can we authorize any MS using IMEI ?? I mean, the authorization field is in the Subscriber table of the database so how is it possible to set authorization with IMEI number. Regards.

8 years, 6 months

2
1
0 0

[PATCH openbsc] mgcp_osmux: available circuit IDs from 0 to 255, not from 0 to 128

by pablo＠gnumonks.org

From: Pablo Neira Ayuso <pablo(a)soleta.eu> Holger reports that the bitmap that accounts for available Osmux circuit IDs is limited to 128, when the maximum number of circuit IDs are determined by the uint8_t field in the header (ie. 256 circuits). --- @Holger: Will be revisiting libosmo-netif too, at quick glance I can see insufficient validation of several functions there that take this allocated ccid as input parameter. openbsc/src/libmgcp/mgcp_osmux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/openbsc/src/libmgcp/mgcp_osmux.c b/openbsc/src/libmgcp/mgcp_osmux.c index 90b7368..d110f42 100644 --- a/openbsc/src/libmgcp/mgcp_osmux.c +++ b/openbsc/src/libmgcp/mgcp_osmux.c @@ -530,7 +530,7 @@ int osmux_send_dummy(struct mgcp_endpoint *endp) } /* bsc-nat allocates/releases the Osmux circuit ID */ -static uint8_t osmux_cid_bitmap[16]; +static uint8_t osmux_cid_bitmap[(OSMUX_CID_MAX + 1) / 8]; int osmux_get_cid(void) { -- 2.1.4

8 years, 6 months

1
0
0 0

recent patch set with wrong From address dwilllmann@

by Neels Hofmeyr

Daniel, your from address had triple l's in them. Just saying in case some config needs fixing. I noticed because I was replying on a patch and got a bounce from sysmocom.de. ~Neels

8 years, 6 months

1
0
0 0

Osmo-BTS-trx compilation Error

by Rehab Khan

Hello list, I have compiled OpenBSC stack following the link http://openbsc.osmocom.org/trac/wiki/network_from_scratch. Everything has been compiled and configured smoothly except osmo-bts.For installing osmo-bts,i git cloned master branch from https://github.com/osmocom/osmo-bts. Following the link, i did configure --enable-trx and when make osmo-bts, i am getting the following error: l1_if.c: In function ‘bts_model_l1sap_down’: l1_if.c:552:23: error: ‘struct amr_multirate_conf’ has no member named ‘mode’ l1_if.c:553:23: error: ‘struct amr_multirate_conf’ has no member named ‘mode’ l1_if.c:554:23: error: ‘struct amr_multirate_conf’ has no member named ‘mode’ l1_if.c:555:23: error: ‘struct amr_multirate_conf’ has no member named ‘mode’ l1_if.c:580:23: error: ‘struct amr_multirate_conf’ has no member named ‘mode’ l1_if.c:581:23: error: ‘struct amr_multirate_conf’ has no member named ‘mode’ l1_if.c:582:23: error: ‘struct amr_multirate_conf’ has no member named ‘mode’ l1_if.c:583:23: error: ‘struct amr_multirate_conf’ has no member named ‘mode’ make: *** [l1_if.o] Error 1 I have tried it with the change branch: jolly/trx and also tried to make osmo-bts-trx in the src directory of osmo-bts but same error persisits. Any help in this regard will be a worth. Thanks Best Regards

8 years, 6 months

1
0
0 0

[openbsc 0/5] sgsn/gbproxy RAND_bytes() usage and test cases

by Daniel Willmann

From: Daniel Willmann <dwillmann(a)sysmocom.de> Hello, the following patches should complete the usage of RAND_bytes() for GPRS. Jacob improved the SGSN test case so it would extract the PTMSI from the LLC frames and use those in the response. This means the gprs_sgsn patch will not break the test anymore. Furthermore, I changed the gbproxy implementation and test case to use RAND_bytes() instead of rand_r(). The test case previously used rand_r() to (re-)set the seed value for TLLI/PTMSI allocation in order to get predictable results. With RAND_bytes() this is not possible. Instead the tests overrides that function, replacing it with a predictable sequence of random numbers. Regards Daniel Daniel Willmann (3): gprs: Use RAND_bytes for p-tmsi gbproxy/test: Add and call cleanup_test function gprs/gb_proxy: Use RAND_bytes for gbproxy TLLI/TMSI allocation Jacob Erlbeck (2): sgsn/test: Add and call cleanup_test function sgsn/test: Really parse received DL LLC messages openbsc/include/openbsc/gb_proxy.h | 4 - openbsc/src/gprs/Makefile.am | 7 +- openbsc/src/gprs/gb_proxy.c | 16 +- openbsc/src/gprs/gprs_sgsn.c | 6 +- openbsc/tests/gbproxy/Makefile.am | 4 +- openbsc/tests/gbproxy/gbproxy_test.c | 110 +++++--- openbsc/tests/gbproxy/gbproxy_test.ok | 514 +++++++++++++++++----------------- openbsc/tests/sgsn/Makefile.am | 2 + openbsc/tests/sgsn/sgsn_test.c | 133 +++++++-- 9 files changed, 464 insertions(+), 332 deletions(-) -- 2.1.4

8 years, 6 months

2
6
0 0

[openbsc 0/4] Use RAND_bytes() instead of rand()

by Daniel Willmann

From: Daniel Willmann <dwillmann(a)sysmocom.de> The following patches uses RAND_bytes() from openssl instead of rand() to generate TMSI/P-TMSI and auth tuples. I didn't change the use of rand_r() in gb-proxy because the gbproxy test seems to depend on predictable randomness. Daniel Willmann (4): libmsc: Use RAND_bytes when choosing a tmsi gprs: Use RAND_bytes for p-tmsi libmsc: Use RAND_bytes to choose auth tuple libmsc: Use RAND_bytes to generate a token openbsc/configure.ac | 2 +- openbsc/src/gprs/gprs_sgsn.c | 4 +++- openbsc/src/libmsc/Makefile.am | 2 +- openbsc/src/libmsc/auth.c | 9 +++++++-- openbsc/src/libmsc/db.c | 12 ++++++++++-- openbsc/src/osmo-nitb/Makefile.am | 2 +- openbsc/tests/channel/Makefile.am | 2 +- openbsc/tests/db/Makefile.am | 2 +- 8 files changed, 25 insertions(+), 10 deletions(-) -- 2.1.4

8 years, 6 months

3
7
0 0

[PATCH] gtp_duplicate(): comment, add todo.

by Neels Hofmeyr

--- gtp/gtp.c | 27 +++++++++++++++++---------- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/gtp/gtp.c b/gtp/gtp.c index e6a610d..de6a7b4 100644 --- a/gtp/gtp.c +++ b/gtp/gtp.c @@ -614,6 +614,15 @@ int gtp_notification(struct gsn_t *gsn, int version, return 0; } +/* Look for a message in the response queue for the given peer and sequence + * number seq. If found, (re-)send the response message and return 0. Otherwise + * return nonzero. This allows catching duplicate messages. + * A response message stays in the response queue until it times out. + * So, for any number of identical requests within that timeout period, the + * same packet can be resent. + * TODO this only checks the peer and sequence number, and does not verify that + * the GTP request is identical to the previous one for this peer and sequence + * nr: a mere peer or seq glitch can cause leaks of previous responses. */ int gtp_duplicate(struct gsn_t *gsn, int version, struct sockaddr_in *peer, uint16_t seq) { @@ -873,7 +882,7 @@ int gtp_echo_ind(struct gsn_t *gsn, int version, struct sockaddr_in *peer, int fd, void *pack, unsigned len) { - /* Check if it was a duplicate request */ + /* Repeat previous response in case of duplicate request */ if (!gtp_duplicate(gsn, 0, peer, get_seq(pack))) return 0; @@ -1258,7 +1267,7 @@ int gtp_create_pdp_ind(struct gsn_t *gsn, int version, uint8_t linked_nsapi = 0; struct pdp_t *linked_pdp = NULL; - /* TODO describe what this is all about: */ + /* Repeat previous response in case of duplicate request */ if (!gtp_duplicate(gsn, version, peer, seq)) return 0; @@ -1955,10 +1964,9 @@ int gtp_update_pdp_ind(struct gsn_t *gsn, int version, uint64_t imsi; uint8_t nsapi; - /* Is this a duplicate ? */ - if (!gtp_duplicate(gsn, version, peer, seq)) { - return 0; /* We already sent of response once */ - } + /* Repeat previous response in case of duplicate request */ + if (!gtp_duplicate(gsn, version, peer, seq)) + return 0; /* Decode information elements */ if (gtpie_decaps(ie, version, pack + hlen, len - hlen)) { @@ -2432,10 +2440,9 @@ int gtp_delete_pdp_ind(struct gsn_t *gsn, int version, int n; int count = 0; - /* Is this a duplicate ? */ - if (!gtp_duplicate(gsn, version, peer, seq)) { - return 0; /* We already sent off response once */ - } + /* Repeat previous response in case of duplicate request */ + if (!gtp_duplicate(gsn, version, peer, seq)) + return 0; /* Find the linked context in question */ if (pdp_getgtp1(&linked_pdp, get_tei(pack))) { -- 2.1.4

8 years, 6 months

1
1
0 0

Another openggsn cosmetic

by Neels Hofmeyr

Another addition to the neels/refactor branch, marking a possible problem in gtp.c. ~Neels

8 years, 6 months

1
1
0 0

gtphub: End User Address IE

by Neels Hofmeyr

Hi, I just noticed that the GGSN returns its IP address in a GTP packet about PDP, in the "End User Address" IE (etsi/GSM/by_chapter/29.060.pdf 7.7.27). I'm asking myself whether this needs to be mapped by gtphub. 127.0.0.3 127.0.0.2 SGSN <-------- GTPHUB <--------- GGSN "127.0.0.2" "127.0.0.2" map this? ^ This sounds almost like no mapping is required, as if it tells the MS which IP address it has "as seen from outside": "The PDP Address shall be the address that this PDP context of the MS is identified with from the external packet data network." But I have no idea, really. Does anyone else? If not, we'll just have to see later... Thanks! ~Neels

8 years, 6 months

1
0
0 0

next version of OAP patch

by Neels Hofmeyr

Hi openbsc, here is my improved version of the OAP aka SGSN-ID patch series. This series is pushed to the neels/sgsn-id-3 branch. This version is substantially simpler, because I decided against factoring out the IPA client. Instead, the gprs_gsup_client.c will directly call the OAP API to handle OAP messages. Factoring out the IPA client was not a requirement and taking too much time, and since the name will remain "GSUP client" (to avoid changing the VTY configuration names among other things), it does after all make sense to think of it as: "the GSUP client employs OAP to authenticate" instead of "GSUP and OAP are two separate clients on the IPA wire". The OAP spec has changed. Particularly instead of SRES and Kc, the challenge response now sends XRES only; and the spec now includes an AUTS request (not yet implemented). Going through the changes, I've made a few fixes (like wrong file header comments), and made some changes. The OAP API looks quite different, and now merely returns struct msgb* and lets the caller take care of sending. This time, OAP has its own separate testsuite tests/oap. I have further OAP tests in mind to add; particularly the complete SGSN registration test from the previous patch version is not yet included here. Anyway, the OAP API test has become more comprehensive. Some of the patch mods have come from comments by hfreyther and jerlbeck, other changes were obvious from reviewing the code. I think this time around the patch is much more mature. I hope you agree, if not I'll gladly improve it further, of course :) Thanks for your reviews! ~Neels

8 years, 6 months

2
16
0 0

openggsn cosmetics

by Neels Hofmeyr

These patches fix some things that hurt my eyes. The renames from dublicate to duplicate may theoretically break API compat, but I could find no affected callers. These are not required, feel free to veto... ~Neels

8 years, 6 months

2
5
0 0

Oct 15, 8pm / OSMUG: "Running OpenAirInterface"

by Harald Welte

Hi all! This is an announcement for an "irregular" Berlin Osmocom User Group event. David Rupprecht of Ruhr-Uni Bochum has offered to give us a presentation sharing his experience in Running OpenAirInterface. OpenAirInterface (http://openairinterface.eurecom.fr/) is a project of the Eurecom research institute in Sofia Antipoils / France. For many years they have been working towards an open source SDR LTE implementation. The presentation will be held on Oct 15, 8pm @ IN-Berlin, Lehrter Str. 53, 10557 Berlin (yes, this is _NOT_ CCC Berlin where regular OSMUG meetings are held!) The meeting is open to anyone interested in mobile communications. You do not have to be involved with the Osmocom projects in order to attend. Anyone interested in mobile communications protocols is welcome. If you are interested to show up, feel free to do so. The meeting is "free as in free beer", despite no actual free beer being around ;) More information about the venue can be found at http://www.in-berlin.de/space/ The official event announcement website is http://openbsc.osmocom.org/trac/blog/david-rub-openair-20151015 Regards, Harald -- - Harald Welte <laforge(a)gnumonks.org> ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)

8 years, 6 months

1
1
0 0

(no subject)

by Neels Hofmeyr

Hi openbsc, the following patch series adds a GTP hub program (maturity level: proof-of-concept). Its aim is related to the recent addition of OAP: it will allow routing multiple SGSNs through one GTP server hub (proxy). The program so far forwards UDP packets to and from hardcoded ports, and logs validity of GTP headers passing through. I think this a good time to do a review cycle and merge to master, before adding the interesting stuff. What will follow: decode GTP body, map/separate PDP contexts across clients and servers, replace TEIs. To do that without reinventing the GTP wheel, I may need to separate data parsing from send/recv in openggsn. There are also some bits that should probably be moved out (to where I copied it from) and the API there changed (so that I can use it here without copying). Those are clearly marked with todo comments. Thanks for your review! ~Neels

8 years, 6 months

3
18
0 0

[PATCH 1/6] osmux: Test cid allocation and de-allocation

by Holger Hans Peter Freyther

From: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> * Test that one can get an id * That they are assigned predicatble right now * That returning them will make the number of used ones go down * That allocating more will fail --- openbsc/include/openbsc/osmux.h | 1 + openbsc/src/libmgcp/mgcp_osmux.c | 14 ++++++++++++++ openbsc/tests/mgcp/mgcp_test.c | 26 ++++++++++++++++++++++++++ 3 files changed, 41 insertions(+) diff --git a/openbsc/include/openbsc/osmux.h b/openbsc/include/openbsc/osmux.h index 8c01fd0..0e727d5 100644 --- a/openbsc/include/openbsc/osmux.h +++ b/openbsc/include/openbsc/osmux.h @@ -22,6 +22,7 @@ int osmux_send_dummy(struct mgcp_endpoint *endp); int osmux_get_cid(void); void osmux_put_cid(uint8_t osmux_cid); +int osmux_used_cid(void); enum osmux_state { OSMUX_STATE_DISABLED = 0, diff --git a/openbsc/src/libmgcp/mgcp_osmux.c b/openbsc/src/libmgcp/mgcp_osmux.c index 90b7368..b0ef69f 100644 --- a/openbsc/src/libmgcp/mgcp_osmux.c +++ b/openbsc/src/libmgcp/mgcp_osmux.c @@ -532,6 +532,20 @@ int osmux_send_dummy(struct mgcp_endpoint *endp) /* bsc-nat allocates/releases the Osmux circuit ID */ static uint8_t osmux_cid_bitmap[16]; +int osmux_used_cid(void) +{ + int i, j, used = 0; + + for (i = 0; i < sizeof(osmux_cid_bitmap) / 8; i++) { + for (j = 0; j < 8; j++) { + if (osmux_cid_bitmap[i] & (1 << j)) + used += 1; + } + } + + return used; +} + int osmux_get_cid(void) { int i, j; diff --git a/openbsc/tests/mgcp/mgcp_test.c b/openbsc/tests/mgcp/mgcp_test.c index b2cb938..7b5de31 100644 --- a/openbsc/tests/mgcp/mgcp_test.c +++ b/openbsc/tests/mgcp/mgcp_test.c @@ -1175,6 +1175,31 @@ static void test_no_name(void) talloc_free(cfg); } +static void test_osmux_cid(void) +{ + int id, i; + + OSMO_ASSERT(osmux_used_cid() == 0); + id = osmux_get_cid(); + OSMO_ASSERT(id == 0); + OSMO_ASSERT(osmux_used_cid() == 1); + osmux_put_cid(id); + OSMO_ASSERT(osmux_used_cid() == 0); + + for (i = 0; i < 16; ++i) { + id = osmux_get_cid(); + OSMO_ASSERT(id == i); + OSMO_ASSERT(osmux_used_cid() == i + 1); + } + + id = osmux_get_cid(); + OSMO_ASSERT(id == -1); + + for (i = 0; i < 256; ++i) + osmux_put_cid(i); + OSMO_ASSERT(osmux_used_cid() == 0); +} + int main(int argc, char **argv) { osmo_init_logging(&log_info); @@ -1193,6 +1218,7 @@ int main(int argc, char **argv) test_multilple_codec(); test_no_cycle(); test_no_name(); + test_osmux_cid(); printf("Done\n"); return EXIT_SUCCESS; -- 2.6.0

8 years, 6 months

3
8
0 0

Re: Oct 07, 8pm / Osmocom Berlin User Group meeting

by Harald Welte

Hi Nico, [responding to the openbsc list, as it is more applicable than baseband-devel] On Sun, Oct 04, 2015 at 01:59:41PM +0200, Nico Golde wrote: > For those interested... is there any code for osmo-iuh already available > somewhere? I don't see it on git.osmocom.org. it is not yet published, I would like to do that at the date of the event itself. It will be on git.osmocom.org. The actual core HNBAP/RUA code is already there. Next is the plan on how to integrate with the existing OsmoNITB. Somehow the A interface code needs to be abstracted out, so that a subscriber_connection can either be served by an A or by an IuCS interface. Another step currently needed is UMTS AKA in the NITB. Once the above two problem areas are adressed, we should have a solution that works at least for signalling (LU, SMS, USSD,...). -- - Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)

8 years, 6 months

1
1
0 0

Oct 07, 8pm / Osmocom Berlin User Group meeting

by Harald Welte

Hi all! This is the announcement for the re-incarnated Osmocom Berlin meeting: Oct 7, 8pm @ CCC Berlin, Marienstr. 11, 10117 Berlin Harald will be presenting about the Iuh protocol stack of UMTS small cells / femtocells and his work towards implementing it as part of Osmocom. Agenda: 20:00h Welcome 20:15h Presentation about Iuh / osmo-iuh 21:00h Informal meeting / chatting The meeting is open to anyone interested in mobile communications. You do not have to be involved with the Osmocom projects in order to attend. Anyone interested in mobile communications protocols is welcome. If you are interested to show up, feel free to do so. There is no registration required. The meeting is free as in "free beer", despite no actual free beer being around. Regards, Harald -- - Harald Welte <laforge(a)gnumonks.org> ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)

8 years, 6 months

1
0
0 0

Help needed with BS11

by Sergey V. Efimov

Hello, One of our BS-11 stations began to behave strangely. I see the following messages during boot-up: PHASE: 1 Load SMU Intended Abis-link: Down PHASE: 2 Load MBCCU MBCCU0: No Load MBCCU1: No Load Abis-link: Down PHASE: 2 Load MBCCU MBCCU0: Load BTSCAC MBCCU1: No Load Abis-link: Down PHASE: 2 Load MBCCU MBCCU0: Load BTSCAC MBCCU1: Load BTSCAC Abis-link: Down PHASE: 2 Load MBCCU MBCCU0: Load BTSCAC MBCCU1: No Load Abis-link: Down It looks like BS tries to load firmware on MBCCU1 and then gives up. I tried to delete and re-create trx1 objects using bs11_config, no result. Tried to reflash BS11, but got software load NACK, and when using —force option the software download process finishes but the boot-up message is the same as above. Does it mean that TRX1 is failed and cannot be used no more? Best Regards, Sergey.

8 years, 6 months

2
1
0 0

Help needed with BS-11

by Sergey V. Efimov

Hello, One of our BS-11 stations began to behave strangely. I see the following messages during boot-up: PHASE: 1 Load SMU Intended Abis-link: Down PHASE: 2 Load MBCCU MBCCU0: No Load MBCCU1: No Load Abis-link: Down PHASE: 2 Load MBCCU MBCCU0: Load BTSCAC MBCCU1: No Load Abis-link: Down PHASE: 2 Load MBCCU MBCCU0: Load BTSCAC MBCCU1: Load BTSCAC Abis-link: Down PHASE: 2 Load MBCCU MBCCU0: Load BTSCAC MBCCU1: No Load Abis-link: Down It looks like BS tries to load firmware on MBCCU1 and then gives up. I tried to delete and re-create trx1 objects using bs11_config, no result. Tried to reflash BS11, but got software load NACK, and when using —force option the software download process finishes but the boot-up message is the same as above. Does it mean that TRX1 is failed and cannot be used no more? Best Regards, Sergey.

8 years, 6 months

1
0
0 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

OpenBSC October 2015