OpenBSC October 2015

openbsc@lists.osmocom.org

17 participants
42 discussions

[PATCH] gtp_duplicate(): comment, add todo.
by Neels Hofmeyr 12 Oct '15

12 Oct '15

--- gtp/gtp.c | 27 +++++++++++++++++---------- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/gtp/gtp.c b/gtp/gtp.c index e6a610d..de6a7b4 100644 --- a/gtp/gtp.c +++ b/gtp/gtp.c @@ -614,6 +614,15 @@ int gtp_notification(struct gsn_t *gsn, int version, return 0; } +/* Look for a message in the response queue for the given peer and sequence + * number seq. If found, (re-)send the response message and return 0. Otherwise + * return nonzero. This allows catching duplicate messages. + * A response message stays in the response queue until it times out. + * So, for any number of identical requests within that timeout period, the + * same packet can be resent. + * TODO this only checks the peer and sequence number, and does not verify that + * the GTP request is identical to the previous one for this peer and sequence + * nr: a mere peer or seq glitch can cause leaks of previous responses. */ int gtp_duplicate(struct gsn_t *gsn, int version, struct sockaddr_in *peer, uint16_t seq) { @@ -873,7 +882,7 @@ int gtp_echo_ind(struct gsn_t *gsn, int version, struct sockaddr_in *peer, int fd, void *pack, unsigned len) { - /* Check if it was a duplicate request */ + /* Repeat previous response in case of duplicate request */ if (!gtp_duplicate(gsn, 0, peer, get_seq(pack))) return 0; @@ -1258,7 +1267,7 @@ int gtp_create_pdp_ind(struct gsn_t *gsn, int version, uint8_t linked_nsapi = 0; struct pdp_t *linked_pdp = NULL; - /* TODO describe what this is all about: */ + /* Repeat previous response in case of duplicate request */ if (!gtp_duplicate(gsn, version, peer, seq)) return 0; @@ -1955,10 +1964,9 @@ int gtp_update_pdp_ind(struct gsn_t *gsn, int version, uint64_t imsi; uint8_t nsapi; - /* Is this a duplicate ? */ - if (!gtp_duplicate(gsn, version, peer, seq)) { - return 0; /* We already sent of response once */ - } + /* Repeat previous response in case of duplicate request */ + if (!gtp_duplicate(gsn, version, peer, seq)) + return 0; /* Decode information elements */ if (gtpie_decaps(ie, version, pack + hlen, len - hlen)) { @@ -2432,10 +2440,9 @@ int gtp_delete_pdp_ind(struct gsn_t *gsn, int version, int n; int count = 0; - /* Is this a duplicate ? */ - if (!gtp_duplicate(gsn, version, peer, seq)) { - return 0; /* We already sent off response once */ - } + /* Repeat previous response in case of duplicate request */ + if (!gtp_duplicate(gsn, version, peer, seq)) + return 0; /* Find the linked context in question */ if (pdp_getgtp1(&linked_pdp, get_tei(pack))) { -- 2.1.4

1 1

Another openggsn cosmetic
by Neels Hofmeyr 12 Oct '15

12 Oct '15

Another addition to the neels/refactor branch, marking a possible problem in gtp.c. ~Neels

1 1

gtphub: End User Address IE
by Neels Hofmeyr 12 Oct '15

12 Oct '15

Hi, I just noticed that the GGSN returns its IP address in a GTP packet about PDP, in the "End User Address" IE (etsi/GSM/by_chapter/29.060.pdf 7.7.27). I'm asking myself whether this needs to be mapped by gtphub. 127.0.0.3 127.0.0.2 SGSN <-------- GTPHUB <--------- GGSN "127.0.0.2" "127.0.0.2" map this? ^ This sounds almost like no mapping is required, as if it tells the MS which IP address it has "as seen from outside": "The PDP Address shall be the address that this PDP context of the MS is identified with from the external packet data network." But I have no idea, really. Does anyone else? If not, we'll just have to see later... Thanks! ~Neels

1 0

next version of OAP patch
by Neels Hofmeyr 12 Oct '15

12 Oct '15

Hi openbsc, here is my improved version of the OAP aka SGSN-ID patch series. This series is pushed to the neels/sgsn-id-3 branch. This version is substantially simpler, because I decided against factoring out the IPA client. Instead, the gprs_gsup_client.c will directly call the OAP API to handle OAP messages. Factoring out the IPA client was not a requirement and taking too much time, and since the name will remain "GSUP client" (to avoid changing the VTY configuration names among other things), it does after all make sense to think of it as: "the GSUP client employs OAP to authenticate" instead of "GSUP and OAP are two separate clients on the IPA wire". The OAP spec has changed. Particularly instead of SRES and Kc, the challenge response now sends XRES only; and the spec now includes an AUTS request (not yet implemented). Going through the changes, I've made a few fixes (like wrong file header comments), and made some changes. The OAP API looks quite different, and now merely returns struct msgb* and lets the caller take care of sending. This time, OAP has its own separate testsuite tests/oap. I have further OAP tests in mind to add; particularly the complete SGSN registration test from the previous patch version is not yet included here. Anyway, the OAP API test has become more comprehensive. Some of the patch mods have come from comments by hfreyther and jerlbeck, other changes were obvious from reviewing the code. I think this time around the patch is much more mature. I hope you agree, if not I'll gladly improve it further, of course :) Thanks for your reviews! ~Neels

2 16

openggsn cosmetics
by Neels Hofmeyr 12 Oct '15

12 Oct '15

These patches fix some things that hurt my eyes. The renames from dublicate to duplicate may theoretically break API compat, but I could find no affected callers. These are not required, feel free to veto... ~Neels

2 5

Oct 15, 8pm / OSMUG: "Running OpenAirInterface"
by Harald Welte 09 Oct '15

09 Oct '15

Hi all! This is an announcement for an "irregular" Berlin Osmocom User Group event. David Rupprecht of Ruhr-Uni Bochum has offered to give us a presentation sharing his experience in Running OpenAirInterface. OpenAirInterface (http://openairinterface.eurecom.fr/) is a project of the Eurecom research institute in Sofia Antipoils / France. For many years they have been working towards an open source SDR LTE implementation. The presentation will be held on Oct 15, 8pm @ IN-Berlin, Lehrter Str. 53, 10557 Berlin (yes, this is _NOT_ CCC Berlin where regular OSMUG meetings are held!) The meeting is open to anyone interested in mobile communications. You do not have to be involved with the Osmocom projects in order to attend. Anyone interested in mobile communications protocols is welcome. If you are interested to show up, feel free to do so. The meeting is "free as in free beer", despite no actual free beer being around ;) More information about the venue can be found at http://www.in-berlin.de/space/ The official event announcement website is http://openbsc.osmocom.org/trac/blog/david-rub-openair-20151015 Regards, Harald -- - Harald Welte <laforge(a)gnumonks.org> ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)

1 1

(no subject)
by Neels Hofmeyr 09 Oct '15

09 Oct '15

Hi openbsc, the following patch series adds a GTP hub program (maturity level: proof-of-concept). Its aim is related to the recent addition of OAP: it will allow routing multiple SGSNs through one GTP server hub (proxy). The program so far forwards UDP packets to and from hardcoded ports, and logs validity of GTP headers passing through. I think this a good time to do a review cycle and merge to master, before adding the interesting stuff. What will follow: decode GTP body, map/separate PDP contexts across clients and servers, replace TEIs. To do that without reinventing the GTP wheel, I may need to separate data parsing from send/recv in openggsn. There are also some bits that should probably be moved out (to where I copied it from) and the API there changed (so that I can use it here without copying). Those are clearly marked with todo comments. Thanks for your review! ~Neels

3 18

[PATCH 1/6] osmux: Test cid allocation and de-allocation
by Holger Hans Peter Freyther 08 Oct '15

08 Oct '15

From: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> * Test that one can get an id * That they are assigned predicatble right now * That returning them will make the number of used ones go down * That allocating more will fail --- openbsc/include/openbsc/osmux.h | 1 + openbsc/src/libmgcp/mgcp_osmux.c | 14 ++++++++++++++ openbsc/tests/mgcp/mgcp_test.c | 26 ++++++++++++++++++++++++++ 3 files changed, 41 insertions(+) diff --git a/openbsc/include/openbsc/osmux.h b/openbsc/include/openbsc/osmux.h index 8c01fd0..0e727d5 100644 --- a/openbsc/include/openbsc/osmux.h +++ b/openbsc/include/openbsc/osmux.h @@ -22,6 +22,7 @@ int osmux_send_dummy(struct mgcp_endpoint *endp); int osmux_get_cid(void); void osmux_put_cid(uint8_t osmux_cid); +int osmux_used_cid(void); enum osmux_state { OSMUX_STATE_DISABLED = 0, diff --git a/openbsc/src/libmgcp/mgcp_osmux.c b/openbsc/src/libmgcp/mgcp_osmux.c index 90b7368..b0ef69f 100644 --- a/openbsc/src/libmgcp/mgcp_osmux.c +++ b/openbsc/src/libmgcp/mgcp_osmux.c @@ -532,6 +532,20 @@ int osmux_send_dummy(struct mgcp_endpoint *endp) /* bsc-nat allocates/releases the Osmux circuit ID */ static uint8_t osmux_cid_bitmap[16]; +int osmux_used_cid(void) +{ + int i, j, used = 0; + + for (i = 0; i < sizeof(osmux_cid_bitmap) / 8; i++) { + for (j = 0; j < 8; j++) { + if (osmux_cid_bitmap[i] & (1 << j)) + used += 1; + } + } + + return used; +} + int osmux_get_cid(void) { int i, j; diff --git a/openbsc/tests/mgcp/mgcp_test.c b/openbsc/tests/mgcp/mgcp_test.c index b2cb938..7b5de31 100644 --- a/openbsc/tests/mgcp/mgcp_test.c +++ b/openbsc/tests/mgcp/mgcp_test.c @@ -1175,6 +1175,31 @@ static void test_no_name(void) talloc_free(cfg); } +static void test_osmux_cid(void) +{ + int id, i; + + OSMO_ASSERT(osmux_used_cid() == 0); + id = osmux_get_cid(); + OSMO_ASSERT(id == 0); + OSMO_ASSERT(osmux_used_cid() == 1); + osmux_put_cid(id); + OSMO_ASSERT(osmux_used_cid() == 0); + + for (i = 0; i < 16; ++i) { + id = osmux_get_cid(); + OSMO_ASSERT(id == i); + OSMO_ASSERT(osmux_used_cid() == i + 1); + } + + id = osmux_get_cid(); + OSMO_ASSERT(id == -1); + + for (i = 0; i < 256; ++i) + osmux_put_cid(i); + OSMO_ASSERT(osmux_used_cid() == 0); +} + int main(int argc, char **argv) { osmo_init_logging(&log_info); @@ -1193,6 +1218,7 @@ int main(int argc, char **argv) test_multilple_codec(); test_no_cycle(); test_no_name(); + test_osmux_cid(); printf("Done\n"); return EXIT_SUCCESS; -- 2.6.0

3 8

Re: Oct 07, 8pm / Osmocom Berlin User Group meeting
by Harald Welte 06 Oct '15

06 Oct '15

Hi Nico, [responding to the openbsc list, as it is more applicable than baseband-devel] On Sun, Oct 04, 2015 at 01:59:41PM +0200, Nico Golde wrote: > For those interested... is there any code for osmo-iuh already available > somewhere? I don't see it on git.osmocom.org. it is not yet published, I would like to do that at the date of the event itself. It will be on git.osmocom.org. The actual core HNBAP/RUA code is already there. Next is the plan on how to integrate with the existing OsmoNITB. Somehow the A interface code needs to be abstracted out, so that a subscriber_connection can either be served by an A or by an IuCS interface. Another step currently needed is UMTS AKA in the NITB. Once the above two problem areas are adressed, we should have a solution that works at least for signalling (LU, SMS, USSD,...). -- - Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)

1 1

Oct 07, 8pm / Osmocom Berlin User Group meeting
by Harald Welte 03 Oct '15

03 Oct '15

Hi all! This is the announcement for the re-incarnated Osmocom Berlin meeting: Oct 7, 8pm @ CCC Berlin, Marienstr. 11, 10117 Berlin Harald will be presenting about the Iuh protocol stack of UMTS small cells / femtocells and his work towards implementing it as part of Osmocom. Agenda: 20:00h Welcome 20:15h Presentation about Iuh / osmo-iuh 21:00h Informal meeting / chatting The meeting is open to anyone interested in mobile communications. You do not have to be involved with the Osmocom projects in order to attend. Anyone interested in mobile communications protocols is welcome. If you are interested to show up, feel free to do so. There is no registration required. The meeting is free as in "free beer", despite no actual free beer being around. Regards, Harald -- - Harald Welte <laforge(a)gnumonks.org> ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

OpenBSC October 2015