OpenBSC March 2015

openbsc@lists.osmocom.org

10 participants
12 discussions

[PATCH 0/4] core/conv: Fast Viterbi decoding

by Thomas Tsou

Hi all, This patch set adds to libosmocore an optimized Viterbi decodeer for architecture specific (Intel SSE) and non-specific cases. The implementation covers codes with constraint lengths of K=5 and K=7 and rates 1/4 to 3/4, which make up the majority of GSM use cases. Speedup from the current implementation is in the range of 5 to 20 depending on the processor and code type. API is unchanged. Tested on Haswell (i7-4770K) and Atom (D2550). Additional test codes from osmo-bts are included. Further tests for AWGN bit-error-rate and benchmarks can be found in the following repository. https://github.com/ttsou/osmo-conv-test Here are some examples. Bit error test for GPRS CS2 with SNR of 5 dB and 100000 bursts. $ ./conv_test -c 2 -e -r 5 -i 100000 ================================================= [+] Testing: GPRS CS2 [.] Specs: (N=2, K=5, non-recursive, flushed, not punctured) [.] Input length : ret = 290 exp = 290 -> OK [.] Output length : ret = 588 exp = 588 -> OK [.] BER tests: [..] Testing base: [..] Input BER.......................... 0.042443 [..] Output BER......................... 0.000006 [..] Output FER......................... 0.001350 (135) [..] Testing SIMD: [..] Input BER.......................... 0.042460 [..] Output BER......................... 0.000005 [..] Output FER......................... 0.001240 (124) Timed AFS benchmark with 8 threads and 100000 bursts per thread. $ ./conv_test -b -c 10 -j 8 -i 100000 ================================================= [+] Testing: GSM TCH/AFS 6.7 [.] Specs: (N=4, K=5, recursive, flushed, punctured) [.] Input length : ret = 140 exp = 140 -> OK [.] Output length : ret = 448 exp = 448 -> OK [.] Performance benchmark: [..] Encoding / Decoding 800000 bursts on 8 thread(s): [..] Testing base: [..] Elapsed time....................... 4.320001 secs [..] Rate............................... 25.925920 Mbps [..] Testing SIMD: [..] Elapsed time....................... 0.458272 secs [..] Rate............................... 244.396341 Mbps [..] Speedup............................ 9.426718 -TT

7 years, 11 months

[PATCH] Use generic auth API

by Max

Signed-off-by: Max <max.suraev(a)fairwaves.co> --- openbsc/src/libmsc/auth.c | 69 +++++++++++++++++++---------------------------- 1 file changed, 28 insertions(+), 41 deletions(-) diff --git a/openbsc/src/libmsc/auth.c b/openbsc/src/libmsc/auth.c index 10d8edf..d04b2fc 100644 --- a/openbsc/src/libmsc/auth.c +++ b/openbsc/src/libmsc/auth.c @@ -24,47 +24,11 @@ #include <openbsc/debug.h> #include <openbsc/auth.h> #include <openbsc/gsm_data.h> - -#include <osmocom/gsm/comp128.h> +#include <osmocom/crypt/auth.h> #include <stdlib.h> -static int -_use_xor(struct gsm_auth_info *ainfo, struct gsm_auth_tuple *atuple) -{ - int i, l = ainfo->a3a8_ki_len; - - if ((l > A38_XOR_MAX_KEY_LEN) || (l < A38_XOR_MIN_KEY_LEN)) { - LOGP(DMM, LOGL_ERROR, "Invalid XOR key (len=%d) %s\n", - ainfo->a3a8_ki_len, - osmo_hexdump(ainfo->a3a8_ki, ainfo->a3a8_ki_len)); - return -1; - } - - for (i=0; i<4; i++) - atuple->sres[i] = atuple->rand[i] ^ ainfo->a3a8_ki[i]; - for (i=4; i<12; i++) - atuple->kc[i-4] = atuple->rand[i] ^ ainfo->a3a8_ki[i]; - - return 0; -} - -static int -_use_comp128_v1(struct gsm_auth_info *ainfo, struct gsm_auth_tuple *atuple) -{ - if (ainfo->a3a8_ki_len != A38_COMP128_KEY_LEN) { - LOGP(DMM, LOGL_ERROR, "Invalid COMP128v1 key (len=%d) %s\n", - ainfo->a3a8_ki_len, - osmo_hexdump(ainfo->a3a8_ki, ainfo->a3a8_ki_len)); - return -1; - } - - comp128(ainfo->a3a8_ki, atuple->rand, atuple->sres, atuple->kc); - - return 0; -} - /* Return values * -1 -> Internal error * 0 -> Not available @@ -76,6 +40,11 @@ int auth_get_tuple_for_subscr(struct gsm_auth_tuple *atuple, { struct gsm_auth_info ainfo; int i, rc; + static struct osmo_sub_auth_data auth = { + .type = OSMO_AUTH_TYPE_GSM + }; + struct osmo_auth_vector _vec; + struct osmo_auth_vector *vec = &_vec; /* Get subscriber info (if any) */ rc = db_get_authinfo_for_subscr(&ainfo, subscr); @@ -109,13 +78,23 @@ int auth_get_tuple_for_subscr(struct gsm_auth_tuple *atuple, return 0; case AUTH_ALGO_XOR: - if (_use_xor(&ainfo, atuple)) - return 0; + auth.algo = OSMO_AUTH_ALG_XOR; + if ((ainfo.a3a8_ki_len > A38_XOR_MAX_KEY_LEN) || (ainfo.a3a8_ki_len < A38_XOR_MIN_KEY_LEN)) { + LOGP(DMM, LOGL_ERROR, "Invalid XOR key (len=%d) %s\n", + ainfo.a3a8_ki_len, + osmo_hexdump(ainfo.a3a8_ki, ainfo.a3a8_ki_len)); + return -1; + } break; case AUTH_ALGO_COMP128v1: - if (_use_comp128_v1(&ainfo, atuple)) - return 0; + auth.algo = OSMO_AUTH_ALG_COMP128v1; + if (ainfo.a3a8_ki_len != A38_COMP128_KEY_LEN) { + LOGP(DMM, LOGL_ERROR, "Invalid COMP128v1 key (len=%d) %s\n", + ainfo.a3a8_ki_len, + osmo_hexdump(ainfo.a3a8_ki, ainfo.a3a8_ki_len)); + return -1; + } break; default: @@ -124,6 +103,14 @@ int auth_get_tuple_for_subscr(struct gsm_auth_tuple *atuple, return 0; } + memcpy(auth.u.gsm.ki, ainfo.a3a8_ki, sizeof(auth.u.gsm.ki)); + + if (osmo_auth_gen_vec(vec, &auth, atuple->rand) < 0) + return -1; + + memcpy(atuple->sres, vec->sres, 4); + memcpy(atuple->kc, vec->kc, 8); + db_sync_lastauthtuple_for_subscr(atuple, subscr); DEBUGP(DMM, "Need to do authentication and ciphering\n"); -- 1.9.1

8 years, 10 months

recurring issue with OpenBSC

by Ciaby

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Hi! First a small update: we finally decided to _not_ use token mode, as it confuses a lot of phones, after receiving the token message the SIM goes into an error state and the only way to recover is to reboot the phone. Now we just read the IMSI straight from the SIM (using the card python library, just like osmo-sim-auth does) and register them. Now, the issue we see is that 1-2 users every day reach a point where they can make phone calls and send messages, but they can't receive neither of them. Sometimes the problem can be fixed by running: > subscriber extension <EXT> clear-requests but this only work when there are pending requests. In other cases, the phone has to be rebooted. Did anyone encounter the same issue? Cheers Ciaby -----BEGIN PGP SIGNATURE----- iQIcBAEBCgAGBQJUef1WAAoJEPU83OtbD4fQ69kQAI7peg30lHwbDPMXnTX80gUu 0dGsiK2iB5oWZ6Ohbs3W+/+xVoMseuG1di6Rk0XT9buN2IOR5fMfAs3INQ2EuAlV qz1RRn5Ux8uV0RJWyAJoSt7eFh3gbnDgsJ+x8SXEHQRw4rYHG2P+HXyEtncW6A6y L8/oPeIxH/LlP/55MP3KUY5BnQmN658LnJU9AFSwPkpjn2f/dj4o6mUdWo8haTTQ UWPWEdhQoeXPBqHsn2cKamT13SmiepMYAGuDEJci9LCS+J8vd70ukAP/oa1L6u1w +3+RbcNvC9fwAKDLU01b/cu630v6/mhk0lxWNlIz/kNL1aHPZe8QhP5sM4SuLtzj UaeHLxp4u2Pb7N31b3qtRA4jgl+5YFla5376F3d00jPSfZpmFggFgdRB2qWhF1m8 WucfzLc41dV1AVTdL90ISSRt1LZ/fLHBea8kgUxK+KrhBO7U7AV3PXk9of4EAf7y VKMX3KZWwtEKhpi0v3PihgW8bS/RaG3zEmsr30QXzXVaZknCfjGi8OOOB0JaHY48 o3g40YpzeyEq1gOyKKfBmtf1qk4GgLyPKfMUoTvXE2oNHmrg3ZlJldABKNzR9qz3 5hsHJ6/QGsBST1E3dphI0Zb6ubLnFwqBl02GyeJELLbtPCLPQMDicx03cqT4BjO3 vzDcPdIWg1sfSomYKMK9 =Zw4T -----END PGP SIGNATURE-----

9 years

[PATCH 1/1] Loggingrb: Build and fix the testcase

by Mike McTernan (wavemobile)

The loggingrb (ringbuffer) testcase was not actually being built and ran; instead the makefile called the normal logging test for a second time. This patch fixes Makefile.am to build the correct files, then the loggingrb testcase is fixed to use the current loggingrb API so that it builds and passes. Signed-off-by: Michael McTernan <Mike.McTernan(a)wavemobile.com> --- tests/Makefile.am | 2 +- tests/loggingrb/loggingrb_test.c | 11 +++++------ 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 2c80063..0bf0c43 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -78,7 +78,7 @@ logging_logging_test_LDADD = $(top_builddir)/src/libosmocore.la fr_fr_test_SOURCES = fr/fr_test.c fr_fr_test_LDADD = $(top_builddir)/src/libosmocore.la $(top_builddir)/src/gb/libosmogb.la $(LIBRARY_DL) -loggingrb_loggingrb_test_SOURCES = logging/logging_test.c +loggingrb_loggingrb_test_SOURCES = loggingrb/loggingrb_test.c loggingrb_loggingrb_test_LDADD = $(top_builddir)/src/libosmocore.la $(top_builddir)/src/vty/libosmovty.la strrb_strrb_test_SOURCES = strrb/strrb_test.c diff --git a/tests/loggingrb/loggingrb_test.c b/tests/loggingrb/loggingrb_test.c index 9957b53..ebc0181 100644 --- a/tests/loggingrb/loggingrb_test.c +++ b/tests/loggingrb/loggingrb_test.c @@ -21,8 +21,7 @@ #include <osmocom/core/logging.h> #include <osmocom/core/utils.h> -#include <osmocom/core/ringb.h> -#include <osmocom/vty/logging_rbvty.h> +#include <osmocom/core/loggingrb.h> enum { DRLL, @@ -61,7 +60,7 @@ int main(int argc, char **argv) struct log_target *ringbuf_target; log_init(&log_info, NULL); - ringbuf_target = log_target_create_rbvty(NULL, 0x1000); + ringbuf_target = log_target_create_rb(0x1000); log_add_target(ringbuf_target); log_set_all_filter(ringbuf_target, 1); log_set_print_filename(ringbuf_target, 0); @@ -74,9 +73,9 @@ int main(int argc, char **argv) DEBUGP(DRLL, "You should see this\n"); DEBUGP(DCC, "You should see this\n"); DEBUGP(DMM, "You should not see this\n"); - fprintf(stderr, ringbuffer_get_nth(ringbuf_target->tgt_rbvty.rb, 0)); - fprintf(stderr, ringbuffer_get_nth(ringbuf_target->tgt_rbvty.rb, 1)); - OSMO_ASSERT(!ringbuffer_get_nth(ringbuf_target->tgt_rbvty.rb, 2)); + fprintf(stderr, log_target_rb_get(ringbuf_target, 0)); + fprintf(stderr, log_target_rb_get(ringbuf_target, 1)); + OSMO_ASSERT(!log_target_rb_get(ringbuf_target, 2)); return 0; } -- 1.8.3.1

9 years

patches4review

by ☎

Hi. As a follow-up on today's discussion here are the links to patches I'd like to get reviewed and merged: http://patchwork.ozlabs.org/patch/400499/ http://patchwork.ozlabs.org/patch/402147/ Also, would be nice to get patchwork subscribed back to ML. -- best regards, Max, http://fairwaves.co

9 years

Patch to add index to SMS table

by Alexander Nikolaev

Hi, I would like to introduce new index for the SMS table. I've run benchmarks using test database with about 8500 records in both SMS and Subscriber tables. Introducing SMS(dest_addr) index reduces execution time 4 times for this benchmark. As far as I can see, db_sms_get_unsent() gets called frequently, so real-life benefits might also be considerable, especially for the large datasets. Patch: https://gist.github.com/ati/5ef481954f5bd38d00fc SQL queries benchmark script (python): https://gist.github.com/ati/bd03be698a89e24d8a89 Regards, Alexander

9 years

[PATCH] ignore debian build byproducts

by Max

Signed-off-by: Max <max.suraev(a)fairwaves.co> --- .gitignore | 1 + openbsc/.gitignore | 1 + 2 files changed, 2 insertions(+) create mode 100644 .gitignore diff --git a/.gitignore b/.gitignore new file mode 100644 index 0000000..89bf7df --- /dev/null +++ b/.gitignore @@ -0,0 +1 @@ +debian/*.log diff --git a/openbsc/.gitignore b/openbsc/.gitignore index 58885b9..2210c47 100644 --- a/openbsc/.gitignore +++ b/openbsc/.gitignore @@ -56,6 +56,7 @@ src/gprs/osmo-gbproxy src/osmo-bsc_nat/osmo-bsc_nat #tests +tests/testsuite.dir tests/bsc-nat/bsc_nat_test tests/bsc-nat-trie/bsc_nat_trie_test tests/channel/channel_test -- 2.1.0

9 years

Final review of L1SAP ported to current maste

by Harald Welte

Dear all, the valuable L1SAP abstraction has been sitting out of master for too long time. It is a pity that this has taken so long. I've finally been able to put some time into osmo-bts again and reviewed the following patch series. It consists of mostly Andreas' work, interspersed with smaller patches/fixups that I introduced after the respective original patch from Andreas. I have started a sysmobts between all of the major steps in this patch series and did a short manual tests involving registration (LU) of two MS, mobile-to-mobile call and vty-to-mobile SMS. So far I couldn't see any problems. What has not been tested yet is the PCU interface as well as encryption support. I plan to do this later this week. I intend to merge the code after this current review cycle. Please take your time to have a look and provide feedback (if any), so we can get this over and work on new features again, rather than infrastrutural changes. I didn't yet rebase the osmo-bts-trx interface on top of the L1SAP, as I don't have a hardware setup for it, and I will leave it to the owners of such hardware to publish/push the respective code after L1SAP is merged. Regards, Harald -- - Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)

9 years

Error - Installating libosmo-abis

by Amber and Sarosh

Hi, I am trying to configure and run OsmoTRX,OsmoBTS, OsmoNITB and LCR as per instructions at ; http://openbsc.osmocom.org/trac/wiki/network_from_scratch After installation of libosmocore when i run ./configure in libosmo-abis-master , I get the error below every time. Please note that I have installed libosmocore-0.6.0 but some how even while running pkg-config --modversion libosmocore command the version is reported as having value of UNKNOWN. I have also set the path of PKG_CONFIG_PATH correctly where the file libosmocore.pc is actually located but still this error is seen. checking if gcc supports -fvisibility=hidden... yes checking for pkg-config... /usr/bin/pkg-config checking pkg-config is at least version 0.9.0... yes checking for LIBOSMOCORE... no configure: error: Package requirements (libosmocore >= 0.3.0) were not met: Requested 'libosmocore >= 0.3.0' but version of Osmocom Core Library is UNKNOWN Consider adjusting the PKG_CONFIG_PATH environment variable if you installed software in a non-standard prefix. Alternatively, you may set the environment variables LIBOSMOCORE_CFLAGS and LIBOSMOCORE_LIBS to avoid the need to call pkg-config. See the pkg-config man page for more details. Please help me in this regard. Regards, Sarosh

9 years

[PATCH 1/3] logging: Implement subsecond resolution of extended timestamps

by Jacob Erlbeck

Currently when using 'logging print extended-timestamp 1', the subsecond part (milliseconds) of the printed timestamp is always 0. This makes it difficult to correlate log entries with PCAP file entries if there are many of them per second. This patch changes _output in logging.c to use gettimeofday() instead of time() when extended timestamps are enabled and replaces the '000' by the milliseconds computed from tv_usec. Sponsored-by: On-Waves ehf --- src/logging.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/logging.c b/src/logging.c index c007a45..20b0596 100644 --- a/src/logging.c +++ b/src/logging.c @@ -38,6 +38,7 @@ #include <strings.h> #endif #include <time.h> +#include <sys/time.h> #include <errno.h> #include <osmocom/core/talloc.h> @@ -254,11 +255,13 @@ static void _output(struct log_target *target, unsigned int subsys, if (!cont) { if (target->print_ext_timestamp) { struct tm tm; - time_t timep = time(NULL); - localtime_r(&timep, &tm); - ret = snprintf(buf + offset, rem, "%04d%02d%02d%02d%02d%02d000 ", + struct timeval tv; + gettimeofday(&tv, NULL); + localtime_r(&tv.tv_sec, &tm); + ret = snprintf(buf + offset, rem, "%04d%02d%02d%02d%02d%02d%03d ", tm.tm_year + 1900, tm.tm_mon + 1, tm.tm_mday, - tm.tm_hour, tm.tm_min, tm.tm_sec); + tm.tm_hour, tm.tm_min, tm.tm_sec, + (int)(tv.tv_usec / 1000)); if (ret < 0) goto err; OSMO_SNPRINTF_RET(ret, rem, offset, len); -- 1.9.1

9 years, 1 month

Cannot build libosmocore git master for debian 7.8

by Stephen Groat

I'm trying to make a Docker image to install network in a box and am having some trouble getting libosmocore to build. >From a base debian image, I'm running apt-get update && apt-get -y upgrade && apt-get -y install wget libopencore-amrwb0 libopencore-amrnb0 libortp8 libortp-dev libopencore-amrnb-dev libopencore-amrwb-dev sqlite3 libdbi-dev libdbi1 libdbd-sqlite3 git build-essential automake libtool libpcsclite1 libpcsclite-dev then: git clone git://git.osmocom.org/libosmocore.git cd libosmocore autoreconf -i ./configure The error I'm currently getting is: checking whether struct tm has tm_gmtoff member... yes ./configure: line 12023: syntax error near unexpected token `PCSC,' ./configure: line 12023: ` PKG_CHECK_MODULES(PCSC, libpcsclite)' Any advice? Thanks, Stephen

9 years, 1 month

AMR support in osmo-nitb

by Ciaby

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Hi, I'm trying to get AMR to work (in TCH/F mode) on osmo-nitb. LCR is compiled with the correct codecs, but looking at the MNCC traffic I only get GSM FR coming from the osmo-nitb side. I already set this in osmo-nitb.cfg: mncc-int default-codec tch-f amr default-codec tch-h amr Any clue about this? Cheers Ciaby -----BEGIN PGP SIGNATURE----- iQIcBAEBCgAGBQJU/3IvAAoJEPU83OtbD4fQmOMP/i46E//ide5JlScpZsN5oVCA u1cYIihZLpHPfKiGYhIp+A7/zX0FQpgiVKYh0n8A58H4UvF9wxG9ZZmX5B9D02aW 8eexmH5jeOAHj7YlHGPl0dK2RAOYie43kFevftPco21o7QmsylZ9+Z1lWn6OREDn R1Mix39wqq0feXxfhaMq/Y5j9XCjGOUS7FXDtuaCjlUANBcmp45WfXwhbwVfeLzX vTwHZ0mfQQ4Uyln8Y1gZL6MdF2WqHYEWND+qB6Aj+QKMLAeFr8yq5hapfev+PKwC kK4MoSJwW2aUi2TGuZqOZM9daJn7BhVfjf56TycyAMTHP3sJSNJKJ8vEzCUZy1ir CmSVe3m+C3QOBVRzbUYR0/sTBJ11+WcNdOMnM4sJCdz1guTzzMMjj4U3RKcMalaj KaqEsdBrpvQ+MRcE07aaRU/wm4ZG89r/enEmyqtIIzKVzJBgjyeZFQw0I5ca9TKA DNgwjcQ3FmHt4iAkDLbQK9OX3fkCcAkmC56bOKl1V16Es9fknrtadRGsLf9a2SzI B1sfVbfjZQ9r7Tag1cv6CUv0NcDK1BNs7VOxSvABFkkAjllbcy1j3HF0H2pMfPqo 3bOJXZ0N4a887lYae7ltPB4IGN9eHBVQwoQCA1yW1xL9AQtRuIiMQuFmodfSH7ij EHzL0rIjViIlxKzJGyDK =Fin+ -----END PGP SIGNATURE-----

9 years, 1 month

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

OpenBSC March 2015