OpenBSC

openbsc@lists.osmocom.org

4315 discussions

Re: bssgp test
by Jacob Erlbeck 08 Jul '15

08 Jul '15

Hi On 05.06.2015 15:15, ☎ wrote: > Could you perhaps summarize what's happening around tests/gb/gprs_bssgp_test.c:229? The line before the failing test is rc = bssgp_tx_fc_bvc(&bctx, tag, bmax, rate, bmax_ms, rate_ms, NULL, NULL); The bssgp_tx_fc_bvc function will in general call gprs_ns_sendmsg -> gprs_ns_tx -> nsip_sendmsg -> sendto. The sendto function had been "replaced" by redefining it locally which worked at least with the default ld up to ubuntu 14.04. (see Holger's replies). The system's sendto will fail in the test, since the UDP socket has not been configured. The local replacement (see gprs_bbsgp_test.c:37) will call fprintf(stderr, "MESSAGE to 0x%08x, msg length %d\n%s\n", dest_host, len, osmo_hexdump(buf, len)); so you just need to look into the stderr output to see, whether this is a linker issue. If yes, the issue will appear in more test programs, since that pattern has been used many times. If there is no way to trick the linker to use the "old" behaviour, those test programs will have to be changed to use another mocking mechanism, e.g. by using the --wrap feature (if it is supported by the linker), see openbsc:openbsc/tests/sgsn/sgsn_test.c. HTH Jacob > > The test fails for me (and another person with ubuntu 15.04 x86_64) on OSMO_ASSERT(rc >> = 0); > > This is 100% reproducible but I don't know much about Gb part so I'm not sure how to > track this down properly. Any ideas/advices? > -- - Jacob Erlbeck <jerlbeck(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschaeftsfuehrer / Managing Directors: Holger Freyther, Harald Welte

3 4

Re: segfault on bssgp test
by ☎ 06 Jul '15

06 Jul '15

Pardon for multiple copies, but this is really curious: gbprocy test also fails for me during OpenBSC build at gbproxy_test.c:1922 which also contains following misterious comment: /* TODO: The following breaks with the current libosmocore, enable it * again (and remove the plain expect_msg), when the msgb_bssgph patch * is integrated */ What is the status of this "msgb_bssgph patch" patch? Is there patchwork link available? I suspect it's still unmerged because swapping the lines as instructed in comment still results in crash with the latest libosmocore from git. Commenting out both lines produce sane-looking output but the test expectedly fails due to mismatch with expected output. I wonder if should comment out the 2nd line until the libosmocore patch is merged or perhaps consider merging the necessary patch? 22.05.2015 15:38, ☎ пишет: > Hi. > > Anyone else experienced this with latest libosmocore from git? > > ./testsuite.at:124: $abs_top_builddir/tests/gb/gprs_bssgp_test > stderr: > MESSAGE to 0x7f0000ff, msg length 12 > 02 00 81 01 01 82 0b 56 04 82 0b 55 > All NS-VCs for NSEI 2901 are either dead or blocked! > All NS-VCs for NSEI 2901 are either dead or blocked! > BSSGP BVCI=0 Rx BVC STATUS, cause=Protocol error - unspecified > BSSGP BVCI=1234 Rx BVC STATUS, cause=Unknown BVCI > NSEI=2901/BVCI=2989 Cannot handle PDU type 34 for unknown BVCI, NS BVCI 2989 > Unable to resolve NSEI 4660 to NS-VC! > Assert failed rc >= 0 gb/gprs_bssgp_test.c:229 > /home/user/source/libosmocore/tests/testsuite.dir/at-groups/19/test-source: line 25: > 8497 Aborted (core dumped) $abs_top_builddir/tests/gb/gprs_ > bssgp_test > -- best regards, Max, http://fairwaves.co

2 6

[PATCH 1/4] sms: Move the routing of the sms to a separate function
by Holger Hans Peyer Freyther 06 Jul '15

06 Jul '15

From: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> The "default-route" for SMPP will be used after a local subscriber look-up. Sometimes we want to route everything to SMPP. Make this possible by changing this routine. --- openbsc/src/libmsc/gsm_04_11.c | 89 ++++++++++++++++++++++++------------------ 1 file changed, 50 insertions(+), 39 deletions(-) diff --git a/openbsc/src/libmsc/gsm_04_11.c b/openbsc/src/libmsc/gsm_04_11.c index 1b2a42c..0150de6 100644 --- a/openbsc/src/libmsc/gsm_04_11.c +++ b/openbsc/src/libmsc/gsm_04_11.c @@ -277,6 +277,55 @@ static int gsm340_gen_sms_deliver_tpdu(struct msgb *msg, struct gsm_sms *sms) return msg->len - old_msg_len; } +int sms_route_mt_sms(struct gsm_subscriber_connection *conn, struct msgb *msg, + struct gsm_sms *gsms, uint8_t sms_mti) +{ + int rc; + + /* determine gsms->receiver based on dialled number */ + gsms->receiver = subscr_get_by_extension(conn->bts->network->subscr_group, + gsms->dst.addr); + if (!gsms->receiver) { +#ifdef BUILD_SMPP + rc = smpp_try_deliver(gsms, conn); + if (rc == 1) { + rc = 1; /* cause 1: unknown subscriber */ + osmo_counter_inc(conn->bts->network->stats.sms.no_receiver); + } else if (rc < 0) { + rc = 21; /* cause 21: short message transfer rejected */ + /* FIXME: handle the error somehow? */ + } +#else + rc = 1; /* cause 1: unknown subscriber */ + osmo_counter_inc(conn->bts->network->stats.sms.no_receiver); +#endif + goto out; + } + + switch (sms_mti) { + case GSM340_SMS_SUBMIT_MS2SC: + /* MS is submitting a SMS */ + rc = gsm340_rx_sms_submit(msg, gsms); + break; + case GSM340_SMS_COMMAND_MS2SC: + case GSM340_SMS_DELIVER_REP_MS2SC: + LOGP(DLSMS, LOGL_NOTICE, "Unimplemented MTI 0x%02x\n", sms_mti); + rc = GSM411_RP_CAUSE_IE_NOTEXIST; + break; + default: + LOGP(DLSMS, LOGL_NOTICE, "Undefined MTI 0x%02x\n", sms_mti); + rc = GSM411_RP_CAUSE_IE_NOTEXIST; + break; + } + + if (!rc && !gsms->receiver) + rc = GSM411_RP_CAUSE_MO_NUM_UNASSIGNED; + +out: + return rc; +} + + /* process an incoming TPDU (called from RP-DATA) * return value > 0: RP CAUSE for ERROR; < 0: silent error; 0 = success */ static int gsm340_rx_tpdu(struct gsm_subscriber_connection *conn, struct msgb *msg) @@ -392,45 +441,7 @@ static int gsm340_rx_tpdu(struct gsm_subscriber_connection *conn, struct msgb *m /* FIXME: This looks very wrong */ send_signal(0, NULL, gsms, 0); - /* determine gsms->receiver based on dialled number */ - gsms->receiver = subscr_get_by_extension(conn->bts->network->subscr_group, - gsms->dst.addr); - if (!gsms->receiver) { -#ifdef BUILD_SMPP - rc = smpp_try_deliver(gsms, conn); - if (rc == 1) { - rc = 1; /* cause 1: unknown subscriber */ - osmo_counter_inc(conn->bts->network->stats.sms.no_receiver); - } else if (rc < 0) { - rc = 21; /* cause 21: short message transfer rejected */ - /* FIXME: handle the error somehow? */ - } -#else - rc = 1; /* cause 1: unknown subscriber */ - osmo_counter_inc(conn->bts->network->stats.sms.no_receiver); -#endif - goto out; - } - - switch (sms_mti) { - case GSM340_SMS_SUBMIT_MS2SC: - /* MS is submitting a SMS */ - rc = gsm340_rx_sms_submit(msg, gsms); - break; - case GSM340_SMS_COMMAND_MS2SC: - case GSM340_SMS_DELIVER_REP_MS2SC: - LOGP(DLSMS, LOGL_NOTICE, "Unimplemented MTI 0x%02x\n", sms_mti); - rc = GSM411_RP_CAUSE_IE_NOTEXIST; - break; - default: - LOGP(DLSMS, LOGL_NOTICE, "Undefined MTI 0x%02x\n", sms_mti); - rc = GSM411_RP_CAUSE_IE_NOTEXIST; - break; - } - - if (!rc && !gsms->receiver) - rc = GSM411_RP_CAUSE_MO_NUM_UNASSIGNED; - + rc = sms_route_mt_sms(conn, msg, gsms, sms_mti); out: sms_free(gsms); -- 2.3.5

1 3

Sending '?' SMS Through VTY and Silent-SMS
by Ma Ma 03 Jul '15

03 Jul '15

Hi everyone, I was just wondering if it is possible to send '?' SMS through the VTY. I was also wondering if someone could provide an example on how to send a silent-sms, whenever I try to send one i get disconnected from the VTY. Regards, Mike

1 0

Random nanoBTS reboot
by Pierre Kim 28 Jun '15

28 Jun '15

Hello, I've been experiencing this bug ever since I started experimenting with OpenBSC. At first I thought it as a problem with unstable connection, but it continued to happen even after I connected to the nanoBTS directly through a switch. I used Wireshark to track down the cause and discovered that OpenBSC was responding too late to PING message from the nanoBTS. I am attaching the pcap file of the moment. This happens as soon as 1 hour from the first connection, sometimes it runs okay for 18 hours but I've never seen my nanoBTS running straight for more than 24hrs Please take a look into the log. Any help will be greatly appreciated. Tell me in case if you need more information Regards, Pierre Following is the log from openbsc console. Sat Jun 27 03:24:43 2015 <0004> bsc_init.c:286 bootstrapping RSL for BTS/TRX (0/0) on ARFCN 520 using MCC=450 MNC=9 LAC=1 CID=0 BSIC=63 TSC=7 Sat Jun 27 08:17:39 2015 <001a> ipa.c:246 Cannot send PING message. Reason: Broken pipe Sat Jun 27 08:17:39 2015 <001a> input/ipaccess.c:110 Unexpected return from ipa_ccm_rcvmsg_base (ret=-32) Sat Jun 27 08:17:39 2015 <001a> input/ipaccess.c:236 Sign link vanished, dead socket Sat Jun 27 08:17:39 2015 <001a> input/ipaccess.c:69 Forcing socket shutdown with no signal link set Sat Jun 27 08:20:51 2015 <001a> input/ipa.c:265 accept()ed new link from 192.168.28.31 to port 3002 Sat Jun 27 08:21:08 2015 <001a> input/ipa.c:265 accept()ed new link from 192.168.28.31 to port 3003 Sat Jun 27 08:21:11 2015 <0004> bsc_init.c:286 bootstrapping RSL for BTS/TRX (0/0) on ARFCN 520 using MCC=450 MNC=9 LAC=1 CID=0 BSIC=63 TSC=7 and sometimes without the error from ipa_ccm_rcvmsg_base Sun Jun 28 09:17:40 2015 <001a> input/ipaccess.c:236 Sign link vanished, dead socket Sun Jun 28 09:17:40 2015 <001a> input/ipaccess.c:69 Forcing socket shutdown with no signal link set Sun Jun 28 09:20:39 2015 <001a> input/ipa.c:265 accept()ed new link from 192.168.28.31 to port 3002 Sun Jun 28 09:20:56 2015 <001a> input/ipa.c:265 accept()ed new link from 192.168.28.31 to port 3003 Sun Jun 28 09:20:59 2015 <0004> bsc_init.c:286 bootstrapping RSL for BTS/TRX (0/0) on ARFCN 520 using MCC=450 MNC=9 LAC=1 CID=0 BSIC=63 TSC=7

1 0

NanoBTS for sale?
by brogan.tom.iii＠gmail.com 26 Jun '15

26 Jun '15

I would like to know if anyone has a Nanobts for sale hopefully under 500$. I'm looking for the 900MHz or 1800MHz ones, preferably the ones with SMA antenna connectors (the white square ones) without internal antennas. Doesn't matter if they are used/old/new, just something that works without issues :)

1 0

[PATCH 2/2] libbsc: Update a BTS's SIs when ms_max_power is changed from VTY.
by Alexander Chemeris 24 Jun '15

24 Jun '15

Otherwise you have to restart BTS or at least break the RSL connection to apply the change. -- Regards, Alexander Chemeris. CEO, Fairwaves, Inc. https://fairwaves.co

3 7

[PATCH] bssgp: Fix IMSI buffer size (Coverity)
by Jacob Erlbeck 19 Jun '15

19 Jun '15

Currently the size of the IMSI pointer is used instead of the size of the talloc'ed buffer. This commit changes the call to gsm48_mi_to_string to use the same value that has been used with talloc_zero_size(). The length is changed to 17 since that value is used for GSM_IMSI_LENGTH in openbsc. Fixes: Coverity CID 1040663 Sponsored-by: On-Waves ehf --- src/gb/gprs_bssgp_bss.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gb/gprs_bssgp_bss.c b/src/gb/gprs_bssgp_bss.c index 962bf2e..3a9012e 100644 --- a/src/gb/gprs_bssgp_bss.c +++ b/src/gb/gprs_bssgp_bss.c @@ -34,6 +34,8 @@ #include "common_vty.h" +#define GSM_IMSI_LENGTH 17 + uint8_t *bssgp_msgb_tlli_put(struct msgb *msg, uint32_t tlli) { uint32_t _tlli = htonl(tlli); @@ -498,8 +500,8 @@ int bssgp_rx_paging(struct bssgp_paging_info *pinfo, if (!TLVP_PRESENT(&tp, BSSGP_IE_IMSI)) goto err_mand_ie; if (!pinfo->imsi) - pinfo->imsi = talloc_zero_size(pinfo, 16); - gsm48_mi_to_string(pinfo->imsi, sizeof(pinfo->imsi), + pinfo->imsi = talloc_zero_size(pinfo, GSM_IMSI_LENGTH); + gsm48_mi_to_string(pinfo->imsi, GSM_IMSI_LENGTH, TLVP_VAL(&tp, BSSGP_IE_IMSI), TLVP_LEN(&tp, BSSGP_IE_IMSI)); -- 1.9.1

2 1

[PATCH] bssgp/test: Add missing START/END printfs
by Jacob Erlbeck 18 Jun '15

18 Jun '15

Sponsored-by: On-Waves ehf --- tests/gb/gprs_bssgp_test.c | 7 ++++++- tests/gb/gprs_bssgp_test.ok | 2 ++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/tests/gb/gprs_bssgp_test.c b/tests/gb/gprs_bssgp_test.c index 63abf8b..14ba4d1 100644 --- a/tests/gb/gprs_bssgp_test.c +++ b/tests/gb/gprs_bssgp_test.c @@ -173,10 +173,13 @@ static void test_bssgp_status(void) static void test_bssgp_bad_reset() { - struct msgb *msg = bssgp_msgb_alloc(); + struct msgb *msg; uint16_t bvci_be = htons(2); uint8_t cause = BSSGP_CAUSE_OML_INTERV; + printf("----- %s START\n", __func__); + msg = bssgp_msgb_alloc(); + msgb_v_put(msg, BSSGP_PDUT_BVC_RESET); msgb_tvlv_put(msg, BSSGP_IE_BVCI, sizeof(bvci_be), (uint8_t *)&bvci_be); msgb_tvlv_put(msg, BSSGP_IE_CAUSE, sizeof(cause), &cause); @@ -184,6 +187,8 @@ static void test_bssgp_bad_reset() msgb_bvci(msg) = 0xbad; msgb_bssgp_send_and_free(msg); + + printf("----- %s END\n", __func__); } static void test_bssgp_flow_control_bvc(void) diff --git a/tests/gb/gprs_bssgp_test.ok b/tests/gb/gprs_bssgp_test.ok index a011bee..83d633b 100644 --- a/tests/gb/gprs_bssgp_test.ok +++ b/tests/gb/gprs_bssgp_test.ok @@ -7,6 +7,8 @@ BSSGP primitive, SAP 16777219, prim = 4, op = 0, msg = 0e 1f 84 f0 12 34 56 1b 8 BSSGP primitive, SAP 16777221, prim = 11, op = 2, msg = 41 07 81 27 BSSGP primitive, SAP 16777221, prim = 11, op = 2, msg = 41 07 81 05 04 82 04 d2 ----- test_bssgp_status END +----- test_bssgp_bad_reset START +----- test_bssgp_bad_reset END ----- test_bssgp_flow_control_bvc START Got message: 26 1e 81 2a 05 82 10 22 03 82 c0 40 01 82 08 11 1c 82 60 20 Got message: 26 1e 81 2a 05 82 10 22 03 82 c0 40 01 82 08 11 1c 82 60 20 3c 81 78 06 82 11 44 -- 1.9.1

1 0

[PATCH] Fix GSM900 ARFCN range check
by Mike McTernan (wavemobile) 18 Jun '15

18 Jun '15

Allow ARFCN 0 to be used in GSM900 band. Signed-off-by: Michael McTernan <mike.mcternan(a)wavemobile.com> Index: osmobss/openbsc/openbsc/src/libbsc/bsc_init.c =================================================================== --- osmobss.orig/openbsc/openbsc/src/libbsc/bsc_init.c 2015-06-03 11:36:16.114471430 +0100 +++ osmobss/openbsc/openbsc/src/libbsc/bsc_init.c 2015-06-18 08:53:14.116369178 +0100 @@ -379,10 +379,10 @@ static int bootstrap_bts(struct gsm_bts } break; case GSM_BAND_900: - if (bts->c0->arfcn < 1 || + if (bts->c0->arfcn < 0 || (bts->c0->arfcn > 124 && bts->c0->arfcn < 955) || bts->c0->arfcn > 1023) { - LOGP(DNM, LOGL_ERROR, "GSM900 channel must be between 1-124, 955-1023.\n"); + LOGP(DNM, LOGL_ERROR, "GSM900 channel must be between 0-124, 955-1023.\n"); return -EINVAL; } break;

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

OpenBSC