> I don't understand. This callback will be called with data you need to
write
> to the network. In case of MTP Level3 you will need to wrap that around
the
> msgb you got.
I means: is the interaction with mtp3 layer implemented (is sending sccp
data by mtp3 implemented by the library?)?
Also, what about the reception of data from mtp3 layer. is that implemented
in the sccp lib.
I am asking these questions because I see the code of mtp3 in the lib but no
significant call is present in the sccp part of the lib.
Thank you for your help.
On Tue, Jun 28, 2016 at 10:05:28AM +0200, Harald Welte wrote:
> [translated from german]
> is it certain that we switch a channel to PDCH only when
> gprs mode != none?
A TS can be GSM_PCHAN_TCH_F_PDCH; those are the only ones for which we
send a PDCH ACT message.
We send a PDCH ACT message
- during init (CHANNEL OML's state changed to enabled -> send PDCH ACT),
- and upon channel release ack when pchan == GSM_PCHAN_TCH_F_PDCH.
So the question is, when we receive a channel release ack, could that be
the PDCH release and we switch PDCH right back on by accident? No, because
we only receive a chan rel ack when the *TCH/F* is being released.
That is because the PDCH release is initiated "internally" from the PDCH
DEACT, and thus this condition in common/rsl.c rsl_tx_rf_rel_ack() catches
on, which existed before dyn PDCH:
if (lchan->rel_act_kind != LCHAN_REL_ACT_RSL) {
LOGP(DRSL, LOGL_NOTICE, "%s not sending REL ACK\n",
gsm_lchan_name(lchan));
return 0;
}
In rsl_rx_rf_chan_rel() the rel_act_kind is set to LCHAN_REL_ACT_RSL, but
not in the rsl_rx_dyn_pdch().
This is analogous to the ip.access way -- the ip.access nanobts replies to
a PDCH DEACT with a PDCH DEACT ACK and doesn't send a separate channel
release ack.
Maybe we could set rel_act_kind to some new LCHAN_REL_ACT_IPAC_DYN_PDCH
for clarity? (But we shouldn't actually send a release ack, to stay
compatible.)
Even though it works as-is, we should indeed add another flag check:
- We do check the flags that no ACT/DEACT is already pending;
- And we do send a PDCH DEACT only if ts->flags & TS_F_PDCH_ACTIVE;
- But we would send a PDCH ACT despite ts->flags & TS_F_PDCH_ACTIVE.
This should never happen, but it would make sense to ensure that.
~Neels
HI.
A little heads up: uhd version in jenkins building osmo-trx should be
updated to 3.9.0 - this would allow gerrit #1117 to be properly verified
by jenkins.
--
Max Suraev <msuraev(a)sysmocom.de> http://www.sysmocom.de/
=======================================================================
* sysmocom - systems for mobile communications GmbH
* Alt-Moabit 93
* 10559 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschaeftsfuehrer / Managing Director: Harald Welte
Hi,
I further implemented the base of the virtual layer with the purpose
of replacing the um-air interface with a multicast-socket solution.
This has been started by Harald Welte some time ago in the Osmobts -
laforge/virt-bts branch.
As I was not really confident enough to create an official new branch
before someone had a look on what I did, so I developed in copies of
the osmocom-bb and osmo-bts projects on my github-page
(https://github.com/BastusIII/osmocom-bb-virt/tree/stumpf/virt-um and
https://github.com/BastusIII/osmo-bts-virt/tree/stumpf/virt-bts).
If someone finds to time to have a look into them (structure, path,
implementation) and give me feedback about it, I would be glad :).
Please use the following config files that i have tested:
- https://github.com/BastusIII/osmocom-config-files/blob/master/openbsc-virtu…
- https://github.com/BastusIII/osmocom-config-files/blob/master/osmobts-virtu…
- https://github.com/BastusIII/osmocom-config-files/blob/master/osmocom-bb-mo…
What works:
BTS:
- downlink over gsmtap and a multicast socket
- OML and RSL on abis properly established and seems to work
- virtual-um connection establishment
Osmocom-bb:
- virtual-um -- l23 app connection establishment (bridging osmocon,
no serial link needed)
- BCCH downlink handling and forwarding to l23 app
- handling of some l1ctl requests from l23 (e.g. power management had
to be mocked, so l23 gets a response and is satisfied)
What not:
BTS:
- missing uplink handling
Osmocom-bb
- missing uplink routines (RACH, TCH, dedicated channels)
- handlers for l23 requests only partially implemented (missing TCH, RACH, ...
I a currently a bit overwhelmed by the mass of messages exchanged
between l23-app (used mobile, btw.) and the virtual-um and hanging
because mobile gets a sync timeout.
I am looking forward to hear from you :).
Sebastian Stumpf
Hi.
In sysmobts we use ugly hack to auto-activate BCCH/CCCH on TS0 via
opstart_compl(). How does channel activation looks like for osmo-bts-trx?
On a related note: how do we decide on number of AGCH? In case of
sysmobts it's communicated to L1 in agch.u8NbrOfAgch via lch_par. What
would be equivalent for osmo-bts-trx?
--
Max Suraev <msuraev(a)sysmocom.de> http://www.sysmocom.de/
=======================================================================
* sysmocom - systems for mobile communications GmbH
* Alt-Moabit 93
* 10559 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschaeftsfuehrer / Managing Director: Harald Welte
> On 13 Jul 2016, at 12:21, Max <msuraev(a)sysmocom.de> wrote:
>
Hi all,
> After looking at the code, I don't think reusing table implementation
> would be easy - the approaches are too different as well as underlying
> data structures.
okay. then we will need to use the tree based version and from my point of view we should do it the following way:
* Remove osmo_t4_decode (and related routines) from libosmocore (last step)
* Make the tree based decoder ready in terms of the surrounding style
* Adopt/Clone the osmo_t4_decode tests and move them to the PCU (as part of the commit that adds the decoder to the PCU)
@Me: After the infrastructure is in the PCU I will remove osmo_t4_decode (and tests) from libosmocore
@Radisys:
I am afraid the tree based decoding is not ready yet and as it impacts the upcoming encoder (and other RLE code as far as I understand) let me put it here.
In osmo-pcu (and all other projects) we use libtalloc for memory allocations. This means the tree should use talloc with proper parent/child allocations. This way the destructor of the decoder will also free all nodes of the tree. There should be no call to malloc/free in the PCU.
Please take the tests from libosmocore and make sure they work with the new decoder. Tests are the lifeline and we need more and not less of them.
The decoder needs to be robust against invalid input. search_runlen can fail but the caller doesn't check for that. Please test with invalid/truncated or broken inputs to see we don't end in a never terminating while loop. Test using unit tests.
Similar the current osmo_t4_decode can return an error that is propagated back to the compressed bitmap decoding and we should have the same.
Reduce code duplication. With the decoder the only difference between the if/else is if the data is filled with 0x00 or 0xFF and which table/root to use. Instead of having code clones please parameterize either by having local variables in the beginning or by calling different (inline) functions.
kind regards
holger
Hi,
I am using osmo-sip-connector 1.20161024 with osmocom-nitb 0.15.1.20161024
on debian jessie. I keep getting the below error[1] causing my syslog to
fill up. Also I can see sometimes the sip connector replies with 0.0.0.0
RTP IP address.
Anyone had this issues before ? Any idea what might be causing this?
Regards,
Stefan
[1] Oct 25 11:58:28 openbsc1 osmo-sip-connector[283]: length
packettport(0x1064c30): zero length packettport(0x1064c30): zero length
packettport(0x1064c30): zero length packettport(0x1064c30): zero length
packettport(0x1064c30): zero length packettport(0x1064c30): zero length
packettport(0x1064c30): zero length packettport(0x1064c30): zero length
packettport(0x1064c30): zero length packettport(0x1064c30): zero length
packettport(0x1064c30): zero length packettport(0x1064c30): zero length
packettport(0x1064c30): zero length packettport(0x1064c30): zero length
packettport(0x1064c30): zero length packettport(0x1064c30): zero length
packettport(0x1064c30): zero length packettport(0x1064c30): zero length
packettport(0x1064c30): zero length packettport(0x1064c30): zero length
packettport(0x1064c30): zero length packettport(0x1064c30): zero length
packettport(0x1064c30): zero length packettport(0x1064c30): zero length
packettport(0x1064c30): zero length packettport(0x1064c30): zero length
packettport(0x1064c30): zero length packettport(0x1064c30): zero length
packettport(0x1064c30): zero length packettport(0x1064c30): zero length
packettport(0x1064c30): zero length packettport(0x1064c30): zero length
packettport(0x1064c30): zero length packettport(0x1064c30): zero length
packettport(0x1064c30): zero length packettport(0x1064c30): zero length
packettport(0x1064c30): zero length packettport(0x1064c30): zero length
packettport(0x1064c30): zero length packettport(0x1064c30): zero length
packettpor
Hi everyone
I was trying Openbsc recently on Ubuntu 16.04.1 and came through these
errors in make check command. Are they harmless? since installation and
make commands were not having any error.
myself@myself34:~/project/openbsc/openbsc$ make check
make check-recursive
make[1]: Entering directory '/home/myself/project/openbsc/openbsc'
Making check in doc
make[2]: Entering directory '/home/myself/project/openbsc/openbsc/doc'
Making check in examples
make[3]: Entering directory '/home/myself/project/openbsc/
openbsc/doc/examples'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/myself/project/openbsc/
openbsc/doc/examples'
make[3]: Entering directory '/home/myself/project/openbsc/openbsc/doc'
make[3]: Nothing to be done for 'check-am'.
make[3]: Leaving directory '/home/myself/project/openbsc/openbsc/doc'
make[2]: Leaving directory '/home/myself/project/openbsc/openbsc/doc'
Making check in include
make[2]: Entering directory '/home/myself/project/openbsc/openbsc/include'
Making check in openbsc
make[3]: Entering directory '/home/myself/project/openbsc/
openbsc/include/openbsc'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/myself/project/openbsc/
openbsc/include/openbsc'
make[3]: Entering directory '/home/myself/project/openbsc/openbsc/include'
make[3]: Nothing to be done for 'check-am'.
make[3]: Leaving directory '/home/myself/project/openbsc/openbsc/include'
make[2]: Leaving directory '/home/myself/project/openbsc/openbsc/include'
Making check in src
make[2]: Entering directory '/home/myself/project/openbsc/openbsc/src'
Making check in libcommon
make[3]: Entering directory '/home/myself/project/openbsc/
openbsc/src/libcommon'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/myself/project/openbsc/
openbsc/src/libcommon'
Making check in libmgcp
make[3]: Entering directory '/home/myself/project/openbsc/
openbsc/src/libmgcp'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/myself/project/openbsc/
openbsc/src/libmgcp'
Making check in libbsc
make[3]: Entering directory '/home/myself/project/openbsc/
openbsc/src/libbsc'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/myself/project/openbsc/openbsc/src/libbsc'
Making check in libmsc
make[3]: Entering directory '/home/myself/project/openbsc/
openbsc/src/libmsc'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/myself/project/openbsc/openbsc/src/libmsc'
Making check in libtrau
make[3]: Entering directory '/home/myself/project/openbsc/
openbsc/src/libtrau'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/myself/project/openbsc/
openbsc/src/libtrau'
Making check in libfilter
make[3]: Entering directory '/home/myself/project/openbsc/
openbsc/src/libfilter'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/myself/project/openbsc/
openbsc/src/libfilter'
Making check in osmo-nitb
make[3]: Entering directory '/home/myself/project/openbsc/
openbsc/src/osmo-nitb'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/myself/project/openbsc/
openbsc/src/osmo-nitb'
Making check in osmo-bsc_mgcp
make[3]: Entering directory '/home/myself/project/openbsc/
openbsc/src/osmo-bsc_mgcp'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/myself/project/openbsc/
openbsc/src/osmo-bsc_mgcp'
Making check in utils
make[3]: Entering directory '/home/myself/project/openbsc/openbsc/src/utils'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/myself/project/openbsc/openbsc/src/utils'
Making check in ipaccess
make[3]: Entering directory '/home/myself/project/openbsc/
openbsc/src/ipaccess'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/myself/project/openbsc/
openbsc/src/ipaccess'
Making check in gprs
make[3]: Entering directory '/home/myself/project/openbsc/openbsc/src/gprs'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/myself/project/openbsc/openbsc/src/gprs'
Making check in osmo-bsc_nat
make[3]: Entering directory '/home/myself/project/openbsc/
openbsc/src/osmo-bsc_nat'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/myself/project/openbsc/
openbsc/src/osmo-bsc_nat'
Making check in osmo-bsc
make[3]: Entering directory '/home/myself/project/openbsc/
openbsc/src/osmo-bsc'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/myself/project/openbsc/
openbsc/src/osmo-bsc'
make[3]: Entering directory '/home/myself/project/openbsc/openbsc/src'
make[3]: Nothing to be done for 'check-am'.
make[3]: Leaving directory '/home/myself/project/openbsc/openbsc/src'
make[2]: Leaving directory '/home/myself/project/openbsc/openbsc/src'
Making check in tests
make[2]: Entering directory '/home/myself/project/openbsc/openbsc/tests'
Making check in gsm0408
make[3]: Entering directory '/home/myself/project/openbsc/
openbsc/tests/gsm0408'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/myself/project/openbsc/
openbsc/tests/gsm0408'
Making check in db
make[3]: Entering directory '/home/myself/project/openbsc/openbsc/tests/db'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/myself/project/openbsc/openbsc/tests/db'
Making check in channel
make[3]: Entering directory '/home/myself/project/openbsc/
openbsc/tests/channel'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/myself/project/openbsc/
openbsc/tests/channel'
Making check in mgcp
make[3]: Entering directory '/home/myself/project/openbsc/
openbsc/tests/mgcp'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/myself/project/openbsc/openbsc/tests/mgcp'
Making check in gprs
make[3]: Entering directory '/home/myself/project/openbsc/
openbsc/tests/gprs'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/myself/project/openbsc/openbsc/tests/gprs'
Making check in abis
make[3]: Entering directory '/home/myself/project/openbsc/
openbsc/tests/abis'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/myself/project/openbsc/openbsc/tests/abis'
Making check in gbproxy
make[3]: Entering directory '/home/myself/project/openbsc/
openbsc/tests/gbproxy'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/myself/project/openbsc/
openbsc/tests/gbproxy'
Making check in trau
make[3]: Entering directory '/home/myself/project/openbsc/
openbsc/tests/trau'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/myself/project/openbsc/openbsc/tests/trau'
Making check in subscr
make[3]: Entering directory '/home/myself/project/openbsc/
openbsc/tests/subscr'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/myself/project/openbsc/
openbsc/tests/subscr'
Making check in mm_auth
make[3]: Entering directory '/home/myself/project/openbsc/
openbsc/tests/mm_auth'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/myself/project/openbsc/
openbsc/tests/mm_auth'
Making check in bsc-nat
make[3]: Entering directory '/home/myself/project/openbsc/
openbsc/tests/bsc-nat'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/myself/project/openbsc/
openbsc/tests/bsc-nat'
Making check in bsc-nat-trie
make[3]: Entering directory '/home/myself/project/openbsc/
openbsc/tests/bsc-nat-trie'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/myself/project/openbsc/
openbsc/tests/bsc-nat-trie'
Making check in bsc
make[3]: Entering directory '/home/myself/project/openbsc/openbsc/tests/bsc'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/myself/project/openbsc/openbsc/tests/bsc'
Making check in smpp
make[3]: Entering directory '/home/myself/project/openbsc/
openbsc/tests/smpp'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/myself/project/openbsc/openbsc/tests/smpp'
Making check in gtphub
make[3]: Entering directory '/home/myself/project/openbsc/
openbsc/tests/gtphub'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/myself/project/openbsc/
openbsc/tests/gtphub'
Making check in sgsn
make[3]: Entering directory '/home/myself/project/openbsc/
openbsc/tests/sgsn'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/myself/project/openbsc/openbsc/tests/sgsn'
Making check in oap
make[3]: Entering directory '/home/myself/project/openbsc/openbsc/tests/oap'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/myself/project/openbsc/openbsc/tests/oap'
Making check in xid
make[3]: Entering directory '/home/myself/project/openbsc/openbsc/tests/xid'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/myself/project/openbsc/openbsc/tests/xid'
Making check in sndcp_xid
make[3]: Entering directory '/home/myself/project/openbsc/
openbsc/tests/sndcp_xid'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/myself/project/openbsc/
openbsc/tests/sndcp_xid'
Making check in slhc
make[3]: Entering directory '/home/myself/project/openbsc/
openbsc/tests/slhc'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/myself/project/openbsc/openbsc/tests/slhc'
Making check in v42bis
make[3]: Entering directory '/home/myself/project/openbsc/
openbsc/tests/v42bis'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/myself/project/openbsc/
openbsc/tests/v42bis'
make[3]: Entering directory '/home/myself/project/openbsc/openbsc/tests'
make check-local
make[4]: Entering directory '/home/myself/project/openbsc/openbsc/tests'
:;{ \
echo '# Signature of the current package.' && \
echo 'm4_define([AT_PACKAGE_NAME],' && \
echo ' [openbsc])' && \
echo 'm4_define([AT_PACKAGE_TARNAME],' && \
echo ' [openbsc])' && \
echo 'm4_define([AT_PACKAGE_VERSION],' && \
echo ' [0.15.0.498-582e4])' && \
echo 'm4_define([AT_PACKAGE_STRING],' && \
echo ' [openbsc 0.15.0.498-582e4])' && \
echo 'm4_define([AT_PACKAGE_BUGREPORT],' && \
echo ' [openbsc(a)lists.osmocom.org])'; \
echo 'm4_define([AT_PACKAGE_URL],' && \
echo ' [])'; \
} >'./package.m4'
/bin/bash ../missing --run autom4te --language=autotest -I '.' -o
testsuite.tmp testsuite.at
mv testsuite.tmp testsuite
/bin/bash './testsuite'
## ------------------------------------ ##
## openbsc 0.15.0.498-582e4 test suite. ##
## ------------------------------------ ##
Regression tests.
1: gsm0408 ok
2: subscr ok
3: db FAILED (testsuite.at:21
)
4: channel ok
5: mgcp ok
6: mgcp-trans skipped (
testsuite.at:38)
7: gprs ok
8: bsc-nat ok
9: smpp ok
10: bsc-nat-trie ok
11: abis ok
12: bsc ok
13: gbproxy ok
14: trau ok
15: sgsn ok
16: oap ok
17: gtphub ok
18: mm_auth ok
19: xid ok
20: sndcp_xid ok
21: slhc ok
22: v42bis ok
## ------------- ##
## Test results. ##
## ------------- ##
ERROR: 21 tests were run,
1 failed unexpectedly.
1 test was skipped.
## -------------------------- ##
## testsuite.log was created. ##
## -------------------------- ##
Please send `tests/testsuite.log' and all information you think might help:
To: <openbsc(a)lists.osmocom.org>
Subject: [openbsc 0.15.0.498-582e4] testsuite: 3 failed
You may investigate any problem if you feel able to do so, in which
case the test suite provides a good starting point. Its output may
be found below `tests/testsuite.dir'.
Makefile:717: recipe for target 'check-local' failed
make[4]: *** [check-local] Error 1
make[4]: Leaving directory '/home/myself/project/openbsc/openbsc/tests'
Makefile:568: recipe for target 'check-am' failed
make[3]: *** [check-am] Error 2
make[3]: Leaving directory '/home/myself/project/openbsc/openbsc/tests'
Makefile:420: recipe for target 'check-recursive' failed
make[2]: *** [check-recursive] Error 1
make[2]: Leaving directory '/home/myself/project/openbsc/openbsc/tests'
Makefile:484: recipe for target 'check-recursive' failed
make[1]: *** [check-recursive] Error 1
make[1]: Leaving directory '/home/myself/project/openbsc/openbsc'
Makefile:775: recipe for target 'check' failed
make: *** [check] Error 2
myself@myself34:~/project/openbsc/openbsc$
Thanks
Abdulghafar
Hi.
Address Sanitizer is currently enabled for libosmocore jenkins build
(which is really great, thanks al being involved!) but not for other
libraries. According to recent checks in
http://jenkins.osmocom.org/jenkins/job/Osmocom_Sanitizer/ asan only
fails for OpenBSC so it seems like it can be enabled for other libosmo*
libraries as well.
What do you think?
--
Max Suraev <msuraev(a)sysmocom.de> http://www.sysmocom.de/
=======================================================================
* sysmocom - systems for mobile communications GmbH
* Alt-Moabit 93
* 10559 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschaeftsfuehrer / Managing Director: Harald Welte
