OpenBSC

openbsc@lists.osmocom.org

19 participants
4282 discussions

libosmocore: to talloc or not to talloc
by Jan Engelhardt 04 Oct '14

04 Oct '14

Changes to previous submission: - split out the implicit declaration patch (p3 -> p3,p1) - edit libosmocore.pc to include Requires: pkgconfig. (in p3) - add (p5) as an optional commit to completely remove the bundled copy The antisymmetry of osmo_config_list_parse is a matter for a subsequent submission. === The following changes since commit c60de4f35f3f73f3d79b4ff61d0a20b92f818702: build: fix linker error with kasumi_test (2014-10-03 08:48:31 +0200) are available in the git repository at: git://git.inai.de/libosmocore HEAD for you to fetch changes up to a962cd7b62b92a0acc49591d9b3af2b46e023850: build: remove bundled copy of talloc (2014-10-04 11:06:44 +0200) ---------------------------------------------------------------- Jan Engelhardt (5): build: resolve compiler warning about implicit delcaration build: resolve link failure in libosmogsm when --disable-talloc is used build: allow using a system-provided talloc properly build: default to system-provided talloc build: remove bundled copy of talloc Makefile.am | 2 + configure.ac | 9 +- include/Makefile.am | 4 - include/osmocom/core/strrb.h | 2 +- include/osmocom/core/talloc.h | 189 ------------------------------------- include/osmocom/core/utils.h | 2 +- include/osmocom/ctrl/control_cmd.h | 2 +- libosmocore.pc.in | 2 +- src/Makefile.am | 10 +- src/ctrl/control_cmd.c | 2 +- src/ctrl/control_if.c | 2 +- src/gb/common_vty.c | 2 +- src/gb/gprs_bssgp.c | 2 +- src/gb/gprs_bssgp_bss.c | 2 +- src/gb/gprs_bssgp_util.c | 2 +- src/gb/gprs_bssgp_vty.c | 2 +- src/gb/gprs_ns.c | 2 +- src/gb/gprs_ns_frgre.c | 2 +- src/gb/gprs_ns_vty.c | 2 +- src/gsm/Makefile.am | 5 +- src/gsm/ipa.c | 2 +- src/gsm/lapd_core.c | 2 +- src/gsmtap_util.c | 2 +- src/logging.c | 2 +- src/logging_syslog.c | 2 +- src/msgb.c | 2 +- src/msgfile.c | 2 +- src/rate_ctr.c | 2 +- src/signal.c | 2 +- src/statistics.c | 2 +- src/talloc.c | 2 +- src/vty/buffer.c | 2 +- src/vty/command.c | 2 +- src/vty/logging_vty.c | 2 +- src/vty/telnet_interface.c | 2 +- src/vty/utils.c | 2 +- src/vty/vector.c | 2 +- src/vty/vty.c | 2 +- tests/Makefile.am | 12 +-- tests/gb/bssgp_fc_test.c | 2 +- tests/gb/gprs_ns_test.c | 2 +- tests/msgfile/msgfile_test.c | 1 + tests/strrb/strrb_test.c | 2 +- tests/timer/timer_test.c | 2 +- tests/vty/vty_test.c | 2 +- 45 files changed, 53 insertions(+), 253 deletions(-) delete mode 100644 include/osmocom/core/talloc.h

2 7

libosmocore: system-talloc+bundled-talloc support
by Jan Engelhardt 03 Oct '14

03 Oct '14

"--disable-talloc" had the effect of a "--enable-system-talloc". So the first patch fixes up all the link failures by adding -ltalloc where needed, _for the case that one decides to use disable-talloc_. Second patch will use pkg-config to determine the parameters for a system talloc. These will be used unconditionally, because the variables TALLOC_CFLAGS/TALLOC_LIBS will be empty when using the bundled talloc. === The following changes since commit c60de4f35f3f73f3d79b4ff61d0a20b92f818702: build: fix linker error with kasumi_test (2014-10-03 08:48:31 +0200) are available in the git repository at: git://git.inai.de/libosmocore HEAD for you to fetch changes up to d6c1607a724a07416c7d39f9b43f7af7349de666: build: default to system-provided talloc (2014-10-03 12:43:25 +0200) ---------------------------------------------------------------- Jan Engelhardt (3): build: resolve link failure in libosmogsm when --disable-talloc is used build: allow using a system-provided talloc properly build: default to system-provided talloc .gitignore | 1 + configure.ac | 26 +++++++++++++++++++------ include/Makefile.am | 5 +++-- include/osmocom/core/talloc.h.in | 6 ++++++ include/osmocom/core/{talloc.h => talloc_int.h} | 0 src/Makefile.am | 7 ++++--- src/gsm/Makefile.am | 5 +++-- tests/Makefile.am | 12 ++++++------ tests/msgfile/msgfile_test.c | 1 + 9 files changed, 44 insertions(+), 19 deletions(-) create mode 100644 include/osmocom/core/talloc.h.in rename include/osmocom/core/{talloc.h => talloc_int.h} (100%)

3 14

libosmo-netif: build system cleanups
by Jan Engelhardt 03 Oct '14

03 Oct '14

The following changes since commit 603f6c40d55b87f81fbd8ff1ad7b9568f3b962ff: build: rename INCLUDES to AM_CPPFLAGS in Makefile.am to avoid warnings (2014-09-11 18:22:02 +0200) are available in the git repository at: git://git.inai.de/libosmo-netif HEAD for you to fetch changes up to 226e99483234c100e5a18ea12838d98a3b091de6: build: remove all_includes (2014-10-02 23:22:55 +0200) ---------------------------------------------------------------- Jan Engelhardt (2): build: put dependency libraries in the right place in Makefiles build: remove all_includes Makefile.am | 1 - examples/Makefile.am | 2 +- examples/channel/Makefile.am | 2 +- src/Makefile.am | 6 +++--- src/channel/abis/Makefile.am | 5 +++-- tests/Makefile.am | 2 +- tests/osmo-pcap-test/Makefile.am | 2 +- 7 files changed, 10 insertions(+), 10 deletions(-)

1 2

libosmocore: some build fixes
by Jan Engelhardt 03 Oct '14

03 Oct '14

The following changes since commit 336915aa0a86316ba26cdfecbf160ed643ccf301: prepare for 0.7.0 release (2014-08-21 15:53:20 +0200) are available in the git repository at: git://git.inai.de/libosmocore HEAD for you to fetch changes up to 0929c5b1d3ae71fb600120fd5c60221495b8391c: build: fix linker error with kasumi_test (2014-10-02 22:33:24 +0200) ---------------------------------------------------------------- Jan Engelhardt (5): utils: resolve compiler warnings on implicit declarations build: resolve link failure in libosmogsm when --disable-talloc is used build: always install our talloc.h build: remove unused all_includes and use AM_CPPFLAGS build: fix linker error with kasumi_test Makefile.am | 1 - include/Makefile.am | 2 -- src/Makefile.am | 3 ++- src/codec/Makefile.am | 3 ++- src/gb/Makefile.am | 3 ++- src/gsm/Makefile.am | 6 +++++- src/vty/Makefile.am | 3 ++- tests/Makefile.am | 6 +++--- utils/Makefile.am | 3 ++- utils/osmo-auc-gen.c | 1 + 10 files changed, 19 insertions(+), 12 deletions(-)

2 9

[PATCH] Add subscriber delete command
by Ruben Pollan 25 Sep '14

25 Sep '14

--- openbsc/include/openbsc/gsm_subscriber.h | 1 + openbsc/src/libbsc/gsm_subscriber_base.c | 2 +- openbsc/src/libmsc/vty_interface_layer3.c | 24 +++++++++++++++++++++++- 3 files changed, 25 insertions(+), 2 deletions(-) diff --git a/openbsc/include/openbsc/gsm_subscriber.h b/openbsc/include/openbsc/gsm_subscriber.h index 7aae4c3..120111b 100644 --- a/openbsc/include/openbsc/gsm_subscriber.h +++ b/openbsc/include/openbsc/gsm_subscriber.h @@ -101,6 +101,7 @@ int subscr_pending_kick(struct gsm_subscriber *subscr); char *subscr_name(struct gsm_subscriber *subscr); +void subscr_free(struct gsm_subscriber *subscr); int subscr_purge_inactive(struct gsm_network *net); void subscr_update_from_db(struct gsm_subscriber *subscr); void subscr_expire(struct gsm_network *net); diff --git a/openbsc/src/libbsc/gsm_subscriber_base.c b/openbsc/src/libbsc/gsm_subscriber_base.c index 5e00443..2b31e95 100644 --- a/openbsc/src/libbsc/gsm_subscriber_base.c +++ b/openbsc/src/libbsc/gsm_subscriber_base.c @@ -66,7 +66,7 @@ struct gsm_subscriber *subscr_alloc(void) return s; } -static void subscr_free(struct gsm_subscriber *subscr) +void subscr_free(struct gsm_subscriber *subscr) { llist_del(&subscr->entry); talloc_free(subscr); diff --git a/openbsc/src/libmsc/vty_interface_layer3.c b/openbsc/src/libmsc/vty_interface_layer3.c index 064eca9..6b53f65 100644 --- a/openbsc/src/libmsc/vty_interface_layer3.c +++ b/openbsc/src/libmsc/vty_interface_layer3.c @@ -465,7 +465,28 @@ DEFUN(subscriber_ussd_notify, return CMD_SUCCESS; } -DEFUN(ena_subscr_authorizde, +DEFUN(ena_subscr_delete, + ena_subscr_delete_cmd, + "subscriber " SUBSCR_TYPES " ID delete", + SUBSCR_HELP "Delete subscriber in HLR\n") +{ + struct gsm_network *gsmnet = gsmnet_from_vty(vty); + struct gsm_subscriber *subscr = + get_subscr_by_argv(gsmnet, argv[0], argv[1]); + + if (!subscr) { + vty_out(vty, "%% No subscriber found for %s %s%s", + argv[0], argv[1], VTY_NEWLINE); + return CMD_WARNING; + } + + db_subscriber_delete(subscr); + subscr_free(subscr); + + return CMD_SUCCESS; +} + +DEFUN(ena_subscr_authorized, ena_subscr_authorized_cmd, "subscriber " SUBSCR_TYPES " ID authorized (0|1)", SUBSCR_HELP "(De-)Authorize subscriber in HLR\n" @@ -982,6 +1003,7 @@ int bsc_vty_init_extra(void) install_element_ve(&show_stats_cmd); install_element_ve(&show_smsqueue_cmd); + install_element(ENABLE_NODE, &ena_subscr_delete_cmd); install_element(ENABLE_NODE, &ena_subscr_name_cmd); install_element(ENABLE_NODE, &ena_subscr_extension_cmd); install_element(ENABLE_NODE, &ena_subscr_authorized_cmd); -- 2.1.0

2 8

[PATCH 1/4] gprs: Fix and check BVCI in BSSGP STATUS messages
by Jacob Erlbeck 23 Sep '14

23 Sep '14

Currently the BVCI is not set in all invocations to bssgp_tx_status() when the cause is UNKNOWN_BVCI. This patch adds the argument where it is missing. It also adds a check for compliance (GSM 08.18, 10.4.14.1) to bssgp_tx_status() to emit errors when the following requirement is not fulfilled: The BVCI must be included if (and only if) the cause is either "BVCI blocked" or "BVCI unknown". Sponsored-by: On-Waves ehf --- src/gb/gprs_bssgp.c | 2 +- src/gb/gprs_bssgp_util.c | 14 ++++++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/src/gb/gprs_bssgp.c b/src/gb/gprs_bssgp.c index 5ef1887..b8c6c74 100644 --- a/src/gb/gprs_bssgp.c +++ b/src/gb/gprs_bssgp.c @@ -998,7 +998,7 @@ int bssgp_rcvmsg(struct msgb *msg) LOGP(DBSSGP, LOGL_NOTICE, "NSEI=%u/BVCI=%u Rejecting PDU " "type %u for unknown BVCI\n", msgb_nsei(msg), ns_bvci, pdu_type); - return bssgp_tx_status(BSSGP_CAUSE_UNKNOWN_BVCI, NULL, msg); + return bssgp_tx_status(BSSGP_CAUSE_UNKNOWN_BVCI, &ns_bvci, msg); } if (bctx) { diff --git a/src/gb/gprs_bssgp_util.c b/src/gb/gprs_bssgp_util.c index ae4647e..261e0b0 100644 --- a/src/gb/gprs_bssgp_util.c +++ b/src/gb/gprs_bssgp_util.c @@ -99,6 +99,20 @@ int bssgp_tx_status(uint8_t cause, uint16_t *bvci, struct msgb *orig_msg) struct bssgp_normal_hdr *bgph = (struct bssgp_normal_hdr *) msgb_put(msg, sizeof(*bgph)); + /* GSM 08.18, 10.4.14.1: The BVCI must be included if (and only if) the + cause is either "BVCI blocked" or "BVCI unknown" */ + if (cause == BSSGP_CAUSE_UNKNOWN_BVCI || cause == BSSGP_CAUSE_BVCI_BLOCKED) { + if (bvci == NULL) + LOGP(DBSSGP, LOGL_ERROR, "BSSGP Tx STATUS, cause=%s: " + "missing conditional BVCI\n", + bssgp_cause_str(cause)); + } else { + if (bvci != NULL) + LOGP(DBSSGP, LOGL_ERROR, "BSSGP Tx STATUS, cause=%s: " + "unexpected conditional BVCI\n", + bssgp_cause_str(cause)); + } + LOGP(DBSSGP, LOGL_NOTICE, "BSSGP BVCI=%u Tx STATUS, cause=%s\n", bvci ? *bvci : 0, bssgp_cause_str(cause)); msgb_nsei(msg) = msgb_nsei(orig_msg); -- 1.9.1

2 5

Support for integrating RRLP with openbsc
by Kunal Dawn 22 Sep '14

22 Sep '14

Hello everyone I am new to openbsc, and trying to implement my own mobile network for my masters project. Till now everything has gone well and my network is working gud. But the issue is when I am trying to implement rrlp with openbsc. I have set the rrlp mode to ms-based, but there is no response from the phone on sending the request. I have checked that the request is going to the phone with the help of wireshark. So please anyone help me with this, that should i use E-OTD or ms-assisted method for getting the response from the phone. Thanking you in anticipation Kunal

1 0

OpenBSC running on an Odroid-XU
by John Baker 19 Sep '14

19 Sep '14

Hi, I have an Odroid-XU I have setup with Debian Wheezy and a USRP B200. After building the UHD drivers from source, I followed the "network from scratch" page. I also configured and built osmo-trx with the --with-neon-vfpv4 option. Things are running OK, a whole lot better than my attempt with OpenBTS actually. I"m able to connect to the network with my Samsung S4 phone, but after an hour or so of the BTS running, I get a UHD recieved time out error (see below). I wonder what could be causing this? I have the B200 plugged into the USB 3.0 port, along with external power. Thanks in advance for any help. root@odroid-wheezy:~# osmo-trx linux; GNU C++ version 4.6.3; Boost_104900; UHD_003.007.002-94-ge56809a0 Config Settings Log Level............... NOTICE Device args............. TRX Base Port........... 5700 TRX Address............. 127.0.0.1 Channels................ 1 Samples-per-Symbol...... 1 External Reference...... Disabled C0 Filler Table......... Disabled Diversity............... Disabled Tuning offset........... 0 -- Loading firmware image: /usr/local/share/uhd/images/usrp_b200_fw.hex... done -- Loading FPGA image: /usr/local/share/uhd/images/usrp_b200_fpga.bin... done -- Operating over USB 3. -- Detecting internal GPSDO.... No GPSDO found -- not found -- Initialize CODEC control... -- Initialize Radio control... -- Performing register loopback test... pass -- Performing CODEC loopback test... pass -- Asking for clock rate 32.000000 MHz -- Actually got clock rate 32.000000 MHz -- Performing timer loopback test... pass -- Asking for clock rate 26.000000 MHz -- Actually got clock rate 26.000000 MHz -- Performing timer loopback test... pass -- Setting B200 1 SPS -- Transceiver active with 1 channel(s) ALERT 3030074464 23:06:10.4 UHDDevice.cpp:832:check_rx_md_err: UHD: Receive timed out ALERT 3030074464 23:06:10.5 UHDDevice.cpp:832:check_rx_md_err: UHD: Receive timed out ALERT 3030074464 23:06:10.6 UHDDevice.cpp:832:check_rx_md_err: UHD: Receive timed out ALERT 3030074464 23:06:10.7 UHDDevice.cpp:832:check_rx_md_err: UHD: Receive timed out ALERT 3030074464 23:06:10.8 UHDDevice.cpp:832:check_rx_md_err: UHD: Receive timed out ALERT 3030074464 23:06:10.9 UHDDevice.cpp:832:check_rx_md_err: UHD: Receive timed out ALERT 3030074464 23:06:11.0 UHDDevice.cpp:832:check_rx_md_err: UHD: Receive timed out ALERT 3030074464 23:06:11.1 UHDDevice.cpp:832:check_rx_md_err: UHD: Receive timed out ALERT 3030074464 23:06:11.2 UHDDevice.cpp:832:check_rx_md_err: UHD: Receive timed out ALERT 3030074464 23:06:11.3 UHDDevice.cpp:832:check_rx_md_err: UHD: Receive timed out ALERT 3030074464 23:06:11.4 UHDDevice.cpp:832:check_rx_md_err: UHD: Receive timed out ALERT 3030074464 23:06:11.5 UHDDevice.cpp:832:check_rx_md_err: UHD: Receive timed out ALERT 3030074464 23:06:11.6 UHDDevice.cpp:832:check_rx_md_err: UHD: Receive timed out ALERT 3030074464 23:06:11.7 UHDDevice.cpp:832:check_rx_md_err: UHD: Receive timed out ALERT 3030074464 23:06:11.9 UHDDevice.cpp:832:check_rx_md_err: UHD: Receive timed out ALERT 3030074464 23:06:12.0 UHDDevice.cpp:832:check_rx_md_err: UHD: Receive timed out ALERT 3030074464 23:06:12.1 UHDDevice.cpp:832:check_rx_md_err: UHD: Receive timed out ALERT 3030074464 23:06:12.2 UHDDevice.cpp:832:check_rx_md_err: UHD: Receive timed out ALERT 3030074464 23:06:12.3 UHDDevice.cpp:832:check_rx_md_err: UHD: Receive timed out ALERT 3030074464 23:06:12.4 UHDDevice.cpp:832:check_rx_md_err: UHD: Receive timed out ALERT 3030074464 23:06:12.5 UHDDevice.cpp:832:check_rx_md_err: UHD: Receive timed out ALERT 3030074464 23:06:12.6 UHDDevice.cpp:832:check_rx_md_err: UHD: Receive timed out ALERT 3030074464 23:06:12.7 UHDDevice.cpp:832:check_rx_md_err: UHD: Receive timed out ALERT 3030074464 23:06:12.8 UHDDevice.cpp:832:check_rx_md_err: UHD: Receive timed out ALERT 3030074464 23:06:12.9 UHDDevice.cpp:832:check_rx_md_err: UHD: Receive timed out ALERT 3030074464 23:06:13.0 UHDDevice.cpp:832:check_rx_md_err: UHD: Receive timed out ALERT 3030074464 23:06:13.1 UHDDevice.cpp:832:check_rx_md_err: UHD: Receive timed out ALERT 3030074464 23:06:13.2 UHDDevice.cpp:832:check_rx_md_err: UHD: Receive timed out ALERT 3030074464 23:06:13.3 UHDDevice.cpp:832:check_rx_md_err: UHD: Receive timed out ALERT 3030074464 23:06:13.4 UHDDevice.cpp:832:check_rx_md_err: UHD: Receive timed out ALERT 3030074464 23:06:13.5 UHDDevice.cpp:832:check_rx_md_err: UHD: Receive timed out ALERT 3030074464 23:06:13.6 UHDDevice.cpp:832:check_rx_md_err: UHD: Receive timed out ALERT 3030074464 23:06:13.7 UHDDevice.cpp:832:check_rx_md_err: UHD: Receive timed out ALERT 3030074464 23:06:13.8 UHDDevice.cpp:832:check_rx_md_err: UHD: Receive timed out ALERT 3030074464 23:06:13.9 UHDDevice.cpp:832:check_rx_md_err: UHD: Receive timed out ALERT 3030074464 23:06:14.0 UHDDevice.cpp:832:check_rx_md_err: UHD: Receive timed out ALERT 3030074464 23:06:14.1 UHDDevice.cpp:832:check_rx_md_err: UHD: Receive timed out ALERT 3030074464 23:06:14.2 UHDDevice.cpp:832:check_rx_md_err: UHD: Receive timed out terminate called after throwing an instance of 'uhd::assertion_error' what(): AssertionError: accum_timeout < _timeout in uint64_t radio_ctrl_core_3000_impl::wait_for_ack(bool) at /root/uhd/host/lib/usrp/cores/radio_ctrl_core_3000.cpp:232

2 1

TIP: Working with nanoBTS behind NAT
by admin＠manateeshome.com 16 Sep '14

16 Sep '14

I wrote a short post about using nanoBTS behind NAT and getting proper connection. http://manatails.net/blog/2014/09/setting-arbitary-destination-ip-for-rtp-p… As OpenBSC does not natively support NAT like Asterisk does, One needs to use a simple hack to manually tell the BSC about the connection information. Regards, Pierre

1 0

osmo-sgsn crash report
by admin＠manateeshome.com 16 Sep '14

16 Sep '14

Hello, I've been working with my nanoBTS units again. But I've noticed some crashes while using GPRS data. I am currently using the newest git repo for everything. And a nanoBTS 1900 and an iPhone. Attached is the log of the crash. Please let me know if you need more information. Regards, Pierre

2 2

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

OpenBSC