OpenBSC

openbsc@lists.osmocom.org

19 participants
4282 discussions

Buying a NanoBTS (Siemens BS-11, IP.Access...) / Network in a Box (UltraWAVE...)...
by Ricardo Hassa 05 Sep '14

05 Sep '14

Hello, anyone can sell me a NanoBTS (Siemens BS-11 etc...) / Network in a Box (UltraWAVE...) or other bts hardware (RangeNetworks, Ip.Access...) that works with OpenBSC? contact me at: ricardohassa [ at ] googlemail.com I am living in germany

1 0

Can't build debian packages of libosmocore
by Ciaby 04 Sep '14

04 Sep '14

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 I'm having this problem with the latest code from git: root@boxie:~/gsm# git clone git://git.osmocom.org/libosmocore.git Cloning into 'libosmocore'... remote: Counting objects: 8770, done. remote: Compressing objects: 100% (4055/4055), done. remote: Total 8770 (delta 5642), reused 6765 (delta 4265) Receiving objects: 100% (8770/8770), 1.62 MiB | 142 KiB/s, done. Resolving deltas: 100% (5642/5642), done. root@boxie:~/gsm# cd libosmocore root@boxie:~/gsm/libosmocore# autoreconf -fi libtoolize: putting auxiliary files in `.'. libtoolize: copying file `./config.guess' libtoolize: copying file `./config.sub' libtoolize: copying file `./install-sh' libtoolize: copying file `./ltmain.sh' libtoolize: putting macros in AC_CONFIG_MACRO_DIR, `m4'. libtoolize: copying file `m4/libtool.m4' libtoolize: copying file `m4/ltoptions.m4' libtoolize: copying file `m4/ltsugar.m4' libtoolize: copying file `m4/ltversion.m4' libtoolize: copying file `m4/lt~obsolete.m4' configure.ac:5: installing `./missing' src/Makefile.am: installing `./depcomp' root@boxie:~/gsm/libosmocore# dpkg-buildpackage dpkg-buildpackage: export CFLAGS from dpkg-buildflags (origin: vendor): -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Wformat-security dpkg-buildpackage: export CPPFLAGS from dpkg-buildflags (origin: vendor): -D_FORTIFY_SOURCE=2 dpkg-buildpackage: export CXXFLAGS from dpkg-buildflags (origin: vendor): -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Wformat-security dpkg-buildpackage: export FFLAGS from dpkg-buildflags (origin: vendor): -g -O2 dpkg-buildpackage: export LDFLAGS from dpkg-buildflags (origin: vendor): -Wl,-Bsymbolic-functions -Wl,-z,relro dpkg-buildpackage: source package libosmocore dpkg-buildpackage: source version 0.7.0 dpkg-buildpackage: source changed by Harald Welte <laforge(a)gnumonks.org> dpkg-buildpackage: host architecture amd64 dpkg-source --before-build libosmocore [...] make[1]: Entering directory `/home/rhizomatica/gsm/libosmocore' sed -i "/dependency_libs/ s/'.*'/''/" `find . -name '*.la'` dh_install dh_install: usr/lib/libosmogsm.so.5.1.0 exists in debian/tmp but is not installed to anywhere dh_install: usr/lib/libosmogsm.so.5 exists in debian/tmp but is not installed to anywhere dh_install: usr/lib/libosmoctrl.so.0.0.0 exists in debian/tmp but is not installed to anywhere dh_install: usr/lib/libosmoctrl.so.0 exists in debian/tmp but is not installed to anywhere dh_install: missing files, aborting make[1]: *** [override_dh_install] Error 2 make[1]: Leaving directory `/home/rhizomatica/gsm/libosmocore' make: *** [binary] Error 2 dpkg-buildpackage: error: debian/rules binary gave error exit status 2 So, it looks like it's trying to build a libosmogsm6 package, but only libosmogsm5.1.0 gets built. I looked around, and the only reference I found is in src/gsm/Makefile.am, and it's correct (6:0:1). What am I doing wrong? :) Cheers Ciaby -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iF4EAREKAAYFAlQDgJkACgkQC30ZhxNccpF5EgD/TmeKcYFpr8O/XXA6RRS7zm10 boe6pxAd8XVku0bVdXsBAJ8zOiPhkTmXlrBc3Tdefrx+subagwnBV1RV4dbses4M =dqEo -----END PGP SIGNATURE-----

4 11

[PATCH openbsc] configure: fix unrecognized option --enable-external-tests
by pablo＠gnumonks.org 02 Sep '14

02 Sep '14

From: Pablo Neira Ayuso <pablo(a)soleta.eu> ./configure --help indicates: --enable-external-tests Include the VTY/CTRL tests in make check [default=no] but ./configure ... --enable-external-tests configure: WARNING: unrecognized options: --enable-external-tests the name of the option seems to be --enable-ext-tests. --- openbsc/configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/openbsc/configure.ac b/openbsc/configure.ac index 0777c0d..40ee444 100644 --- a/openbsc/configure.ac +++ b/openbsc/configure.ac @@ -141,7 +141,7 @@ AC_ARG_ENABLE([vty_tests], [Include the VTY/CTRL tests in make check (deprecated) [default=no]]), [enable_ext_tests="$enableval"],[enable_ext_tests="no"]) -AC_ARG_ENABLE([ext_tests], +AC_ARG_ENABLE([external_tests], AC_HELP_STRING([--enable-external-tests], [Include the VTY/CTRL tests in make check [default=no]]), [enable_ext_tests="$enableval"],[enable_ext_tests="no"]) -- 1.7.10.4

2 1

[PATCH] gprs: Fix and check BVCI in BSSGP STATUS messages
by Jacob Erlbeck 01 Sep '14

01 Sep '14

Currently the BVCI is not set in all invocations to bssgp_tx_status() when the cause is UNKNOWN_BVCI. This patch adds the argument where it is missing. It also adds a check for compliance (GSM 08.18, 10.4.14.1) to bssgp_tx_status() to emit errors when the following requirement is not fulfilled: The BVCI must be included if (and only if) the cause is either "BVCI blocked" or "BVCI unknown". Sponsored-by: On-Waves ehf --- src/gb/gprs_bssgp.c | 2 +- src/gb/gprs_bssgp_util.c | 14 ++++++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/src/gb/gprs_bssgp.c b/src/gb/gprs_bssgp.c index 5ef1887..b8c6c74 100644 --- a/src/gb/gprs_bssgp.c +++ b/src/gb/gprs_bssgp.c @@ -998,7 +998,7 @@ int bssgp_rcvmsg(struct msgb *msg) LOGP(DBSSGP, LOGL_NOTICE, "NSEI=%u/BVCI=%u Rejecting PDU " "type %u for unknown BVCI\n", msgb_nsei(msg), ns_bvci, pdu_type); - return bssgp_tx_status(BSSGP_CAUSE_UNKNOWN_BVCI, NULL, msg); + return bssgp_tx_status(BSSGP_CAUSE_UNKNOWN_BVCI, &ns_bvci, msg); } if (bctx) { diff --git a/src/gb/gprs_bssgp_util.c b/src/gb/gprs_bssgp_util.c index ae4647e..261e0b0 100644 --- a/src/gb/gprs_bssgp_util.c +++ b/src/gb/gprs_bssgp_util.c @@ -99,6 +99,20 @@ int bssgp_tx_status(uint8_t cause, uint16_t *bvci, struct msgb *orig_msg) struct bssgp_normal_hdr *bgph = (struct bssgp_normal_hdr *) msgb_put(msg, sizeof(*bgph)); + /* GSM 08.18, 10.4.14.1: The BVCI must be included if (and only if) the + cause is either "BVCI blocked" or "BVCI unknown" */ + if (cause == BSSGP_CAUSE_UNKNOWN_BVCI || cause == BSSGP_CAUSE_BVCI_BLOCKED) { + if (bvci == NULL) + LOGP(DBSSGP, LOGL_ERROR, "BSSGP Tx STATUS, cause=%s: " + "missing conditional BVCI\n", + bssgp_cause_str(cause)); + } else { + if (bvci != NULL) + LOGP(DBSSGP, LOGL_ERROR, "BSSGP Tx STATUS, cause=%s: " + "unexpected conditional BVCI\n", + bssgp_cause_str(cause)); + } + LOGP(DBSSGP, LOGL_NOTICE, "BSSGP BVCI=%u Tx STATUS, cause=%s\n", bvci ? *bvci : 0, bssgp_cause_str(cause)); msgb_nsei(msg) = msgb_nsei(orig_msg); -- 1.9.1

1 0

Osmocom meetup in Boston
by Alexander Chemeris 01 Sep '14

01 Sep '14

Hi all, I plan to setup a meetup about Osmocom in Boston closer to the end of Sept. If you're interested - please sign up for it here, to help us gauge the interest: http://www.meetup.com/Open-source-telecom/ The plan is to have this as a more or less regular meeting around open-source solutions for telecom, particularly Osmocom, OpenBTS and OpenLTE, but including projects like Freeswitch, Clearwater, etc. These projects are interesting to me personally and after the first meeting the list might be shrunk or expanded based on the interest from other participants. -- Regards, Alexander Chemeris. CEO, Fairwaves, Inc. https://fairwaves.co

1 0

[PATCH] debian: fix build errors with libosmogsm and libosmoctrl
by Ciaby 01 Sep '14

01 Sep '14

libosmogsm: the transition from 5 to 6 wasn't done properly. Fixed version number. libosmoctrl: missing definition in debian/control and also missing libosmoctrl0.install. --- debian/control | 6 ++++++ debian/libosmoctrl0.install | 1 + debian/libosmogsm5.install | 1 - debian/libosmogsm6.install | 1 + src/gsm/Makefile.am | 2 +- 5 files changed, 9 insertions(+), 2 deletions(-) create mode 100644 debian/libosmoctrl0.install delete mode 100644 debian/libosmogsm5.install create mode 100644 debian/libosmogsm6.install diff --git a/debian/control b/debian/control index 3204f0f..e81f7cf 100644 --- a/debian/control +++ b/debian/control @@ -44,6 +44,12 @@ Architecture: any Depends: ${shlibs:Depends}, ${misc:Depends} Description: Osmo VTY library +Package: libosmoctrl0 +Section: libs +Architecture: any +Depends: ${shlibs:Depends}, ${misc:Depends} +Description: Osmo control library + Package: libosmocore-dev Section: libdevel Architecture: any diff --git a/debian/libosmoctrl0.install b/debian/libosmoctrl0.install new file mode 100644 index 0000000..6b23be8 --- /dev/null +++ b/debian/libosmoctrl0.install @@ -0,0 +1 @@ +usr/lib/libosmoctrl*.so.* diff --git a/debian/libosmogsm5.install b/debian/libosmogsm5.install deleted file mode 100644 index 12c9180..0000000 --- a/debian/libosmogsm5.install +++ /dev/null @@ -1 +0,0 @@ -usr/lib/libosmogsm*.so.* diff --git a/debian/libosmogsm6.install b/debian/libosmogsm6.install new file mode 100644 index 0000000..12c9180 --- /dev/null +++ b/debian/libosmogsm6.install @@ -0,0 +1 @@ +usr/lib/libosmogsm*.so.* diff --git a/src/gsm/Makefile.am b/src/gsm/Makefile.am index 4207959..1e2d893 100644 --- a/src/gsm/Makefile.am +++ b/src/gsm/Makefile.am @@ -1,6 +1,6 @@ # This is _NOT_ the library release version, it's an API version. # Please read Chapter 6 "Library interface versions" of the libtool documentation before making any modification -LIBVERSION=6:0:1 +LIBVERSION=6:0:0 AM_CFLAGS = -Wall ${GCC_FVISIBILITY_HIDDEN} $(all_includes) -I$(top_srcdir)/include -- 1.7.9.5 --------------020605080303040703010001 Content-Type: application/octet-stream; name="0001-debian-fix-build-errors-with-libosmogsm-and-libosmoc.patch.sig" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-debian-fix-build-errors-with-libosmogsm-and-libosmoc.pa"; filename*1="tch.sig" iF4EABEKAAYFAlQDjVQACgkQC30ZhxNccpEcUwD+PuSik47JmvVhLd7L74WaPo70JqqsK1MN zN8pgoPwYhEBAJXssWBprtwVxVGNVd0dcS7eEBQMF5By6ksG436tapcS --------------020605080303040703010001--

1 0

[PATCH] debian: fix build errors with libosmogsm and libosmoctrl
by Ciaby 01 Sep '14

01 Sep '14

libosmogsm: the transition from 5 to 6 wasn't done properly. Fixed version number. libosmoctrl: missing definition in debian/control and also missing libosmoctrl0.install. --- debian/control | 6 ++++++ debian/libosmoctrl0.install | 1 + debian/libosmogsm5.install | 1 - debian/libosmogsm6.install | 1 + src/gsm/Makefile.am | 2 +- 5 files changed, 9 insertions(+), 2 deletions(-) create mode 100644 debian/libosmoctrl0.install delete mode 100644 debian/libosmogsm5.install create mode 100644 debian/libosmogsm6.install diff --git a/debian/control b/debian/control index 3204f0f..e81f7cf 100644 --- a/debian/control +++ b/debian/control @@ -44,6 +44,12 @@ Architecture: any Depends: ${shlibs:Depends}, ${misc:Depends} Description: Osmo VTY library +Package: libosmoctrl0 +Section: libs +Architecture: any +Depends: ${shlibs:Depends}, ${misc:Depends} +Description: Osmo control library + Package: libosmocore-dev Section: libdevel Architecture: any diff --git a/debian/libosmoctrl0.install b/debian/libosmoctrl0.install new file mode 100644 index 0000000..6b23be8 --- /dev/null +++ b/debian/libosmoctrl0.install @@ -0,0 +1 @@ +usr/lib/libosmoctrl*.so.* diff --git a/debian/libosmogsm5.install b/debian/libosmogsm5.install deleted file mode 100644 index 12c9180..0000000 --- a/debian/libosmogsm5.install +++ /dev/null @@ -1 +0,0 @@ -usr/lib/libosmogsm*.so.* diff --git a/debian/libosmogsm6.install b/debian/libosmogsm6.install new file mode 100644 index 0000000..12c9180 --- /dev/null +++ b/debian/libosmogsm6.install @@ -0,0 +1 @@ +usr/lib/libosmogsm*.so.* diff --git a/src/gsm/Makefile.am b/src/gsm/Makefile.am index 4207959..1e2d893 100644 --- a/src/gsm/Makefile.am +++ b/src/gsm/Makefile.am @@ -1,6 +1,6 @@ # This is _NOT_ the library release version, it's an API version. # Please read Chapter 6 "Library interface versions" of the libtool documentation before making any modification -LIBVERSION=6:0:1 +LIBVERSION=6:0:0 AM_CFLAGS = -Wall ${GCC_FVISIBILITY_HIDDEN} $(all_includes) -I$(top_srcdir)/include -- 1.7.9.5 --------------070700020400040502040808 Content-Type: application/octet-stream; name="0001-debian-fix-build-errors-with-libosmogsm-and-libosmoc.patch.sig" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-debian-fix-build-errors-with-libosmogsm-and-libosmoc.pa"; filename*1="tch.sig" iF4EABEKAAYFAlQGAmEACgkQC30ZhxNccpHMZAEAuXAMQd3yavDff+y8bU0ZEWKORaplPlFS iEZ706MhotYA/ioKSXn35kmFyDFIv7Kdzcf5GmVDdwS8OwhCBJrJWv83 --------------070700020400040502040808--

1 0

[PATCH] debian: fix build errors with libosmogsm and libosmoctrl
by Ciaby 01 Sep '14

01 Sep '14

libosmogsm: the transition from 5 to 6 wasn't done properly. Fixed version number. libosmoctrl: missing definition in debian/control and also missing libosmoctrl0.install. --- debian/control | 6 ++++++ debian/libosmoctrl0.install | 1 + .../{libosmogsm5.install => libosmogsm6.install} | 0 src/gsm/Makefile.am | 2 +- 4 files changed, 8 insertions(+), 1 deletion(-) create mode 100644 debian/libosmoctrl0.install rename debian/{libosmogsm5.install => libosmogsm6.install} (100%) diff --git a/debian/control b/debian/control index 3204f0f..e81f7cf 100644 --- a/debian/control +++ b/debian/control @@ -44,6 +44,12 @@ Architecture: any Depends: ${shlibs:Depends}, ${misc:Depends} Description: Osmo VTY library +Package: libosmoctrl0 +Section: libs +Architecture: any +Depends: ${shlibs:Depends}, ${misc:Depends} +Description: Osmo control library + Package: libosmocore-dev Section: libdevel Architecture: any diff --git a/debian/libosmoctrl0.install b/debian/libosmoctrl0.install new file mode 100644 index 0000000..6b23be8 --- /dev/null +++ b/debian/libosmoctrl0.install @@ -0,0 +1 @@ +usr/lib/libosmoctrl*.so.* diff --git a/debian/libosmogsm5.install b/debian/libosmogsm6.install similarity index 100% rename from debian/libosmogsm5.install rename to debian/libosmogsm6.install diff --git a/src/gsm/Makefile.am b/src/gsm/Makefile.am index 4207959..1e2d893 100644 --- a/src/gsm/Makefile.am +++ b/src/gsm/Makefile.am @@ -1,6 +1,6 @@ # This is _NOT_ the library release version, it's an API version. # Please read Chapter 6 "Library interface versions" of the libtool documentation before making any modification -LIBVERSION=6:0:1 +LIBVERSION=6:0:0 AM_CFLAGS = -Wall ${GCC_FVISIBILITY_HIDDEN} $(all_includes) -I$(top_srcdir)/include -- 1.7.9.5 --------------080008040908010200020003 Content-Type: application/octet-stream; name="0001-debian-fix-build-errors-with-libosmogsm-and-libosmoc.patch.sig" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-debian-fix-build-errors-with-libosmogsm-and-libosmoc.pa"; filename*1="tch.sig" iF4EABEKAAYFAlQGBL8ACgkQC30ZhxNccpFrWQD/ZM1qKhGG0XYqxdU6adl3sub3NOTZk6XE DeprqaFLzGgA/R0FmlHzefNHPxRgZo0NnUNVamw65cfmhB1jGbnMMjH2 --------------080008040908010200020003--

1 0

[PATCH 1/8] l1sap: Port code to new ciphering handling
by Harald Welte 28 Aug '14

28 Aug '14

... introduced in 2cc37035d73191b71b9ba9c0d559a0da6a5f35e5 --- include/osmo-bts/l1sap.h | 2 ++ src/common/l1sap.c | 45 ++++++++++++++++++++++++++++++++---------- src/osmo-bts-sysmo/l1_if.c | 32 ------------------------------ src/osmo-bts-sysmo/l1_if.h | 3 --- tests/sysmobts/sysmobts_test.c | 10 +++++++--- 5 files changed, 44 insertions(+), 48 deletions(-) diff --git a/include/osmo-bts/l1sap.h b/include/osmo-bts/l1sap.h index dee430f..e76aca6 100644 --- a/include/osmo-bts/l1sap.h +++ b/include/osmo-bts/l1sap.h @@ -68,4 +68,6 @@ extern uint8_t gsmtap_sapi_acch; #define msgb_l1sap_prim(msg) ((struct osmo_phsap_prim *)(msg)->l1h) +int bts_check_for_first_ciphrd(struct gsm_lchan *lchan, + uint8_t *data, int len); #endif /* L1SAP_H */ diff --git a/src/common/l1sap.c b/src/common/l1sap.c index 14dbde9..9c7a9c6 100644 --- a/src/common/l1sap.c +++ b/src/common/l1sap.c @@ -481,6 +481,39 @@ static void radio_link_timeout(struct gsm_lchan *lchan, int bad_frame) } } +static inline int check_for_first_ciphrd(struct gsm_lchan *lchan, + uint8_t *data, int len) +{ + uint8_t n_s; + + /* if this is the first valid message after enabling Rx + * decryption, we have to enable Tx encryption */ + if (lchan->ciph_state != LCHAN_CIPH_RX_CONF) + return 0; + + /* HACK: check if it's an I frame, in order to + * ignore some still buffered/queued UI frames received + * before decryption was enabled */ + if (data[0] != 0x01) + return 0; + + if ((data[1] & 0x01) != 0) + return 0; + + n_s = data[1] >> 5; + if (lchan->ciph_ns != n_s) + return 0; + + return 1; +} + +/* public helper for the test */ +int bts_check_for_first_ciphrd(struct gsm_lchan *lchan, + uint8_t *data, int len) +{ + return check_for_first_ciphrd(lchan, data, len); +} + /* DATA received from bts model */ static int l1sap_ph_data_ind(struct gsm_bts_trx *trx, struct osmo_phsap_prim *l1sap, struct ph_data_param *data_ind) @@ -557,16 +590,8 @@ static int l1sap_ph_data_ind(struct gsm_bts_trx *trx, } else le = &lchan->lapdm_ch.lapdm_dcch; - /* if this is the first valid message after enabling Rx - * decryption, we have to enable Tx encryption */ - if (lchan->ciph_state == LCHAN_CIPH_RX_CONF) { - /* HACK: check if it's an I frame, in order to - * ignore some still buffered/queued UI frames received - * before decryption was enabled */ - if (data[0] == 0x01 && (data[1] & 0x01) == 0) { - l1sap_tx_ciph_req(trx, chan_nr, 1, 0); - } - } + if (check_for_first_ciphrd(lchan, data, len)) + l1sap_tx_ciph_req(lchan->ts->trx, chan_nr, 1, 0); /* SDCCH, SACCH and FACCH all go to LAPDm */ msgb_pull(msg, (msg->l2h - msg->data)); diff --git a/src/osmo-bts-sysmo/l1_if.c b/src/osmo-bts-sysmo/l1_if.c index b62a2a3..14efc2c 100644 --- a/src/osmo-bts-sysmo/l1_if.c +++ b/src/osmo-bts-sysmo/l1_if.c @@ -356,31 +356,6 @@ static int check_for_ciph_cmd(struct femtol1_hdl *fl1h, return 1; } -static inline void check_for_first_ciphrd(struct femtol1_hdl *fl1h, - GsmL1_MsgUnitParam_t *msgUnitParam, - struct gsm_lchan *lchan) -{ - uint8_t n_s; - - /* if this is the first valid message after enabling Rx - * decryption, we have to enable Tx encryption */ - if (lchan->ciph_state != LCHAN_CIPH_RX_CONF) - return; - - /* HACK: check if it's an I frame, in order to - * ignore some still buffered/queued UI frames received - * before decryption was enabled */ - if (msgUnitParam->u8Buffer[0] != 0x01) - return; - if ((msgUnitParam->u8Buffer[1] & 0x01) != 0) - return; - n_s = msgUnitParam->u8Buffer[1] >> 5; - if (lchan->ciph_ns != n_s) - return; - lchan->ciph_state = LCHAN_CIPH_TXRX_REQ; - l1if_set_ciphering(fl1h, lchan, 1); -} - /* public helpers for the test */ int bts_check_for_ciph_cmd(struct femtol1_hdl *fl1h, struct msgb *msg, struct gsm_lchan *lchan) @@ -388,13 +363,6 @@ int bts_check_for_ciph_cmd(struct femtol1_hdl *fl1h, return check_for_ciph_cmd(fl1h, msg, lchan); } -void bts_check_for_first_ciphrd(struct femtol1_hdl *fl1h, - GsmL1_MsgUnitParam_t *msgUnitParam, - struct gsm_lchan *lchan) -{ - return check_for_first_ciphrd(fl1h, msgUnitParam, lchan); -} - static const uint8_t fill_frame[GSM_MACBLOCK_LEN] = { 0x03, 0x03, 0x01, 0x2B, 0x2B, 0x2B, 0x2B, 0x2B, 0x2B, 0x2B, 0x2B, 0x2B, 0x2B, 0x2B, 0x2B, 0x2B, 0x2B, 0x2B, 0x2B, 0x2B, diff --git a/src/osmo-bts-sysmo/l1_if.h b/src/osmo-bts-sysmo/l1_if.h index 6f58e95..a425776 100644 --- a/src/osmo-bts-sysmo/l1_if.h +++ b/src/osmo-bts-sysmo/l1_if.h @@ -138,7 +138,4 @@ int l1if_rf_clock_info_correct(struct femtol1_hdl *fl1h); /* public helpers for test */ int bts_check_for_ciph_cmd(struct femtol1_hdl *fl1h, struct msgb *msg, struct gsm_lchan *lchan); -void bts_check_for_first_ciphrd(struct femtol1_hdl *fl1h, - GsmL1_MsgUnitParam_t *msgUnitParam, - struct gsm_lchan *lchan); #endif /* _FEMTO_L1_H */ diff --git a/tests/sysmobts/sysmobts_test.c b/tests/sysmobts/sysmobts_test.c index acbc09c..3ed78fd 100644 --- a/tests/sysmobts/sysmobts_test.c +++ b/tests/sysmobts/sysmobts_test.c @@ -18,6 +18,7 @@ */ #include <osmo-bts/bts.h> +#include <osmo-bts/l1sap.h> #include "femtobts.h" #include "l1_if.h" @@ -169,14 +170,17 @@ static void test_sysmobts_cipher(void) /* Handle message sent before ciphering was received */ memcpy(&unit.u8Buffer[0], too_early_classmark, ARRAY_SIZE(too_early_classmark)); unit.u8Size = ARRAY_SIZE(too_early_classmark); - bts_check_for_first_ciphrd(&fl1h, &unit, &lchan); + rc = bts_check_for_first_ciphrd(&lchan, unit.u8Buffer, unit.u8Size); + OSMO_ASSERT(rc == 0); OSMO_ASSERT(lchan.ciph_state == LCHAN_CIPH_RX_CONF); /* Now send the first ciphered message */ memcpy(&unit.u8Buffer[0], first_ciphered_cipher_cmpl, ARRAY_SIZE(first_ciphered_cipher_cmpl)); unit.u8Size = ARRAY_SIZE(first_ciphered_cipher_cmpl); - bts_check_for_first_ciphrd(&fl1h, &unit, &lchan); - OSMO_ASSERT(lchan.ciph_state == LCHAN_CIPH_TXRX_REQ); + rc = bts_check_for_first_ciphrd(&lchan, unit.u8Buffer, unit.u8Size); + OSMO_ASSERT(rc == 1); + /* we cannot test for lchan.ciph_state == * LCHAN_CIPH_RX_CONF_TX_REQ, as + * this happens asynchronously on the other side of the l1sap queue */ } int main(int argc, char **argv) -- 2.1.0 --PMULwz+zIGJzpDN9 Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0002-Add-MEAS-MPH_INFO-IND-message-to-PH-MPH-TCH-SAP-inte.patch"

1 0

(no subject)
by Snehasish Kar (Vehere) 26 Aug '14

26 Aug '14

Dear Groupmembers Please help me with this case. I have successfully sent rrlp request to the mobile and the mobile automatically turns its gps on as a response to it. But it doesn't provide me its location or request for any kind of assistance data. So please let me know what i am missing and what i have to do. Thanks & Regards Snehasish

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

OpenBSC