OpenBSC April 2014

openbsc@lists.osmocom.org

15 participants
22 discussions

[PATCH] ipa: Be consistent in checking conn->cfg (Coverity)

by Jacob Erlbeck

Coverity complains about checking connection->cfg in bsc_close_connection() at one place but not at the second. This patch fixes this by adding a check before accessing cfg when generating the 'partial message' log message. Fixes: Coverity CID 1195180 Sponsored-by: On-Waves ehf --- openbsc/src/osmo-bsc_nat/bsc_nat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/openbsc/src/osmo-bsc_nat/bsc_nat.c b/openbsc/src/osmo-bsc_nat/bsc_nat.c index 524186a..9defbd2 100644 --- a/openbsc/src/osmo-bsc_nat/bsc_nat.c +++ b/openbsc/src/osmo-bsc_nat/bsc_nat.c @@ -916,7 +916,7 @@ void bsc_close_connection(struct bsc_connection *connection) if (connection->pending_msg) { LOGP(DNAT, LOGL_ERROR, "Dropping partial message on connection %d.\n", - connection->cfg->nr); + connection->cfg ? connection->cfg->nr : -1); msgb_free(connection->pending_msg); connection->pending_msg = NULL; } -- 1.7.9.5

11 years, 6 months

SMPP + OpenBSC

by Jesús Vega Diaz

Hi all; I have deployed one ipaccess nanoBTS 1800, with OpenBSC (osmo-nitb) and all the osmocom suite apps. I have already make succesfully GSM calls, SMS, and GPRS/EDGE packet data connections. I now want support for sending binary SMS, i have read that with SMPP i would can. I have compiled OpenBSC with SMPP but now I don´t know how to use it, i think it is in the OpenBSC vty, but i don´t know the commands or how to use the interface. If you can give me some light in this thread i will grant you. Sorry for my English Best Regards Jesús Vega Diaz

11 years, 6 months

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

OpenBSC April 2014