9 Mar
2014
9 Mar
'14
11:54 a.m.
An according change in the OpoenBSC is following.
Since we're changing the external API we should probably increase a
lib version as well.
--
Regards,
Alexander Chemeris.
CEO, Fairwaves, Inc. / ООО УмРадио
https://fairwaves.co
9 Mar
9 Mar
7:23 p.m.
On Sun, Mar 09, 2014 at 11:54:56AM +0100, Alexander Chemeris wrote:
An according change in the OpoenBSC is following.
Since we're changing the external API we should probably increase a
lib version as well.
Hi,
to ease migration it is easier if you introduce a new method and
deprecate the other. Otherwise OpenBSC requires an unreleased version
of libosmocore. Otherwise it is a basic rename. :)
10 Mar
10 Mar
7:40 p.m.
Good idea. An updated patch is attached.
On Sun, Mar 9, 2014 at 7:23 PM, Holger Hans Peter Freyther
<holger(a)freyther.de> wrote:
On Sun, Mar 09, 2014 at 11:54:56AM +0100, Alexander
Chemeris wrote:
--
Regards,
Alexander Chemeris.
CEO, Fairwaves, Inc. / ООО УмРадио
https://fairwaves.co
An according change in the OpoenBSC is
following.
Since we're changing the external API we should probably increase a
lib version as well.
Hi,
to ease migration it is easier if you introduce a new method and
deprecate the other. Otherwise OpenBSC requires an unreleased version
of libosmocore. Otherwise it is a basic rename. :)
11 Mar
11 Mar
3:26 p.m.
On Mon, Mar 10, 2014 at 07:40:51PM +0100, Alexander Chemeris wrote:
Good idea. An updated patch is attached.
+/* DEPRECATED: use gsm340_gen_address_field() instead
*/
+int gsm340_gen_oa(uint8_t *oa, unsigned int oa_len, uint8_t type,
+ uint8_t plan, const char *number) OSMO_DEPRECATED("Use gsm340_gen_address_field()
instead");
this comment doesn't really add any value. You are using OSMO_DEPRECTAED
but you do not directly/indirectly the header file defining it. In fact
gsm0411_smc.c fails to compile due this.
5:16 p.m.
On Tue, Mar 11, 2014 at 6:26 PM, Holger Hans Peter Freyther
<holger(a)freyther.de> wrote:
On Mon, Mar 10, 2014 at 07:40:51PM +0100, Alexander
Chemeris wrote:
I don't see how it harms either. Though I've removed it in the attached patch.
Good idea. An updated patch is attached.
+/* DEPRECATED: use gsm340_gen_address_field()
instead */
+int gsm340_gen_oa(uint8_t *oa, unsigned int oa_len, uint8_t type,
+ uint8_t plan, const char *number) OSMO_DEPRECATED("Use
gsm340_gen_address_field() instead");
this comment doesn't really add any value. You are using OSMO_DEPRECTAED
but you do not directly/indirectly the header file defining it. In fact
gsm0411_smc.c fails to compile due this.
Oops, forgot to include this in the patch, my apologies.
Updated patch is attached.
--
Regards,
Alexander Chemeris.
CEO, Fairwaves, Inc. / ООО УмРадио
https://fairwaves.co
12 Mar
12 Mar
1:37 p.m.
On Tue, Mar 11, 2014 at 08:16:49PM +0400, Alexander Chemeris wrote:
wrong patch. I merged this one anyway after grepping my checkouts
for the typo.
You are using
OSMO_DEPRECTAED
but you do not directly/indirectly the header file defining it. In fact
gsm0411_smc.c fails to compile due this.
Oops, forgot to include this in the patch, my apologies.
Updated patch is attached.
2:05 p.m.
On Wed, Mar 12, 2014 at 4:37 PM, Holger Hans Peter Freyther
<holger(a)freyther.de> wrote:
On Tue, Mar 11, 2014 at 08:16:49PM +0400, Alexander
Chemeris wrote:
wrong patch. I merged this one anyway after grepping my checkouts
for the typo.
Sorry, the correct patch attached.
--
Regards,
Alexander Chemeris.
CEO, Fairwaves, Inc. / ООО УмРадио
https://fairwaves.co
You are
using OSMO_DEPRECTAED
but you do not directly/indirectly the header file defining it. In fact
gsm0411_smc.c fails to compile due this.
Oops, forgot to include this in the patch, my apologies.
Updated patch is attached.
16 Mar
16 Mar
10:50 a.m.
Hi Holger,
It seems there are no more comments on this code. Could you please merge it?
It is independent of other changes.
On Wed, Mar 12, 2014 at 5:05 PM, Alexander Chemeris
<alexander.chemeris(a)gmail.com> wrote:
On Wed, Mar 12, 2014 at 4:37 PM, Holger Hans Peter
Freyther
<holger(a)freyther.de> wrote:
--
Regards,
Alexander Chemeris.
CEO, Fairwaves, Inc. / ООО УмРадио
https://fairwaves.co
On Tue, Mar 11, 2014 at 08:16:49PM +0400,
Alexander Chemeris wrote:
wrong patch. I merged this one anyway after grepping my checkouts
for the typo.
Sorry, the correct patch attached.
--
Regards,
Alexander Chemeris.
CEO, Fairwaves, Inc. / ООО УмРадио
https://fairwaves.co You are
using OSMO_DEPRECTAED
but you do not directly/indirectly the header file defining it. In fact
gsm0411_smc.c fails to compile due this.
Oops, forgot to include this in the patch, my apologies.
Updated patch is attached.
26 Mar
26 Mar
8:22 p.m.
On Sun, Mar 16, 2014 at 01:50:10PM +0400, Alexander Chemeris wrote:
Hi Holger,
It seems there are no more comments on this code. Could you please merge it?
It is independent of other changes.
Hi!
in Osmocom we prefer shorted/abbreviated names. Do you mind if we call
it gsm340_gen_addr_field instead? This way some of the lines from the
testcase get closer to 80 chars.
holger
27 Mar
27 Mar
6:14 a.m.
Holger,
On Wed, Mar 26, 2014 at 11:22 PM, Holger Hans Peter Freyther
<holger(a)freyther.de> wrote:
On Sun, Mar 16, 2014 at 01:50:10PM +0400, Alexander
Chemeris wrote:
Good idea. I'll update the patch during the next week.
--
Regards,
Alexander Chemeris.
CEO, Fairwaves, Inc.
https://fairwaves.co
Hi Holger,
It seems there are no more comments on this code. Could you please merge it?
It is independent of other changes.
in Osmocom we prefer shorted/abbreviated names. Do you mind if we call
it gsm340_gen_addr_field instead? This way some of the lines from the
testcase get closer to 80 chars.
18 Apr
18 Apr
7:46 a.m.
Hi Holger,
I was busy recently, sorry. I plan to get back to this patch set soon.
Please excuse typos. Written with a touchscreen keyboard.
--
Regards,
Alexander Chemeris
CEO/Founder Fairwaves LLC
https://fairwaves.co
18 апр. 2014 г. 1:30 пользователь "Holger Hans Peter Freyther" <
holger(a)freyther.de> написал:
On Thu, Mar 27, 2014 at 09:14:26AM +0400, Alexander
Chemeris wrote:
Good idea. I'll update the patch during the
next week.
Did I miss your follow-up patch?
3666
days inactive
3706
days old
11 comments
2 participants
participants (2)
-
Alexander Chemeris -
Holger Hans Peter Freyther