Review at https://gerrit.osmocom.org/107
rlc.h: remove duplicated define RLC_EGPRS_SNS
Change-Id: Ibb718ba9be21831c56c5949e730fab5acd691d7c --- M src/rlc.h 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/07/107/1
diff --git a/src/rlc.h b/src/rlc.h index 8f75588..03659da 100644 --- a/src/rlc.h +++ b/src/rlc.h @@ -27,7 +27,6 @@
#define RLC_GPRS_SNS 128 /* GPRS, must be power of 2 */ #define RLC_GPRS_WS 64 /* max window size */ -#define RLC_EGPRS_SNS 2048 /* EGPRS, must be power of 2 */ #define RLC_EGPRS_MIN_WS 64 /* min window size */ #define RLC_EGPRS_MAX_WS 1024 /* min window size */ #define RLC_EGPRS_SNS 2048 /* EGPRS, must be power of 2 */
Patch Set 1: Code-Review+2
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/107/1//COMMIT_MSG Commit Message:
Line 7: rlc.h: remove duplicated define RLC_EGPRS_SNS Can you explain where it is duplicated? What is the compiler warning you get?
Hello Harald Welte, Jenkins Builder, Holger Freyther,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/107
to look at the new patch set (#2).
rlc.h: remove duplicated define RLC_EGPRS_SNS
The second #define RLC_EGPRS_SNS is 3 lines below of the first one.
Change-Id: Ibb718ba9be21831c56c5949e730fab5acd691d7c --- M src/rlc.h 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/07/107/2
diff --git a/src/rlc.h b/src/rlc.h index 8f75588..03659da 100644 --- a/src/rlc.h +++ b/src/rlc.h @@ -27,7 +27,6 @@
#define RLC_GPRS_SNS 128 /* GPRS, must be power of 2 */ #define RLC_GPRS_WS 64 /* max window size */ -#define RLC_EGPRS_SNS 2048 /* EGPRS, must be power of 2 */ #define RLC_EGPRS_MIN_WS 64 /* min window size */ #define RLC_EGPRS_MAX_WS 1024 /* min window size */ #define RLC_EGPRS_SNS 2048 /* EGPRS, must be power of 2 */
Patch Set 2:
(1 comment)
@Holger: I'vn't looked at compiler warnings. Just found it by accident ;)
https://gerrit.osmocom.org/#/c/107/1/src/rlc.h File src/rlc.h:
Line 33 here
Patch Set 2: Code-Review+2
Holger Freyther has submitted this change and it was merged.
Change subject: rlc.h: remove duplicated define RLC_EGPRS_SNS ......................................................................
rlc.h: remove duplicated define RLC_EGPRS_SNS
The second #define RLC_EGPRS_SNS is 3 lines below of the first one.
Change-Id: Ibb718ba9be21831c56c5949e730fab5acd691d7c Reviewed-on: https://gerrit.osmocom.org/107 Tested-by: Jenkins Builder Reviewed-by: Holger Freyther holger@freyther.de --- M src/rlc.h 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: Jenkins Builder: Verified Holger Freyther: Looks good to me, approved
diff --git a/src/rlc.h b/src/rlc.h index 8f75588..03659da 100644 --- a/src/rlc.h +++ b/src/rlc.h @@ -27,7 +27,6 @@
#define RLC_GPRS_SNS 128 /* GPRS, must be power of 2 */ #define RLC_GPRS_WS 64 /* max window size */ -#define RLC_EGPRS_SNS 2048 /* EGPRS, must be power of 2 */ #define RLC_EGPRS_MIN_WS 64 /* min window size */ #define RLC_EGPRS_MAX_WS 1024 /* min window size */ #define RLC_EGPRS_SNS 2048 /* EGPRS, must be power of 2 */
-
Harald Welte -
Holger Freyther
-
lynxis lazus