Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/105 to look at the new patch set (#2). tbf_ul: use correct size for chunk_size The size of the hole array in bytes was used instead of the size of elements. Change-Id: If6bf3e5f1ad773ddaa9fb2ce7c069e6b26659cbf --- M src/tbf_ul.cpp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/05/105/2 diff --git a/src/tbf_ul.cpp b/src/tbf_ul.cpp index 9e763f4..1316204 100644 --- a/src/tbf_ul.cpp +++ b/src/tbf_ul.cpp @@ -60,7 +60,7 @@ LOGP(DRLCMACUL, LOGL_DEBUG, "- Assembling frames: (len=%d)\n", len); num_frames = Decoding::rlc_data_from_ul_data( - rdbi, cs, data, &(frames[0]), sizeof(frames), + rdbi, cs, data, &(frames[0]), ARRAY_SIZE(frames), &dummy_tlli); /* create LLC frames */ -- To view, visit https://gerrit.osmocom.org/105 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: If6bf3e5f1ad773ddaa9fb2ce7c069e6b26659cbf Gerrit-PatchSet: 2 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu>

Holger Freyther has submitted this change and it was merged. Change subject: tbf_ul: use correct size for chunk_size ...................................................................... tbf_ul: use correct size for chunk_size The size of the hole array in bytes was used instead of the size of elements. Change-Id: If6bf3e5f1ad773ddaa9fb2ce7c069e6b26659cbf Reviewed-on: https://gerrit.osmocom.org/105 Tested-by: Jenkins Builder Reviewed-by: Holger Freyther <holger@freyther.de> --- M src/tbf_ul.cpp 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified Holger Freyther: Looks good to me, approved diff --git a/src/tbf_ul.cpp b/src/tbf_ul.cpp index 9e763f4..1316204 100644 --- a/src/tbf_ul.cpp +++ b/src/tbf_ul.cpp @@ -60,7 +60,7 @@ LOGP(DRLCMACUL, LOGL_DEBUG, "- Assembling frames: (len=%d)\n", len); num_frames = Decoding::rlc_data_from_ul_data( - rdbi, cs, data, &(frames[0]), sizeof(frames), + rdbi, cs, data, &(frames[0]), ARRAY_SIZE(frames), &dummy_tlli); /* create LLC frames */ -- To view, visit https://gerrit.osmocom.org/105 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6bf3e5f1ad773ddaa9fb2ce7c069e6b26659cbf Gerrit-PatchSet: 3 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Holger Freyther <holger@freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu>