On Wed, Apr 30, 2014 at 05:01:55PM +0300, Nikola Kolev wrote:
Fix for FreeBSD.
Hey!
could you extend the commit message a bit? E.g. include the compile error you fixed and mention how IF_RECVIF is compatible to the bindtodevice. The support to IF_SENDIF doesn't seem to have ever been finished in FreeBSD.
On Apr 30 2014, Holger Hans Peter Freyther wrote:
On Wed, Apr 30, 2014 at 05:01:55PM +0300, Nikola Kolev wrote:
Fix for FreeBSD.
Hey!
could you extend the commit message a bit? E.g. include the compile error you fixed and mention how IF_RECVIF is compatible to the bindtodevice. The support to IF_SENDIF doesn't seem to have ever been finished in FreeBSD.
I separated the patch file to 2 different files because of different commit messages and sent them back to the mail list.
On Wed, May 07, 2014 at 11:06:20AM +0300, Nikola Kolev wrote:
Hi!
I separated the patch file to 2 different files because of different commit messages and sent them back to the mail list.
please use "git commit" and then git format-patch and send the result of it. Using git send-email gives you extra points. Like FreeBSD is an engineering project, I try to have Osmocom become one too. So the commit message should be held to the same standard as the rest of the code.
E.g. if your code works with SO_RECVIF and the commit message talks about SO_SENDIF we need to fix either one or the other (and seeing that the SO_SENDIF code was never finished the commit message should be changed though).
cheers holger
-
Holger Hans Peter Freyther -
Nikola Kolev