Hello list,
we are working on extensions to pySim for the sjs2 card mainly to make our 5G phones to accept our network.
How should we send this patches?
Via this mailing list or should we wait a little longer until Harald finished restructuring the mailing lists?
Best Regards
Bjoern
Hello,
On 3/17/21 9:56 AM, Riemer, Björn wrote:
How should we send this patches?
we do accept patches via Gerrit, please see:
https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit/
Best regards, Vadim.
Hi Bjoern,
On Wed, Mar 17, 2021 at 08:56:35AM +0000, Riemer, Björn wrote:
we are working on extensions to pySim for the sjs2 card mainly to make our 5G phones to accept our network.
excellent. I presume it mostly relates to either disabling some EF.UST entries related to 5G, or filling those files in DF_5GS with content?
How should we send this patches?
We are using a gerrit-based patch submission process, see https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit and https://gerrit.osmocom.org/q/project:pysim
gerrit is integrated with jenkins, wehre a build slave will execute automatic tests with a variety of different physical SIM cards.
Only if those pass, you get a V+1. And we perform code review/voting in the gerrit, too.
Via this mailing list or should we wait a little longer until Harald finished restructuring the mailing lists?
I would prefer to submit via gerrit. If you face some difficulties, we can fall back to the mailing list, but then somebody will have to pick the patches up from the ML and push them in gerrit anyway, as all our commits go through gerrit for automatic testing and approvals.
Thanks, Harald
Hi Harald,
Von: Harald Welte laforge@osmocom.org Gesendet: Mittwoch, 17. März 2021 17:11
excellent. I presume it mostly relates to either disabling some EF.UST entries related to 5G, or filling those files in DF_5GS with content?
Currently we are flippng some bits in the EF*plmnwACT lists and adding additional entries in the ehplmn list. It seems that one specific baseband vendor needs the current HPLMN in the eHPLMN list as well..
We might have a look at the other files as well, but for now testing is not so fast as we have very limited access to the offices where the gNodeB is located..
gerrit is integrated with jenkins, wehre a build slave will execute automatic tests with a variety of different physical SIM cards.
Does this mean that if we introduce layout and content changes to the pySim-read output we have to modify the files in the pysim-testdata subfolder as well?
Bjoern
On March 17, 2021 9:48:54 PM GMT+01:00, "Riemer, Björn" bjoern.riemer@fokus.fraunhofer.de wrote:
gerrit is integrated with jenkins, wehre a build slave will execute automatic tests with a variety of different physical SIM cards.
Does this mean that if we introduce layout and content changes to the pySim-read output we have to modify the files in the pysim-testdata subfolder as well?
Yes, you will see the patches failing otherwise. You can re-upload any number of times until it passes.
Please not in general I would encourage most new features, particularly for supporting new file types to be primarily developed for pysim-shell. But let's first have your patches in gerrit and review them there.
Thanks!
-
Harald Welte -
Harald Welte -
Riemer, Björn -
Vadim Yanitskiy