Dears,
Can you explain how to add packages to wire shark ?
I quoted the following :
A-bis OML dissector¶ http://openbsc.osmocom.org/trac/wiki/PacketDump#A-bisOMLdissector
To add a dissector for the GSM 12.21 A-bis Organization and Maintenance Layer (OML), you can use the abis_oml.patch file from the wireshark directory of our git repository. This will be submitted for inclusion into wireshark soon.
From
http://openbsc.osmocom.org/trac/wiki/PacketDump
is the above updated on the latest apt-get install wireshark , or we need to get the sources and apply the patch !!! plz let me know how ?
Omar Atia TPSG Functional Consultant
ITS Logo.png T. + (961) 9 641555 ext. 416
M. + (961) 3 001294 F. + (961) 9 641555 ext. 217
degital signeture.pngE. mailto:omar.atia@its.ws omar.atia@its.ws
On 01/11/2011 08:47 AM, Omar Atia wrote:
Dears,
is the above updated on the latest apt-get install wireshark , or we need to get the sources and apply the patch !!! plz let me know how ?
Yes, you will need to get the sources and then apply the patches. The easiest way to apply them is using git am on a copy of the sources created with git svn. There are plenty of manuals around the web for that.
holger
Dear Holger,, Can you plz send me the git link which is suitable to apply patch through it . Thanks, Omar Atia -----Original Message----- From: openbsc-bounces@lists.gnumonks.org [mailto:openbsc-bounces@lists.gnumonks.org] On Behalf Of Holger Hans Peter Freyther Sent: Tuesday, January 11, 2011 10:17 AM To: openbsc@lists.gnumonks.org Subject: Re: Adding patches to wireshark...
On 01/11/2011 08:47 AM, Omar Atia wrote:
Dears,
is the above updated on the latest apt-get install wireshark , or we need
to
get the sources and apply the patch !!! plz let me know how ?
Yes, you will need to get the sources and then apply the patches. The easiest way to apply them is using git am on a copy of the sources created with git svn. There are plenty of manuals around the web for that.
holger
On 01/11/2011 09:31 AM, Omar Atia wrote:
Dear Holger,, Can you plz send me the git link which is suitable to apply patch through it
Dear Oma,
I think you need to be proactive beyond sending email. Have you googled for git svn tutorial? Do you know what git, svn and such are? Have you ever used one of these? Do you know the concept of a patch? Have you created one yourself? applied one? Do you know where to find the wireshark svn repository? have you searched for it? What were your search terms?
Yes dear I worked git which I used to download the src for libosmocore and opensbsc...
I have downloaded the sources from debian wireshark , even I have compiled it when I tired to install the patch ...
Patch -p1 (patch file) it raises a problem in Makefile.common , and didn't patch the Makefile.common but it did create the C and header files for the below patch abis_oml.patch under dissector, but the issue in the make file , how can I add them to make file in order to be compiled ...
Any way I will google git svn tonight and check it , but if you have any hint for the version of wireshark I should download the sources for it let me know .
Thanks, Omar Atia
-----Original Message----- From: openbsc-bounces@lists.gnumonks.org [mailto:openbsc-bounces@lists.gnumonks.org] On Behalf Of Holger Hans Peter Freyther Sent: Tuesday, January 11, 2011 10:49 AM To: openbsc@lists.gnumonks.org Subject: Re: Adding patches to wireshark...
On 01/11/2011 09:31 AM, Omar Atia wrote:
Dear Holger,, Can you plz send me the git link which is suitable to apply patch through
it
Dear Oma,
I think you need to be proactive beyond sending email. Have you googled for git svn tutorial? Do you know what git, svn and such are? Have you ever used one of these? Do you know the concept of a patch? Have you created one yourself? applied one? Do you know where to find the wireshark svn repository? have you searched for it? What were your search terms?
I have downloaded the sources from debian wireshark , even I have compiled it when I tired to install the patch ...
I compiled a new wireshark (based on the 1.4.2 sources, but from svn/git will probably be easier) this week end and the patch may not apply totally cleanly and you will need tweaks and such ...
Totally new dissectors might also require a autoreconf -i (so you'd better know autotools and how to solve those issue as well, google for it)
But any decent programmer should have no trouble fixing all that by himself. All this is provided "AS-IS" and making it work for your specific setup is up to you.
Cheers,
Sylvain
On 01/11/2011 10:01 AM, Omar Atia wrote:
Yes dear I worked git which I used to download the src for libosmocore and opensbsc...
:)
Patch -p1 (patch file) it raises a problem in Makefile.common , and didn't patch the Makefile.common but it did create the C and header files for the below patch abis_oml.patch under dissector, but the issue in the make file , how can I add them to make file in order to be compiled ...
Always hard to judge where the difficulty is. The GNU patch program is leaving a FILENAME.orig and a FILENAME.rej next to the file that failed to be patched. In your case you should have a Makefile.common.rej that shows you which 'hunk' (part of the patch) was not applied. You simply need to add the abis-oml c file to that...
Any way I will google git svn tonight and check it , but if you have any hint for the version of wireshark I should download the sources for it let me know .
I have rebased the patches, added a README with the svn version that these patches apply to to the OpenBSC git.
everything clear now?
Thanks It is clear for me !! just send me 1 pcap file to open it with the patched wireshark and it should have abis-oml protocol sniffed inside it , in order to make sure that the patch is okay as I have added the c file inside one place in Makefile.common I will copy the place below :
Under : DISSECTOR_SRC= . . . . packet-gsm_a_common.c \ packet-gsm_a_dtap.c \ packet-gsm_a_gm.c \ packet-gsm_abis_oml.c \ packet-gsm_a_rp.c \ packet-gsm_a_rr.c \ packet-gsm_bsslap.c \
is this right ? shall I add it in different place ( C file and header are created under ) /epan/dissectors
Thanks, Omar Aia
-----Original Message----- From: openbsc-bounces@lists.gnumonks.org [mailto:openbsc-bounces@lists.gnumonks.org] On Behalf Of Holger Hans Peter Freyther Sent: Tuesday, January 11, 2011 5:41 PM To: openbsc@lists.gnumonks.org Subject: Re: Adding patches to wireshark...
On 01/11/2011 10:01 AM, Omar Atia wrote:
Yes dear I worked git which I used to download the src for libosmocore and opensbsc...
:)
Patch -p1 (patch file) it raises a problem in Makefile.common , and didn't patch the Makefile.common but it did create the C and header files for the below patch abis_oml.patch under dissector, but the issue in the make file
,
how can I add them to make file in order to be compiled ...
Always hard to judge where the difficulty is. The GNU patch program is leaving a FILENAME.orig and a FILENAME.rej next to the file that failed to be patched. In your case you should have a Makefile.common.rej that shows you which 'hunk' (part of the patch) was not applied. You simply need to add the abis-oml c file to that...
Any way I will google git svn tonight and check it , but if you have any hint for the version of wireshark I should download the sources for it
let
me know .
I have rebased the patches, added a README with the svn version that these patches apply to to the OpenBSC git.
everything clear now?
-
Holger Hans Peter Freyther -
Omar Atia -
Sylvain Munaut