Holger Hans Peter Freyther wrote:
hmm, I might not understand what your patch does but the trx_id is still in more than a single place. Make the ipaccess_unit the primary holder of the trx_id.
in my last patch (for osmo-bts), the trx_id is set in each entry of an array of ipaccess_unit structure. the first entry is used for OML link, trx_id is not used there, so it is set to 0. the second (and subsequent) array entry is used for RSL. there the trx_id is set to the TRX number, starting with 0. (sysmobts only uses one TRX.)
e1inp_ipa_bts_rsl_connect(line, "127.0.0.1", IPA_TCP_PORT_RSL);
e1inp_ipa_bts_rsl_connect(line, "127.0.0.1", IPA_TCP_PORT_RSL, 0);
- line = abis_open(bts, btsb->bsc_oml_host, "sysmoBTS");
- line = abis_open(bts, btsb->bsc_oml_host, "sysmoBTS", 1);
Why do you start with trx_id == 1 in the BTS part but in the manual case with 0?
the abis_open() function gets the number of TRX to be used, not the trx_id. as shown above, the abis_open shall create the OML link and 1 RSL link for 1 TRX. the e1inp_ip_bts_rsl_connect() function, as shown above, gets the parameter 0, which means it should connect the first RSL link, which uses trx_id 0.