Re: [PATCH] sms: Rename gsm340_gen_oa() to gsm340_gen_address_field().

On Tue, Mar 11, 2014 at 6:26 PM, Holger Hans Peter Freyther holger@freyther.de wrote:

On Mon, Mar 10, 2014 at 07:40:51PM +0100, Alexander Chemeris wrote:

...

Good idea. An updated patch is attached.

...

+/* DEPRECATED: use gsm340_gen_address_field() instead */ +int gsm340_gen_oa(uint8_t *oa, unsigned int oa_len, uint8_t type,

• uint8_t plan, const char *number) OSMO_DEPRECATED("Use gsm340_gen_address_field() instead");
  

this comment doesn't really add any value.

I don't see how it harms either. Though I've removed it in the attached patch.

You are using OSMO_DEPRECTAED but you do not directly/indirectly the header file defining it. In fact gsm0411_smc.c fails to compile due this.

Oops, forgot to include this in the patch, my apologies. Updated patch is attached.