21 Jan
2014
21 Jan
'14
10:54 a.m.
On Tue, Jan 21, 2014 at 11:19:17AM +0100, Andreas Eversberg wrote:
dear andreas,
i looked at the code again. my thoughts are:
the trx_id in the parameters (that is e1inp_ipa_bts_rsl_connect)
should be renamed to "index". that is what the parameter is used
for: the index of the RSL link instance. we could provide sign_link
instead of some index, but inside e1inp_ipa_bts_rsl_connect we call
ipa_client_conn_create, which also requires an index. (this index is
stored at priv_nr of the osmo_fd, to resolve ABIS link when
receiving data.)
thanks a lot. I went through the code as well and I think the first
version you sent is better than the second one. On the first version
what I am missing is some documentation on how we segment the TS
array for OML/RSL and a range check for the trx/index. Do you think
you could add this to the first patch?
thanks
holger