From Holger Freyther holger@freyther.de:
Holger Freyther has posted comments on this change.
Change subject: add vty call show asciidoc: generate a documentation for counters ......................................................................
Patch Set 1: Code-Review+1
(3 comments)
https://gerrit.osmocom.org/#/c/70/1/src/vty/stats_vty.c File src/vty/stats_vty.c:
Line 362: struct vty *vty = sctx_; I think you will not find another place with a '_' as suffix to a parameter. What is the semantic for that? (I assume you use it in other projects?)
Line 363: const char *description = counter->description ? counter->description : ""; Have you encountered counters without a description?
Line 397: description, For XML there is something like xml_escape. Do we need (and can we) escape characters for asciidoc? E.g. if the description includes '|'?