Change in libosmocore[master]: add vty call show asciidoc: generate a documentation for cou...

Holger Freyther has posted comments on this change. Change subject: add vty call show asciidoc: generate a documentation for counters ...................................................................... Patch Set 1: Code-Review+1 (3 comments) https://gerrit.osmocom.org/#/c/70/1/src/vty/stats_vty.c File src/vty/stats_vty.c: Line 362: struct vty *vty = sctx_; I think you will not find another place with a '_' as suffix to a parameter. What is the semantic for that? (I assume you use it in other projects?) Line 363: const char *description = counter->description ? counter->description : ""; Have you encountered counters without a description? Line 397: description, For XML there is something like xml_escape. Do we need (and can we) escape characters for asciidoc? E.g. if the description includes '|'? -- To view, visit https://gerrit.osmocom.org/70 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8af883167e5ee631059299b107ea83c8bbffdfb Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Holger Freyther <holger(a)freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes