21 Jan
2014
21 Jan
'14
11:19 a.m.
Holger Hans Peter Freyther wrote:
th your patch there is:
* trx->nr
* trx_id in the parameters
* trx_id in the ipaccess_unit
So how can we reduce the amount of duplication? trx->nr will not go
away. Can we change e1inp_ipa_bts_rsl_connect to already work on a
sign_link (that normally would be created more late, probably not)?
dear holger,
i looked at the code again. my thoughts are:
the trx_id in the parameters (that is e1inp_ipa_bts_rsl_connect) should
be renamed to "index". that is what the parameter is used for: the index
of the RSL link instance. we could provide sign_link instead of some
index, but inside e1inp_ipa_bts_rsl_connect we call
ipa_client_conn_create, which also requires an index. (this index is
stored at priv_nr of the osmo_fd, to resolve ABIS link when receiving data.)
the trx_id in the ipaccess_unit is something that is replied to the BSC,
to identify the TRX. there should be no relation between the value of
trx_id and the actual RSL link instance. this makes sense, if multiple
devices provide different TRX for the same BTS. (e.g. first device
provides two TRX with trx_id 0 and 1, and second device provides two
additional TRX with trx_id 2 and 3. both devices have only two RSL link
instances.)
best regards,
andreass