Re: [openbsc PATCH 1/5] openbsc/gsm_data_shared.h: Added the attribute reduce_power in TRX

On Mon, Apr 28, 2014 at 01:38:47PM +0200, Alvaro Neira Ayuso wrote:

From: Álvaro Neira Ayuso anayuso@sysmocom.de

--- a/openbsc/include/openbsc/gsm_data_shared.h +++ b/openbsc/include/openbsc/gsm_data_shared.h @@ -371,6 +371,7 @@ struct gsm_bts_trx { uint16_t arfcn; int nominal_power; /* in dBm */ unsigned int max_power_red; /* in actual dB */

• int power_reduce; /* in dBm */

any reason to make it use int and not unsigned int? As this is a relative value the right unit is dB (take this with a grain of salt as I am just a software guy)