Re: [PATCH] sms: Rename gsm340_gen_oa() to gsm340_gen_address_field().

Holger,

On Wed, Mar 26, 2014 at 11:22 PM, Holger Hans Peter Freyther holger@freyther.de wrote:

On Sun, Mar 16, 2014 at 01:50:10PM +0400, Alexander Chemeris wrote:

...

Hi Holger,

It seems there are no more comments on this code. Could you please merge it? It is independent of other changes.

in Osmocom we prefer shorted/abbreviated names. Do you mind if we call it gsm340_gen_addr_field instead? This way some of the lines from the testcase get closer to 80 chars.

Good idea. I'll update the patch during the next week.