On Thu, Jul 08, 2010 at 10:58:42PM +0200, Sylvain Munaut wrote:
(even though
what could be properly decoded before
also can be properly decoded now, no change for this).
Well, I think that before
encode(decode(x)) == x
because the 'errors' matched in encode and decode. Therefore message
sent from GSM to GSM actually worked fine and only if you involved the
VTY interface then it failed.
ACK.
But if they don't match anymore, then VTY ->
GSM will work but GSM ->
GSM will be broken.
The idea of storing a plaintext version and the binary-encoded TPDU inside
the SQL database was exactly to solve this. the plaintext/UTF8 version is
intended for human readers, but if we have the BLOB from a MO SMS (or an
external application writing to the database), then that very same unmodified
BLOB should be sent to the other MS as part of the MT SMS.
So whatever modifications we make, we should keep in mind that the transparent
MO-SMS to MT-SMS path remains unharmed.
--
- Harald Welte <laforge(a)gnumonks.org>
http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)