Re: Patch for OpenBSC [Nokia Site family]

Hi Holger,

Sorry for that, clearly there are some mistakes in the patch, will try and fix it.

Thnaks for the feedback!

Regards, Csaba

----- Eredeti üzenet ----- Feladó: "Holger Hans Peter Freyther" holger@freyther.de Címzett: "Sipos Csaba" sipos.csaba@kvk.uni-obuda.hu Másolatot kap: openbsc@lists.osmocom.org Elküldött üzenetek: Vasárnap, 2015. Február. 1. 14:56:59 Tárgy: Re: Patch for OpenBSC [Nokia Site family]

On Sun, Feb 01, 2015 at 11:39:53AM +0100, Sipos Csaba wrote:

Dear Holger,

thank you!

•  "nokia_site bts-reset-timer  <15-100>",
  

• bts->nokia.bts_reset_timer_cnf = atoi(argv[0]);

without using this new command the default will change from 15 to 0 seconds? Shouldn't you initialize bts_reset_timer_cnf with 15 somewhere? And what is the reason to make this variable a bitfield? is it transported on the wire like this?