Re: l1-sap patches for osmo-bts

Holger Hans Peter Freyther wrote:

dear holger,

thanx for looking at my pataches.

• case OSMO_PRIM(PRIM_PH_DATA, PRIM_OP_INDICATION):

• if (L1SAP_IS_CHAN_TCHF(chan_nr)) {
  

• 	if (trx->ts[tn].pchan == GSM_PCHAN_PDCH) {
  

• 		if (L1SAP_IS_PTCCH(fn)) {
  

• 			if (l1sap->oph.primitive
  

• 					== PRIM_OP_INDICATION) {
  

• 				if (data[0] == 7)
  
  

this is exactly what i want to avoid when doing the new patches. where did you see this? look at patch 2653aee1 [1], there i put GSMTAP forwarding for PDCH in a seperate function:

+ case OSMO_PRIM(PRIM_PH_DATA, PRIM_OP_INDICATION): + if (trx->ts[tn].pchan == GSM_PCHAN_PDCH) + rc = gsmtap_pdch(l1sap, &chan_type, &tn, &ss, &fn, &data, + &len);

did i made some mistake when pushing it? the code you mentioned above was still in jolly/l1sap branch. i just removed that obsolete branch.

regards,

andreas

[1] http://git.osmocom.org/osmo-bts/commit/?h=jolly/l1sap_parts&id=2653aee16...