hi, i reworked my l1sap patches for osmo-bts. (they are the base for adding osmo-bts-trx model code, which allow support for OpenBTS transceivers, like UmTRX or Calypso-BTS.) each single patch was tested, if Sysmocom-BTS is still functioning after applying it, rather than testing all patches together. i do not send the patches to mailing list, since there are 21 patches, and i don't want to spam the list before i know that these patches are small enough to be reviewed and understood. the branch is jolly/l1sap_parts. please let me know, whether they require better description or finer splitting. regards, andreas from last path to first patch: commit 0c0229886f6f6eba029c044e4cac8b420d86cd1c Author: Andreas Eversberg <jolly(a)eversberg.eu> Date: Sun Sep 1 12:30:52 2013 +0200 Remove obsolete gsmtap handling from osmo-bts-sysmo part. commit dfc8a3635e527960fa615c4ce7342e9739230a79 Author: Andreas Eversberg <jolly(a)eversberg.eu> Date: Sun Jun 16 15:09:56 2013 +0200 sysmobts: Forward CMR from L1 (Phone) to RTP payload commit 8cfffc712914107fe8277c96ad3afb1891f25014 Author: Andreas Eversberg <jolly(a)eversberg.eu> Date: Sun Sep 1 12:06:19 2013 +0200 Add gsmtap option to command line to main.c of osmo-bts-sysmo commit 8ca47efb9cf9861a2766c41b96469263e1e13ed9 Author: Andreas Eversberg <jolly(a)eversberg.eu> Date: Sun Sep 1 12:04:49 2013 +0200 Move gsmtap VTY commands from osmo-bts-sysmo to common part commit 2653aee1604d1504d707c9ed264dcb5cdaf2b01d Author: Andreas Eversberg <jolly(a)eversberg.eu> Date: Mon Jul 29 09:45:22 2013 +0200 Send primitives at PH-/MPH-/TCH-SAP interface via GSMTAP commit 66c08e87a2985ffd48e6d870ac6318c2b82a1476 Author: Andreas Eversberg <jolly(a)eversberg.eu> Date: Sun Sep 1 11:57:07 2013 +0200 Move loopback control VTY commands from osmo-bts-sysmo to common part commit 8015bfcb3014c707bfe16ed4b52612e6fe377e75 Author: Andreas Eversberg <jolly(a)eversberg.eu> Date: Thu Feb 14 11:17:58 2013 +0100 Correctly fill system information messages from BSC SI 5*/6 require L2 header of 0x03,0x03. All SI might be less than 23 octets, so they need to be filled with 0x2b. commit ebc180d0270293195c830193234608629b50bc03 Author: Andreas Eversberg <jolly(a)eversberg.eu> Date: Sun Jun 16 13:26:14 2013 +0200 sysmobts: Clean up transitions for lchan cipher state There are three transitions: 1. LCHAN_CIPH_NONE -> LCHAN_CIPH_RX_REQ -> LCHAN_CIPH_RX_CONF It is used to enable ciphering in RX (uplink) direction only. 2. LCHAN_CIPH_RX_CONF -> LCHAN_CIPH_RX_CONF_TX_REQ -> LCHAN_CIPH_RXTX_CONF It is used to additionally enable ciphering in TX (downlink) direction. 3. LCHAN_CIPH_NONE -> LCHAN_CIPH_RXTX_REQ -> LCHAN_CIPH_RX_CONF_TX_REQ -> LCHAN_CIPH_RXTX_CONF It is used to enable ciphering in both TX and RX directions. This is used when the channel is activated with encryption already enabled. (assignment or handover) In order to follow the order of these transitions, the RX direction must always be set before the TX direction. If no cipher key is set (A5/0), ciphering is set to ALG 0, but lchan cipher state remains at LCHAN_CIPH_NONE. commit c5f478d8d6702961dfb74642108187e653a05775 Author: Andreas Eversberg <jolly(a)eversberg.eu> Date: Sat Aug 31 20:30:40 2013 +0200 Add MEAS (MPH_INFO) IND message to PH-/MPH-/TCH-SAP interface This part moves processing of measurement infos from osmo-bts-sysmo to common part. commit ffc1cc39ea28b695b98eedd1d16bdd023e4a77ad Author: Andreas Eversberg <jolly(a)eversberg.eu> Date: Sun Sep 1 11:09:20 2013 +0200 Add SDCCH/SACCH/FACCH messages to PH-/MPH-/TCH-SAP interface This part moves control channel message primitives from osmo-bts-sysmo to common part. In order to control ciphering fo BTS model, CIPHER (MPH_INFO) messages are used. commit adc84b8db3bff29b5c681e04e078ee6000e5f4bf Author: Andreas Eversberg <jolly(a)eversberg.eu> Date: Sun Sep 1 10:08:15 2013 +0200 Add TCH messages to PH-/MPH-/TCH-SAP interface This part moves TCH handling from osmo-bts-sysmo to common part. The RTP handling is done at the common part, so they can be used by other BTS models. commit 2510e3f23ed4fa0a469484703c6b86574f175cdc Author: Andreas Eversberg <jolly(a)eversberg.eu> Date: Sun Sep 1 09:19:45 2013 +0200 Move chan act/rel/modify from bts_model to PH-/MPH-/TCH-SAP interface This part replaces channel activation/deactivation/modification routines by MPH_INFO messages. commit b1df874be87cf09290a3dd0d95790bc74f3d09fa Author: Andreas Eversberg <jolly(a)eversberg.eu> Date: Sun Sep 1 09:02:24 2013 +0200 Relace bts_model_get_time() by get_time() at common part commit f5b8b0de3303cefb06838991441e24c6d58e7aae Author: Andreas Eversberg <jolly(a)eversberg.eu> Date: Sat Aug 31 19:49:12 2013 +0200 Add TIME (MPH_INFO) IND messages to PH-/MPH-/TCH-SAP interface This part moves GSM time handling from osmo-bts-sysmo part to common part. commit a8d8eac3924517842c69a8d2b8ea4d8f17ce2c3a Author: Andreas Eversberg <jolly(a)eversberg.eu> Date: Fri Aug 30 08:48:38 2013 +0200 Add PDCH messages to PH-/MPH-/TCH-SAP interface This part moves PDTCH, PACCH and PTCCH message primitives from osmo-bts-sysmo to common part. commit ebcbe2f73078200317d5b8a134753a069f9c3572 Author: Andreas Eversberg <jolly(a)eversberg.eu> Date: Fri Aug 30 08:03:09 2013 +0200 Add PCH/AGCH message to PH-/MPH-/TCH-SAP interface This part moves PCH and AGCH message primitives from osmo-bts-sysmo to common part. commit 0521a5b654251fcd9a2923c607c8dbad3bd44a30 Author: Andreas Eversberg <jolly(a)eversberg.eu> Date: Fri Aug 30 07:46:30 2013 +0200 Add RACH message to PH-/MPH-/TCH-SAP interface This part moves RACH message primitives from osmo-bts-sysmo to common part. commit 2ee4f41d6c5fe78bb0c347e673e2411486f2bc3f Author: Andreas Eversberg <jolly(a)eversberg.eu> Date: Mon Jul 29 09:42:23 2013 +0200 Add BCCH message to PH-/MPH-/TCH-SAP interface This first part moves BCCH message primitives from osmo-bts-sysmo to common part. A new file "common/l1sap.c" is introduced to implement handling of layer 1 messages from/to BTS model. commit 4db570049f7ef6f7604e504083e8a3b751b09d6c Author: Andreas Eversberg <jolly(a)eversberg.eu> Date: Mon Jul 29 09:37:07 2013 +0200 Add header file of PH-/MPH-/TCH-SAP interface to common part of osmo-bts Instead of handling primitives directly at layer 1 specific code, osmo-bts handles primitives at common code. When all primitive are moved, the l1sap interface will: - receive PH-DATA indications and forward them to layer 2. - check for RF link loss and notify BSC. - receive TCH indications and forward them via RTP. - receive PH-RTS indications and send PH-DATA requests with content according to its logical channel. - receive TCH-RTS indications and send TCH requests with content received via RTP or loopback from TCH indications. - send MPH-INFO requests to activate, deactivate and modify logical channels and handle their confirms. - receive MPH-INFO indications with measurements from tranceiver. - forward received and transmitted PH-DATA to GSMTAP. commit ebb73d8cc333584d440398a7bed41f3584693f40 Author: Andreas Eversberg <jolly(a)eversberg.eu> Date: Sun Jul 28 11:48:40 2013 +0200 sysmo-bts: Use correct boundaries of L1 msg when forwarding to L1 proxy In case of a headroom in a message, the 'head' pointer will not point to the actual data. commit 2ef39102fed2167014938221411055a43a1dd763 Author: Andreas Eversberg <jolly(a)eversberg.eu> Date: Tue Feb 5 09:31:20 2013 +0100 Remove obsolete osmo-bts-bb code