OpenBSC

openbsc@lists.osmocom.org

10 participants
4277 discussions

[PATCH 0/4] libosmocore: several cleanups
by pablo＠gnumonks.org 29 Mar '11

29 Mar '11

From: Pablo Neira Ayuso <pablo(a)gnumonks.org> This patchset includes several cleanups previous to another patchset that will contain the namespace pollution fix (to appear soon). They're available in the branch pablo/cleanups in libosmocore. Please merge it. Pablo Neira Ayuso (4): bitvec: add bitvec_find_first_bit_pos() from gsm/rxlev_stat.c write_queue: use full path of includes in osmocom/core/write_queue.h vty: move vty_out_rate_ctr_group prototype to osmocom/vty/misc.h utils: move OSMO_SNPRINT_RET() macro definition to osmocom/core/utils.h include/osmocom/core/bitvec.h | 2 ++ include/osmocom/core/rate_ctr.h | 3 --- include/osmocom/core/utils.h | 9 +++++++++ include/osmocom/core/write_queue.h | 4 ++-- include/osmocom/vty/Makefile.am | 2 +- include/osmocom/vty/misc.h | 10 ++++++++++ src/bitvec.c | 14 ++++++++++++++ src/gsm/rxlev_stat.c | 12 ------------ src/logging.c | 26 ++++++++------------------ 9 files changed, 46 insertions(+), 36 deletions(-) create mode 100644 include/osmocom/vty/misc.h -- 1.7.2.3

2 1

[PATCH] [RFC] src: add prefix osmocom_ to all functions in libosmocore
by pablo＠gnumonks.org 29 Mar '11

29 Mar '11

From: Pablo Neira Ayuso <pablo(a)gnumonks.org> This patch is a RFC, I can add the prefix osmocom_ to all functions in libosmocore to fix with the existing namespace pollution. This task was proposed by Harald. Let me know if you are OK with this approach and I'll send a patchset along this week. --- include/osmocom/core/backtrace.h | 2 +- src/backtrace.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/osmocom/core/backtrace.h b/include/osmocom/core/backtrace.h index bbbb2c2..7c248aa 100644 --- a/include/osmocom/core/backtrace.h +++ b/include/osmocom/core/backtrace.h @@ -1,6 +1,6 @@ #ifndef _OSMO_BACKTRACE_H_ #define _OSMO_BACKTRACE_H_ -void generate_backtrace(); +void osmocom_generate_backtrace(); #endif diff --git a/src/backtrace.c b/src/backtrace.c index ecd6b9c..5c609bb 100644 --- a/src/backtrace.c +++ b/src/backtrace.c @@ -29,7 +29,7 @@ #ifdef HAVE_EXECINFO_H #include <execinfo.h> -void generate_backtrace() +void osmocom_generate_backtrace() { int i, nptrs; void *buffer[100]; -- 1.7.2.3

4 6

[PATCH] openBSC: include new file osmocom/vty/misc.h in several daemons
by pablo＠gnumonks.org 29 Mar '11

29 Mar '11

From: Pablo Neira Ayuso <pablo(a)gnumonks.org> Minor change in openBSC due to new osmocom/vty/misc.h file that was added in the patchset entitled: libosmocore: several cleanups It's available in pablo/cleanups branch in openbsc git tree. Please, merge it. Pablo Neira Ayuso (1): src: include new file osmocom/vty/misc.h for vty_out_rate_ctr_group() openbsc/src/gprs/sgsn_vty.c | 1 + openbsc/src/libgb/gprs_bssgp_vty.c | 1 + openbsc/src/libgb/gprs_ns_vty.c | 1 + openbsc/src/osmo-bsc_nat/bsc_nat_vty.c | 1 + 4 files changed, 4 insertions(+), 0 deletions(-) -- 1.7.2.3

1 1

[PATCH 1/4] bitvec: add bitvec_find_first_bit_pos() from gsm/rxlev_stat.c
by pablo＠gnumonks.org 29 Mar '11

29 Mar '11

From: Pablo Neira Ayuso <pablo(a)gnumonks.org> This patch adds bitvec_find_bit_pos() to bitvec.c where it really belongs to. Before this patch used to be part of gsm/rxlev_stat.c --- include/osmocom/core/bitvec.h | 2 ++ src/bitvec.c | 14 ++++++++++++++ src/gsm/rxlev_stat.c | 12 ------------ 3 files changed, 16 insertions(+), 12 deletions(-) diff --git a/include/osmocom/core/bitvec.h b/include/osmocom/core/bitvec.h index 42977fb..bbe1641 100644 --- a/include/osmocom/core/bitvec.h +++ b/include/osmocom/core/bitvec.h @@ -68,6 +68,8 @@ int bitvec_set_uint(struct bitvec *bv, unsigned int in, int count); /* get multiple bits (based on numeric value) from current pos */ int bitvec_get_uint(struct bitvec *bv, int num_bits); +/* find the first bit set in bit vector */ +int bitvec_find_bit_pos(const struct bitvec *bv, unsigned int n, enum bit_value val); /* Pad the bit vector up to a certain bit position */ int bitvec_spare_padding(struct bitvec *bv, unsigned int up_to_bit); diff --git a/src/bitvec.c b/src/bitvec.c index 4984af2..4fd3834 100644 --- a/src/bitvec.c +++ b/src/bitvec.c @@ -217,3 +217,17 @@ int bitvec_spare_padding(struct bitvec *bv, unsigned int up_to_bit) return 0; } + +/* find first bit set in bit vector */ +int bitvec_find_bit_pos(const struct bitvec *bv, unsigned int n, + enum bit_value val) +{ + unsigned int i; + + for (i = n; i < bv->data_len*8; i++) { + if (bitvec_get_bit_pos(bv, i) == val) + return i; + } + + return -1; +} diff --git a/src/gsm/rxlev_stat.c b/src/gsm/rxlev_stat.c index 626aaff..d226861 100644 --- a/src/gsm/rxlev_stat.c +++ b/src/gsm/rxlev_stat.c @@ -30,18 +30,6 @@ #include <osmocom/core/bitvec.h> #include <osmocom/gsm/rxlev_stat.h> -int bitvec_find_bit_pos(const struct bitvec *bv, unsigned int n, enum bit_value val) -{ - unsigned int i; - - for (i = n; i < bv->data_len*8; i++) { - if (bitvec_get_bit_pos(bv, i) == val) - return i; - } - - return -1; -} - void rxlev_stat_input(struct rxlev_stats *st, uint16_t arfcn, uint8_t rxlev) { struct bitvec bv; -- 1.7.2.3

1 3

[PATCH] ipaccess-proxy: fix segfault in handle_dead_socket
by pablo＠gnumonks.org 28 Mar '11

28 Mar '11

From: Pablo Neira Ayuso <pablo(a)gnumonks.org> This patch fixes a segfault if we or one BTS start a TCP connection and close it before any IPAC_MSGT_ID_RESP message is sent. --- openbsc/src/ipaccess/ipaccess-proxy.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/openbsc/src/ipaccess/ipaccess-proxy.c b/openbsc/src/ipaccess/ipaccess-proxy.c index 56fe160..d98eb54 100644 --- a/openbsc/src/ipaccess/ipaccess-proxy.c +++ b/openbsc/src/ipaccess/ipaccess-proxy.c @@ -806,6 +806,11 @@ static void handle_dead_socket(struct bsc_fd *bfd) switch (bfd->priv_nr & 0xff) { case OML_FROM_BTS: /* incoming OML data from BTS, forward to BSC OML */ + /* The BTS started a connection with us but we got no + * IPAC_MSGT_ID_RESP message yet, in that scenario we did not + * allocate the ipa_bts_conn structure. */ + if (ipbc == NULL) + break; ipbc->oml_conn = NULL; bsc_conn = ipbc->bsc_oml_conn; /* close the connection to the BSC */ -- 1.7.2.3

2 1

switchin from multidrop to star
by kobayashi_maru＠onlinehome.de 27 Mar '11

27 Mar '11

hello i tried to switch back one of my bs-11 from multidrop to star ("./bs11_config bport0-star" after disconnecting) but i always get a NACK. whats wrong there? T.

1 0

trx1 not found/not existing trx1
by kobayashi_maru＠onlinehome.de 27 Mar '11

27 Mar '11

hello, as you know, my 2nd bs-11(bts1) in multidrop konfig is bootstrapped as bts/trx(1/1) although only trx0 is used on bts1, and the 2nd bs-11 isnt seen by any handy. the debugp message says "abis_nm.c: 518 OC=Radio-Carrier(02) INST=(00,01,ff) STATE CHG: TRX 1 does not exist unknown object class" of course does trx1 not exist, since there are only trx0s, bts0 uses trx0 and bts1 as well (its trx0, of course) what does that mean? T.

1 0

[PATCH] tests: fix bsc-nat test
by pablo＠gnumonks.org 27 Mar '11

27 Mar '11

From: Pablo Neira Ayuso <pablo(a)gnumonks.org> In 136f453dd2492b95004461a33c90b11732f33bd8, I forgot to update the new header path in the test/bsc-nat files (this happened to me because I forgot to configured openBSC without --enable-nat). --- openbsc/tests/bsc-nat/Makefile.am | 4 ++-- openbsc/tests/bsc-nat/bsc_nat_test.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/openbsc/tests/bsc-nat/Makefile.am b/openbsc/tests/bsc-nat/Makefile.am index 04bdb97..4785098 100644 --- a/openbsc/tests/bsc-nat/Makefile.am +++ b/openbsc/tests/bsc-nat/Makefile.am @@ -1,5 +1,5 @@ INCLUDES = $(all_includes) -I$(top_srcdir)/include -AM_CFLAGS=-Wall -ggdb3 $(LIBOSMOCORE_CFLAGS) $(LIBOSMOSCCP_CFLAGS) $(COVERAGE_CFLAGS) +AM_CFLAGS=-Wall -ggdb3 $(LIBOSMOCORE_CFLAGS) $(LIBOSMOGSM_CFLAGS) $(LIBOSMOSCCP_CFLAGS) $(COVERAGE_CFLAGS) AM_LDFLAGS = $(COVERAGE_LDFLAGS) EXTRA_DIST = bsc_data.c @@ -16,4 +16,4 @@ bsc_nat_test_LDADD = $(top_builddir)/src/libbsc/libbsc.a \ $(top_srcdir)/src/libabis/libabis.a \ $(top_srcdir)/src/libtrau/libtrau.a \ $(top_srcdir)/src/libcommon/libcommon.a \ - $(LIBOSMOCORE_LIBS) -lrt $(LIBOSMOSCCP_LIBS) $(LIBOSMOVTY_LIBS) + $(LIBOSMOCORE_LIBS) $(LIBOSMOGSM_LIBS) -lrt $(LIBOSMOSCCP_LIBS) $(LIBOSMOVTY_LIBS) diff --git a/openbsc/tests/bsc-nat/bsc_nat_test.c b/openbsc/tests/bsc-nat/bsc_nat_test.c index 504b691..f5de953 100644 --- a/openbsc/tests/bsc-nat/bsc_nat_test.c +++ b/openbsc/tests/bsc-nat/bsc_nat_test.c @@ -27,10 +27,10 @@ #include <openbsc/bsc_nat.h> #include <openbsc/bsc_nat_sccp.h> -#include <osmocore/talloc.h> +#include <osmocom/core/talloc.h> #include <osmocom/sccp/sccp.h> -#include <osmocore/protocol/gsm_08_08.h> +#include <osmocom/gsm/protocol/gsm_08_08.h> #include <stdio.h> -- 1.7.2.3

2 1

[ADM] New commitlog mailing list
by Harald Welte 27 Mar '11

27 Mar '11

Hi all! We haven't had a functioning commit log mailinglist since mid-2009, when the revision control system of openbsc was converted from svn to git. Especially today, with the large number of separate git repositories on http://cgit.osmocom.org/, it is very easy to loose track of what other developers are doing. The new mailing list 'osmocom-commitlog' (renamed from openbsc-commits) will receive updates from all repositories on git.osmocom.org. Feel free to subscribe at http://lists.osmocom.org/mailman/listinfo/osmocom-commitlog Cheers, Harald -- - Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)

2 2

[ADM] Problems with osmocom git server
by Harald Welte 27 Mar '11

27 Mar '11

Hi all! We're sorry to report that there are some problems with our git repositories at the moment, resulting in 'early EOF / index-pack failed' messages when users are attempting to clone one of our repositories. The problem has been thoroughly analyzed, but even after many hours of analysis, no solution has been found yet. Your best chance is to keep re-trying the clone, in 5-10% of the cases it will succeed. More technical details are available at this posting to the git mailing list: http://article.gmane.org/gmane.comp.version-control.git/169909 Sorry for the inconvenience. -- - Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)

2 2

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

OpenBSC