- OpenBSC - lists.osmocom.org

[PATCH 1/4] core: RELEASE COMPLETE can be without any payload
by Sergey.Kostanbaev 25 Nov '15

25 Nov '15

From: Sergey Kostanbaev <Sergey.Kostanbaev(a)gmail.com> This series of patches supposed to add support of USSD-menu style message handling with language support. --- src/gsm/gsm0480.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/gsm/gsm0480.c b/src/gsm/gsm0480.c index 952604b..9bd54fa 100644 --- a/src/gsm/gsm0480.c +++ b/src/gsm/gsm0480.c @@ -248,12 +248,6 @@ int gsm0480_decode_ss_request(const struct gsm48_hdr *hdr, uint16_t len, struct ss_request *req) { int rc = 0; - - if (len < sizeof(*hdr) + 2) { - LOGP(0, LOGL_DEBUG, "SS Request is too short.\n"); - return 0; - } - if ((hdr->proto_discr & 0x0f) == GSM48_PDISC_NC_SS) { req->transaction_id = hdr->proto_discr & 0x70; rc = parse_ss(hdr, len, req); -- 1.9.1

1 3

[PATCH 3/3] mncc: Send "Dest OOO" cause in case of a link radio failure.
by Alexander Chemeris 24 Nov '15

24 Nov '15

Previously we were sending a generic "Resource unavailable" cause code making it impossible to distinguish real error cases from a regular radio link failure. This was the reason for many "unknown" call errors we've seen at Rhizomatica installations. Now they are properly classified as non-erroneous call failures. The code is also a part of the achemeris/mncc_cause_fixes_master branch. -- Regards, Alexander Chemeris. CEO, Fairwaves, Inc. https://fairwaves.co

1 2

[PATCH 2/3] mncc: Log CC cause when sending a primitive to MNCC.
by Alexander Chemeris 24 Nov '15

24 Nov '15

The code is also a part of the achemeris/mncc_cause_fixes_master branch. -- Regards, Alexander Chemeris. CEO, Fairwaves, Inc. https://fairwaves.co

1 1

HAVE_LIBCARES
by Neels Hofmeyr 23 Nov '15

23 Nov '15

About below commit: Sorry / Thanks! I forgot to move gtphub into the HAVE_LIBCARES conditional when I added ares... The gtphub tests wrap the ares functions away, so they build without libc-ares. But does it make sense to enable the gtphub test when the binary isn't built? ~Neels > commit 97b6bfa996ed1745d27c5598186c4583f7e90861 > Author: Harald Welte <laforge(a)gnumonks.org> > Date: Sat Nov 21 13:16:08 2015 +0100 > > Fix compilation with no libc-ares present on the system > > This build failure was introduced with the OAP and gtphub changes. > > diff --git a/openbsc/src/gprs/Makefile.am b/openbsc/src/gprs/Makefile.am > index 5212c67..5e115eb 100644 > --- a/openbsc/src/gprs/Makefile.am > +++ b/openbsc/src/gprs/Makefile.am > @@ -11,9 +11,8 @@ noinst_HEADERS = gprs_sndcp.h > bin_PROGRAMS = osmo-gbproxy > > if HAVE_LIBGTP > -bin_PROGRAMS += osmo-gtphub > if HAVE_LIBCARES > -bin_PROGRAMS += osmo-sgsn > +bin_PROGRAMS += osmo-sgsn osmo-gtphub > endif > endif > > diff --git a/openbsc/tests/Makefile.am b/openbsc/tests/Makefile.am > index 995660a..04b8e34 100644 > --- a/openbsc/tests/Makefile.am > +++ b/openbsc/tests/Makefile.am > @@ -13,7 +13,10 @@ SUBDIRS += smpp > endif > > if HAVE_LIBGTP > -SUBDIRS += sgsn oap gtphub > +SUBDIRS += gtphub > +if HAVE_LIBCARES > +SUBDIRS += sgsn oap > +endif > endif >

2 1

[PATCH 00/16] GTP kernel update (patch bomb)
by Andreas Schultz 23 Nov '15

23 Nov '15

Hi, Sorry for smsching this all together, but I couldn't find a logical point to split the patches. Also the order can't really be changed as most patches depend on each other. After this series, the GTP kernel module is functional for IPv4 payload in IPv4 GTP tunnels (for GTPv0 and v1). The libgtnl API was changed without increasing the SO version of the lib. I think this is ok since nothing really uses it (yet) nor has the library been offcially released. Andreas Schultz (16): gtp: remove unused local variable gtp: remove genl_register_family_with_ops for Linux < 3.13 gtp: convert the global gtp_instance_list to a per netns list gtp: select netns based on NL attribute gtp-rtnl: and netns support gtp: add error handling to gtp_newlink gtp: fix the order of error cases in gtp_encap_enable gtp: add socket destroy handler gtp: replace udp encap setup with setup_udp_tunnel_sock gtp: switch to iptunnel framework and no longer depend on real_dev gtp: Split TID handling got GTPv0 and GTPv1 gtp-rtnl: sync GTPA_FLOW nl attribute name from kernel to userspace gtp-rtnl: real_ifname is not long needed, remove it gtp-rtnl: Split tid handling for GTPv0 and GTPv1 list Andreas Schultz as author gtp: add support for replacing PDP contexts gtp.c | 657 ++++++++++++++++++++++++--------------- gtp_nl.h | 3 + libgtnl/AUTHORS | 1 + libgtnl/include/libgtpnl/gtp.h | 6 + libgtnl/include/libgtpnl/gtpnl.h | 3 +- libgtnl/include/linux/gtp_nl.h | 5 +- libgtnl/src/gtp-genl.c | 34 +- libgtnl/src/gtp-rtnl.c | 10 +- libgtnl/src/gtp.c | 44 ++- libgtnl/src/internal.h | 13 +- libgtnl/src/libgtpnl.map | 6 + libgtnl/tools/Makefile.am | 4 +- libgtnl/tools/gtp-link-add.c | 5 +- libgtnl/tools/gtp-tunnel.c | 132 +++++--- libgtnl/tools/gtpnl.c | 35 --- 15 files changed, 613 insertions(+), 345 deletions(-) delete mode 100644 libgtnl/tools/gtpnl.c -- 2.5.0

4 39

channel availability
by Suraev 23 Nov '15

23 Nov '15

Hi. While trying to debug issue with osmo-pcu failing to allocate tfi due to pdch unavailability I've noticed that regular connection attempts are also failing with imm. ass. reject due to channel unavailability. I do not see rach flood so it feels like misconfiguration or maybe hw issue. MY question is - how to troubleshoot this? Where can I look as to which channels are available, which are occupied and by whom? thanks, Max.

3 7

RFC: removing talloc for good?
by Harald Welte 21 Nov '15

21 Nov '15

Hi all, I've been looking into upgrading our copy of talloc.[ch] in libosmocore, but unlike 7 years ago, it is not that easy anymore. The build system integration is quite heavy, and it might be a good point to simply drop talloc from libosmocore. Also contrary to 7 years ago, distributions tend to ship libtalloc these days. So there's not really any reason to continue shiping it. Right now I'm making it optional, and have sorted out how to make this source compatible. But this generates runtime incompabilities, due to the ABI incompabibilities between our ancient talloc and current talloc :( While the API of our talloc and current talloc seems compatible, the ABI is not. For example, they changed talloc_free() into an inline function resulting in calls to _talloc_free(), while our code links directly against talloc_free(). So We'd have to move from libosmocore-6.0.0 to 7.0.0 as part of the transition and cannot really keep both options without causing additional compatibility issues to our users. So the question is: Why bother? does anyone have objections to removing the built-in talloc? -- - Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)

2 3

EGPRS(EDGE) data rate is not stable?
by wangpalm 20 Nov '15

20 Nov '15

With phone attached to my configured EGPRS, sometimes it has a data rate around 200kbps (which is near optimal), while frequently it has a intolerablly slow data rate. Is it a common problem, or it's due to incorrect configrations or hardware problems? I run a gsm test system with nanobts, and the libosmocore, openbsc, openggsn codes are based on the version around end of April 2015. The configuration is made accorrding to the instruction from openbsc web. The correction in fc_queue_timer_cfg has also been made according to Jacob Erlbeck.

3 3

[PATCH] gtphub: fix build: remove obsolete EXTRA_DIST.
by Neels Hofmeyr 18 Nov '15

18 Nov '15

--- openbsc/tests/gtphub/Makefile.am | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/openbsc/tests/gtphub/Makefile.am b/openbsc/tests/gtphub/Makefile.am index d818811..59480ed 100644 --- a/openbsc/tests/gtphub/Makefile.am +++ b/openbsc/tests/gtphub/Makefile.am @@ -2,10 +2,7 @@ AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include AM_CFLAGS=-Wall -ggdb3 $(LIBOSMOCORE_CFLAGS) EXTRA_DIST = \ - gtphub_test.ok \ - gtphub_nc_test.sh \ - gtphub_nc_test.ok \ - hex2bin.py + gtphub_test.ok noinst_PROGRAMS = gtphub_test -- 2.1.4

2 2

[PATCH 1/3] gtphub: fix gtphub_read() semantics.
by Neels Hofmeyr 18 Nov '15

18 Nov '15

gtphub always wants to know the sender, hence make the from_addr pointer mandatory. Fixes two coverity complaints (1339766, 1339764). Sponsored-by: On-Waves ehi --- openbsc/src/gprs/gtphub.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/openbsc/src/gprs/gtphub.c b/openbsc/src/gprs/gtphub.c index e00d6cd..049e9f5 100644 --- a/openbsc/src/gprs/gtphub.c +++ b/openbsc/src/gprs/gtphub.c @@ -784,16 +784,16 @@ static int gtphub_bind_start(struct gtphub_bind *b, return 0; } -/* Recv datagram from from->fd, optionally write sender's address to *from_addr. +/* Recv datagram from from->fd, write sender's address to *from_addr. * Return the number of bytes read, zero on error. */ static int gtphub_read(const struct osmo_fd *from, struct osmo_sockaddr *from_addr, uint8_t *buf, size_t buf_len) { - /* recvfrom requires the available length set in *from_addr_len. */ - if (from_addr) - from_addr->l = sizeof(from_addr->a); + OSMO_ASSERT(from_addr); + /* recvfrom requires the available length set in *from_addr_len. */ + from_addr->l = sizeof(from_addr->a); errno = 0; ssize_t received = recvfrom(from->fd, buf, buf_len, 0, (struct sockaddr*)&from_addr->a, @@ -807,12 +807,10 @@ static int gtphub_read(const struct osmo_fd *from, return 0; } - if (from_addr) { - LOG(LOGL_DEBUG, "from %s\n", osmo_sockaddr_to_str(from_addr)); - } + LOG(LOGL_DEBUG, "Received %d bytes from %s\n%s\n", + (int)received, osmo_sockaddr_to_str(from_addr), + osmo_hexdump(buf, received)); - LOG(LOGL_DEBUG, "Received %d %s\n", - (int)received, osmo_hexdump(buf, received)); return received; } -- 2.1.4

1 3