- OpenBSC - lists.osmocom.org

Wiki update for B2x0 series
by Sipos Csaba 26 Dec '15

26 Dec '15

Dear list, As of today, I revised and updated the Wiki page for Ettus SDRs. https://openbsc.osmocom.org/trac/wiki/Ettus_USRP_B2xx_family What is tested: - Voice calls (MO and MT with full rate) - Interconnect with Asterisk (voice call routing and interconnecting GSM calls to SIP or other telephony technologies) - SMS (MO and MT) - GPRS What needs to be tested: - Voice calls with half rate and AMR If someone can go through it and revise it, that would be nice. Regards, Csaba

1 0

Osmo-PCU: make error
by Sipos Csaba 26 Dec '15

26 Dec '15

Dear Jacob, Today I started to update my setup to latest master for all the Osmocom projects and hit a compile error with Osmo-PCU: root@D6420:~/newer_osmocom/osmo-pcu# make Making all in src make[1]: Entering directory `/root/newer_osmocom/osmo-pcu/src' CXX gprs_debug.lo CXX csn1.lo CXX gsm_rlcmac.lo CXX gprs_bssgp_pcu.lo In file included from /usr/local/include/osmocom/gsm/prim.h:3:0, from /usr/local/include/osmocom/gprs/gprs_bssgp.h:8, from ./gprs_bssgp_pcu.h:32, from gprs_bssgp_pcu.cpp:22: /usr/local/include/osmocom/core/prim.h:23:27: error: uninitialized const 'osmo_prim_op_names' [-fpermissive] const struct value_string osmo_prim_op_names[5]; ^ In file included from /usr/local/include/osmocom/core/msgb.h:24:0, from /usr/local/include/osmocom/gprs/gprs_ns.h:8, from ./gprs_bssgp_pcu.h:31, from gprs_bssgp_pcu.cpp:22: /usr/local/include/osmocom/core/utils.h:22:8: note: 'const struct value_string' has no user-provided default constructor struct value_string { ^ /usr/local/include/osmocom/core/utils.h:23:15: note: and the implicitly-defined constructor does not initialize 'unsigned int value_string::value' unsigned int value; /*!< \brief numeric value */ ^ make[1]: *** [gprs_bssgp_pcu.lo] Error 1 make[1]: Leaving directory `/root/newer_osmocom/osmo-pcu/src' make: *** [all-recursive] Error 1 I can see that you moving some parts from openbsc to the core library, probably that process is not yet finsihed (or merged to master) and that is causing this problem. Just wanted to give some feedback and notify the list about this. Regards, Csaba

2 3

[PATCH] fix format warnings added by 86ec3118
by Neels Hofmeyr 24 Dec '15

24 Dec '15

Commit 86ec3118 ("msgb: Let msgb_hexdump be more tolerant") added new format warnings to my 64bit build of libosmocore. It's not a pressing matter, really, but the libosmocore build is otherwise clean of such warnings so it'd be nice to keep it that way. This patch fixes the warnings by using PRIdPTR. That seems to be the Correct Way to fix it, but I'm a bit unsure. Thanks for any thoughts! Neels Hofmeyr (1): Fix some recently added formats on 64bit src/msgb.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) -- 2.1.4

2 2

(no subject)
by Alexander Huemer 24 Dec '15

24 Dec '15

Hi. This patch is for osmo-iuh. Without it the build only works on machines that have the needed headers in the default search path for includes. Otherwise the build fails like this: > gcc -DPACKAGE_NAME=\"osmo-iuh\" -DPACKAGE_TARNAME=\"osmo-iuh\" -DPACKAGE_VERSION=\"0.0\" -DPACKAGE_STRING=\"osmo-iuh\ 0.0\" -DPACKAGE_BUGREPORT=\"\ openbsc(a)lists.osmocom.org\" -DPACKAGE_URL=\"\" -DPACKAGE=\"osmo-iuh\" -DVERSION=\"0.0\" -DSTDC_HEADERS=1 -I. -I/home/blackbit/usr/stow/libasn1c/include/ -I/home/blackbit/usr/stow/libasn1c/include/asn1c -I. -g -O2 -MT Criticality.o -MD -MP -MF $depbase.Tpo -c -o Criticality.o Criticality.c &&\ > mv -f $depbase.Tpo $depbase.Po > In file included from Criticality.h:50:0, > from Criticality.c:8: > /home/blackbit/usr/stow/libasn1c/include/asn1c/asn_internal.h:18:33: fatal error: osmocom/core/talloc.h: No such file or directory > compilation terminated. Kind regards, -Alex

2 2

[PATCH] fix build if depenedencies are in distinct directories
by Alexander Huemer 24 Dec '15

24 Dec '15

Hi. This patch is for libosmo-sccp. Without it the build only works on machines that have the needed headers in the default search path for includes. Otherwise the build fails like this: > /bin/bash ../libtool --tag=CC --mode=compile gcc -DPACKAGE_NAME=\"libosmo-sccp\" -DPACKAGE_TARNAME=\"libosmo-sccp\" -DPACKAGE_VERSION=\"0.0.6.3.33-8209\" -DPACKAGE_STRING=\"libosmo-sccp\ 0.0.6.3.33-8209\" -DPACKAGE_BUGREPORT=\"openbsc(a)lists.osmocom.org\" -DPACKAGE_URL=\"\" -DPACKAGE=\"libosmo-sccp\" -DVERSION=\"0.0.6.3.33-8209\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -I. -I../include -I.. -Wall -I/home/blackbit/usr/stow/libosmocore/include/ -g -O2 -MT sua.lo -MD -MP -MF .deps/sua.Tpo -c -o sua.lo sua.c > libtool: compile: gcc -DPACKAGE_NAME=\"libosmo-sccp\" -DPACKAGE_TARNAME=\"libosmo-sccp\" -DPACKAGE_VERSION=\"0.0.6.3.33-8209\" "-DPACKAGE_STRING=\"libosmo-sccp 0.0.6.3.33-8209\"" -DPACKAGE_BUGREPORT=\"openbsc(a)lists.osmocom.org\" -DPACKAGE_URL=\"\" -DPACKAGE=\"libosmo-sccp\" -DVERSION=\"0.0.6.3.33-8209\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -I. -I../include -I.. -Wall -I/home/blackbit/usr/stow/libosmocore/include/ -g -O2 -MT sua.lo -MD -MP -MF .deps/sua.Tpo -c sua.c -fPIC -DPIC -o .libs/sua.o > sua.c:32:34: fatal error: osmocom/netif/stream.h: No such file or directory > compilation terminated. Kind regards, -Alex

2 2

osmobts multiple bts
by stanley lary 24 Dec '15

24 Dec '15

Hi, I have followed the steps as in Multi-BTS with Osmocom and a single UmTRX <http://umtrx.org/multi-bts-with-osmocom-and-a-single-umtrx/> but I wasn't able to get the right results. I was able to get both TX transmitting the broadcast channel but when I try to connect my phone, only BTS0 works fine. When I try to change the BTS unit_id, I noticed that only the BTS having the lower unit_id would work while the other one only transmits broadcast signals (ex: unit_id 1801 works if I have 1801 and 1802). Any ideas what could be the problem ? Thank you, <http://umtrx.org/multi-bts-with-osmocom-and-a-single-umtrx/>

1 0

osmo-iuh update
by Harald Welte 23 Dec '15

23 Dec '15

FYI: Last night I a) merged the SCTP support for libosmo-netif to master b) moved the sua code from osmo-iuh into the libosmo-sccp repository, where we now build a shared libosmo-sigtran.so, which will be linked by the MSC, SGSN and HNB-GW code for the IuCS/IuPS interface. Unlike the spec demands, we will not use SCCP in M3UA in SCTP here, but will use SUA in SCTP as a simplification. Furthermore, the SUA code in libosmo-sigtran does not yet a) fully implement all the correct state machine transitions and inactivity timers (this is to be done) b) implement the ASP management state machines This is done as a short-cut as we initially only want to communicate between our own network elements. What's important is that we can use wireshark for decoding the protocol stacking that we use, and that the SCCP USER SAP is specified in a way that will enable us to put SCCP+M3UA or other sigtran dialects underneath the RANAP code in the future, as needed. Regards, Harald -- - Harald Welte <hwelte(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschaeftsfuehrer / Managing Directors: Holger Freyther, Harald Welte

3 2

osmo-iuh: fix Makefile.am
by Alexander Huemer 23 Dec '15

23 Dec '15

This patch fixes the build at least for me after $ git clean -xfd

2 5

ffasn1c in osmo-iuh?
by Neels Hofmeyr 22 Dec '15

22 Dec '15

Hi, so in osmo-iuh, we're using the libre asn1c, the generated sources found in e.g. src/hnbap/. But I do find the dirs: ./asn1/rua/ffasn1c ./asn1/ranap/ffasn1c ./asn1/hnbap/ffasn1c that kind of look like we were using the ffasn1c compiler. Those are obsolete, right? Remove? ~Neels -- - Neels Hofmeyr <nhofmeyr(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Holger Freyther, Harald Welte

2 1

[PATCH 1/2] bitvec: Add get/set byte sequences
by Jacob Erlbeck 21 Dec '15

21 Dec '15

The new functions bitvec_get_bytes and bitvec_set_bytes copy byte sequences from bitvecs to uint8_t arrays and vice versa. While the bytes in the bitvecs do not need to be aligned, the uint8_t arrays always are. In case the bytes in the bitvec are aligned, the implementation uses memcpy. Note that the implementation like the other existing functions assume MSB first encoding. Sponsored-by: On-Waves ehf --- include/osmocom/core/bitvec.h | 2 ++ src/bitvec.c | 75 +++++++++++++++++++++++++++++++++++++++++++ tests/Makefile.am | 9 ++++-- tests/testsuite.at | 6 ++++ 4 files changed, 90 insertions(+), 2 deletions(-) diff --git a/include/osmocom/core/bitvec.h b/include/osmocom/core/bitvec.h index 62e2e7b..445730e 100644 --- a/include/osmocom/core/bitvec.h +++ b/include/osmocom/core/bitvec.h @@ -63,5 +63,7 @@ int bitvec_set_uint(struct bitvec *bv, unsigned int in, int count); int bitvec_get_uint(struct bitvec *bv, int num_bits); int bitvec_find_bit_pos(const struct bitvec *bv, unsigned int n, enum bit_value val); int bitvec_spare_padding(struct bitvec *bv, unsigned int up_to_bit); +int bitvec_get_bytes(struct bitvec *bv, uint8_t *bytes, int count); +int bitvec_set_bytes(struct bitvec *bv, const uint8_t *bytes, int count); /*! @} */ diff --git a/src/bitvec.c b/src/bitvec.c index 8da5a48..726a768 100644 --- a/src/bitvec.c +++ b/src/bitvec.c @@ -1,6 +1,7 @@ /* bit vector utility routines */ /* (C) 2009 by Harald Welte <laforge(a)gnumonks.org> + * (C) 2015 by Sysmocom s.f.m.c. GmbH * * All Rights Reserved * @@ -30,6 +31,7 @@ #include <errno.h> #include <stdint.h> +#include <string.h> #include <osmocom/core/bitvec.h> @@ -261,4 +263,77 @@ int bitvec_find_bit_pos(const struct bitvec *bv, unsigned int n, return -1; } +/*! \brief get multiple bytes from current pos + * Assumes MSB first encoding. + * \param[in] bv bit vector + * \param[in] bytes array + * \param[in] count number of bytes to copy + */ +int bitvec_get_bytes(struct bitvec *bv, uint8_t *bytes, int count) +{ + int byte_offs = bytenum_from_bitnum(bv->cur_bit); + int bit_offs = bv->cur_bit % 8; + uint8_t c, last_c; + int i; + uint8_t *src; + + if (byte_offs + count + (bit_offs ? 1 : 0) > bv->data_len) + return -EINVAL; + + if (bit_offs == 0) { + memcpy(bytes, bv->data + byte_offs, count); + } else { + src = bv->data + byte_offs; + last_c = *(src++); + for (i = count; i > 0; i--) { + c = *(src++); + *(bytes++) = + (last_c << bit_offs) | + (c >> (8 - bit_offs)); + last_c = c; + } + } + + bv->cur_bit += count * 8; + return 0; +} + +/*! \brief set multiple bytes at current pos + * Assumes MSB first encoding. + * \param[in] bv bit vector + * \param[in] bytes array + * \param[in] count number of bytes to copy + */ +int bitvec_set_bytes(struct bitvec *bv, const uint8_t *bytes, int count) +{ + int byte_offs = bytenum_from_bitnum(bv->cur_bit); + int bit_offs = bv->cur_bit % 8; + uint8_t c, last_c; + int i; + uint8_t *dst; + + if (byte_offs + count + (bit_offs ? 1 : 0) > bv->data_len) + return -EINVAL; + + if (bit_offs == 0) { + memcpy(bv->data + byte_offs, bytes, count); + } else if (count > 0) { + dst = bv->data + byte_offs; + /* Get lower bits of first dst byte */ + last_c = *dst >> (8 - bit_offs); + for (i = count; i > 0; i--) { + c = *(bytes++); + *(dst++) = + (last_c << (8 - bit_offs)) | + (c >> bit_offs); + last_c = c; + } + /* Overwrite lower bits of N+1 dst byte */ + *dst = (*dst & ((1 << (8 - bit_offs)) - 1)) | + (last_c << (8 - bit_offs)); + } + + bv->cur_bit += count * 8; + return 0; +} /*! @} */ diff --git a/tests/Makefile.am b/tests/Makefile.am index 3dc9bd9..0d220e8 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -10,7 +10,8 @@ check_PROGRAMS = timer/timer_test sms/sms_test ussd/ussd_test \ kasumi/kasumi_test logging/logging_test fr/fr_test \ loggingrb/loggingrb_test strrb/strrb_test \ vty/vty_test comp128/comp128_test utils/utils_test \ - smscb/gsm0341_test stats/stats_test + smscb/gsm0341_test stats/stats_test \ + bitvec/bitvec_test if ENABLE_MSGFILE check_PROGRAMS += msgfile/msgfile_test @@ -37,6 +38,9 @@ auth_milenage_test_LDADD = $(top_builddir)/src/libosmocore.la $(top_builddir)/sr bits_bitrev_test_SOURCES = bits/bitrev_test.c bits_bitrev_test_LDADD = $(top_builddir)/src/libosmocore.la +bitvec_bitvec_test_SOURCES = bitvec/bitvec_test.c +bitvec_bitvec_test_LDADD = $(top_builddir)/src/libosmocore.la + conv_conv_test_SOURCES = conv/conv_test.c conv_conv_test_LDADD = $(top_builddir)/src/libosmocore.la @@ -124,7 +128,8 @@ EXTRA_DIST = testsuite.at $(srcdir)/package.m4 $(TESTSUITE) \ fr/fr_test.ok loggingrb/logging_test.ok \ loggingrb/logging_test.err strrb/strrb_test.ok \ vty/vty_test.ok comp128/comp128_test.ok \ - utils/utils_test.ok stats/stats_test.ok + utils/utils_test.ok stats/stats_test.ok \ + bitvec/bitvec_test.ok DISTCLEANFILES = atconfig diff --git a/tests/testsuite.at b/tests/testsuite.at index a542798..4a3fc0d 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -21,6 +21,12 @@ cat $abs_srcdir/bits/bitrev_test.ok > expout AT_CHECK([$abs_top_builddir/tests/bits/bitrev_test], [0], [expout]) AT_CLEANUP +AT_SETUP([bitvec]) +AT_KEYWORDS([bitvec]) +cat $abs_srcdir/bitvec/bitvec_test.ok > expout +AT_CHECK([$abs_top_builddir/tests/bitvec/bitvec_test], [0], [expout], [ignore]) +AT_CLEANUP + AT_SETUP([conv]) AT_KEYWORDS([conv]) cat $abs_srcdir/conv/conv_test.ok > expout -- 1.9.1

1 2