OpenBSC

openbsc@lists.osmocom.org

4315 discussions

[PATCH] osmo-pcu[master]: add comments to describe functions
by lynxis lazus 25 May '16

25 May '16

Review at https://gerrit.osmocom.org/106 add comments to describe functions Change-Id: Ie351632001abbeb82008a5eecae0d0323a8ef7d7 --- M src/bts.cpp M src/tbf_ul.cpp 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/06/106/1 diff --git a/src/bts.cpp b/src/bts.cpp index fdae1f0..c3d17ff 100644 --- a/src/bts.cpp +++ b/src/bts.cpp @@ -1317,6 +1317,7 @@ return -EINVAL; } +/*! \brief process egprs and gprs data blocks */ int gprs_rlcmac_pdch::rcv_data_block(uint8_t *data, uint32_t fn, struct pcu_l1_meas *meas, GprsCodingScheme cs) { diff --git a/src/tbf_ul.cpp b/src/tbf_ul.cpp index 5178875..23b21e3 100644 --- a/src/tbf_ul.cpp +++ b/src/tbf_ul.cpp @@ -138,6 +138,7 @@ return msg; } +/*! \brief receive data from PDCH/L1 */ int gprs_rlcmac_ul_tbf::rcv_data_block_acknowledged( const struct gprs_rlc_data_info *rlc, uint8_t *data, struct pcu_l1_meas *meas) -- To view, visit https://gerrit.osmocom.org/106 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie351632001abbeb82008a5eecae0d0323a8ef7d7 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

3 2

[PATCH] osmo-pcu[master]: tbf_ul: use correct size for chunk_size
by lynxis lazus 25 May '16

25 May '16

Review at https://gerrit.osmocom.org/105 tbf_ul: use correct size for chunk_size The size of the hole array in bytes was used instead of the size of elements. Change-Id: If6bf3e5f1ad773ddaa9fb2ce7c069e6b26659cbf --- M src/tbf_ul.cpp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/05/105/1 diff --git a/src/tbf_ul.cpp b/src/tbf_ul.cpp index 9e763f4..5178875 100644 --- a/src/tbf_ul.cpp +++ b/src/tbf_ul.cpp @@ -60,7 +60,7 @@ LOGP(DRLCMACUL, LOGL_DEBUG, "- Assembling frames: (len=%d)\n", len); num_frames = Decoding::rlc_data_from_ul_data( - rdbi, cs, data, &(frames[0]), sizeof(frames), + rdbi, cs, data, &(frames[0]), ARRAY_SIZE(frame), &dummy_tlli); /* create LLC frames */ -- To view, visit https://gerrit.osmocom.org/105 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If6bf3e5f1ad773ddaa9fb2ce7c069e6b26659cbf Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

2 4

[PATCH] osmo-pcu[master]: rlc.h: remove duplicated define RLC_EGPRS_SNS
by lynxis lazus 25 May '16

25 May '16

Review at https://gerrit.osmocom.org/107 rlc.h: remove duplicated define RLC_EGPRS_SNS Change-Id: Ibb718ba9be21831c56c5949e730fab5acd691d7c --- M src/rlc.h 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/07/107/1 diff --git a/src/rlc.h b/src/rlc.h index 8f75588..03659da 100644 --- a/src/rlc.h +++ b/src/rlc.h @@ -27,7 +27,6 @@ #define RLC_GPRS_SNS 128 /* GPRS, must be power of 2 */ #define RLC_GPRS_WS 64 /* max window size */ -#define RLC_EGPRS_SNS 2048 /* EGPRS, must be power of 2 */ #define RLC_EGPRS_MIN_WS 64 /* min window size */ #define RLC_EGPRS_MAX_WS 1024 /* min window size */ #define RLC_EGPRS_SNS 2048 /* EGPRS, must be power of 2 */ -- To view, visit https://gerrit.osmocom.org/107 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibb718ba9be21831c56c5949e730fab5acd691d7c Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

3 6

[PATCH] libosmocore[master]: misc: Some spelling errors corrected
by Holger Freyther 25 May '16

25 May '16

Review at https://gerrit.osmocom.org/114 misc: Some spelling errors corrected Change-Id: Ibfc239b84879556624ca6020ae6a63d102640c94 --- M src/logging.c M src/sim/card_fs_tetra.c 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/14/114/1 diff --git a/src/logging.c b/src/logging.c index b2f8d43..8a10133 100644 --- a/src/logging.c +++ b/src/logging.c @@ -130,7 +130,7 @@ "Don't use. It doesn't log anything", "Log debug messages and higher levels", "Log informational messages and higher levels", - "Log noticable messages and higher levels", + "Log noticeable messages and higher levels", "Log error messages and higher levels", "Log only fatal messages", NULL, diff --git a/src/sim/card_fs_tetra.c b/src/sim/card_fs_tetra.c index 625adbd..657e55f 100644 --- a/src/sim/card_fs_tetra.c +++ b/src/sim/card_fs_tetra.c @@ -204,7 +204,7 @@ EF_LIN_FIX_N(0x6F2B, SFI_NONE, "EF.MSGEXT", F_OPTIONAL, 16, 16, "Message Extension"), EF_LIN_FIX_N(0x6F2C, SFI_NONE, "EF.EADDR", 0, 17, 17, - "Emergency adresses"), + "Emergency addresses"), EF_TRANSP_N(0x6F2D, SFI_NONE, "EF.EINFO", 0, 2, 2, "Emergency call information"), EF_LIN_FIX_N(0x6F2E, SFI_NONE, "EF.DMOCh", F_OPTIONAL, 4, 4, -- To view, visit https://gerrit.osmocom.org/114 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibfc239b84879556624ca6020ae6a63d102640c94 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Holger Freyther <holger(a)freyther.de>

2 2

[PATCH] openbsc[master]: filter/nat: Fix the context for the imsi assignment
by Holger Freyther 25 May '16

25 May '16

Review at https://gerrit.osmocom.org/102 filter/nat: Fix the context for the imsi assignment In c09f8a3b7fb94ccef41e33c32bfe2bff1ffe0e44 as part of a cleanup I accidently changed the talloc context from "con" to "bsc". The issue occurred at an earlier commit when assigning req.ctx to the "wrong" context. The allocation needs to be scoped by the struct nat_sccp_connection and not the connection from BSC to NAT. Before we have a nat_sccp_connection we scope the copied imsi to the bsc_connection and then steal it, but for the identity resp we will always have a nat_sccp_connection and can already use the right context. Change-Id: I53789aad2809e19338ad3b2deb72c4757e7bd524 Related: OS#1733 --- M openbsc/src/osmo-bsc_nat/bsc_nat_filter.c M openbsc/tests/bsc-nat/bsc_nat_test.c 2 files changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/02/102/1 diff --git a/openbsc/src/osmo-bsc_nat/bsc_nat_filter.c b/openbsc/src/osmo-bsc_nat/bsc_nat_filter.c index 393aea3..e735290 100644 --- a/openbsc/src/osmo-bsc_nat/bsc_nat_filter.c +++ b/openbsc/src/osmo-bsc_nat/bsc_nat_filter.c @@ -109,7 +109,7 @@ if (!hdr48) return -1; - req.ctx = bsc; + req.ctx = con; req.black_list = &bsc->nat->imsi_black_list; req.access_lists = &bsc->nat->access_lists; req.local_lst_name = bsc->cfg->acc_lst_name; diff --git a/openbsc/tests/bsc-nat/bsc_nat_test.c b/openbsc/tests/bsc-nat/bsc_nat_test.c index a405763..b531c6b 100644 --- a/openbsc/tests/bsc-nat/bsc_nat_test.c +++ b/openbsc/tests/bsc-nat/bsc_nat_test.c @@ -978,10 +978,13 @@ } memset(&cause, 0, sizeof(cause)); + OSMO_ASSERT(!con->filter_state.imsi); if (bsc_nat_filter_dt(bsc, msg, con, parsed, &cause) != 1) { printf("FAIL: Should have passed..\n"); abort(); } + OSMO_ASSERT(con->filter_state.imsi); + OSMO_ASSERT(talloc_parent(con->filter_state.imsi) == con); /* just some basic length checking... */ for (i = ARRAY_SIZE(id_resp); i >= 0; --i) { -- To view, visit https://gerrit.osmocom.org/102 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I53789aad2809e19338ad3b2deb72c4757e7bd524 Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Holger Freyther <holger(a)freyther.de>

3 4

[PATCH] openbsc[master]: debian: Make upgrading from debian SID easier
by Holger Freyther 25 May '16

25 May '16

Review at https://gerrit.osmocom.org/113 debian: Make upgrading from debian SID easier Make sure the version number of this sourcepackage is higher than the one found in Debian SID. Change-Id: I838632e9e90378a03235c2aebd5bc9ed06627ec8 --- M debian/changelog 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/13/113/1 diff --git a/debian/changelog b/debian/changelog index 5f00a30..6a0362a 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,4 +1,10 @@ -openbsc (0.14.0) UNRELEASED; urgency=low +openbsc (0.15.1) UNRELEASED; urgency=medium + + * Move forward toward a new release. + + -- Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Tue, 24 May 2016 23:14:31 +0200 + +openbsc (0.14.0) unstable; urgency=low * New upstream tag and additional patches. -- To view, visit https://gerrit.osmocom.org/113 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I838632e9e90378a03235c2aebd5bc9ed06627ec8 Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Holger Freyther <holger(a)freyther.de>

1 2

[PATCH] libosmo-abis[master]: debian: Make upgrading from debian SID easier
by Holger Freyther 25 May '16

25 May '16

Review at https://gerrit.osmocom.org/110 debian: Make upgrading from debian SID easier Make sure the version number of this sourcepackage is higher than the one found in Debian SID. Change-Id: I393ef6624f112794e15b81a0cc9dbd8b0a871b07 --- M debian/changelog 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/10/110/1 diff --git a/debian/changelog b/debian/changelog index f1842fa..b2cf0e9 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,4 +1,10 @@ -libosmo-abis (0.3.2) UNRELEASED; urgency=medium +libosmo-abis (0.3.3) UNRELEASED; urgency=medium + + * Move forward towards a new release. + + -- Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Tue, 24 May 2016 23:02:47 +0200 + +libosmo-abis (0.3.2) unstable; urgency=medium * Bump so version to re-link libosmovty -- To view, visit https://gerrit.osmocom.org/110 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I393ef6624f112794e15b81a0cc9dbd8b0a871b07 Gerrit-PatchSet: 1 Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Owner: Holger Freyther <holger(a)freyther.de>

1 2

[PATCH] libosmo-sccp[master]: debian: Make upgrading from debian SID easier
by Holger Freyther 25 May '16

25 May '16

Review at https://gerrit.osmocom.org/109 debian: Make upgrading from debian SID easier Make sure the version number of this sourcepackage is higher than the one found in Debian SID. Change-Id: I87534954c1f4b499e27452382df412454ea16b64 --- M debian/changelog 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/09/109/1 diff --git a/debian/changelog b/debian/changelog index 9e5884e..b7a0c97 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +libosmo-sccp (0.7.1) UNRELEASED; urgency=medium + + * Move forward towards a new release. + + -- Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Tue, 24 May 2016 22:57:59 +0200 + libosmo-sccp (0.7.0) unstable; urgency=medium * New release. -- To view, visit https://gerrit.osmocom.org/109 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I87534954c1f4b499e27452382df412454ea16b64 Gerrit-PatchSet: 1 Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Owner: Holger Freyther <holger(a)freyther.de>

1 2

[PATCH] openbsc[master]: rtp_proxy.c: Ensure msgb_alloc is large enough for largest A...
by Neels Hofmeyr 25 May '16

25 May '16

Review at https://gerrit.osmocom.org/91 rtp_proxy.c: Ensure msgb_alloc is large enough for largest AMR frame In AMR 12.2 (mode 7), the actual RTP payload is 33 bytes. Howeerver, as we store the length of the (dynamically-sized) AMR payload in the first byte, our buffer needs at least 33+1 byte in size. Change-Id: If1ad5d2d68c85733306c75ea62f67fe8fbc143b3 --- M openbsc/src/libtrau/rtp_proxy.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/91/91/1 diff --git a/openbsc/src/libtrau/rtp_proxy.c b/openbsc/src/libtrau/rtp_proxy.c index 8c982c9..6c04610 100644 --- a/openbsc/src/libtrau/rtp_proxy.c +++ b/openbsc/src/libtrau/rtp_proxy.c @@ -172,7 +172,7 @@ /* always allocate for the maximum possible size to avoid * fragmentation */ new_msg = msgb_alloc(sizeof(struct gsm_data_frame) + - MAX_RTP_PAYLOAD_LEN, "GSM-DATA (TCH)"); + MAX_RTP_PAYLOAD_LEN+1, "GSM-DATA (TCH)"); if (!new_msg) return -ENOMEM; -- To view, visit https://gerrit.osmocom.org/91 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If1ad5d2d68c85733306c75ea62f67fe8fbc143b3 Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge(a)gnumonks.org>

3 3

[PATCH] osmo-pcu[master]: bts/counter: replace '_' with '-' in counter names
by lynxis lazus 24 May '16

24 May '16

Review at https://gerrit.osmocom.org/103 bts/counter: replace '_' with '-' in counter names Conform to the convention. Change-Id: I6162694aae8d354aba318cc1acfdac108239fef0 --- M src/bts.cpp 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/03/103/1 diff --git a/src/bts.cpp b/src/bts.cpp index fdae1f0..03b0401 100644 --- a/src/bts.cpp +++ b/src/bts.cpp @@ -71,8 +71,8 @@ { "rlc.ack.failed", "RLC Ack Failed "}, { "rlc.rel.timedout", "RLC Release Timeout "}, { "rlc.late-block", "RLC Late Block "}, - { "rlc.sent_dummy", "RLC Sent Dummy "}, - { "rlc.sent_control", "RLC Sent Control "}, + { "rlc.sent-dummy", "RLC Sent Dummy "}, + { "rlc.sent-control", "RLC Sent Control "}, { "decode.errors", "Decode Errors "}, { "sba.allocated", "SBA Allocated "}, { "sba.freed", "SBA Freed "}, -- To view, visit https://gerrit.osmocom.org/103 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6162694aae8d354aba318cc1acfdac108239fef0 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

2 2

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

OpenBSC