- OpenBSC - lists.osmocom.org

[PATCH] libosmo-netif[releases/0.0.6-stable]: debian: Bump version to 0.0.6.1 with osmux leak fixes
by Holger Freyther 26 May '16

26 May '16

Review at https://gerrit.osmocom.org/123 debian: Bump version to 0.0.6.1 with osmux leak fixes Attempt to fix leaks in osmux and cherry-pick two changes from master back to this release. Change-Id: I8793bc823cd72a7c883df17cf2f8d3b74df675a9 --- M debian/changelog 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/23/123/1 diff --git a/debian/changelog b/debian/changelog index 2180e56..d129d37 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +libosmo-netif (0.0.6.1) UNRELEASED; urgency=medium + + * Bugfix release for OS#1733 + + -- Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Thu, 26 May 2016 14:14:24 +0200 + libosmo-netif (0.0.6) unstable; urgency=medium * Drop libosmovty dependency. -- To view, visit https://gerrit.osmocom.org/123 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8793bc823cd72a7c883df17cf2f8d3b74df675a9 Gerrit-PatchSet: 1 Gerrit-Project: libosmo-netif Gerrit-Branch: releases/0.0.6-stable Gerrit-Owner: Holger Freyther <holger(a)freyther.de>

1 1

[PATCH] libosmo-netif[releases/0.0.6-stable]: osmux: Add function to delete all msgs pending for a circuit
by Holger Freyther 26 May '16

26 May '16

Hello Jenkins Builder, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/122 to review the following change. osmux: Add function to delete all msgs pending for a circuit Use this function in osmux_batch_del_circuit() since msgs are stored in a list per circuit. After the circuit is free()d the msgs are lost. Before this patch any messages enqueued inside a batch when the circiut is deleted were leaking. Change-Id: Ib0311652183332d0475bf7347023d518d38487ef Ticket: OS#1733 Reviewed-on: https://gerrit.osmocom.org/120 Tested-by: Jenkins Builder Reviewed-by: Holger Freyther <holger(a)freyther.de> --- M src/osmux.c 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/22/122/1 diff --git a/src/osmux.c b/src/osmux.c index 1f5bbe2..0bee9cc 100644 --- a/src/osmux.c +++ b/src/osmux.c @@ -225,6 +225,16 @@ circuit->nmsgs--; } +static void osmux_circuit_del_msgs(struct osmux_batch *batch, struct osmux_circuit *circuit) +{ + struct msgb *cur, *tmp; + llist_for_each_entry_safe(cur, tmp, &circuit->msg_list, list) { + osmux_batch_dequeue(cur, circuit); + msgb_free(cur); + batch->nmsgs--; + } +} + struct osmux_input_state { struct msgb *out_msg; struct msgb *msg; @@ -538,6 +548,7 @@ if (circuit->dummy) batch->ndummy--; llist_del(&circuit->head); + osmux_circuit_del_msgs(batch, circuit); talloc_free(circuit); } -- To view, visit https://gerrit.osmocom.org/122 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib0311652183332d0475bf7347023d518d38487ef Gerrit-PatchSet: 1 Gerrit-Project: libosmo-netif Gerrit-Branch: releases/0.0.6-stable Gerrit-Owner: Holger Freyther <holger(a)freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>

1 1

[PATCH] libosmo-netif[releases/0.0.6-stable]: osmux: Pass circuit to _batch_del_circuit() and use it from ...
by Holger Freyther 26 May '16

26 May '16

Hello Jenkins Builder, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/121 to review the following change. osmux: Pass circuit to _batch_del_circuit() and use it from _xfrm_input_fini() Change-Id: If224980123d4a369133499ab7b577d02511f4055 Ticket: OS#1733 Reviewed-on: https://gerrit.osmocom.org/119 Tested-by: Jenkins Builder Reviewed-by: Holger Freyther <holger(a)freyther.de> --- M src/osmux.c 1 file changed, 10 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/21/121/1 diff --git a/src/osmux.c b/src/osmux.c index 8025d5d..1f5bbe2 100644 --- a/src/osmux.c +++ b/src/osmux.c @@ -533,14 +533,8 @@ return circuit; } -static void osmux_batch_del_circuit(struct osmux_batch *batch, int ccid) +static void osmux_batch_del_circuit(struct osmux_batch *batch, struct osmux_circuit *circuit) { - struct osmux_circuit *circuit; - - circuit = osmux_batch_find_circuit(batch, ccid); - if (circuit == NULL) - return; - if (circuit->dummy) batch->ndummy--; llist_del(&circuit->head); @@ -713,8 +707,13 @@ void osmux_xfrm_input_close_circuit(struct osmux_in_handle *h, int ccid) { struct osmux_batch *batch = (struct osmux_batch *)h->internal_data; + struct osmux_circuit *circuit; - osmux_batch_del_circuit(batch, ccid); + circuit = osmux_batch_find_circuit(batch, ccid); + if (circuit == NULL) + return; + + osmux_batch_del_circuit(batch, circuit); } void osmux_xfrm_input_fini(struct osmux_in_handle *h) @@ -722,10 +721,9 @@ struct osmux_batch *batch = (struct osmux_batch *)h->internal_data; struct osmux_circuit *circuit, *next; - llist_for_each_entry_safe(circuit, next, &batch->circuit_list, head) { - llist_del(&circuit->head); - talloc_free(circuit); - } + llist_for_each_entry_safe(circuit, next, &batch->circuit_list, head) + osmux_batch_del_circuit(batch, circuit); + osmo_timer_del(&batch->timer); talloc_free(batch); } -- To view, visit https://gerrit.osmocom.org/121 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If224980123d4a369133499ab7b577d02511f4055 Gerrit-PatchSet: 1 Gerrit-Project: libosmo-netif Gerrit-Branch: releases/0.0.6-stable Gerrit-Owner: Holger Freyther <holger(a)freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>

1 1

[PATCH] libosmo-netif[master]: osmux: Add function to delete all msgs pending for a circuit
by daniel 26 May '16

26 May '16

Review at https://gerrit.osmocom.org/120 osmux: Add function to delete all msgs pending for a circuit Use this function in osmux_batch_del_circuit() since msgs are stored in a list per circuit. After the circuit is free()d the msgs are lost. Before this patch any messages enqueued inside a batch when the circiut is deleted were leaking. Change-Id: Ib0311652183332d0475bf7347023d518d38487ef Ticket: OS#1733 --- M src/osmux.c 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/20/120/1 diff --git a/src/osmux.c b/src/osmux.c index 44b4b96..01d0bdc 100644 --- a/src/osmux.c +++ b/src/osmux.c @@ -225,6 +225,17 @@ circuit->nmsgs--; } +static void osmux_circuit_del_msgs(struct osmux_batch *batch, struct osmux_circuit *circuit) +{ + struct msgb *cur, *tmp; + llist_for_each_entry_safe(cur, tmp, &circuit->msg_list, list) { + + osmux_batch_dequeue(cur, circuit); + msgb_free(cur); + batch->nmsgs--; + } +} + struct osmux_input_state { struct msgb *out_msg; struct msgb *msg; @@ -538,6 +549,7 @@ if (circuit->dummy) batch->ndummy--; llist_del(&circuit->head); + osmux_circuit_del_msgs(batch, circuit); talloc_free(circuit); } -- To view, visit https://gerrit.osmocom.org/120 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib0311652183332d0475bf7347023d518d38487ef Gerrit-PatchSet: 1 Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>

2 5

[PATCH] libosmo-netif[master]: osmux: Pass circuit to _batch_del_circuit() and use it from ...
by daniel 25 May '16

25 May '16

Review at https://gerrit.osmocom.org/119 osmux: Pass circuit to _batch_del_circuit() and use it from _xfrm_input_fini() Change-Id: If224980123d4a369133499ab7b577d02511f4055 Ticket: OS#1733 --- M src/osmux.c 1 file changed, 8 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/19/119/1 diff --git a/src/osmux.c b/src/osmux.c index 8025d5d..44b4b96 100644 --- a/src/osmux.c +++ b/src/osmux.c @@ -533,14 +533,8 @@ return circuit; } -static void osmux_batch_del_circuit(struct osmux_batch *batch, int ccid) +static void osmux_batch_del_circuit(struct osmux_batch *batch, struct osmux_circuit *circuit) { - struct osmux_circuit *circuit; - - circuit = osmux_batch_find_circuit(batch, ccid); - if (circuit == NULL) - return; - if (circuit->dummy) batch->ndummy--; llist_del(&circuit->head); @@ -713,8 +707,13 @@ void osmux_xfrm_input_close_circuit(struct osmux_in_handle *h, int ccid) { struct osmux_batch *batch = (struct osmux_batch *)h->internal_data; + struct osmux_circuit *circuit; - osmux_batch_del_circuit(batch, ccid); + circuit = osmux_batch_find_circuit(batch, ccid); + if (circuit == NULL) + return; + + osmux_batch_del_circuit(batch, circuit); } void osmux_xfrm_input_fini(struct osmux_in_handle *h) @@ -723,8 +722,7 @@ struct osmux_circuit *circuit, *next; llist_for_each_entry_safe(circuit, next, &batch->circuit_list, head) { - llist_del(&circuit->head); - talloc_free(circuit); + osmux_batch_del_circuit(batch, circuit); } osmo_timer_del(&batch->timer); talloc_free(batch); -- To view, visit https://gerrit.osmocom.org/119 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If224980123d4a369133499ab7b577d02511f4055 Gerrit-PatchSet: 1 Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>

2 6

[PATCH] libsmpp34[master]: Fix various typos in log messages
by Holger Freyther 25 May '16

25 May '16

Review at https://gerrit.osmocom.org/115 Fix various typos in log messages Change-Id: If52a8546b09ac14c00e6323984eda6d88a558830 --- M src/smpp34_dumpPdu.c M src/smpp34_pack.c M src/smpp34_unpack.c M test_apps/recv_and_unpack.inc 4 files changed, 19 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libsmpp34 refs/changes/15/115/1 diff --git a/src/smpp34_dumpPdu.c b/src/smpp34_dumpPdu.c index 76cd70b..89d6e53 100644 --- a/src/smpp34_dumpPdu.c +++ b/src/smpp34_dumpPdu.c @@ -68,7 +68,7 @@ #par,inst par,dummy_b);\ if( lenval >= left ){\ PUTLOG("[%s:%08X(%s)]", par, inst par,\ - "Value lenght exceed buffer lenght");\ + "Value length exceed buffer length");\ return( -1 );\ };\ snprintf((char*)dest, left, "%s", l_dest);\ @@ -86,7 +86,7 @@ "%-30s[%04X] [%s]\n",#par,inst par,dummy_b);\ if( lenval >= left ){\ PUTLOG("[%s:%04X(%s)]", par, inst par,\ - "Value lenght exceed buffer lenght");\ + "Value length exceed buffer length");\ return( -1 );\ };\ snprintf((char*)dest, left, "%s", l_dest);\ @@ -104,7 +104,7 @@ #par,inst par, dummy_b);\ if( lenval >= left ){\ PUTLOG("[%s:%02X(%s)]", par, inst par,\ - "Value lenght exceed buffer lenght");\ + "Value length exceed buffer length");\ return( -1 );\ };\ snprintf((char*)dest, left, "%s", l_dest);\ @@ -116,7 +116,7 @@ #par, inst par);\ if( lenval >= left ){\ PUTLOG("[%s:%s(%s)]", par, inst par, \ - "Value lenght exceed buffer lenght");\ + "Value length exceed buffer length");\ return( -1 );\ };\ PUTLOG("[%s:%s(%s)]", par, inst par, "OK");\ @@ -143,7 +143,7 @@ lenval = *((inst par) - 1);\ if( (lenval + 33) >= left ){\ PUTLOG("[%s:%s(%s)]", par, inst par, \ - "Value lenght exceed buffer lenght");\ + "Value length exceed buffer length");\ return( -1 );\ };\ PUTLOG("[%s:%s(%s)]", par, "<bin>", "OK");\ @@ -170,7 +170,7 @@ memcpy(&l_lenval, ((inst par) - sizeof(uint16_t)), sizeof(uint16_t));\ if( (l_lenval + 33) >= left ){\ PUTLOG("[%s:%s(%s)]", par, inst par, \ - "Value lenght exceed buffer lenght");\ + "Value length exceed buffer length");\ return( -1 );\ };\ PUTLOG("[%s:%s(%s)]", par, "<bin>", "OK");\ diff --git a/src/smpp34_pack.c b/src/smpp34_pack.c index 1916172..b36e7a4 100644 --- a/src/smpp34_pack.c +++ b/src/smpp34_pack.c @@ -63,7 +63,7 @@ lenval = sizeof(uint32_t);\ if( lenval >= left ){\ PUTLOG("[%s:%08X(%s)]", par, inst par,\ - "Value lenght exceed buffer lenght");\ + "Value length exceed buffer length");\ return( -1 );\ };\ _str(inst par,dummy_b);\ @@ -81,7 +81,7 @@ lenval = sizeof(uint16_t);\ if( lenval >= left ){\ PUTLOG("[%s:%04X(%s)]", par, inst par,\ - "Value lenght exceed buffer lenght");\ + "Value length exceed buffer length");\ return( -1 );\ };\ _str(inst par,dummy_b);\ @@ -98,7 +98,7 @@ lenval = sizeof(uint8_t);\ if( lenval >= left ){\ PUTLOG("[%s:%02X(%s)]", par, inst par,\ - "Value lenght exceed buffer lenght");\ + "Value length exceed buffer length");\ return( -1 );\ };\ _str(inst par,dummy_b);\ @@ -123,7 +123,7 @@ lenval = strlen((char*)inst par) + 1;\ if( lenval > left ){\ PUTLOG("[len(%s):%d(%s)]", par, lenval, \ - "Value lenght exceed buffer lenght");\ + "Value length exceed buffer length");\ return( -1 );\ };\ if( lenval > sizeval ){\ @@ -143,7 +143,7 @@ lenval = *((inst par) - 1);\ if( lenval >= left ){\ PUTLOG("[leng %s:%d(%s)]", par, lenval,\ - "Value lenght exceed buffer lenght");\ + "Value length exceed buffer length");\ return( -1 );\ };\ if( lenval >= sizeval ){\ @@ -162,7 +162,7 @@ memcpy(&l_lenval, ((inst par) - sizeof(uint16_t)), sizeof(uint16_t));\ if( l_lenval >= left ){\ PUTLOG("[leng %s:%d(%s)]", par, l_lenval,\ - "Value lenght exceed buffer lenght");\ + "Value length exceed buffer length");\ return( -1 );\ };\ if( l_lenval > sizeval ){\ diff --git a/src/smpp34_unpack.c b/src/smpp34_unpack.c index e378b0b..f498d01 100644 --- a/src/smpp34_unpack.c +++ b/src/smpp34_unpack.c @@ -60,7 +60,7 @@ lenval = sizeof( uint32_t );\ if( lenval > left ){\ PUTLOG("[%s:%08X(%s)]", par, inst par,\ - "Value lenght exceed buffer lenght");\ + "Value length exceed buffer length");\ return( -1 );\ };\ memcpy(&inst par, aux, lenval);\ @@ -78,7 +78,7 @@ lenval = sizeof( uint16_t );\ if( lenval > left ){\ PUTLOG("[%s:%04X(%s)]", par, inst par,\ - "Value lenght exceed buffer lenght");\ + "Value length exceed buffer length");\ return( -1 );\ }\ memcpy(&inst par, aux, lenval);\ @@ -96,7 +96,7 @@ lenval = sizeof( uint8_t );\ if( lenval > left ){\ PUTLOG("[%s:%02X(%s)]", par, inst par,\ - "Value lenght exceed buffer lenght");\ + "Value length exceed buffer length");\ return( -1 );\ };\ memcpy(&inst par, aux, lenval);\ @@ -129,7 +129,7 @@ lenval = strlen( (char*) aux ) + 1;\ if( lenval > left ){\ PUTLOG("[len(%s):%d(%s)]", par, lenval, \ - "Value lenght exceed buffer lenght");\ + "Value length exceed buffer length");\ return( -1 );\ };\ if( lenval > size ){\ @@ -147,7 +147,7 @@ lenval = *((inst par) - 1);\ if( lenval > left ){\ PUTLOG("[leng %s:%d(%s)]", par, lenval,\ - "Value lenght exceed buffer lenght");\ + "Value length exceed buffer length");\ return( -1 );\ };\ if( lenval > size ){\ @@ -165,7 +165,7 @@ memcpy(&l_lenval, (inst par - sizeof(uint16_t)), sizeof(uint16_t));\ if( l_lenval > left ){\ PUTLOG("[leng %s:%d(%s)]", par, l_lenval,\ - "Value lenght exceed buffer lenght");\ + "Value length exceed buffer length");\ return( -1 );\ };\ if( l_lenval > size ){\ diff --git a/test_apps/recv_and_unpack.inc b/test_apps/recv_and_unpack.inc index 090ea11..1b85a19 100644 --- a/test_apps/recv_and_unpack.inc +++ b/test_apps/recv_and_unpack.inc @@ -3,7 +3,7 @@ /* Read from socket (This is a sample, must be more complex) **********/ ret = recv(sock_tcp, local_buffer, 4, MSG_PEEK); if( ret != 4 ){ printf("Error in recv(PEEK)\n");return( -1 );}; - memcpy(&tempo, local_buffer, sizeof(uint32_t)); /* get lenght PDU */ + memcpy(&tempo, local_buffer, sizeof(uint32_t)); /* get length PDU */ local_buffer_len = ntohl( tempo ); ret = recv(sock_tcp, local_buffer, local_buffer_len, 0); if( ret != local_buffer_len ){ -- To view, visit https://gerrit.osmocom.org/115 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If52a8546b09ac14c00e6323984eda6d88a558830 Gerrit-PatchSet: 1 Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Owner: Holger Freyther <holger(a)freyther.de>

2 2

[PATCH] libsmpp34[master]: debian: Make upgrading from debian SID easier
by Holger Freyther 25 May '16

25 May '16

Review at https://gerrit.osmocom.org/112 debian: Make upgrading from debian SID easier Make sure the version number of this sourcepackage is higher than the one found in Debian SID. Change-Id: I77126b0b9a8dbc4dcdc02a5a3b4718129b308930 --- M debian/changelog 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libsmpp34 refs/changes/12/112/1 diff --git a/debian/changelog b/debian/changelog index 20ae3d3..aae6e0d 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,4 +1,10 @@ -libsmpp34 (1.10z1) UNRELEASED; urgency=low +libsmpp34 (1.11) UNRELEASED; urgency=medium + + * Move forward towards a new release. + + -- Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Tue, 24 May 2016 23:07:49 +0200 + +libsmpp34 (1.10z1) stable; urgency=low * Add depedency from libsmpp34-dev to the main library -- To view, visit https://gerrit.osmocom.org/112 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I77126b0b9a8dbc4dcdc02a5a3b4718129b308930 Gerrit-PatchSet: 1 Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Owner: Holger Freyther <holger(a)freyther.de>

1 2

[PATCH] osmo-pcu[master]: add comments to describe functions
by lynxis lazus 25 May '16

25 May '16

Review at https://gerrit.osmocom.org/106 add comments to describe functions Change-Id: Ie351632001abbeb82008a5eecae0d0323a8ef7d7 --- M src/bts.cpp M src/tbf_ul.cpp 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/06/106/1 diff --git a/src/bts.cpp b/src/bts.cpp index fdae1f0..c3d17ff 100644 --- a/src/bts.cpp +++ b/src/bts.cpp @@ -1317,6 +1317,7 @@ return -EINVAL; } +/*! \brief process egprs and gprs data blocks */ int gprs_rlcmac_pdch::rcv_data_block(uint8_t *data, uint32_t fn, struct pcu_l1_meas *meas, GprsCodingScheme cs) { diff --git a/src/tbf_ul.cpp b/src/tbf_ul.cpp index 5178875..23b21e3 100644 --- a/src/tbf_ul.cpp +++ b/src/tbf_ul.cpp @@ -138,6 +138,7 @@ return msg; } +/*! \brief receive data from PDCH/L1 */ int gprs_rlcmac_ul_tbf::rcv_data_block_acknowledged( const struct gprs_rlc_data_info *rlc, uint8_t *data, struct pcu_l1_meas *meas) -- To view, visit https://gerrit.osmocom.org/106 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie351632001abbeb82008a5eecae0d0323a8ef7d7 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

3 2

[PATCH] osmo-pcu[master]: tbf_ul: use correct size for chunk_size
by lynxis lazus 25 May '16

25 May '16

Review at https://gerrit.osmocom.org/105 tbf_ul: use correct size for chunk_size The size of the hole array in bytes was used instead of the size of elements. Change-Id: If6bf3e5f1ad773ddaa9fb2ce7c069e6b26659cbf --- M src/tbf_ul.cpp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/05/105/1 diff --git a/src/tbf_ul.cpp b/src/tbf_ul.cpp index 9e763f4..5178875 100644 --- a/src/tbf_ul.cpp +++ b/src/tbf_ul.cpp @@ -60,7 +60,7 @@ LOGP(DRLCMACUL, LOGL_DEBUG, "- Assembling frames: (len=%d)\n", len); num_frames = Decoding::rlc_data_from_ul_data( - rdbi, cs, data, &(frames[0]), sizeof(frames), + rdbi, cs, data, &(frames[0]), ARRAY_SIZE(frame), &dummy_tlli); /* create LLC frames */ -- To view, visit https://gerrit.osmocom.org/105 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If6bf3e5f1ad773ddaa9fb2ce7c069e6b26659cbf Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

2 4

[PATCH] osmo-pcu[master]: rlc.h: remove duplicated define RLC_EGPRS_SNS
by lynxis lazus 25 May '16

25 May '16

Review at https://gerrit.osmocom.org/107 rlc.h: remove duplicated define RLC_EGPRS_SNS Change-Id: Ibb718ba9be21831c56c5949e730fab5acd691d7c --- M src/rlc.h 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/07/107/1 diff --git a/src/rlc.h b/src/rlc.h index 8f75588..03659da 100644 --- a/src/rlc.h +++ b/src/rlc.h @@ -27,7 +27,6 @@ #define RLC_GPRS_SNS 128 /* GPRS, must be power of 2 */ #define RLC_GPRS_WS 64 /* max window size */ -#define RLC_EGPRS_SNS 2048 /* EGPRS, must be power of 2 */ #define RLC_EGPRS_MIN_WS 64 /* min window size */ #define RLC_EGPRS_MAX_WS 1024 /* min window size */ #define RLC_EGPRS_SNS 2048 /* EGPRS, must be power of 2 */ -- To view, visit https://gerrit.osmocom.org/107 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibb718ba9be21831c56c5949e730fab5acd691d7c Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

3 6