OpenBSC

openbsc@lists.osmocom.org

13 participants
4278 discussions

[openggsn] [PATCH 1/2] Fix possible buffer overflow for gsn_restart file path
by Neels Hofmeyr 18 Aug '16

18 Aug '16

For strncat, to obtain n, one must not subtract the length of what is appended, but the length of what is already written from the buffer size. Verified with this little test program: #include <stdio.h> #include <string.h> int main() { char buf[20]; strncpy(buf, "123", 10); strncat(buf, "456789012345", 10 - strlen(buf)); printf("%s\n", buf); return 0; } It prints "1234567890". --- gtp/gtp.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gtp/gtp.c b/gtp/gtp.c index 12cb492..34e1dc6 100644 --- a/gtp/gtp.c +++ b/gtp/gtp.c @@ -648,9 +648,10 @@ static void log_restart(struct gsn_t *gsn) int counter = 0; char filename[NAMESIZE]; - filename[NAMESIZE - 1] = 0; /* No null term. guarantee by strncpy */ + /* guarantee nul term, strncpy might omit if too long */ + filename[NAMESIZE - 1] = 0; strncpy(filename, gsn->statedir, NAMESIZE - 1); - strncat(filename, RESTART_FILE, NAMESIZE - 1 - sizeof(RESTART_FILE)); + strncat(filename, RESTART_FILE, NAMESIZE - 1 - strlen(filename)); i = umask(022); -- 2.1.4

2 2

lchan broken unusable activation timeout
by Keith 18 Aug '16

18 Aug '16

Hi all In some communities we are using 5Ghz wifi links between the box running openBSC and the sbts2050. In often works well for some time, but then we get plagued with BROKEN_UNUSABLE channels: I cannot say exactly why, probably rain, solar radiation, aliens, goblins.. etc. I have yet to actually be able to watch it happen. I usually just discover the problem, correct it and then it works fine until I get bored watching. BTS 1, TRX 0, Timeslot 1, Lchan 2: Type NONE Connection: 0, State: BROKEN UNUSABLE Error reason: activation timeout This requires then either A) use the drop command in the vty B) restart the osmo-bts process on the 2050 (same thing as A really) C) restart osmo-nitb All these things are ugly, as they will drop other calls on the BTS at the time. The question is, would somebody help make this more robust, as in have it self repair? Initial questions: Why does the broken unusable channel stay as such until manual intervention, Is is just because the code has not been written to monitor and recover, or is there some other reason? I am thinking that nobody ever did this, probably all testing and installation has been done using nice reliable cabled ethernet and not ugly nasty packet dropping 3km wifi links. :-) Thanks!

2 10

revert policy?
by Neels Hofmeyr 18 Aug '16

18 Aug '16

Hi list, I'd like to gauge your opinions on how to handle reverts: On the one hand, it is good to keep the revert as an exact reverse of the original commit. On the other hand, it may be good to include an in-code comment in the revert to clarify the details for future readers. If both the revert and the comment happen in the same commit, 'git blame' nicely shows that they are related. I would tend towards keeping the revert "clean" and adding comments in a separate commit -- how would you handle this? Thanks, ~Neels -- - Neels Hofmeyr <nhofmeyr(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Harald Welte

2 1

multiline comment style?
by Neels Hofmeyr 18 Aug '16

18 Aug '16

Hi list, I've now heard two conflicting instructions on multi-line comments in osmocom code; I'd like this clarified, which is the preferred multiline comment style? From Holger, first hand: /* * multi * line */ vs. from Harald (?), via hearsay: /* multi * line */ The first is easier to edit, while the last takes up less space... I always used the shorter one until Holger told me to expand. Thanks, ~Neels -- - Neels Hofmeyr <nhofmeyr(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Harald Welte

2 1

Re: Error in making OsmoNITB on Linux
by Neels Hofmeyr 17 Aug '16

17 Aug '16

On Wed, Aug 10, 2016 at 06:16:22PM +0100, Abdulghafar Shabaneh wrote: > Hi Neels > > I did build everything again and got the same error, I use git version > 2.1.4 > there is no PROJECT in the git link you provided but I use the normal ones > from As with common shell scripting lingo, the "$PROJECT" was intended to be replaced with the separate project names following below, and actually you've done this correctly: > git clone git://git.osmocom.org/libosmocore.git > git clone git://git.osmocom.org/libosmo-abis.git > git clone git://git.osmocom.org/libosmo-netif.git > git clone git://git.osmocom.org/libosmo-sccp.git > git clone git://git.osmocom.org/openggsn.git > git clone git://git.osmocom.org/libsmpp34.git > git clone git://git.osmocom.org/openbsc.git I have verified that the build works on my raspberry. I must say it takes impossibly long to build :) My pi hasn't been upgraded in a long time (because that also takes impossibly long). It is still on Debian 7.5. Here are the things I did for a working build: # make /usr/local owned by me, so I can install there without sudo sudo chown -R $USER /usr/local # install dependencies sudo apt-get install automake build-essential gcc pkg-config libc-ares-dev libdbi-dev libpcap-dev libpcsclite-dev libsctp-dev libssl-dev libtalloc-dev libtool make libortp-dev libdbd-sqlite3 # make sure all the libraries will be found -- raspberry pi seems to not # include /usr/local by default. Without this I get an error for openbsc's make # check that the libosmo-abis.so.5 it not found, in the testsuite.log: # (note that you have to do this in every shell you open, or include in your # ~/.profile or something similar.) export LD_LIBRARY_PATH=/usr/local/lib # finally clone and build all projects as listed above. git clone xxx cd xxx autoreconf -fi ./configure make make check make install cd .. # For openbsc, you need to build in openbsc/openbsc, and I passed these config # options: ./configure --enable-smpp --enable-osmo-bsc --enable-nat Thus osmo-nitb works: neels@raspberrypi ~/osmo/openbsc/openbsc/src/osmo-nitb $ ./osmo-nitb -c ../../doc/examples/osmo-nitb/sysmobts/openbsc.cfg <0005> bsc_init.c:498 VTY at 127.0.0.1 4242 <001d> input/ipaccess.c:838 enabling ipaccess BSC mode <0016> smpp_smsc.c:978 SMPP at 0.0.0.0 2775 <0005> bsc_hack.c:318 CTRL at 127.0.0.1 4249 DB: Database initialized. DB: Database prepared. > I have a text file for each of the terminal output but this is too long. > Should I send them separately or in one long email. I'll ask in the list > once you tell me. If the above instructions still don't resolve the issue: It would be sufficient to provide all the commands you have issued and the (final) error message(s) produced. But to make sure that the juicy interesting bits aren't missing, it's easiest to post it all. Posting build output should not harm much; last time you posted a screenshot image file of a small portion of build output, which easily exceeds the file size of your complete build output in plain text format :) You can also opt for using services like http://paste.lisp.org Make sure you don't forget to include the commands you ran to start the build! ~Neels -- - Neels Hofmeyr <nhofmeyr(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Harald Welte

2 2

SS MM Messages (Call forwarding etc)
by Keith Whyte 16 Aug '16

16 Aug '16

Hi All, A few weeks ago, I wrote to the list about a handset that was opening and holding an lchan after doing IMSI attach. After some investigation I see this phone is querying the network for call forwarding status. This phone then cannot send any more USSD codes, or make calls, although it can receive, but for some reason insists on doing the query again after call termination. Doing the same from other handsets, by dialling such codes as *#21# in each case gives the same result of eternal lchan usage, although some (more modern) phones seem to eventually timeout, releasing the channel while others do not. I connected numerous phones and did the same on each one and pretty soon I have a kind of DOS situation on the network in that SDCCH is at capacity. The last log message resulting from the request is /openbsc/openbsc/src/libmsc/gsm_04_08.c:3586 Dispatching 04.08 message, pdisc=11 although strangely with one phone, this is followed shortly by: libosmocore/src/gsm/gsm0480.c:219 USSD Request is too short. openbsc/openbsc/src/libmsc/ussd.c:55 Unhandled SS so for that one phone, it would seem handle_rcv_ussd() is being called from gsm0408_dispatch() I have been going through the code, basically adding more debug output to try to verify what is being called from where, and I also found the functionality in libosmocore such as gsm0480_decode_ss_request(), although this is not called at anytime from the nitb. This is an enormous project! I notice these lines in openbsc/openbsc/src/linmsc/gsm_04_08.c in gsm48_rx_mm_serv_req() /* we will send a MM message soon */ conn->expire_timer_stopped = 1; It would seem that we don't ever send this MM message. It's not clear to me where I might try to check again on the status of this MM request, or if the problem is a lack of full implementation of these supplementary service requests. Would anybody be interested in working on this with me? Keith.

2 5

fyi, neels accounts mixup solved
by Neels Hofmeyr 12 Aug '16

12 Aug '16

Today I've solved the recent weird mixup in gerrit of my main sysmocom account "nhofmeyr" and my private mail address account "neels_test_account". For some time now I've been marking my commits as neels(a)hofmeyr.de, which should have been nhofmeyr(a)sysmocom.de. The config is now fixed in my various git repositories and my future commits should be authored as nhofmeyr. If you spot another neels(a)hofmeyr.de, that's a bug :) ~Neels -- - Neels Hofmeyr <nhofmeyr(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Harald Welte

1 0

osmo-trx: only one TCH/H lchan
by Neels Hofmeyr 10 Aug '16

10 Aug '16

I'd just like to draw attention to an issue that I've just reported: osmo-bts-trx: fails to assign second lchan on TCH/H TS http://osmocom.org/issues/1795 Comments and supplementary facts are welcome! ~Neels -- - Neels Hofmeyr <nhofmeyr(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Harald Welte

1 0

CI infrastructure changes
by Holger Freyther 09 Aug '16

09 Aug '16

Hi, the CI infrastructure exists because I found it import to have all Osmocom software compile and I set-up the Jenkins on my personal infrastructure. Since the adoption of gerrit having a stable build infrastructure is crucial though and my set-up was too flawed. In the past the VirtualBox running the Linux node got stuck and needed manual intervention. As it was running on my private system I was the only one capable of doing that. Sysmocom has offered to rent a dedicated build system and I have used some of my freelancing time to do the migration. * The Jenkins UI/Server jail has been migrated to the system that runs most of the other Osmocom infrastructure. DNS should be updated soon and then TLS will be enabled for the login. * OsmocomBuild1 is a Debian8.0/amd64 build slave with plenty of RAM and running on a SSD. All Linux builds should have been migrated away from the Ubuntu-1504-64 system to it. * rtl-sdr has some funny issue with make uninstall and Doxygen. If someone wants to fix it please go ahead, otherwise I will probably disable doxygen for this build. * I tried to have OpenBSC/OpenBSC-gerrit run in docker[1] so we can run all configurations at the same time but Jenkins is stepping on itself (and removing files from one label and impacting the other). At least we seem to have a benefit if two people upload changes at the same time. kind regards holger [1] I would prefer something without a server (as aborting a build doesn't abort the container) but still convenient enough to just create a new network namespace and remove it on exit [2] We are only executing the four configurations in parallel as the "build concurrently" option is stepping on each other (files vanish, etc).

2 1

[PATCH] remove INSTALL file to have a clean git status
by Neels Hofmeyr 09 Aug '16

09 Aug '16

From: Neels Hofmeyr <neels(a)hofmeyr.de> The INSTALL file is being overwritten by autoreconf, but it is committed as empty file. As a result, the INSTALL file always shows as modified. Instead, remove INSTALL from git and ignore it. --- .gitignore | 1 + INSTALL | 0 2 files changed, 1 insertion(+) delete mode 100644 INSTALL diff --git a/.gitignore b/.gitignore index e15c19b..d1a0b33 100644 --- a/.gitignore +++ b/.gitignore @@ -39,6 +39,7 @@ libtool ltmain.sh missing stamp-h1 +INSTALL # vim *.sw? diff --git a/INSTALL b/INSTALL deleted file mode 100644 index e69de29..0000000 -- 2.1.4

3 4

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

OpenBSC