OpenBSC May 2016

openbsc@lists.osmocom.org

25 participants
164 discussions

by Neels Hofmeyr

Hi Daniel, it seems I'm through with the IuPS branch refactoring. I'm not entirely sure why I'm allowed to do so, but I managed to push the branch to gerrit as refs/heads/sysmocom/iups, so you should see this in origin: sysmocom/iups The branch is fully mergeable to openbsc master as far as I'm concerned, I'm fairly sure that it shouldn't break 2G GPRS -- but untested!! Another limitation: the libosmo-netif and libosmo-sccp branches should possibly be merged to master first. About sysmocom/iups: Most commits have been regrouped and relabeled, yet some remain as they were in the "old" sysmocom/iu branch. I was originally aiming for a 1:1 similarity, but I "had" to change various things: * Some of the commit log messages from sysmocom/iu have been placed in the code as comments instead. * iu_rab_act_ps() was moved (too gprs specific) * some changes were dropped because they were bogus * comments were added, minor cosmetic changes were made * at least the DRANAP, DSUA have been re-ordered cosmetically (to match) * A test failure was fixed * ... * Some "unrelated" patches waiting for review on gerrit are not included in the branch (https://gerrit.osmocom.org/91, 93, 94) Please take a look at the new branch and test it with 3G IuPS. (Since IuCS does not exist on the branch, maybe you need to trick around to have an osmo-cscn? It's an interesting discussion how useful IuPS is without IuCS.) If you have any local further developments on your box, please try to rebase them onto the new branch. If any problems show up, let's clear them in the coming days. Thanks! ~Neels -- - Neels Hofmeyr <nhofmeyr(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Holger Freyther, Harald Welte

9 years, 1 month

gerrit: merge conflict?

by Neels Hofmeyr

My patches https://gerrit.osmocom.org/93 and 94 show as merge conflict in the overview. Yet when I rebase them onto origin/master, neither has a merge conflict. Before 92 was submitted, gerrit said that 93 conflicted with https://gerrit.osmocom.org/92 which has no overlaps, the changes are more than 60 lines apart. In the log I also see a jenkins build success. I have no idea what to make of this. How can I see merge conflicts that gerrit saw and be less confused? ~Neels -- - Neels Hofmeyr <nhofmeyr(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Holger Freyther, Harald Welte

9 years, 1 month

Dynamic parameter changing in OpenBsc/OpenBTS

by אילן וייס

Hello Hello I am using the OpenBTS/OpenBsc software and would like to ask if it is possible to change the following parameters dynamically in the L2/L3 open SW: MCC MNC The name of the network provider Band ARFCN TA filter BA List CA list LAC CRO Parameter: in a rage of -126 to 126 RAC NMO BSIC Cell ID T3212 Power of transmission Neighbor list for UTRA and E-UTRA (System Info 2) I saw that changing these parameters via Vty (telnet) affected only the openbsc.cfg and openbts.cfg files by saving the changes but actually the BSC was not affected from the changes - only after turning the BSC off and on. Can we avoid BSC "restart"? Thanks in advanced, Ilan

9 years, 1 month

[PATCH] openbsc[master]: subscr_name(): Handle case for subscr == NULL

by Neels Hofmeyr

Review at https://gerrit.osmocom.org/92 subscr_name(): Handle case for subscr == NULL subscr_name() was called from several places: * either without a check for subscr being NULL, which for example was causing a segfault if we hand-over a channel before identifying the subscriber * or with an explicit NULL check and the ternary operator (?). We now simplify the code by checking for the NULL Subscriber in subscr_name() itself. Change-Id: Ide09f4a515222eb2ec6c25e7a6a8c5f6cc2ffd4b --- M openbsc/src/libbsc/abis_rsl.c M openbsc/src/libcommon/gsm_subscriber_base.c M openbsc/src/libmsc/gsm_04_08.c 3 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/92/92/1 diff --git a/openbsc/src/libbsc/abis_rsl.c b/openbsc/src/libbsc/abis_rsl.c index df76788..868a069 100644 --- a/openbsc/src/libbsc/abis_rsl.c +++ b/openbsc/src/libbsc/abis_rsl.c @@ -1048,7 +1048,7 @@ int i; char *name = ""; - if (lchan && lchan->conn && lchan->conn->subscr) + if (lchan && lchan->conn) name = subscr_name(lchan->conn->subscr); DEBUGP(DMEAS, "[%s] MEASUREMENT RESULT NR=%d ", name, mr->nr); diff --git a/openbsc/src/libcommon/gsm_subscriber_base.c b/openbsc/src/libcommon/gsm_subscriber_base.c index 50f4118..1f98cc6 100644 --- a/openbsc/src/libcommon/gsm_subscriber_base.c +++ b/openbsc/src/libcommon/gsm_subscriber_base.c @@ -43,6 +43,9 @@ char *subscr_name(struct gsm_subscriber *subscr) { + if (!subscr) + return "unknown"; + if (strlen(subscr->name)) return subscr->name; diff --git a/openbsc/src/libmsc/gsm_04_08.c b/openbsc/src/libmsc/gsm_04_08.c index f02f784..8b4ca67 100644 --- a/openbsc/src/libmsc/gsm_04_08.c +++ b/openbsc/src/libmsc/gsm_04_08.c @@ -447,8 +447,7 @@ msg->lchan = conn->lchan; LOGP(DMM, LOGL_INFO, "Subscriber %s: LOCATION UPDATING REJECT " - "LAC=%u BTS=%u\n", conn->subscr ? - subscr_name(conn->subscr) : "unknown", + "LAC=%u BTS=%u\n", subscr_name(conn->subscr), bts->location_area_code, bts->nr); return gsm48_conn_sendmsg(msg, conn, NULL); @@ -1147,9 +1146,7 @@ break; case GSM48_MT_MM_TMSI_REALL_COMPL: DEBUGP(DMM, "TMSI Reallocation Completed. Subscriber: %s\n", - conn->subscr ? - subscr_name(conn->subscr) : - "unknown subscriber"); + subscr_name(conn->subscr)); release_loc_updating_req(conn, 1); break; case GSM48_MT_MM_IMSI_DETACH_IND: -- To view, visit https://gerrit.osmocom.org/92 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ide09f4a515222eb2ec6c25e7a6a8c5f6cc2ffd4b Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge(a)gnumonks.org>

9 years, 1 month

[PATCH] osmo-pcu[master]: introduce new counter rlc_sent_control

by lynxis lazus

Review at https://gerrit.osmocom.org/99 introduce new counter rlc_sent_control Counts control messages (UL/DL assignment, UL ACKs or page requests) Change-Id: Ib41031d430beddfb48d54470e632436f2c99c360 --- M src/bts.cpp M src/bts.h M src/gprs_rlcmac_sched.cpp 3 files changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/99/99/1 diff --git a/src/bts.cpp b/src/bts.cpp index d1636b6..fdae1f0 100644 --- a/src/bts.cpp +++ b/src/bts.cpp @@ -72,6 +72,7 @@ { "rlc.rel.timedout", "RLC Release Timeout "}, { "rlc.late-block", "RLC Late Block "}, { "rlc.sent_dummy", "RLC Sent Dummy "}, + { "rlc.sent_control", "RLC Sent Control "}, { "decode.errors", "Decode Errors "}, { "sba.allocated", "SBA Allocated "}, { "sba.freed", "SBA Freed "}, diff --git a/src/bts.h b/src/bts.h index 829e3c2..35f24d1 100644 --- a/src/bts.h +++ b/src/bts.h @@ -234,6 +234,7 @@ CTR_RLC_REL_TIMEDOUT, CTR_RLC_LATE_BLOCK, CTR_RLC_SENT_DUMMY, + CTR_RLC_SENT_CONTROL, CTR_DECODE_ERRORS, CTR_SBA_ALLOCATED, CTR_SBA_FREED, @@ -311,6 +312,7 @@ void rlc_rel_timedout(); void rlc_late_block(); void rlc_sent_dummy(); + void rlc_sent_control(); void decode_error(); void sba_allocated(); void sba_freed(); @@ -452,6 +454,7 @@ CREATE_COUNT_INLINE(rlc_rel_timedout, CTR_RLC_REL_TIMEDOUT); CREATE_COUNT_INLINE(rlc_late_block, CTR_RLC_LATE_BLOCK); CREATE_COUNT_INLINE(rlc_sent_dummy, CTR_RLC_SENT_DUMMY); +CREATE_COUNT_INLINE(rlc_sent_control, CTR_RLC_SENT_CONTROL); CREATE_COUNT_INLINE(decode_error, CTR_DECODE_ERRORS) CREATE_COUNT_INLINE(sba_allocated, CTR_SBA_ALLOCATED) CREATE_COUNT_INLINE(sba_freed, CTR_SBA_FREED) diff --git a/src/gprs_rlcmac_sched.cpp b/src/gprs_rlcmac_sched.cpp index 087c03c..b513b5b 100644 --- a/src/gprs_rlcmac_sched.cpp +++ b/src/gprs_rlcmac_sched.cpp @@ -339,6 +339,8 @@ /* Prio 1: select control message */ msg = sched_select_ctrl_msg(trx, ts, fn, block_nr, pdch, ul_ass_tbf, dl_ass_tbf, ul_ack_tbf); + if (msg) + bts->bts->rlc_sent_control(); /* Prio 2: select data message for downlink */ if (!msg) { -- To view, visit https://gerrit.osmocom.org/99 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib41031d430beddfb48d54470e632436f2c99c360 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

9 years, 1 month

[PATCH] osmo-pcu[master]: gprs_rlcmac_sched: fix mistype of CONTROL ACK

by lynxis lazus

Review at https://gerrit.osmocom.org/100 gprs_rlcmac_sched: fix mistype of CONTROL ACK Change-Id: If37b33f69cd659d913ed81eb6060a42734ba524f --- M src/gprs_rlcmac_sched.cpp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/00/100/1 diff --git a/src/gprs_rlcmac_sched.cpp b/src/gprs_rlcmac_sched.cpp index b513b5b..fce3aaf 100644 --- a/src/gprs_rlcmac_sched.cpp +++ b/src/gprs_rlcmac_sched.cpp @@ -132,7 +132,7 @@ /* * Assignments for the same direction have lower precedence, - * because they may kill the TBF when the CONTOL ACK is + * because they may kill the TBF when the CONTROL ACK is * received, thus preventing the others from being processed. */ -- To view, visit https://gerrit.osmocom.org/100 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If37b33f69cd659d913ed81eb6060a42734ba524f Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

9 years, 1 month

[PATCH] osmo-pcu[master]: tbf_dl: replace cross-file deklaration with correct header

by lynxis lazus

Review at https://gerrit.osmocom.org/95 tbf_dl: replace cross-file deklaration with correct header Change-Id: I9b4eb664d444258c9bcf53f9b44552d8dd3155e9 --- M src/tbf_dl.cpp 1 file changed, 1 insertion(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/95/95/1 diff --git a/src/tbf_dl.cpp b/src/tbf_dl.cpp index 62d378f..da6628a 100644 --- a/src/tbf_dl.cpp +++ b/src/tbf_dl.cpp @@ -34,6 +34,7 @@ extern "C" { #include <osmocom/core/msgb.h> #include <osmocom/core/talloc.h> +#include <osmocom/gprs/gprs_bssgp_bss.h> } #include <errno.h> @@ -42,11 +43,6 @@ /* After sending these frames, we poll for ack/nack. */ #define POLL_ACK_AFTER_FRAMES 20 - -extern "C" { -int bssgp_tx_llc_discarded(struct bssgp_bvc_ctx *bctx, uint32_t tlli, - uint8_t num_frames, uint32_t num_octets); -} static inline void tbf_update_ms_class(struct gprs_rlcmac_tbf *tbf, const uint8_t ms_class) -- To view, visit https://gerrit.osmocom.org/95 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9b4eb664d444258c9bcf53f9b44552d8dd3155e9 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

9 years, 1 month

[PATCH] openbsc[master]: drop unneccessary duplicate linking: tests/gsm0408

by Neels Hofmeyr

Review at https://gerrit.osmocom.org/90 drop unneccessary duplicate linking: tests/gsm0408 Change-Id: I8b6fb27d1db0157cb7d61f18b03f33c4f3168946 --- M openbsc/tests/gsm0408/Makefile.am 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/90/90/1 diff --git a/openbsc/tests/gsm0408/Makefile.am b/openbsc/tests/gsm0408/Makefile.am index ee04102..79fb9f1 100644 --- a/openbsc/tests/gsm0408/Makefile.am +++ b/openbsc/tests/gsm0408/Makefile.am @@ -8,6 +8,5 @@ gsm0408_test_LDADD = $(top_builddir)/src/libbsc/libbsc.a \ $(top_builddir)/src/libmsc/libmsc.a \ $(top_builddir)/src/libtrau/libtrau.a \ - $(top_builddir)/src/libbsc/libbsc.a \ $(top_builddir)/src/libcommon/libcommon.a \ $(LIBOSMOCORE_LIBS) $(LIBOSMOGSM_LIBS) $(LIBOSMOABIS_LIBS) -ldbi -- To view, visit https://gerrit.osmocom.org/90 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8b6fb27d1db0157cb7d61f18b03f33c4f3168946 Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>

9 years, 1 month

[PATCH] osmo-pcu[master]: bts/rate_ctr: replace spaces by tabs

by lynxis lazus

Review at https://gerrit.osmocom.org/96 bts/rate_ctr: replace spaces by tabs Use tabs like other counters for seperation. Introduced by 2cb1547 Change-Id: I32eebfe5934c919eccc1e28938ca00c49368297e --- M src/bts.cpp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/96/96/1 diff --git a/src/bts.cpp b/src/bts.cpp index a182317..d1636b6 100644 --- a/src/bts.cpp +++ b/src/bts.cpp @@ -71,7 +71,7 @@ { "rlc.ack.failed", "RLC Ack Failed "}, { "rlc.rel.timedout", "RLC Release Timeout "}, { "rlc.late-block", "RLC Late Block "}, - { "rlc.sent_dummy", "RLC Sent Dummy "}, + { "rlc.sent_dummy", "RLC Sent Dummy "}, { "decode.errors", "Decode Errors "}, { "sba.allocated", "SBA Allocated "}, { "sba.freed", "SBA Freed "}, -- To view, visit https://gerrit.osmocom.org/96 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I32eebfe5934c919eccc1e28938ca00c49368297e Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

9 years, 1 month

[PATCH] osmo-pcu[master]: introduce new counter rlc_sent_dummy

by lynxis lazus

Review at https://gerrit.osmocom.org/85 introduce new counter rlc_sent_dummy rlc_sent_dummy count the amount of dummy package which are sent in case no data packet is in the queue. Change-Id: Ia60eab853d9145980f30d63e4ce4b520b8c51381 --- M src/bts.cpp M src/bts.h M src/gprs_rlcmac_sched.cpp 3 files changed, 9 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/85/85/1 diff --git a/src/bts.cpp b/src/bts.cpp index ccc433b..a8b27bd 100644 --- a/src/bts.cpp +++ b/src/bts.cpp @@ -71,6 +71,7 @@ { "rlc.ack.failed", "RLC Ack Failed" }, { "rlc.rel.timedout", "RLC Release Timeout" }, { "rlc.late-block", "RLC Late Block" }, + { "rlc.sent_dummy", "RLC Send Dummy" }, { "decode.errors", "Decode Errors" }, { "sba.allocated", "SBA Allocated" }, { "sba.freed", "SBA Freed" }, diff --git a/src/bts.h b/src/bts.h index c975304..829e3c2 100644 --- a/src/bts.h +++ b/src/bts.h @@ -233,6 +233,7 @@ CTR_RLC_ACK_FAILED, CTR_RLC_REL_TIMEDOUT, CTR_RLC_LATE_BLOCK, + CTR_RLC_SENT_DUMMY, CTR_DECODE_ERRORS, CTR_SBA_ALLOCATED, CTR_SBA_FREED, @@ -309,6 +310,7 @@ void rlc_ack_failed(); void rlc_rel_timedout(); void rlc_late_block(); + void rlc_sent_dummy(); void decode_error(); void sba_allocated(); void sba_freed(); @@ -449,6 +451,7 @@ CREATE_COUNT_INLINE(rlc_ack_failed, CTR_RLC_ACK_FAILED); CREATE_COUNT_INLINE(rlc_rel_timedout, CTR_RLC_REL_TIMEDOUT); CREATE_COUNT_INLINE(rlc_late_block, CTR_RLC_LATE_BLOCK); +CREATE_COUNT_INLINE(rlc_sent_dummy, CTR_RLC_SENT_DUMMY); CREATE_COUNT_INLINE(decode_error, CTR_DECODE_ERRORS) CREATE_COUNT_INLINE(sba_allocated, CTR_SBA_ALLOCATED) CREATE_COUNT_INLINE(sba_freed, CTR_SBA_FREED) diff --git a/src/gprs_rlcmac_sched.cpp b/src/gprs_rlcmac_sched.cpp index 8e05623..087c03c 100644 --- a/src/gprs_rlcmac_sched.cpp +++ b/src/gprs_rlcmac_sched.cpp @@ -348,8 +348,12 @@ } /* Prio 3: send dummy contol message */ - if (!msg) + if (!msg) { + /* increase counter */ msg = sched_dummy(); + if (msg) + bts->bts->rlc_sent_dummy(); + } if (!msg) return -ENOMEM; -- To view, visit https://gerrit.osmocom.org/85 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia60eab853d9145980f30d63e4ce4b520b8c51381 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

9 years, 1 month

← Newer
1
...
7
8
9
10
11
12
13
...
17
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

OpenBSC May 2016