Review at https://gerrit.osmocom.org/109
debian: Make upgrading from debian SID easier
Make sure the version number of this sourcepackage is higher than
the one found in Debian SID.
Change-Id: I87534954c1f4b499e27452382df412454ea16b64
---
M debian/changelog
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/09/109/1
diff --git a/debian/changelog b/debian/changelog
index 9e5884e..b7a0c97 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+libosmo-sccp (0.7.1) UNRELEASED; urgency=medium
+
+ * Move forward towards a new release.
+
+ -- Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Tue, 24 May 2016 22:57:59 +0200
+
libosmo-sccp (0.7.0) unstable; urgency=medium
* New release.
--
To view, visit https://gerrit.osmocom.org/109
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I87534954c1f4b499e27452382df412454ea16b64
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Holger Freyther <holger(a)freyther.de>
Review at https://gerrit.osmocom.org/91
rtp_proxy.c: Ensure msgb_alloc is large enough for largest AMR frame
In AMR 12.2 (mode 7), the actual RTP payload is 33 bytes. Howeerver,
as we store the length of the (dynamically-sized) AMR payload in the
first byte, our buffer needs at least 33+1 byte in size.
Change-Id: If1ad5d2d68c85733306c75ea62f67fe8fbc143b3
---
M openbsc/src/libtrau/rtp_proxy.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/91/91/1
diff --git a/openbsc/src/libtrau/rtp_proxy.c b/openbsc/src/libtrau/rtp_proxy.c
index 8c982c9..6c04610 100644
--- a/openbsc/src/libtrau/rtp_proxy.c
+++ b/openbsc/src/libtrau/rtp_proxy.c
@@ -172,7 +172,7 @@
/* always allocate for the maximum possible size to avoid
* fragmentation */
new_msg = msgb_alloc(sizeof(struct gsm_data_frame) +
- MAX_RTP_PAYLOAD_LEN, "GSM-DATA (TCH)");
+ MAX_RTP_PAYLOAD_LEN+1, "GSM-DATA (TCH)");
if (!new_msg)
return -ENOMEM;
--
To view, visit https://gerrit.osmocom.org/91
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If1ad5d2d68c85733306c75ea62f67fe8fbc143b3
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge(a)gnumonks.org>
On openbsc master, in do_lchan_free(), a T3111 timer is started in case
the lchan is in an error state. Why?
3GPP TS 04.08:
The sole purpose of timer T3111 is to let some time [pass] to acknowledge
the disconnection and to protect the channel in case of loss of the
acknowledge frame.
I'm asking because for dyn PDCH, I'm looking at jolly's branch, which adds
channel defragmentation: when a channel is released, do_pdch_defrag()
closes gaps in the assignments by swapping active channels into empty
slots. It appears that the defragmentation code doesn't want to wait for
T3111 ... and prefers to run through channel reallocations more quickly,
if that makes any sense?
Also, I'm not sure whether we want the defragmentation feature at this
time. It seems to be orthogonal, not related to dynamic reassignment of
TCH <-> PDCH per se.
Thanks for any opinions or hints!
For details, take a look at a6c1c652e5f9cd7f2e456af39a54b8fafdc5b344
openbsc/src/libbsc/abis_rsl.c:69:do_lchan_free()
(branch users/neels/dyn_pdch)
~Neels
--
- Neels Hofmeyr <nhofmeyr(a)sysmocom.de> http://www.sysmocom.de/
=======================================================================
* sysmocom - systems for mobile communications GmbH
* Alt-Moabit 93
* 10559 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschäftsführer / Managing Directors: Holger Freyther, Harald Welte
> On 04 May 2016, at 14:01, gitosis(a)osmocom.org wrote:
Hi
> msc subscr: add paging timeout
>
> In NITB, the paging timeout would be handled from the BSC side. In IuCS, we
> need to invalidate the paging request from libmsc alone, so add a paging timer
> to gsm_subscriber.
>
> Possibly, the HNB-GW should respond with a paging failure and libmsc could
> trigger on that, nevertheless libmsc should not rely on a failure message to
> expire pending pagings.
I don't think this belongs into the gsm_subscriber. If you compare this with the architectural change that removed the "subscriber queue" we are going to repeat the same mistake again. The timeout belongs into the logical "operation" and not the subscriber (the object of the logical operation).
cheers
holger