[PATCH] osmo-pcu[master]: tbf_dl: replace cross-file deklaration with correct header
Review at https://gerrit.osmocom.org/95 tbf_dl: replace cross-file deklaration with correct header Change-Id: I9b4eb664d444258c9bcf53f9b44552d8dd3155e9 --- M src/tbf_dl.cpp 1 file changed, 1 insertion(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/95/95/1 diff --git a/src/tbf_dl.cpp b/src/tbf_dl.cpp index 62d378f..da6628a 100644 --- a/src/tbf_dl.cpp +++ b/src/tbf_dl.cpp @@ -34,6 +34,7 @@ extern "C" { #include <osmocom/core/msgb.h> #include <osmocom/core/talloc.h> +#include <osmocom/gprs/gprs_bssgp_bss.h> } #include <errno.h> @@ -42,11 +43,6 @@ /* After sending these frames, we poll for ack/nack. */ #define POLL_ACK_AFTER_FRAMES 20 - -extern "C" { -int bssgp_tx_llc_discarded(struct bssgp_bvc_ctx *bctx, uint32_t tlli, - uint8_t num_frames, uint32_t num_octets); -} static inline void tbf_update_ms_class(struct gprs_rlcmac_tbf *tbf, const uint8_t ms_class) -- To view, visit https://gerrit.osmocom.org/95 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9b4eb664d444258c9bcf53f9b44552d8dd3155e9 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: lynxis lazus <lynxis@fe80.eu>
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/95/1//COMMIT_MSG Commit Message: PS1, Line 7: deklaration declaration :) -- To view, visit https://gerrit.osmocom.org/95 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b4eb664d444258c9bcf53f9b44552d8dd3155e9 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Holger Freyther <holger@freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/95 to look at the new patch set (#2). tbf_dl: replace cross-file declaration with correct header Change-Id: I9b4eb664d444258c9bcf53f9b44552d8dd3155e9 --- M src/tbf_dl.cpp 1 file changed, 1 insertion(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/95/95/2 diff --git a/src/tbf_dl.cpp b/src/tbf_dl.cpp index 62d378f..da6628a 100644 --- a/src/tbf_dl.cpp +++ b/src/tbf_dl.cpp @@ -34,6 +34,7 @@ extern "C" { #include <osmocom/core/msgb.h> #include <osmocom/core/talloc.h> +#include <osmocom/gprs/gprs_bssgp_bss.h> } #include <errno.h> @@ -42,11 +43,6 @@ /* After sending these frames, we poll for ack/nack. */ #define POLL_ACK_AFTER_FRAMES 20 - -extern "C" { -int bssgp_tx_llc_discarded(struct bssgp_bvc_ctx *bctx, uint32_t tlli, - uint8_t num_frames, uint32_t num_octets); -} static inline void tbf_update_ms_class(struct gprs_rlcmac_tbf *tbf, const uint8_t ms_class) -- To view, visit https://gerrit.osmocom.org/95 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9b4eb664d444258c9bcf53f9b44552d8dd3155e9 Gerrit-PatchSet: 2 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Holger Freyther <holger@freyther.de> Gerrit-Reviewer: Jenkins Builder
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/95 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b4eb664d444258c9bcf53f9b44552d8dd3155e9 Gerrit-PatchSet: 2 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Holger Freyther <holger@freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: No
Holger Freyther has submitted this change and it was merged. Change subject: tbf_dl: replace cross-file declaration with correct header ...................................................................... tbf_dl: replace cross-file declaration with correct header Change-Id: I9b4eb664d444258c9bcf53f9b44552d8dd3155e9 Reviewed-on: https://gerrit.osmocom.org/95 Tested-by: Jenkins Builder Reviewed-by: Holger Freyther <holger@freyther.de> --- M src/tbf_dl.cpp 1 file changed, 1 insertion(+), 5 deletions(-) Approvals: Jenkins Builder: Verified Holger Freyther: Looks good to me, approved diff --git a/src/tbf_dl.cpp b/src/tbf_dl.cpp index 62d378f..da6628a 100644 --- a/src/tbf_dl.cpp +++ b/src/tbf_dl.cpp @@ -34,6 +34,7 @@ extern "C" { #include <osmocom/core/msgb.h> #include <osmocom/core/talloc.h> +#include <osmocom/gprs/gprs_bssgp_bss.h> } #include <errno.h> @@ -42,11 +43,6 @@ /* After sending these frames, we poll for ack/nack. */ #define POLL_ACK_AFTER_FRAMES 20 - -extern "C" { -int bssgp_tx_llc_discarded(struct bssgp_bvc_ctx *bctx, uint32_t tlli, - uint8_t num_frames, uint32_t num_octets); -} static inline void tbf_update_ms_class(struct gprs_rlcmac_tbf *tbf, const uint8_t ms_class) -- To view, visit https://gerrit.osmocom.org/95 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b4eb664d444258c9bcf53f9b44552d8dd3155e9 Gerrit-PatchSet: 3 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Holger Freyther <holger@freyther.de> Gerrit-Reviewer: Jenkins Builder
participants (2)
-
Holger Freyther -
lynxis lazus