OpenBSC January 2014

openbsc@lists.osmocom.org

33 participants
53 discussions

[PATCH] sms/dtap: Add log messages to analyse SMS message loss
by Jacob Erlbeck 30 Jan '14

30 Jan '14

Incoming DTAP messages from MS are discarded during silent calls, which leads to the repeated delivery of SMS since the ACKs are not being processed. This patch adds some log messages that have been helpful to track this down. Sponsored-by: On-Waves ehf --- openbsc/src/libmsc/gsm_04_08.c | 1 + openbsc/src/libmsc/osmo_msc.c | 4 ++++ openbsc/src/libmsc/silent_call.c | 5 +++++ 3 files changed, 10 insertions(+) diff --git a/openbsc/src/libmsc/gsm_04_08.c b/openbsc/src/libmsc/gsm_04_08.c index bc4a9c3..cd2a0b5 100644 --- a/openbsc/src/libmsc/gsm_04_08.c +++ b/openbsc/src/libmsc/gsm_04_08.c @@ -3303,6 +3303,7 @@ int gsm0408_dispatch(struct gsm_subscriber_connection *conn, struct msgb *msg) uint8_t pdisc = gh->proto_discr & 0x0f; int rc = 0; + LOGP(DRLL, LOGL_DEBUG, "Dispatching 04.08 message, pdisc=%d\n", pdisc); if (silent_call_reroute(conn, msg)) return silent_call_rx(conn, msg); diff --git a/openbsc/src/libmsc/osmo_msc.c b/openbsc/src/libmsc/osmo_msc.c index 31b72b9..f3badb7 100644 --- a/openbsc/src/libmsc/osmo_msc.c +++ b/openbsc/src/libmsc/osmo_msc.c @@ -59,6 +59,8 @@ static int msc_compl_l3(struct gsm_subscriber_connection *conn, struct msgb *msg return BSC_API_CONN_POL_ACCEPT; if (trans_has_conn(conn)) return BSC_API_CONN_POL_ACCEPT; + + LOGP(DRR, LOGL_INFO, "MSC Complete L3: Rejecting connection.\n"); return BSC_API_CONN_POL_REJECT; } @@ -71,11 +73,13 @@ static void msc_assign_compl(struct gsm_subscriber_connection *conn, uint8_t rr_cause, uint8_t chosen_channel, uint8_t encr_alg_id, uint8_t speec) { + LOGP(DRR, LOGL_DEBUG, "MSC assign complete (do nothing).\n"); } static void msc_assign_fail(struct gsm_subscriber_connection *conn, uint8_t cause, uint8_t *rr_cause) { + LOGP(DRR, LOGL_DEBUG, "MSC assign failure (do nothing).\n"); } static void msc_classmark_chg(struct gsm_subscriber_connection *conn, diff --git a/openbsc/src/libmsc/silent_call.c b/openbsc/src/libmsc/silent_call.c index cdc82b5..4462dfc 100644 --- a/openbsc/src/libmsc/silent_call.c +++ b/openbsc/src/libmsc/silent_call.c @@ -76,6 +76,7 @@ static int paging_cb_silent(unsigned int hooknum, unsigned int event, int silent_call_rx(struct gsm_subscriber_connection *conn, struct msgb *msg) { /* FIXME: do something like sending it through a UDP port */ + LOGP(DLSMS, LOGL_NOTICE, "Discarding L3 message from a silent call.\n"); return 0; } @@ -109,6 +110,7 @@ int silent_call_reroute(struct gsm_subscriber_connection *conn, struct msgb *msg } /* otherwise, reroute */ + LOGP(DLSMS, LOGL_INFO, "Rerouting L3 message from a silent call.\n"); return 1; } @@ -136,6 +138,9 @@ int gsm_silent_call_stop(struct gsm_subscriber *subscr) if (!conn->silent_call) return -EINVAL; + DEBUGPC(DLSMS, "Stopping silent call using Timeslot %u on ARFCN %u\n", + conn->lchan->ts->nr, conn->lchan->ts->trx->arfcn); + conn->silent_call = 0; msc_release_connection(conn); -- 1.7.9.5

1 0

Re: RF power problems with current master of osmo-trx
by Tom Tsou 30 Jan '14

30 Jan '14

On Sat, Jan 25, 2014 at 2:57 AM, Andreas Eversberg <andreas(a)eversberg.eu> wrote: > so when i stop sending the bursts, the filler table will continue to > transmit bursts. do i understand it correctly: if i send a single idle burst > (frame??) after sending bursts, the filler table is disabled until new > bursts are sent? Sorry, I misspoke about disabling transmission. The filler table resends the last burst in the multiframe, so the idle burst is usually just a dummy burst, which does not actually stop physical transmission. To fully turn off the downlink signal on a particular slot requires disabling the slot by the channel combination. That said, I agree with Alexander that the retransmission portion of the filler table should be turned off because the behavior is incorrect. With a few exceptions (e.g. FCCH), bursts should *not* be retransmitted at L1 and doing so generates an invalid signal. Note that the filler table cannot be completely disabled because it is part of the real-time loop that drives the device I/O. If the upper layer does not send a burst for a particular slot, or that burst arrives late (stale burst), something still must be transmitted. Currently, in that case, the burst comes from the filler table if the slot is active or zeros if the slot is turned off. Again, I do not think the current implementation is entirely correct, but that depends on expectations of the upper layers. -TT

3 10

SMPP fixes
by Daniel Willmann 28 Jan '14

28 Jan '14

Hello, I have found a couple bugs in the read callback of smpp_smsc.c with regards to guarding against malformed packets. Please see attached patches for fixes. They are also published in openbsc branch daniel/smpp-fixes Regarding the last fix I don't think it is necessary to receive messages up to SSIZE_MAX, but since I don't have/know a value for the maximum sensible size I left it like that for now. Regards, Daniel -- - Daniel Willmann <dwillmann(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Schivelbeiner Str. 5 * 10439 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschaeftsfuehrer / Managing Directors: Holger Freyther, Harald Welte

3 12

[PATCH 1/9] Add function to update TRAU muxer after assignment or handover
by Andreas Eversberg 27 Jan '14

27 Jan '14

From: Andreas Eversberg <andreas(a)eversberg.eu> E1 based BTS use TRAU muxer to decode TRAU frames. After changing channel from one timeslot to another (due to handover or assignment), the TRAU muxer must be updated. The call reference of the call is disconnected from the old channel and connected to the new channel. --- openbsc/include/openbsc/gsm_data.h | 14 ++++++++++++++ openbsc/include/openbsc/trau_mux.h | 3 +++ openbsc/src/libbsc/bsc_api.c | 5 +++++ openbsc/src/libbsc/handover_logic.c | 7 +++++-- openbsc/src/libmsc/gsm_04_08.c | 12 +++++++++--- openbsc/src/libtrau/trau_mux.c | 18 ++++++++++++++++++ 6 files changed, 54 insertions(+), 5 deletions(-) diff --git a/openbsc/include/openbsc/gsm_data.h b/openbsc/include/openbsc/gsm_data.h index 7c3ca84..41fe328 100644 --- a/openbsc/include/openbsc/gsm_data.h +++ b/openbsc/include/openbsc/gsm_data.h @@ -382,6 +382,20 @@ static inline int is_nokia_bts(struct gsm_bts *bts) return 0; } +static inline int is_e1_bts(struct gsm_bts *bts) +{ + switch (bts->type) { + case GSM_BTS_TYPE_BS11: + case GSM_BTS_TYPE_RBS2000: + case GSM_BTS_TYPE_NOKIA_SITE: + return 1; + default: + break; + } + + return 0; +} + enum gsm_auth_policy gsm_auth_policy_parse(const char *arg); const char *gsm_auth_policy_name(enum gsm_auth_policy policy); diff --git a/openbsc/include/openbsc/trau_mux.h b/openbsc/include/openbsc/trau_mux.h index 3de50f7..d211d8d 100644 --- a/openbsc/include/openbsc/trau_mux.h +++ b/openbsc/include/openbsc/trau_mux.h @@ -51,6 +51,9 @@ int trau_recv_lchan(struct gsm_lchan *lchan, uint32_t callref); /* send trau from application */ int trau_send_frame(struct gsm_lchan *lchan, struct gsm_data_frame *frame); +/* switch trau muxer to new lchan */ +int switch_trau_mux(struct gsm_lchan *old_lchan, struct gsm_lchan *new_lchan); + /* callback invoked if we receive TRAU frames */ int subch_cb(struct subch_demux *dmx, int ch, uint8_t *data, int len, void *_priv); diff --git a/openbsc/src/libbsc/bsc_api.c b/openbsc/src/libbsc/bsc_api.c index 86d2493..e567038 100644 --- a/openbsc/src/libbsc/bsc_api.c +++ b/openbsc/src/libbsc/bsc_api.c @@ -31,6 +31,7 @@ #include <openbsc/handover.h> #include <openbsc/debug.h> #include <openbsc/gsm_04_08.h> +#include <openbsc/trau_mux.h> #include <osmocom/gsm/protocol/gsm_08_08.h> @@ -419,6 +420,10 @@ static void handle_ass_compl(struct gsm_subscriber_connection *conn, return; } + /* switch TRAU muxer for E1 based BTS from one channel to another */ + if (is_e1_bts(conn->bts)) + switch_trau_mux(conn->lchan, conn->secondary_lchan); + /* swap channels */ osmo_timer_del(&conn->T10); diff --git a/openbsc/src/libbsc/handover_logic.c b/openbsc/src/libbsc/handover_logic.c index 9cf26af..36a758b 100644 --- a/openbsc/src/libbsc/handover_logic.c +++ b/openbsc/src/libbsc/handover_logic.c @@ -39,6 +39,7 @@ #include <openbsc/signal.h> #include <osmocom/core/talloc.h> #include <openbsc/transaction.h> +#include <openbsc/trau_mux.h> struct bsc_handover { struct llist_head list; @@ -264,6 +265,10 @@ static int ho_gsm48_ho_compl(struct gsm_lchan *new_lchan) osmo_timer_del(&ho->T3103); + /* switch TRAU muxer for E1 based BTS from one channel to another */ + if (is_e1_bts(new_lchan->conn->bts)) + switch_trau_mux(ho->old_lchan, new_lchan); + /* Replace the ho lchan with the primary one */ if (ho->old_lchan != new_lchan->conn->lchan) LOGP(DHO, LOGL_ERROR, "Primary lchan changed during handover.\n"); @@ -278,8 +283,6 @@ static int ho_gsm48_ho_compl(struct gsm_lchan *new_lchan) rsl_lchan_set_state(ho->old_lchan, LCHAN_S_INACTIVE); lchan_release(ho->old_lchan, 0, RSL_REL_LOCAL_END); - /* do something to re-route the actual speech frames ! */ - llist_del(&ho->list); talloc_free(ho); diff --git a/openbsc/src/libmsc/gsm_04_08.c b/openbsc/src/libmsc/gsm_04_08.c index 0c6b100..dbb30ec 100644 --- a/openbsc/src/libmsc/gsm_04_08.c +++ b/openbsc/src/libmsc/gsm_04_08.c @@ -1648,6 +1648,9 @@ static int tch_recv_mncc(struct gsm_network *net, uint32_t callref, int enable) lchan = trans->conn->lchan; bts = lchan->ts->trx->bts; + /* store receive state */ + trans->tch_recv = enable; + switch (bts->type) { case GSM_BTS_TYPE_NANOBTS: case GSM_BTS_TYPE_OSMO_SYSMO: @@ -1655,10 +1658,8 @@ static int tch_recv_mncc(struct gsm_network *net, uint32_t callref, int enable) LOGP(DCC, LOGL_ERROR, "Error: RTP proxy is disabled\n"); return -EINVAL; } - /* in case, we don't have a RTP socket yet, we note this - * in the transaction and try later */ + /* in case, we don't have a RTP socket yet, we try later */ if (!lchan->abis_ip.rtp_socket) { - trans->tch_recv = enable; DEBUGP(DCC, "queue tch_recv_mncc request (%d)\n", enable); return 0; } @@ -1677,6 +1678,11 @@ static int tch_recv_mncc(struct gsm_network *net, uint32_t callref, int enable) case GSM_BTS_TYPE_BS11: case GSM_BTS_TYPE_RBS2000: case GSM_BTS_TYPE_NOKIA_SITE: + /* in case we don't have a TCH with correct mode, we try later */ + if (lchan->tch_mode == GSM48_CMODE_SIGN) { + DEBUGP(DCC, "queue tch_recv_mncc request (%d)\n", enable); + return 0; + } if (enable) return trau_recv_lchan(lchan, callref); return trau_mux_unmap(NULL, callref); diff --git a/openbsc/src/libtrau/trau_mux.c b/openbsc/src/libtrau/trau_mux.c index c9d77cf..7b9bac0 100644 --- a/openbsc/src/libtrau/trau_mux.c +++ b/openbsc/src/libtrau/trau_mux.c @@ -31,6 +31,7 @@ #include <osmocom/core/talloc.h> #include <openbsc/trau_upqueue.h> #include <osmocom/core/crcgen.h> +#include <openbsc/transaction.h> /* this corresponds to the bit-lengths of the individual codec * parameters as indicated in Table 1.1 of TS 06.10 */ @@ -518,3 +519,20 @@ int trau_send_frame(struct gsm_lchan *lchan, struct gsm_data_frame *frame) return subchan_mux_enqueue(mx, dst_e1_ss->e1_ts_ss, trau_bits_out, TRAU_FRAME_BITS); } + +/* switch trau muxer to new lchan */ +int switch_trau_mux(struct gsm_lchan *old_lchan, struct gsm_lchan *new_lchan) +{ + struct gsm_network *net = old_lchan->ts->trx->bts->network; + struct gsm_trans *trans; + + /* look up transaction with TCH frame receive enabled */ + llist_for_each_entry(trans, &net->trans_list, entry) { + if (trans->conn && trans->conn->lchan == old_lchan && trans->tch_recv) { + /* switch */ + trau_recv_lchan(new_lchan, trans->callref); + } + } + + return 0; +} -- 1.8.1.5

6 37

GPRS, EDGE support
by Sipos Csaba 26 Jan '14

26 Jan '14

Hi Guys, I just wanted to ask a few questions about packet data availability/support, because I did not find the specifics on the site. 1. Is there a working GPRS/EDGE implementation in the moment? If not, what is the plan or the state of the development process? 2. Which hardware should I buy, if I want to play with GPRS/EDGE? I am thinking about USRP or BladeRF, but maybe there is a better alternative. I am willing to spend more in order to get a more future proof unit (for example: to have a unit which is capable of doing EDGE if and when it is going to be supported). 3. This is not related to packet data. I wonder if I buy a USRP unit , it is possible to configure and use one USRP device with more than one TRX? In general, I think a lot of people are interested in packet data and OpenBSC/OpenBTS, it would be nice to clarify these informations on the site. BR, Csaba

10 32

Control interface and counters
by Holger Hans Peter Freyther 25 Jan '14

25 Jan '14

Dear Ivan, I noticed that you added a lot of commands to query counters. When we are designing the interface we made sure to add wildcard commands. So most counters can be already read without adding a special command for that. holger

2 2

Re: RF power problems with current master of osmo-trx
by Alexander Chemeris 25 Jan '14

25 Jan '14

Hi Thomas, I'm moving this discussion to the OpenBSC mailing list, as it has nothing to do with UmTRX, but rather with OsmoTRX. On Sat, Jan 25, 2014 at 11:36 AM, Tom Tsou <tom(a)tsou.cc> wrote: > On Sat, Jan 25, 2014 at 1:22 AM, Andreas Eversberg <andreas(a)eversberg.eu> wrote: >> once a channel was activeated, >> there will be RF power on the specific TS, even when osmo-bts does not send >> bursts anymore. i guess that some filler table of osmo-trx causes it. i >> think it would be nice if osmo-trx would stop transmitting, when there are >> no more bursts comming from osmo-bts. (at least after a while.) > > Yes, this is the behaviour of the filler table, which will resend the > previous frame until a new frame arrives. Sending an idle frame will > disable output, which is how the filler table is managed in OpenBTS. > You can disable the filler table with this patch. Could you make this configurable from the command line or from the socket control interface? I believe we should leave filler table as the default option, but allow one to disable it when OsmoTRX is used with OsmoBTS. -- Regards, Alexander Chemeris. CEO, Fairwaves LLC / ООО УмРадио http://fairwaves.ru

3 3

OsmoBTS branch for network_from_scratch.
by Andrew Back 25 Jan '14

25 Jan '14

Hello, When following the network_from_scratch instructions with a Linaro Ubuntu 12.11 host, I encountered a build error when it came to OsmoBTS: linaro-ubuntu-desktop:~/osmocom/osmo-bts> make Making all in include make[1]: Entering directory `/home/linaro/osmocom/osmo-bts/include' Making all in osmo-bts make[2]: Entering directory `/home/linaro/osmocom/osmo-bts/include/osmo-bts' make[2]: Nothing to be done for `all'. make[2]: Leaving directory `/home/linaro/osmocom/osmo-bts/include/osmo-bts' make[2]: Entering directory `/home/linaro/osmocom/osmo-bts/include' make[2]: Nothing to be done for `all-am'. make[2]: Leaving directory `/home/linaro/osmocom/osmo-bts/include' make[1]: Leaving directory `/home/linaro/osmocom/osmo-bts/include' Making all in src make[1]: Entering directory `/home/linaro/osmocom/osmo-bts/src' Making all in common make[2]: Entering directory `/home/linaro/osmocom/osmo-bts/src/common' CC gsm_data_shared.o CC sysinfo.o CC logging.o CC abis.o abis.c: In function ‘abis_sock_cb’: abis.c:360:2: warning: #warning HACK [-Wcpp] CC oml.o oml.c: In function ‘rx_oml_ipa_rsl_connect’: oml.c:1049:17: warning: assignment from incompatible pointer type [enabled by default] oml.c:1053:2: warning: passing argument 1 of ‘abis_open’ from incompatible pointer type [enabled by default] ../../include/osmo-bts/abis.h:35:5: note: expected ‘struct ipabis_link *’ but argument is of type ‘struct e1inp_sign_link *’ CC bts.o CC rsl.o rsl.c:140:2: warning: #warning merge lchan_lookup with OpenBSC [-Wcpp] rsl.c: In function ‘get_rsl_local_ip’: rsl.c:1265:32: error: ‘struct e1inp_sign_link’ has no member named ‘bfd’ rsl.c: In function ‘rsl_rx_ipac_XXcx’: rsl.c:1398:5: warning: initialization from incompatible pointer type [enabled by default] make[2]: *** [rsl.o] Error 1 make[2]: Leaving directory `/home/linaro/osmocom/osmo-bts/src/common' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/linaro/osmocom/osmo-bts/src' make: *** [all-recursive] Error 1 linaro-ubuntu-desktop:~/osmocom/osmo-bts> This was resolved by building from branch jolly/trx_rebased instead of jolly/trx. Should we now be using the rebased branch? If so I will update the wiki. Regards, Andrew -- Andrew Back http://carrierdetect.com

2 1

Re: Re[2]: GPRS, EDGE support
by Don Fanning 24 Jan '14

24 Jan '14

Again, I can't speak to the USRP or BladeRF. OpenBTS is a completely different project with a completely different scope. The projects share very little of a common code base therefore I would consider it incompatible as architecturally they are night and day. OpenBTS is a hack of GSM protocol while OpenBSC is a emulation of the GSM/GPRS mobile network infrastructure. If I had to recommend available compatible hardware, I would suggest community based hardware like Harald's own sysmoBTS or Alexander's UmTRX. On Thu, Jan 23, 2014 at 9:37 AM, Sipos Csaba <dchardware(a)gmail.com> wrote: > Hi Don, > > > Thanks for the answer. > > > THe problem with nanobts that it is unaccessible, and even when it turns > up on ebay, it costs a fortune. > > > I'd rather pay that fortune for an USRP or half that fortune for a > bladerf, and I will have an SDR which I can use not only as a BTS. > > > So, at the moment GPRS/EDGE is only possible with nanoBTS? What about USRP > or BladeRF running OpenBTS? > > > BR, > > Csaba > > > > There has been a working GPRS stack for a while now: > > http://openbsc.osmocom.org/trac/wiki/OpenBSC_GPRS > > > As for USRP or OpenBTS, I cannot comment upon having never used either > platform. >

1 0

[PATCH] lapd/test: Add test case for RSL EST REQ -> LAPD
by Jacob Erlbeck 24 Jan '14

24 Jan '14

This test case processes RSL establish requests for SMS (SAPI 3) on the SDCCH and the SACCH channels. The TX queues are checked after processing each message. Ticket: #225 Sponsored-by: On-Waves ehf --- tests/lapd/lapd_test.c | 120 +++++++++++++++++++++++++++++++++++++++++------ tests/lapd/lapd_test.ok | 7 +++ 2 files changed, 112 insertions(+), 15 deletions(-) diff --git a/tests/lapd/lapd_test.c b/tests/lapd/lapd_test.c index 37c0db8..b4594de 100644 --- a/tests/lapd/lapd_test.c +++ b/tests/lapd/lapd_test.c @@ -80,6 +80,14 @@ static const uint8_t rel_req[] = { 0x02, 0x07, 0x01, 0x0a, 0x02, 0x40, 0x14, 0x01 }; +static const uint8_t est_req_sdcch_sapi3[] = { + 0x02, 0x04, 0x01, 0x20, 0x02, 0x03 +}; + +static const uint8_t est_req_sacch_sapi3[] = { + 0x02, 0x04, 0x01, 0x0b, 0x02, 0x43 +}; + static struct msgb *create_cm_serv_req(void) { struct msgb *msg; @@ -131,6 +139,16 @@ static struct msgb *create_rel_req(void) return msg; } +static struct msgb *create_est_req(const uint8_t *est_req, size_t est_req_size) +{ + struct msgb *msg; + + msg = msgb_from_array(est_req, est_req_size); + msg->l2h = msg->data; + msg->l3h = msg->l2h + sizeof(struct abis_rsl_rll_hdr); + return msg; +} + static int send(struct msgb *in_msg, struct lapdm_channel *chan) { struct osmo_phsap_prim pp; @@ -350,6 +368,52 @@ static void test_lapdm_polling() lapdm_channel_exit(&ms_to_bts_channel); } +static void test_lapdm_contention_resolution() +{ + printf("I test contention resultion by having two mobiles collide and " + "first mobile repeating SABM.\n"); + + int rc; + struct lapdm_polling_state test_state; + struct osmo_phsap_prim pp; + + /* Configure LAPDm on both sides */ + struct lapdm_channel bts_to_ms_channel; + memset(&bts_to_ms_channel, 0, sizeof(bts_to_ms_channel)); + + memset(&test_state, 0, sizeof(test_state)); + test_state.bts = &bts_to_ms_channel; + + /* BTS to MS in polling mode */ + lapdm_channel_init(&bts_to_ms_channel, LAPDM_MODE_BTS); + lapdm_channel_set_flags(&bts_to_ms_channel, LAPDM_ENT_F_POLLING_ONLY); + lapdm_channel_set_l1(&bts_to_ms_channel, NULL, &test_state); + lapdm_channel_set_l3(&bts_to_ms_channel, bts_to_ms_tx_cb, &test_state); + + /* Send SABM MS 1, we must get UA */ + send_sabm(&bts_to_ms_channel, 0); + rc = lapdm_phsap_dequeue_prim(&bts_to_ms_channel.lapdm_dcch, &pp); + CHECK_RC(rc); + OSMO_ASSERT(memcmp(pp.oph.msg->l2h, ua, ARRAY_SIZE(ua)) == 0); + + /* Send SABM MS 2, we must get nothing, due to collision */ + send_sabm(&bts_to_ms_channel, 1); + rc = lapdm_phsap_dequeue_prim(&bts_to_ms_channel.lapdm_dcch, &pp); + OSMO_ASSERT(rc == -ENODEV); + + /* Send SABM MS 1 again, we must get UA gain */ + send_sabm(&bts_to_ms_channel, 0); + rc = lapdm_phsap_dequeue_prim(&bts_to_ms_channel.lapdm_dcch, &pp); + CHECK_RC(rc); + OSMO_ASSERT(memcmp(pp.oph.msg->l2h, ua, ARRAY_SIZE(ua)) == 0); + + /* clean up */ + lapdm_channel_exit(&bts_to_ms_channel); + + /* idempotent */ + lapdm_channel_exit(&bts_to_ms_channel); +} + static void test_lapdm_early_release() { printf("I test RF channel release of an unestablished channel.\n"); @@ -381,14 +445,13 @@ static void test_lapdm_early_release() lapdm_channel_exit(&bts_to_ms_channel); } -static void test_lapdm_contention_resolution() +static void lapdm_establish(const uint8_t *est_req, size_t est_req_size) { - printf("I test contention resultion by having two mobiles collide and " - "first mobile repeating SABM.\n"); - int rc; struct lapdm_polling_state test_state; struct osmo_phsap_prim pp; + struct msgb *msg; + const char *queue_name; /* Configure LAPDm on both sides */ struct lapdm_channel bts_to_ms_channel; @@ -403,22 +466,39 @@ static void test_lapdm_contention_resolution() lapdm_channel_set_l1(&bts_to_ms_channel, NULL, &test_state); lapdm_channel_set_l3(&bts_to_ms_channel, bts_to_ms_tx_cb, &test_state); - /* Send SABM MS 1, we must get UA */ - send_sabm(&bts_to_ms_channel, 0); + /* Send the release request */ + msg = create_est_req(est_req, est_req_size); + rc = lapdm_rslms_recvmsg(msg, &bts_to_ms_channel); + fprintf(stderr, "recvmsg: got rc %d: %s\n", rc, rc <= 0 ? strerror(-rc) : "???"); + OSMO_ASSERT(rc == 0); + + /* Take message from queue */ rc = lapdm_phsap_dequeue_prim(&bts_to_ms_channel.lapdm_dcch, &pp); + if (rc >= 0) + queue_name = "DCCH"; + else { + rc = lapdm_phsap_dequeue_prim(&bts_to_ms_channel.lapdm_acch, &pp); + if (rc >= 0) + queue_name = "ACCH"; + } + + fprintf(stderr, "dequeue: got rc %d: %s\n", rc, + rc <= 0 ? strerror(-rc) : "-"); CHECK_RC(rc); - OSMO_ASSERT(memcmp(pp.oph.msg->l2h, ua, ARRAY_SIZE(ua)) == 0); - /* Send SABM MS 2, we must get nothing, due to collision */ - send_sabm(&bts_to_ms_channel, 1); - rc = lapdm_phsap_dequeue_prim(&bts_to_ms_channel.lapdm_dcch, &pp); - OSMO_ASSERT(rc == -ENODEV); + printf("Took message from %s queue: L2 header size %d, " + "SAP %#x, %d/%d, Link 0x%02x\n", + queue_name, msgb_l2len(pp.oph.msg) - msgb_l3len(pp.oph.msg), + pp.oph.sap, pp.oph.primitive, pp.oph.operation, + pp.u.data.link_id); + printf("Message: %s\n", osmo_hexdump(pp.oph.msg->data, pp.oph.msg->len)); + + OSMO_ASSERT(pp.oph.msg->data == msgb_l2(pp.oph.msg)); - /* Send SABM MS 1 again, we must get UA gain */ - send_sabm(&bts_to_ms_channel, 0); rc = lapdm_phsap_dequeue_prim(&bts_to_ms_channel.lapdm_dcch, &pp); - CHECK_RC(rc); - OSMO_ASSERT(memcmp(pp.oph.msg->l2h, ua, ARRAY_SIZE(ua)) == 0); + OSMO_ASSERT(rc < 0); + rc = lapdm_phsap_dequeue_prim(&bts_to_ms_channel.lapdm_acch, &pp); + OSMO_ASSERT(rc < 0); /* clean up */ lapdm_channel_exit(&bts_to_ms_channel); @@ -427,6 +507,15 @@ static void test_lapdm_contention_resolution() lapdm_channel_exit(&bts_to_ms_channel); } +static void test_lapdm_establishment() +{ + printf("I test RF channel establishment.\n"); + printf("Testing SAPI3/SDCCH\n"); + lapdm_establish(est_req_sdcch_sapi3, sizeof(est_req_sdcch_sapi3)); + printf("Testing SAPI3/SACCH\n"); + lapdm_establish(est_req_sacch_sapi3, sizeof(est_req_sacch_sapi3)); +} + int main(int argc, char **argv) { osmo_init_logging(&info); @@ -434,6 +523,7 @@ int main(int argc, char **argv) test_lapdm_polling(); test_lapdm_early_release(); test_lapdm_contention_resolution(); + test_lapdm_establishment(); printf("Success.\n"); return 0; diff --git a/tests/lapd/lapd_test.ok b/tests/lapd/lapd_test.ok index 27389bf..e4b1359 100644 --- a/tests/lapd/lapd_test.ok +++ b/tests/lapd/lapd_test.ok @@ -21,4 +21,11 @@ I test RF channel release of an unestablished channel. I test contention resultion by having two mobiles collide and first mobile repeating SABM. bts_to_ms_tx_cb: MS->BTS(us) message 25 BTS: Verifying CM request. +I test RF channel establishment. +Testing SAPI3/SDCCH +Took message from DCCH queue: L2 header size 3, SAP 0x1000000, 0/0, Link 0x03 +Message: 0f 3f 01 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b +Testing SAPI3/SACCH +Took message from ACCH queue: L2 header size 5, SAP 0x1000000, 0/0, Link 0x43 +Message: 00 00 0f 3f 01 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b Success. -- 1.7.9.5

1 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

OpenBSC January 2014