Hi Harald, On Sun, Sep 6, 2015 at 8:09 AM, Harald Welte <laforge(a)gnumonks.org> wrote: That's incredible. Thank you for making this final step. I'd appreciate recommendations on how to do this differently. IIRC the code frees messages after the function and the queue was pointing to a freed message. this led to undefined behavior. There is a companion patch to this to manually activate/deactivate a channel. I'd appreciate recommendations on how to properly implement it as well. Loopback and channel activation functions are very helpful for the L0/L1 development. We're little busy this week, so assume we're ok by default. If we find time for testing and find something - we'll let you know. Worst case we'll fix TRX support after it's merged. Could you share what kind of testing has been performed, so we can shape our expectations? Indeed. I can promise to look into this, but it'll be a long time before I can do that. If there is any interest in doing this before then - don't hold your breath. Totally agree. -- Regards, Alexander Chemeris. CEO, Fairwaves, Inc. https://fairwaves.co

I think the AMR part could be generalized as well? I am currently adding the configuration for MR to OpenBSC. I wonder if there is value in being able to separate the thresholds for the BTS and the MS?

Dear Harald, Your work is much apreciated, there are a lot of important features in these branches not yet merged to the master. I will test it on a B200 with a strong focus on PS domain (probably next week because I am quite busy at the moment). The new Wiki article about how to operate the B200/B210 with the Osmocom projects is also in the pipe :-) Regards, Csaba ----- Eredeti üzenet ----- Feladó: "Harald Welte" <laforge(a)gnumonks.org> Címzett: openbsc(a)lists.osmocom.org Elküldött üzenetek: Vasárnap, 2015. Szeptember 6. 15:09:09 Tárgy: L1SAP and TRX rebase, the last one (TM) Dear all, after my futile attempt in September last year to finally merge l1sap (see the 201409-l1sap branch), I'm making one final attempt. The following branches have been created + pushed: * 201509-l1sap: The core l1sap change that I intend to merge This is most of the heavy lifting by introducing L1SAP between the sysmobts l1 and the common code. Hasn't been modified much. * 201509-trx-rebase: osmo-bts-trx support that I intend to merge This is what I can merge without too much review, as it does not touch the common code, except some minor l1sap fixes, and * the AMR multirate change, requiring a matching patch on openbsc.git * bts_model_abis_close() which should be fine * ability to configue multiple TRX from VTY * 201509-fairwaves-rebase Stuff I cannot merge in its current form * the abis/e1inp multi-trx and reconnect changes require in-depth review and testing. Part of it is marked as HACK even by Andreas. * a so-called 'fix for use after free' that is actually a patch that introduces another copy for every primitive and is only required for the loopback mode * copying gsm_data_common.[ch] into the repo for debian packaging [let's not discuss further work on this before l1sap and trx-rebase are merged] I recommend everyone with a stake in this to review or test the code in 201509-l1sap and 201509-trx-rebase now. My schedule is to merge at some point next week, unless someone raises some serious objections. What needs to be done after the merge is to unify the src/common/power_control.c code from Holger originating in master with src/common/loops.c from Andreas originating from the osmo-trx branch. There is no doubt that the power control and timing advance loops should be part of common, as this is required in virtually any BTS hardware. However, we can safely merge/unify this after the merging of the above branches. Regards, Harald -- - Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)