Hi stsp,
I noticed in the recent gsm0808_cell_id_list2 a review item slipped by: A "LAI" is by definition a PLMN (MCC+MNC) plus a LAC. So saying "LAI and LAC" is like saying "My family and my brother".
So maybe we want to rename the "lai_and_lac" member of struct gsm0808_cell_id_list2 before it gets tagged for release. Just "lai" would be accurate, as its type (struct osmo_location_area_id) suggests.
~N
I noticed that the CELL_IDENT enum has a similar quirk: CELL_IDENT_LAI_AND_LAC so it probably came from that.
I think we should rename it and have a backwards compat: #define CELL_IDENT_LAI_AND_LAC CELL_IDENT_LAI
~N
On Thu, Mar 22, 2018 at 12:43:35AM +0100, Neels Hofmeyr wrote:
Hi stsp,
I noticed in the recent gsm0808_cell_id_list2 a review item slipped by: A "LAI" is by definition a PLMN (MCC+MNC) plus a LAC. So saying "LAI and LAC" is like saying "My family and my brother".
So maybe we want to rename the "lai_and_lac" member of struct gsm0808_cell_id_list2 before it gets tagged for release. Just "lai" would be accurate, as its type (struct osmo_location_area_id) suggests.
~N
On Fri, Mar 23, 2018 at 04:33:39PM +0100, Neels Hofmeyr wrote:
I noticed that the CELL_IDENT enum has a similar quirk: CELL_IDENT_LAI_AND_LAC so it probably came from that.
Yes, this is where it came from.
I think we should rename it and have a backwards compat: #define CELL_IDENT_LAI_AND_LAC CELL_IDENT_LAI
The standard from 1999 (TS 08.08 section 3.2.2.27 "Cell Identifier list") calls it just "LAI":
"Location Area Identification, LAI, is used to identify all cells within a Location Area"
So I would agree with your proposal.