22 Oct
2017
22 Oct
'17
9:34 p.m.
This patch was merged, but I frankly don't like what it does.
Building in a separate dir is fine, but it does so with a bunch of changes
along that introduce indenting errors and potentially destroy the scripts'
certainty of building cleanly every time.
Please still reply to my comments at
https://gerrit.osmocom.org/#/c/3132/
...maybe actually here on the ML instead of on gerrit?
Thanks!
~N
23 Oct
23 Oct
11:57 a.m.
New subject: [MERGED] libosmocore[master]: Cleanup jenkins build scripts
Hi Neels,
On Sun, Oct 22, 2017 at 09:34:07PM +0200, Neels Hofmeyr wrote:
This patch was merged, but I frankly don't like
what it does.
Building in a separate dir is fine, but it does so with a bunch of changes
along that introduce indenting errors and potentially destroy the scripts'
certainty of building cleanly every time.
I though there was two subsequent runs of "autoreconf -fi", one for building
in-source
and one for building out-of-source, and the rm-rf is the cause of it. Maybe I have
misunderstood what the original code was intending to do. In any case, an out-of-source
build "autoreconf -fi" will not have different results from one for in-source,
which is why I thought the patch is a good idea.
A common scripts for three lines seems rather odd to me, too - but then,
I don't really care all too much.
I'm not opposed to reverting it. Your call.
--
- Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)
2808
days inactive
2809
days old
1 comments
2 participants
participants (2)
-
Harald Welte -
Neels Hofmeyr