I am a bit ambiguous on our use of comments in gerrit.
We do discuss at least some fairly interesting things in the comments on patches waiting for approval in gerrit.
When these discussions are attempted on openbsc@ or osmocom-net-gprs@, you tend to block off and redirect the discussion back to the gerrit comments infrastructure.
However, we have moved the gerrit mails to a separate and very noisy mailing list, and these potentially interesting discussions are moved essentially out of the public focus.
Also, if we in future would like to investigate discussion on some topic, we need to search both the main ML and the gerrit ML.
IMHO it would make sense to copy the human originated comments to our "human" mailing lists, so that the automatic jenkins and gerrit notifications remain on the noisy ML while we see all discussions here.
Is that easy to achieve (filter on originator of comment), and would you guys agree?
~Neels
I think such comments usually require context in a form of patch diff so interested person got to go to gerrit anyway so there's not much sense in duplicating them into ML.
On 06/21/2016 01:24 PM, Neels Hofmeyr wrote:
I am a bit ambiguous on our use of comments in gerrit.
We do discuss at least some fairly interesting things in the comments on patches waiting for approval in gerrit.
When these discussions are attempted on openbsc@ or osmocom-net-gprs@, you tend to block off and redirect the discussion back to the gerrit comments infrastructure.
However, we have moved the gerrit mails to a separate and very noisy mailing list, and these potentially interesting discussions are moved essentially out of the public focus.
Also, if we in future would like to investigate discussion on some topic, we need to search both the main ML and the gerrit ML.
IMHO it would make sense to copy the human originated comments to our "human" mailing lists, so that the automatic jenkins and gerrit notifications remain on the noisy ML while we see all discussions here.
Is that easy to achieve (filter on originator of comment), and would you guys agree?
~Neels
On Tue, Jun 21, 2016 at 01:28:31PM +0200, Max wrote:
I think such comments usually require context in a form of patch diff so interested person got to go to gerrit anyway so there's not much sense in duplicating them into ML.
For example the last couple comments on https://gerrit.osmocom.org/331 would be interesting for people not reading the gerrit ML, and each mail has a link to the related patch?
Admittedly, the numerous short voting comments on the patches leading up to https://gerrit.osmocom.org/255 would certainly constitute noise.
I still think it's suboptimal to drift into discussions off of the ML...
~Neels