Review at https://gerrit.osmocom.org/101
Fix copy-paste error in SI6
Fix error which prevented enabling DTX for half-rate channels.
Change-Id: I7d41df0068783c8fb33ddeeab1d1dcf63c2c259f --- M openbsc/src/libbsc/system_information.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/01/101/1
diff --git a/openbsc/src/libbsc/system_information.c b/openbsc/src/libbsc/system_information.c index 1f1d81e..bf20394 100644 --- a/openbsc/src/libbsc/system_information.c +++ b/openbsc/src/libbsc/system_information.c @@ -932,7 +932,7 @@ si6->cell_options = bts->si_common.cell_options; si6->ncc_permitted = bts->si_common.ncc_permitted; /* allow/disallow DTXu */ - gsm48_set_dtx(&si6->cell_options, bts->dtxu, bts->dtxu, true); + gsm48_set_dtx(&si6->cell_options, bts->dtxu, bts->dtxu, false);
/* SI6 Rest Octets: 10.5.2.35a: PCH / NCH info, VBS/VGCS options */
Patch Set 1: Code-Review+2
(1 comment)
https://gerrit.osmocom.org/#/c/101/1/openbsc/src/libbsc/system_information.c File openbsc/src/libbsc/system_information.c:
Line 935: gsm48_set_dtx(&si6->cell_options, bts->dtxu, bts->dtxu, false); Okay. so we are not on BCCH so it needs to be false here. But what do you think of using an enum value in the long run here?
Holger Freyther has submitted this change and it was merged.
Change subject: Fix copy-paste error in SI6 ......................................................................
Fix copy-paste error in SI6
Fix error which prevented enabling DTX for half-rate channels.
Change-Id: I7d41df0068783c8fb33ddeeab1d1dcf63c2c259f Reviewed-on: https://gerrit.osmocom.org/101 Tested-by: Jenkins Builder Reviewed-by: Holger Freyther holger@freyther.de --- M openbsc/src/libbsc/system_information.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Jenkins Builder: Verified Holger Freyther: Looks good to me, approved
diff --git a/openbsc/src/libbsc/system_information.c b/openbsc/src/libbsc/system_information.c index 1f1d81e..bf20394 100644 --- a/openbsc/src/libbsc/system_information.c +++ b/openbsc/src/libbsc/system_information.c @@ -932,7 +932,7 @@ si6->cell_options = bts->si_common.cell_options; si6->ncc_permitted = bts->si_common.ncc_permitted; /* allow/disallow DTXu */ - gsm48_set_dtx(&si6->cell_options, bts->dtxu, bts->dtxu, true); + gsm48_set_dtx(&si6->cell_options, bts->dtxu, bts->dtxu, false);
/* SI6 Rest Octets: 10.5.2.35a: PCH / NCH info, VBS/VGCS options */
-
Holger Freyther -
Max