Dear Holger, Yes , I found two 1 location update reject and one location update accept .is this abis oml ? Thanks, Omar
------Original Message------ From: Holger Hans Peter Freyther Sender: openbsc-bounces@lists.gnumonks.org To: openbsc@lists.gnumonks.org Subject: Re: Adding patches to wireshark... Sent: Jan 11, 2011 11:37 PM
On 01/11/2011 09:08 PM, Omar Atia wrote:
Thanks It is clear for me !! just send me 1 pcap file to open it with the patched wireshark
Hmm, who do you address with this request? Have you attempted to search for 'pcap' in the OpenBSC wiki?
Sent via BlackBerry® from mtc touch
On 01/11/2011 09:45 PM, omar.atia@its.ws wrote:
Dear Holger, Yes , I found two 1 location update reject and one location update accept .is this abis oml ? Thanks, Omar
well,
same thing again. You should write what you have tried to answer this question your self. Wireshark supports filters, you can filter for a given protocol... this way it is super easy to figure out if you have any OML messages in the trace...
Dear Holger,,
Sorry for bothering you a lot . OML doesn't appear in the filter means failed to patch , let me again repeat everything with autoconf -i.
Thanks, Omar Atia
-----Original Message----- From: openbsc-bounces@lists.gnumonks.org [mailto:openbsc-bounces@lists.gnumonks.org] On Behalf Of Holger Hans Peter Freyther Sent: Tuesday, January 11, 2011 11:13 PM To: openbsc@lists.gnumonks.org Subject: Re: Adding patches to wireshark...
On 01/11/2011 09:45 PM, omar.atia@its.ws wrote:
Dear Holger, Yes , I found two 1 location update reject and one location update accept
.is this abis oml ?
Thanks, Omar
well,
same thing again. You should write what you have tried to answer this question your self. Wireshark supports filters, you can filter for a given protocol... this way it is super easy to figure out if you have any OML messages in the trace...
On 01/12/2011 08:45 AM, Omar Atia wrote:
Dear Holger,,
Sorry for bothering you a lot . OML doesn't appear in the filter means failed to patch , let me again repeat everything with autoconf -i.
Hi Omar,
well. the only problem is you are not showing the self motivation required to participate in a Free Software Project. I joined Free Software Projects to learn, and one simply does not learn by just asking for the solution, one needs to try stuff.
So again. Which combination of OML did you try in the filter bar? You can also get all the protocols listed by wireshark and search there. Also look at the file name of the abis oml dissector and try this.
holger
Dear Holger,,, I wrote OML in the filter bar ,,,response was it is neither a field or protocol name ...(is there any other syntax for protocol name for a-bis-oml). Just write down protocol name in the filter bar . Thanks, Omar Atia
-----Original Message----- From: openbsc-bounces@lists.gnumonks.org [mailto:openbsc-bounces@lists.gnumonks.org] On Behalf Of Holger Hans Peter Freyther Sent: Wednesday, January 12, 2011 9:56 AM To: Omar Atia Cc: openbsc@lists.gnumonks.org Subject: Re: Adding patches to wireshark...
On 01/12/2011 08:45 AM, Omar Atia wrote:
Dear Holger,,
Sorry for bothering you a lot . OML doesn't appear in the filter means failed to patch , let me again
repeat
everything with autoconf -i.
Hi Omar,
well. the only problem is you are not showing the self motivation required to participate in a Free Software Project. I joined Free Software Projects to learn, and one simply does not learn by just asking for the solution, one needs to try stuff.
So again. Which combination of OML did you try in the filter bar? You can also get all the protocols listed by wireshark and search there. Also look at the file name of the abis oml dissector and try this.
holger
On 01/12/2011 10:59 AM, Omar Atia wrote:
Dear Holger,,, I wrote OML in the filter bar ,,,response was it is neither a field or protocol name ...(is there any other syntax for protocol name for a-bis-oml). Just write down protocol name in the filter bar .
Hi Omar,
here are the options to figure out the name of the protocol for wireshark
1.) Edit -> Preferences -> Protocols and search for something that contains OML, Abis, A-bis in the name. (Actually it is A-bis OML and sorts at the top).
2.) You can look at the dissector sourcecode and search for 'register_dissector'. It normally comes at the bottom of the dissector sourcecode. The string is the dissector name.
3.) the convention of epan appears to be packet-FOO.c where FOO is the protocol name. In your case this would be 'gsm_abis_oml'. Wireshark has nice completion in the filter bar. By just typing 'g' for GSM it will show you all GSM protocols it knows, it should list gsm_abis_oml.
Dear Holger,
While compiling wireshark ,after patching 'gsm_abis_oml' I got the following :
gcc -DHAVE_CONFIG_H -I. -I../.. -I./../.. -I./.. -I/usr/local/include -DPLUGIN_DIR="/usr/local/lib/wireshark/plugins/1.5.0" -Werror -DINET6 "-D_U_=__attribute__((unused))" -g -O2 -Wall -W -Wextra -Wdeclaration-after-statement -Wendif-labels -Wpointer-arith -Wno-pointer-sign -Warray-bounds -Wcast-align -Wformat-security -I/usr/local/include -D_REENTRANT -pthread -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/freetype2 -I/usr/include/directfb -I/usr/include/libpng12 -I/usr/include/pixman-1 -MT libdissectors_la-packet-gsm_abis_oml.lo -MD -MP -MF .deps/libdissectors_la-packet-gsm_abis_oml.Tpo -c packet-gsm_abis_oml.c -fPIC -DPIC -o .libs/libdissectors_la-packet-gsm_abis_oml.o cc1: warnings being treated as errors packet-gsm_abis_oml.c: In function 'proto_register_abis_oml': packet-gsm_abis_oml.c:1555: error: assignment from incompatible pointer type packet-gsm_abis_oml.c:1556: error: assignment from incompatible pointer type make[5]: *** [libdissectors_la-packet-gsm_abis_oml.lo] Error 1
inside the patched file it contains an error , can u advise how to fix it ?
I'm moving into the right path now ...
Thanks, Omar Atia
-----Original Message----- From: openbsc-bounces@lists.gnumonks.org [mailto:openbsc-bounces@lists.gnumonks.org] On Behalf Of Holger Hans Peter Freyther Sent: Wednesday, January 12, 2011 12:16 PM To: openbsc@lists.gnumonks.org Subject: Re: Adding patches to wireshark...
On 01/12/2011 10:59 AM, Omar Atia wrote:
Dear Holger,,, I wrote OML in the filter bar ,,,response was it is neither a field or protocol name ...(is there any other syntax for protocol name for a-bis-oml). Just write down protocol name in the filter bar .
Hi Omar,
here are the options to figure out the name of the protocol for wireshark
1.) Edit -> Preferences -> Protocols and search for something that contains OML, Abis, A-bis in the name. (Actually it is A-bis OML and sorts at the top).
2.) You can look at the dissector sourcecode and search for 'register_dissector'. It normally comes at the bottom of the dissector sourcecode. The string is the dissector name.
3.) the convention of epan appears to be packet-FOO.c where FOO is the protocol name. In your case this would be 'gsm_abis_oml'. Wireshark has nice completion in the filter bar. By just typing 'g' for GSM it will show you all GSM protocols it knows, it should list gsm_abis_oml.
You mean this one
1.1.6 Compiler warnings
You should write code that is free of compiler warnings. Such warnings will often indicate questionable code and sometimes even real bugs, so it's best to avoid warnings at all.
The compiler flags in the Makefiles are set to "treat warnings as errors", so your code won't even compile when warnings occur.
Warnings are treated as error ...
-----Original Message----- From: openbsc-bounces@lists.gnumonks.org [mailto:openbsc-bounces@lists.gnumonks.org] On Behalf Of Holger Hans Peter Freyther Sent: Wednesday, January 12, 2011 5:17 PM To: Omar Atia Cc: openbsc@lists.gnumonks.org Subject: Re: Adding patches to wireshark...
On 01/12/2011 04:11 PM, Omar Atia wrote:
Dear Holger,
inside the patched file it contains an error , can u advise how to fix it
?
I'm moving into the right path now ...
You have not read the README.
The wireshark patch from the directory that is downloaded when using git openbsc.git
The wireshark sources from
svn checkout http://anonsvn.wireshark.org/wireshark/trunk wireshark
any way the error has disappeared when I removed -Werror (treat warnings as error ) from makefile but it still compiling the rest .
-----Original Message----- From: openbsc-bounces@lists.gnumonks.org [mailto:openbsc-bounces@lists.gnumonks.org] On Behalf Of Holger Hans Peter Freyther Sent: Wednesday, January 12, 2011 5:35 PM To: openbsc@lists.gnumonks.org Subject: Re: Adding patches to wireshark...
On 01/12/2011 04:28 PM, Omar Atia wrote:
You mean this one
no. from where you got the patch...
On 01/12/2011 04:48 PM, Omar Atia wrote:
The wireshark patch from the directory that is downloaded when using git openbsc.git
The wireshark sources from
svn checkout http://anonsvn.wireshark.org/wireshark/trunk wireshark
any way the error has disappeared when I removed -Werror (treat warnings as error ) from makefile but it still compiling the rest.
... openbsc/wirehsark/README... it is not that difficult.. removing -Werror is not a very bright idea as well. The signature of the value_match callback has changed... the patches are already updated, the README indicates the SVN version of wireshark to be used...
Dear Holger,
1st there is no readme under wireshark directory , you can browse the source online .
http://openbsc.osmocom.org/trac/browser/wireshark
Please find as well snap shot for OML abis protocol working on wireshark I have compiled.
Let me check the path I'm downloading sources from it using git . I'm running from the new git repositories
Thanks, Omar Atia
-----Original Message----- From: openbsc-bounces@lists.gnumonks.org [mailto:openbsc-bounces@lists.gnumonks.org] On Behalf Of Holger Hans Peter Freyther Sent: Wednesday, January 12, 2011 5:56 PM To: openbsc@lists.gnumonks.org Subject: Re: Adding patches to wireshark...
On 01/12/2011 04:48 PM, Omar Atia wrote:
The wireshark patch from the directory that is downloaded when using git openbsc.git
The wireshark sources from
svn checkout http://anonsvn.wireshark.org/wireshark/trunk wireshark
any way the error has disappeared when I removed -Werror (treat warnings
as
error ) from makefile but it still compiling the rest.
... openbsc/wirehsark/README... it is not that difficult.. removing -Werror is not a very bright idea as well. The signature of the value_match callback has changed... the patches are already updated, the README indicates the SVN version of wireshark to be used...
On 01/12/2011 05:36 PM, Omar Atia wrote:
Dear Holger,
1st there is no readme under wireshark directory , you can browse the source online .
Hi,
this seems to be an issue due us migrating the git repository from one server to another. I have poked harald and he will update the repo url on the server or such. Thanks for reporting it. If you browse through git.osmocom.org you will see the README.
Please find as well snap shot for OML abis protocol working on wireshark I have compiled.
congrats.
Thanks Holger for updating wireshark patches and added README file , I have patched sources with all patches provided , and all protocols come on wireshark filter when reading README file it is a simple as that .
Thanks again ...
-----Original Message----- From: openbsc-bounces@lists.gnumonks.org [mailto:openbsc-bounces@lists.gnumonks.org] On Behalf Of Holger Hans Peter Freyther Sent: Wednesday, January 12, 2011 6:45 PM To: Omar Atia Cc: openbsc@lists.gnumonks.org Subject: Re: Adding patches to wireshark...
On 01/12/2011 05:36 PM, Omar Atia wrote:
Dear Holger,
1st there is no readme under wireshark directory , you can browse the
source
online .
Hi,
this seems to be an issue due us migrating the git repository from one server to another. I have poked harald and he will update the repo url on the server or such. Thanks for reporting it. If you browse through git.osmocom.org you will see the README.
Please find as well snap shot for OML abis protocol working on wireshark I have compiled.
congrats.
-
Holger Hans Peter Freyther -
Omar Atia -
omar.atia＠its.ws