Hi Harlad,
does this make sense to you?
openbsc/src/abis_nm.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/openbsc/src/abis_nm.c b/openbsc/src/abis_nm.c index bb7248b..dce1c35 100644 --- a/openbsc/src/abis_nm.c +++ b/openbsc/src/abis_nm.c @@ -653,13 +653,13 @@ objclass2nmstate(struct gsm_bts *bts, u_int8_t obj_class, nm_state = &bts->bs11.cclk.nm_state; break; case BS11_OBJ_BBSIG: - if (obj_inst->ts_nr > bts->num_trx) + if (obj_inst->trx_nr >= bts->num_trx) return NULL; trx = gsm_bts_trx_num(bts, obj_inst->trx_nr); nm_state = &trx->bs11.bbsig.nm_state; break; case BS11_OBJ_PA: - if (obj_inst->ts_nr > bts->num_trx) + if (obj_inst->trx_nr >= bts->num_trx) return NULL; trx = gsm_bts_trx_num(bts, obj_inst->trx_nr); nm_state = &trx->bs11.pa.nm_state;
On Mon, Dec 21, 2009 at 05:10:30PM +0100, Holger Freyther wrote:
Hi Harlad,
does this make sense to you?
not sure. The Siemens vendor specific attributes don't really follow the standard 12.21 conventions and somethimes seem to use arbitrary object intance fields for whatever they seem fit. I think this needs careful analysis of actual protocol traces before any modifiations.
On Monday 21 December 2009 22:13:30 Harald Welte wrote:
On Mon, Dec 21, 2009 at 05:10:30PM +0100, Holger Freyther wrote:
Hi Harlad,
does this make sense to you?
not sure. The Siemens vendor specific attributes don't really follow the standard 12.21 conventions and somethimes seem to use arbitrary object intance fields for whatever they seem fit. I think this needs careful analysis of actual protocol traces before any modifiations.
I agree but the usage is not consistent. It is using ts_nr to compare to max_trx and then uses trx_nr to access things. But we share the same thought that this needs careful consideration and testing.
z.