Hi!
As some other developers are starting to work with (and on) the test suites in the osmo-ttcn3-hacks repository, I migrated it to gerrit today for future code / patch reviews. I also worked on building the codebase without having to rely on some out-of-tree clones of upstream titan repositories. Rather, the makefiles now ensure that all dependencies are cloned + linked from within the osmo-ttcn3-hacks repository.
I also added jenkins build testing, i.e. we will not get any future patches into the repository which would break TTCN-3 compiletion. So far, it validates only on Debian9 with TITAN 6.1.0. As I've already seen a lot of code that compiles on 9.3.0 (my developent system) but not on 6.1.0, we will likely add build validation for 6.3.0 soon.
The first patch that has succesfully passed compilation is at https://gerrit.osmocom.org/#/c/5302/6
Please note that right now we only test the TTCN3->C++ compilation, and not the compilation of the resulting C++ code for performance reasons. It would be easy to add if we're willing to wait for the compile time, but I think it's not really needed. I so far have not yet managed to make ttcn3_compiler generate any C++ which would then later not pass the g++ compilation - at least not on a clean build environment.
Regards, Harald
Excellent news.
However, it seems like it's setup differently to other Osmo* projects: - if I submit patch via gerrit for osmo-bsc for example than it just appears in master branch as it is - if I submit patch via gerrit forosmo-ttcn3-hacks than there're additional merge commits in master branch
AFAIK it's rebase-if-necessary vs merge-if-necessary settings in gerrit. It doesn't seem to be crucial, still I'd prefer if we could stick to the same style for all projects. Personally I'd favor rebase style due to absence of empty merge commits.
What do you guys think?
On Thu, Dec 14, 2017 at 04:16:53PM +0100, Max wrote:
- if I submit patch via gerrit forosmo-ttcn3-hacks than there're additional merge
commits in master branch
this is the only setting that gerrit can't inherit from the global projects settings (ts) and I set it to rebase-if-necessary on each project individually. I've just changed it for osmo-ttcn3-hacks now.
~N