Hi Alexander,

thanks for your patch submission! I ran into the same problem just yesterday.

It is true that the lines your patch removes can be removed. However, the patch alone does not solve the build problem for me. In a clean checkout with the patch applied, I do still get the error:

hnbgw_ranap.c:36:28: fatal error: ranap_ies_defs.h: No such file or directory #include "ranap_ies_defs.h"

It first appears that the problem is related to the fact that asn1tostruct.py creates all of the *_ies_defs.h, *_decoder.c and *_encoder.c files in one step. However, taking a closer look, the root cause for the missing ranap_ies_defs.h is: automake seems unaware that the ranap sources need to be built. Having them in hnbgw_SOURCES alone is not enough, apparently. Looking at a verbose build log revealed that the asn1tostruct.py was never called on the RANAP asn. I'm still not sure why the hnbap and rua were generated and the ranap was omitted (there seems to be no difference to ranap), but adding a BUILT_SOURCES to Makefile.am solves the problem for me.

The fact that multiple files are built from one step should actually not be a problem: all three files get generated from the first dependency, after which the remaining files are already newer than the asn file -> "nothing to be done".

So I'm committing your patch to remove extraneous lines, and am adding a BUILT_SOURCES directive in a separate commit.

~Neels

On Mon, Dec 21, 2015 at 08:44:35PM +0100, Alexander Huemer wrote:

---

src/Makefile.am | 9 --------- 1 file changed, 9 deletions(-)

diff --git a/src/Makefile.am b/src/Makefile.am index 73b3987..48c861d 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -11,20 +11,11 @@ bin_PROGRAMS = hnbgw hnbgw_SOURCES = hnbap_encoder.c hnbap_decoder.c rua_encoder.c rua_decoder.c ranap_common.c rua_common.c hnbap_common.c iu_helpers.c asn1helpers.c hnbgw.c hnbgw_hnbap.c hnbgw_rua.c hnbgw_ranap.c ranap_decoder.c ranap_encoder.c ranap_msg_factory.c hnbgw_LDADD = $(OSMOCORE_LIBS) $(OSMOVTY_LIBS) $(OSMOGSM_LIBS) $(ASN1C_LIBS) $(COMMON_LDADD) hnbap/libosmo-asn1-hnbap.a rua/libosmo-asn1-rua.a ranap/libosmo-asn1-ranap.a

-ranap_ies_defs.h: ranap_encoder.c -ranap_decoder.c: ranap_encoder.c

-rua_ies_defs.h: rua_encoder.c -rua_decoder.c: rua_encoder.c

hnbap_encoder.c hnbap_decoder.c hnbap_ies_defs.h: $(ASN1_ROOT)/hnbap/HNBAP-PDU-Contents.asn -hnbap_encoder.c : $(ASN1_ROOT)/hnbap/HNBAP-PDU-Contents.asn $(ASN1TOSTRUCT) -f $<

rua_encoder.c rua_decoder.c rua_ies_defs.h: $(ASN1_ROOT)/rua/RUA-PDU-Contents.asn -rua_encoder.c : $(ASN1_ROOT)/rua/RUA-PDU-Contents.asn $(ASN1TOSTRUCT) -p RUA_ -f $<

ranap_encoder.c rua_decoder.c rua_ies_defs.h : $(ASN1_ROOT)/ranap/RANAP-PDU-Contents.asn -ranap_encoder.c : $(ASN1_ROOT)/ranap/RANAP-PDU-Contents.asn $(ASN1TOSTRUCT) -p RANAP_ -f $< -- 2.6.2

--- src/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/Makefile.am b/src/Makefile.am index ec7250b..9d45a5a 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -19,5 +19,5 @@ hnbap_encoder.c hnbap_decoder.c hnbap_ies_defs.h: $(ASN1_ROOT)/hnbap/HNBAP-PDU-C rua_encoder.c rua_decoder.c rua_ies_defs.h: $(ASN1_ROOT)/rua/RUA-PDU-Contents.asn $(ASN1TOSTRUCT) -p RUA_ -f $<

-ranap_encoder.c rua_decoder.c rua_ies_defs.h: $(ASN1_ROOT)/ranap/RANAP-PDU-Contents.asn +ranap_encoder.c ranap_decoder.c ranap_ies_defs.h: $(ASN1_ROOT)/ranap/RANAP-PDU-Contents.asn $(ASN1TOSTRUCT) -p RANAP_ -f $<